Laurent Rineau
07eb230ed8
Merge pull request #8149 from lrineau/cgallab-cont
...
Rename Polyhedron demo to CGAL Lab everywhere
2024-04-25 11:30:08 +02:00
Laurent Rineau
2a2031df3b
Rename cgallab to CGALlab
...
@janetournois (see https://github.com/CGAL/cgal/pull/8149#issuecomment-2066444180
2024-04-23 15:09:51 +02:00
Laurent Rineau
67466144bb
Merge pull request #8139 from janetournois/Mesh_3-revert_encroachment_loop-jtournois
...
Mesh_3 - revert encroachment rule modification, and fix infinite refinement
2024-04-22 14:53:50 +02:00
Laurent Rineau
621859b526
Rename Polyhedron demo to CGAL Lab
...
And announce it in the `CHANGES.md`.
2024-04-18 12:39:30 +02:00
Jane Tournois
a8debb0d2d
Revert "Fix sometimes creating holes in the C3T3"
...
This reverts commit 06d272169f .
There may be an inconsistency between exact and inexact computations,
in the facet encroachment rule
This code was leading to a local infinite refinement loop during cells refinement
2024-04-11 14:16:41 +02:00
Laurent Rineau
bffa8f213e
Merge pull request #8072 from janetournois/Mesh_3-use_one_step_loop-jtournois
...
Mesh_3 - fix mesher using the `one_step()` loop
# Conflicts:
# Mesh_3/include/CGAL/Mesh_3/Triangulation_helpers.h
2024-03-26 10:21:00 +01:00
Jane Tournois
ad98ab16b7
unused argc, argv
2024-03-22 10:22:48 +01:00
Jane Tournois
644d6493eb
nearest_power_vertex() does not work on an empty triangulation
2024-03-21 16:33:26 +01:00
Jane Tournois
44e176b88a
unused typedef
...
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2024-03-21 16:13:30 +01:00
Jane Tournois
5b004ffbe6
add a test for one_step() loop with features on tiny data
2024-03-14 17:27:47 +01:00
Jane Tournois
80fd8759dd
avoid insertion of points inside protecting balls, during initialization step
2024-03-14 16:40:28 +01:00
Jane Tournois
4e81649dd9
use set_surface_only() to be more explicit
2024-03-14 16:32:29 +01:00
Jane Tournois
d085faba0c
remove duplicate
2024-03-14 16:31:11 +01:00
Jane Tournois
83c88da327
move clear_cells_and_facets_from_c3t3() inside the constructor of Mesher_3
...
to make sure the input c3t3 is fully clean before starting refinement
2024-03-14 16:28:46 +01:00
Sébastien Loriot
910945eb5f
undo dependency changes + always use core if not disabled
2024-02-27 16:19:28 +01:00
Sébastien Loriot
3b30756cd3
do not depend on CGAL_Core
2024-02-27 14:46:18 +01:00
Andreas Fabri
e4558a4d4b
Merge branch 'master' into CORE-boost_mp_number-GF
2024-02-23 17:04:37 +01:00
Laurent Rineau
a32899f73c
Merge pull request #8029 from janetournois/Mesh_3-edge_min_size-jtournois
...
Mesh_3 with `edge_min_size` - make uses of `curve_segment_length()` consistent
2024-02-16 18:03:13 +01:00
Laurent Rineau
d9ebccd627
Merge pull request #8030 from janetournois/Mesh_3-perturber_doc-jtournois
...
Mesh_3 - fix perturber doc
2024-02-16 18:03:10 +01:00
Laurent Rineau
f407ea44ee
Merge pull request #8029 from janetournois/Mesh_3-edge_min_size-jtournois
...
Mesh_3 with `edge_min_size` - make uses of `curve_segment_length()` consistent
2024-02-16 18:02:36 +01:00
Sébastien Loriot
0e3074689b
fix warning
2024-02-14 11:03:10 +01:00
Jane Tournois
51ebe945de
fix the perturber doc, that was mixed with exuder (in 5.5, doc is valid)
2024-02-12 12:12:10 +01:00
Jane Tournois
34514d33f7
factorize code using curve_segment_length to one function
...
and use it everywhere
2024-02-12 11:46:33 +01:00
Sebastien Loriot
caecbe29c7
Replace boost::mpl ( #7813 )
...
- `boost::mpl::if_` --> `std::conditional`
- `boost::enable_if` -> `std::enable_if`
- `boost::mpl::and_` -> `&&`
- `boost::mpl::or_` -> `||`
- `boost::constant::bool_` -> `std::bool_constant`
- ...
2023-12-26 17:33:36 +01:00
Sébastien Loriot
15aa810876
Merge remote-tracking branch 'cgal/5.6.x-branch'
2023-12-22 17:16:49 +01:00
Sebastien Loriot
eb659137e6
Mesh_3 - `edge_min_size` may cause hanging ( #7863 )
...
## Summary of Changes
When the criterion `edge_min_size` is set, the graph of features is
likely to be invalid or at least inconsistent with the input graph.
Checking its topology does not make any sense and could lead to hanging
when trying to compute polyline feature lengths (because it's trying to
walk on different curves, jumping from one to the other, etc).
This PR disables the check-features-after-protect step when
`edge_min_size` is used, since we anyway do not expect the feature graph
to be exactly matching the one of the input.
## Release Management
* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
2023-12-22 17:15:37 +01:00
Jane Tournois
a66e78a672
when curves topology is valid, use curve_segment_length
2023-12-15 15:52:02 +01:00
Jane Tournois
3ef2ce9163
check_and_repopulate_edges() reactivated with minimal size
...
disabling it may give too bad results
change the arc_length computation when minimal size is used, instead,
by approximating it by the segment length
2023-12-15 14:44:33 +01:00
Jane Tournois
7fa2db8dfc
add helper function minimal_weight()
2023-12-14 19:01:57 +01:00
Jane Tournois
85b8da120d
constify more
2023-12-14 15:36:57 +01:00
Jane Tournois
54677b388c
set default minimal_size_ to -1 and add helper function to check if it is set
2023-12-14 15:35:06 +01:00
Laurent Rineau
ef881a1aa9
Merge pull request #7844 from janetournois/Mesh_3-remove_unused_criteria-GF
...
Mesh_3 - `Mesh_criteria_3` cleaning
2023-12-11 13:56:26 +01:00
Laurent Rineau
b4820031eb
Merge pull request #7911 from sloriot/M3-params_errors
...
Mesh_3: Fix copy/paste errors in parameters
2023-12-11 13:54:47 +01:00
Mael Rouxel-Labbé
b4d465ce85
Add a test
2023-12-05 22:34:00 +01:00
Jane Tournois
8a4c99f19b
remove unused variables
...
now there is only one possible sizing definition left, they have
become useless
2023-11-30 09:53:04 +01:00
Laurent Rineau
0744eba4bf
Merge pull request #7754 from janetournois/Mesh_3-manifold_and_min_size-jtournois
...
Mesh_3 - use `manifold()` and `facet_min_size` together
2023-11-29 17:23:25 +01:00
Laurent Rineau
95b83b1214
Merge pull request #7845 from puneetmatharu/patch-cgal-dont-override-build-testing
...
Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject
2023-11-29 17:22:54 +01:00
Laurent Rineau
eb59cc6105
Merge remote-tracking branch 'cgal/master' into Installation-ITK-jtournois
2023-11-24 10:50:26 +01:00
Laurent Rineau
9262c6a8b6
Re-add CGAL_ITK_support.cmake
...
That will allow to be compatible with ITK version 4.13 and 5.x.
2023-11-23 17:25:18 +01:00
Jane Tournois
7fdc36dbbe
remove *_sizing_field criteria from test
2023-11-23 15:48:46 +01:00
Jane Tournois
4f2ec8abe0
increase facet size
2023-11-17 16:21:37 +01:00
Jane Tournois
850c99e0f2
make data match exactly at vertices
...
with no degenerate border edges
2023-11-17 16:18:04 +01:00
Sébastien Loriot
cfac63f156
Merge remote-tracking branch 'cgal/master' into HEAD
2023-11-16 11:35:35 +01:00
Jane Tournois
e4e13e2f57
do not check the graph of features after protection when minimal_size is set
...
when minimal_size is set, the graph of features is likely to be invalid
or at least inconsistent with the input graph
so checking its topology does not make any sense and could lead to
- assertions failing in debug mode,
- hanging in release mode
2023-11-14 12:28:18 +01:00
Jane Tournois
0b73361226
remove CGAL_ITK_support.cmake
...
and adapt the CMakeLists that were using it
2023-11-13 12:47:39 +01:00
Jane Tournois
c85711d58f
test cleaning
2023-11-03 09:50:25 +01:00
Puneet Matharu
7944441068
Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject.
2023-11-02 18:09:03 +00:00
Jane Tournois
5b6bf12745
use get_parameter_reference for all the possibly-field parameters
2023-11-02 14:39:34 +01:00
Jane Tournois
093660ce43
remove unused and undocumented criterion cell_radius_edge
2023-11-02 14:27:31 +01:00
Jane Tournois
361c5c5009
remove all the _sizing_field parameters that have never been used
...
they were removed from the documentation before being merged in the master branch
see SVN commit
1614a89e32
2023-11-02 14:13:07 +01:00