include/CGAL/Min_sphere_of_spheres_d/Min_sphere_of_spheres_d_support_set_impl.h:49: warning: comparison between signed and unsigned integer expressions
Warning from clang:
Mesh_3/include/CGAL/Mesh_3/C3T3_helpers.h:1358:25: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
Workaround a bug in g++-4.8.3 (and previous versions):
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47679
that is triggered in some cases when boost::optional is used.
Using boost::make_optional to copy-initialize 'bbox' hides the
warning about '*bbox' not being initialized. See that StackOverflow
answer:
http://stackoverflow.com/a/21755207/1728537
The warning was, for example, with g++-4.8.3:
.../test/Polyhedron_Demo/./CGAL_demo/Scene_interface.h: In member function 'virtual Scene_item::Bbox Scene_polyhedron_selection_item::bbox() const':
.../test/Polyhedron_Demo/./CGAL_demo/Scene_interface.h:32:45: warning: '*((void*)& item_bbox +44)' may be used uninitialized in this function [-Wmaybe-uninitialized]
xmax(_xmax), ymax(_ymax), zmax(_zmax)
^
In file included from .../test/Polyhedron_Demo/Scene_polyhedron_selection_item.cpp:1:0:
.../test/Polyhedron_Demo/Scene_polyhedron_selection_item.h:288:35: note: '*((void*)& item_bbox +44)' was declared here
boost::optional<CGAL::Bbox_3> item_bbox;
That bug is not yet fixed in more recent versions of g++.
Warning with g++-4.8.3:
.../include/CGAL/Min_sphere_of_spheres_d/Min_sphere_of_spheres_d_support_set_impl.h:171:11: warning: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Wstrict-overflow]
for (int j=i+1; j<m; ++j)
^
That warning is about "signed overflow", and the code actually does not
use the sign of the integer.
- Remove the paragraph "This is the beta version of the CGAL Manual
generated with doxygen." that was in the main page of the CGAL manual.
- Add a section, at the end of the main page, that explains where to
find the manuals of previous CGAL versions.
The changes the interface ID declared by
demo/Mesh_3/include/CGAL_demo/Plugin_interface.h, so that the ID of
plugin interface for the Polyedron demo and the Mesh_3 are
different. That will allow to have plugins for both demos in the same
directory.
it collects edges incident to the internal facets of the conflict zone,
that are restricted to the surface.
For each such edge :
- if it appears once, we keep it
- if it appears twice, we don't consider it
- if it appears more than twice, we are in a non-manifold configuration,
and the move (pump) is canceled