Commit Graph

57 Commits

Author SHA1 Message Date
Eric Berberich e6d6802a96 svn mv to right position 2012-08-03 20:57:41 +00:00
Eric Berberich 7fdba3893b renamed missing directories 2012-08-03 17:35:29 +00:00
Laurent Rineau e87895400f Fix a bug created by that revision:
| ------------------------------------------------------------------------
  | r57003 | afabri | 2010-06-23 10:30:32 +0200 (Wed, 23 Jun 2010) | 1 line
  | 
  | int -> size_t and static_casts
  | ------------------------------------------------------------------------

The conversion from int to size_t is not always safe. Here the right type
was a signed type: std::ptrdiff_t, especially because the variable stores a
difference between two pointers.

The bug was discovered by a very recent version of clang:
clang version 3.2 (trunk 160721)

The error was:
cd /home/lrineau/CGAL/CGAL-4.1-Ic-113/cmake/platforms/x86-64_Linux-2.6_llvm-clang-with-g++-4.6.2_F16/src/CGAL && /usr/local/packages/llvm-trunk/bin/clang++   -DCGAL_EXPORTS -DCGAL_TEST_SUITE -DCGAL_USE_MPFR -DCGAL_USE_GMPXX -DCGAL_USE_GMP --std=c++11 -fno-strict-aliasing -Wall -fPIC -I/home/lrineau/CGAL/CGAL-4.1-Ic-113/cmake/platforms/x86-64_Linux-2.6_llvm-clang-with-g++-4.6.2_F16/include -I/home/lrineau/CGAL/CGAL-4.1-Ic-113/include -I/home/lrineau/CGAL/boost/boost-release-branch    -o CMakeFiles/CGAL.dir/all_files.cpp.o -c /home/lrineau/CGAL/CGAL-4.1-Ic-113/cmake/platforms/x86-64_Linux-2.6_llvm-clang-with-g++-4.6.2_F16/src/CGAL/all_files.cpp
In file included from /home/lrineau/CGAL/CGAL-4.1-Ic-113/cmake/platforms/x86-64_Linux-2.6_llvm-clang-with-g++-4.6.2_F16/src/CGAL/all_files.cpp:2:
/home/lrineau/CGAL/CGAL-4.1-Ic-113/src/CGAL/JAMA_numeric_solver.cpp:83:14: error: case value evaluates to -1, which cannot be narrowed to type 'std::size_t' (aka 'unsigned long') [-Wc++11-narrowing]
        case -1:
             ^
/home/lrineau/CGAL/CGAL-4.1-Ic-113/src/CGAL/JAMA_numeric_solver.cpp:109:14: error: case value evaluates to -1, which cannot be narrowed to type 'std::size_t' (aka 'unsigned long') [-Wc++11-narrowing]
        case -1:
             ^
In file included from /home/lrineau/CGAL/CGAL-4.1-Ic-113/cmake/platforms/x86-64_Linux-2.6_llvm-clang-with-g++-4.6.2_F16/src/CGAL/all_files.cpp:13:
/home/lrineau/CGAL/CGAL-4.1-Ic-113/src/CGAL/Turkowski_numeric_solver.cpp:398:8: error: case value evaluates to -1, which cannot be narrowed to type 'std::size_t' (aka 'unsigned long') [-Wc++11-narrowing]
  case -1:
       ^
/home/lrineau/CGAL/CGAL-4.1-Ic-113/src/CGAL/Turkowski_numeric_solver.cpp:431:8: error: case value evaluates to -1, which cannot be narrowed to type 'std::size_t' (aka 'unsigned long') [-Wc++11-narrowing]
  case -1:
       ^
4 errors generated.
2012-07-26 12:46:30 +00:00
Laurent Rineau 5b5dd33848 merge changes from next 2012-01-09 12:33:39 +00:00
Philipp Möller b154f31f27 Removed unused variables from old Qt3 code for cleaner compilation 2011-11-21 15:37:08 +00:00
Andreas Fabri f8a1a2e2c8 Suppress warning about potential dll linkage problem 2011-10-17 13:08:07 +00:00
Sébastien Loriot 91a5327fa8 change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Eric Berberich eb7a5ed11e branch-build is now HOT on next ;-) 2011-04-15 09:12:06 +00:00
Eric Berberich 2733a26a3f Qt -> Qt3 2011-04-15 08:43:49 +00:00
Sébastien Loriot a2cec87f46 replace remaing fabs in include files by CGAL::abs 2011-02-18 15:37:40 +00:00
Andreas Fabri bfa1c00225 int -> size_t and static_casts 2010-06-23 08:30:32 +00:00
Sébastien Loriot d53e01f1a1 remove package namespace macro 2010-06-09 08:45:58 +00:00
Sébastien Loriot 52317dd49f add python script (replace_CGAL_NAMESPACE.py) to replace CGAL_BEGIN_NAMESPACE and CGAL_END_NAMESPACE
by namespace CGAL { and } //namespace CGAL. in all .h and .cpp files
in a directory.
Apply it to all packages in the trunk
Remove macro definition from the config.h file.
2010-06-09 07:37:13 +00:00
Laurent Rineau 3147e41e61 Revert that patch:
| ------------------------------------------------------------------------
  | r55821 | drussel | 2010-04-29 04:19:59 +0200 (Thu, 29 Apr 2010) | 1 line
  | Changed paths:
  |    M /trunk/Kinetic_data_structures/src/CGAL/numeric_solvers_support.cpp
  | 
  | use the newish grand unified polynomial internally
  | ------------------------------------------------------------------------

Reasons are:
  - it uses C99 dynamic C arrays allocated on the stack instead of
  std::vector,
  - C99 dynamic C arrays are not in C++98 (they will probably be in C++0x),
  - g++ implements that as an extension,
  - VC++ does not,
  - that is in libCGAL, and for that reason the whole CGAL testsuite is red
  under Microsoft VC++.

Suggestion (already emailed to Daniel): use std::vector instead of dynamic
C arrays, and resubmit the patch.
2010-04-30 16:25:32 +00:00
Daniel Russel 149955e65b use the newish grand unified polynomial internally 2010-04-29 02:19:59 +00:00
Sylvain Pion 5fda817f95 Remove a few "warning: extra ';'" with g++ -pedantic. 2009-11-14 11:49:52 +00:00
Andreas Fabri 2047473feb Removed makefiles 2008-12-12 08:02:55 +00:00
Daniel Russel 562b62e0a3 don't make intervals with inf 2008-09-26 19:18:11 +00:00
Laurent Rineau 234e77e615 Add a vpath, to ease the in-place(1) compilation of Qt_widget.
(1) Directly in the subversion tree, outside of a CGAL installation.
2008-04-25 14:03:30 +00:00
Andreas Meyer c1d1609af1 replaced CGAL_assertion( false* and CGAL_assertion( 0*
with CGAL_error/CGAL_error_msg
2007-11-08 00:27:20 +00:00
Daniel Russel 8a107b364b fixed qt problem--too fancy with overloading 2007-07-10 22:09:27 +00:00
Daniel Russel 2f35c55283 oops, something had gotten confused, CGALQT should now compile 2007-06-15 20:42:44 +00:00
Daniel Russel 7d9a1eaf8c libCGAL builds 2007-06-10 23:46:47 +00:00
Daniel Russel c1fd50a09b pre global replace 2007-06-10 23:05:03 +00:00
Daniel Russel 5a7bf47ead added header 2007-03-26 19:03:11 +00:00
Andreas Fabri 20ed3865aa added space 2007-03-11 19:58:35 +00:00
Sylvain Pion 1745f8b0eb comment out unused variable (spotted by pgcc) 2007-03-09 13:28:35 +00:00
Laurent Rineau 7a299a8431 Fix a "warning: unused parameter 'end'" in the compilation of libCGAL. 2007-03-03 09:29:10 +00:00
Daniel Russel a8ce13422d some steps towards handling duplicate points in RT3, I need to get to other things now 2007-02-27 22:45:58 +00:00
Efi Fogel b14cda945d used relative path in vpath statement for windows 2007-02-12 21:45:49 +00:00
Daniel Russel 9f504e4ae2 try to disable warning 2007-02-11 22:00:24 +00:00
Efi Fogel 7a8af94b1f cleanup generic rules 2007-02-11 17:15:52 +00:00
Daniel Russel fed20e7df2 fixed some max 2007-02-08 16:31:14 +00:00
Daniel Russel 26e2e082d3 collapsed files 2007-02-07 06:42:22 +00:00
Daniel Russel dca595a3b8 simplified Delaunay_3 to try to track down bug in regular 2007-01-31 03:15:14 +00:00
Daniel Russel e48c4a7906 tweaked error reporting 2007-01-30 21:02:03 +00:00
Andreas Fabri 26b7fc73e1 fixed path 2007-01-29 20:50:40 +00:00
Andreas Fabri be46ecfc11 Replace variable with relative path as moc doesn't understand Windows paths with colons 2007-01-29 09:09:15 +00:00
Daniel Russel 02ccc9c36f before trying to clean things up for new number type stuff 2007-01-18 23:26:44 +00:00
Daniel Russel 32f0018112 replaced static with namespace 2006-10-25 15:46:14 +00:00
Daniel Russel ea2ddfde4d added interval_guard 2006-07-13 15:04:56 +00:00
Daniel Russel 683dd804a1 minor change to get better error catching in test suite 2006-05-04 09:15:56 +00:00
Sylvain Pion d2740513aa Use .cpp file extension instead of .C for src/*/* files. 2006-04-14 09:19:29 +00:00
Sylvain Pion 55ed3d7ceb Add #include <CGAL/basic.h> at the beginning 2006-04-13 23:34:58 +00:00
Sylvain Pion 22ad725de1 Move src/*.C to src/CGAL/*.C 2006-04-13 22:24:18 +00:00
Daniel Russel 974fa3962e removed KINEITC dir variable 2006-03-31 09:46:24 +00:00
Joachim Reichel c62eb076e6 LGPL copyright notices added to makefiles and compute_TAUCS_OSTYPE 2006-03-09 20:47:20 +00:00
Daniel Russel ba271aac8f bye,bye makefile_lib 2006-02-23 14:48:22 +00:00
Joachim Reichel cb43de6d9f $Id$ $Date$ replaced by $Id$ 2006-02-16 20:53:46 +00:00
Daniel Russel 3d66565dc8 done renaming 2006-02-16 18:49:58 +00:00