Commit Graph

110426 Commits

Author SHA1 Message Date
Anirudh Lakhanpal 057caa3d19 used std::array for point storage in the following examples of Bounding_volumes (1)min_annulus_d_fast_exact.cpp (2)min_annulus_d.cpp (3)min_ellipse_2.cpp (4)min_sphere_3.cpp (5)min_sphere_homogenous_3.cpp 2025-01-26 17:54:36 +05:30
Anirudh Lakhanpal 27c788d1d3 Used std::arr<T>.end() instead of adding n to the .begin() iterator 2025-01-22 19:27:31 +05:30
Anirudh Lakhanpal b17854f45b
Merge branch 'CGAL:master' into master 2025-01-22 17:58:28 +05:30
Anirudh Lakhanpal 6b0a8c5b6d Used std::array instead of std::vector as the size is known at compile time 2025-01-22 17:56:58 +05:30
Sébastien Loriot c313da8791 Merge remote-tracking branch 'cgal/6.0.x-branch' 2025-01-22 10:55:21 +01:00
Sébastien Loriot 5139e6ed09 Merge remote-tracking branch 'cgal/5.6.x-branch' into HEAD 2025-01-22 10:54:25 +01:00
Sebastien Loriot 6d458bbd31
Triangulation_3 traverser benchmark and doc fixes (#8708)
## Summary of Changes

Use the public API of traverser, fix compilation and documentation of
`Triangulation_simplex_3<Tds>`

This PR follows #8694

## Release Management

* Affected package(s): Triangulation_3, TDS doc
2025-01-22 10:50:41 +01:00
Sebastien Loriot db45571323
refactor: remove duplicate header file inclusion (#8692)
## Summary of Changes

remove duplicate header file inclusion

## Release Management

* Affected package(s): Polygon_mesh_processing
2025-01-22 10:46:18 +01:00
Anirudh Lakhanpal 724ef98978 avoid using c style arrays 2025-01-21 23:12:12 +05:30
Jane Tournois fbaccdb075 fix compilation on msvc and use public API 2025-01-21 15:55:25 +01:00
Jane Tournois b721064782 fix doc of Triangulation_simplex_3 (the template param is TDS) 2025-01-21 15:54:49 +01:00
Anirudh Lakhanpal 93f02ccd61 +testing2 2025-01-21 19:32:32 +05:30
Anirudh Lakhanpal d0f7159b9c +testing 2025-01-21 19:30:38 +05:30
Sébastien Loriot b4a8c00e09 Merge remote-tracking branch 'cgal/6.0.x-branch' 2025-01-20 10:19:17 +01:00
Sebastien Loriot 816cd11e3a
Replace boost::optional with std::optional (#8695)
## Summary of Changes

Some occurrences that slipped through.

See https://github.com/CGAL/cgal/pull/7526

## Release Management

* Affected package(s): `Tetrahedral_remeshing`, `Triangulation_3`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): - 
* License and copyright ownership: no change
2025-01-20 10:13:50 +01:00
Sebastien Loriot 76321c4be1
Aos 2 fixes efif (#8666)
## Fixed the Landmark point-location strategy of the Aos_2 package, so
that it can be applied to arrangements on a sphere.

The title says it all.
I slightly changed one paragraph in the user manual. 
Here is the new version:

The arrangement attached to the landmark strategy must be either (i) an
instance of the `Arrangement_2]<Geom,Dcel>` class template, where the
`Traits` parameter is substituted by a geometry-traits class that models
the `ArrangementLandmarkTraits_2` concept, or (ii) an instance of the
`Arrangement_on_surface_2<GeomTraits,TopolTraits>` class template, where
the `GeometryTraits` is similarly substituted; see Section The Landmark
Concept for details about this concept.

## Release Management

* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): NA
* Feature/Small Feature (if any): NA
* Link to compiled documentation: Changed one paragraph; see above.
* License and copyright ownership: TAU
2025-01-20 10:05:42 +01:00
Sébastien Loriot 81076472b1 try to fix CI 2025-01-17 19:05:39 +01:00
Sebastien Loriot 01647a0019
Fix compilation of T3 traverser benchmark (#8694)
## Release Management

* Affected package(s): `Triangulation_3`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): - 
* License and copyright ownership: no change
2025-01-17 19:00:50 +01:00
Sébastien Loriot 6d20c44ccf Merge remote-tracking branch 'cgal/6.0.x-branch' 2025-01-17 18:52:55 +01:00
Sébastien Loriot bcd33215a7 Merge remote-tracking branch 'cgal/5.6.x-branch' 2025-01-17 18:52:19 +01:00
Sébastien Loriot 5e2fbcf707 Merge pull request #8691 from lrineau/CGAL-Github-use-ubuntu-22.04-GF
FOR 5.6.x ONLY: use ubuntu-22.04 as Github runner
2025-01-17 18:47:28 +01:00
Sébastien Loriot fe88db2bb3 workaround issue with file command 2025-01-17 18:46:13 +01:00
Sebastien Loriot ea22cc086f
Use the same generator for reproducible runs (#8683)
Ref:
```
------------------------------------------------------------------
- Tetrahedral_remeshing/ProgramOutput.execution   of  test_tetrahedral_remeshing_of_one_subdomain
------------------------------------------------------------------

CGAL::Random()::get_seed() = 1736397916
CGAL Random seed = 1736397916
valid data structure
valid triangulation
Tetrahedral remeshing (nb_iter = 1, protect = false)
Init tetrahedral remeshing...done.
# Iteration 1 #
Split long edges... done (2449 splits, in 0.0591981 sec).
Collapse short edges... done (0 collapses, in 0.077903 seconds).
Flip edges...
Flip edges... done (83/2946 surface/volume flips done, in 0.336761 seconds).
Smooth vertices... done (0/760/1915 vertices smoothed, average move = 0.083582, in 0.128201 seconds).
# Iteration 1 done : 3449 vertices #
Flip edges...
Flip edges... done (32/2958 surface/volume flips done, in 0.318584 seconds).
Smooth vertices... done (0/415/1307 vertices smoothed, average move = 0.0443012, in 0.153528 seconds).
# Iteration 2 (flip and smooth only) done : 3449 vertices #
Flip edges...
Flip edges... done (19/2333 surface/volume flips done, in 0.297889 seconds).
Smooth vertices...CGAL error: assertion violation!
Expression : 
File       : /Users/geometryfactory/CGAL/testsuite/CGAL-6.1-Ic-59/include/CGAL/Intersections_3/internal/Ray_3_Triangle_3_intersection.h
Line       : 382
Explanation: 
Refer to the bug-reporting instructions at https://www.cgal.org/bug_report.html
libc++abi: terminating due to uncaught exception of type CGAL::Assertion_exception: CGAL ERROR: assertion violation!
File: /Users/geometryfactory/CGAL/testsuite/CGAL-6.1-Ic-59/include/CGAL/Intersections_3/internal/Ray_3_Triangle_3_intersection.h
Line: 382
```


https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-59/Tetrahedral_remeshing/TestReport_monet_macOS-x86_64-core_boost_backend.gz
2025-01-17 18:37:33 +01:00
Sebastien Loriot 026700f989
PMP::isotropic_remeshing() - Fix removal of boundary degenerate faces (#8685)
## Summary of Changes

update status of border edges when removing a (degenerate) border face

## Release Management

* Affected package(s): PMP
* License and copyright ownership: unchanged
2025-01-17 18:36:58 +01:00
Sébastien Loriot 679cd8cd23 workaround issue with file command 2025-01-17 17:15:49 +01:00
Sébastien Loriot 796a7bd066 more types 2025-01-17 15:09:38 +01:00
Mael 72520db3a8
Use std::optional::reset
Co-authored-by: Anirudh Lakhanpal <91114837+SharonIV0x86@users.noreply.github.com>
2025-01-17 09:15:36 +01:00
Efi Fogel f6b935401e Further pacify msvc; replaced auto with actual type (Inner_ccb_const_iterator) 2025-01-16 19:05:22 +02:00
Mael Rouxel-Labbé e1b7c4726e Replace boost::optional with std::optional
See https://github.com/CGAL/cgal/pull/7526
2025-01-16 13:45:12 +01:00
Mael Rouxel-Labbé 8fe8a8c904 Fix compilation of traverser benchmark 2025-01-16 11:03:06 +01:00
zfb132 d5d01a4d32
refactor: remove duplicate header file inclusion 2025-01-15 23:34:10 +08:00
Laurent Rineau 170952b927 FOR 5.6.x ONLY: use ubuntu-22.04 as Github runner
`ubuntu-latest` was recently turned from 22.04 to 24.04. And 5.6.x is
not ready for that.

See the run
https://github.com/CGAL/cgal/actions/runs/12787411585/job/35648286539?pr=8688#step:3:46

DO NOT MERGE INTO `6.0.x` or `master`.
2025-01-15 14:35:28 +01:00
Jane Tournois 8e0ebb9a39 update status of border edges when removing a (degenerate) border face 2025-01-10 13:42:33 +00:00
Efi Fogel de7c24ad03 Pacify msvc; replaced auto with actual type (Isolated_vertex_const_iterator) 2025-01-09 20:34:12 +02:00
Sébastien Loriot 36d98614df Merge remote-tracking branch 'cgal/6.0.x-branch' 2025-01-09 19:23:19 +01:00
Sébastien Loriot 0eb709dd65 Merge remote-tracking branch 'cgal/5.6.x-branch' into HEAD 2025-01-09 19:22:39 +01:00
Sebastien Loriot 17e6644f9f
Orthtree: Doc and traits bugfixes (#8678)
## Summary of Changes

Octree doc states requirement of RandomAccessIterator for point range
added missing _object types for functors in traits

## Release Management

* Affected package(s): Orthtree
2025-01-09 19:14:51 +01:00
Sebastien Loriot a7afaf81f0
Stream_support: Document that WKT can also handle 3D points (#8669)
## Summary of Changes

Fix in the documentation, namely that also 3D points may be used.

## Release Management

* Affected package(s): Stream_support
2025-01-09 19:07:13 +01:00
Sebastien Loriot 8be09c9cc4
Handle copy of non manifold umbrella in a Face_filtered_graph (#8682) 2025-01-09 19:06:36 +01:00
Sébastien Loriot 765fea2134 use the same generator for reproducible runs 2025-01-09 10:18:25 +01:00
Sébastien Loriot 1e06a8813f handle special case when FFG has a non-manifold mesh and not all umbrellas are selected 2025-01-08 17:31:21 +01:00
Sebastien Loriot 5040cbca54
Add missing closing grouping commands (#8675)
In a number of cases the command `@{` (or `\{`) is not closed by a
corresponding closing command (`@}`). For the `\=name` command this is
apparently not necessary but it is better to have corresponding open and
close commands.

(also corrected a split in a line that I noticed in
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Arr_conic_traits_2.h)
2025-01-07 15:39:48 +01:00
Sven Oesau e1cc01c34d removed unnecessary typename 2025-01-07 09:15:10 +01:00
Laurent Rineau e9a2365557
Doxygen: fix doc compilation with Doxygen 1.10 or later (#8665)
- Introduce container images for Doxygen.
- Ensure compatibility with Doxygen 1.10 and later.
- Revert previous stylesheet changes to restore the correct stylesheet
path (reverts #8331).
2025-01-06 16:38:20 +01:00
Sven Oesau 01e7864526 fixed type of construct_point_d_object 2025-01-06 16:24:02 +01:00
Sven Oesau e8aff9cbe5
Update Orthtree/include/CGAL/Orthtree_traits_point.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-01-06 13:53:33 +01:00
Sven Oesau 2e0fbc7a98 Octree doc states requirement of RandomAccessIterator
added missing _object types for functors in traits
2025-01-06 12:49:21 +01:00
Efi Fogel df1179889c Made the Base type public and fixed the Approximate_2 operator that operates on x-monotone curves 2024-12-30 00:57:16 +02:00
Sebastien Loriot 1c04f5768c
Doxygen incompatibility in respect to `FULL_SIDEBAR` setting (#8674)
Due to an incompatibility change in doxygen (see
2a62c19755 (commitcomment-150534822))
it is necessary to add the setting for `FULL_SIDEBAR` to the setup of
the CGAL documentation.
2024-12-27 10:28:24 +01:00
Sebastien Loriot f30cdccb67
Spelling correction (#8672)
Spelling correction

Note: we also have a similar spelling error in:
```
Surface_mesh_skeletonization/benchmark/Surface_mesh_skeletonization/mcf_scale_invariance.cpp:104:  output.open("correspondance.cgal");
Surface_mesh_skeletonization/examples/Surface_mesh_skeletonization/MCF_Skeleton_example.cpp:68:  output.open("correspondance-poly.polylines.txt");
Surface_mesh_skeletonization/examples/Surface_mesh_skeletonization/MCF_Skeleton_LCC_example.cpp:66:  output.open("correspondance-lcc.polylines.txt");
Surface_mesh_skeletonization/examples/Surface_mesh_skeletonization/MCF_Skeleton_om_example.cpp:75:  output.open("correspondance-sm.polylines.txt");
Surface_mesh_skeletonization/examples/Surface_mesh_skeletonization/MCF_Skeleton_sm_example.cpp:67:  output.open("correspondance-sm.polylines.txt");
Surface_mesh_skeletonization/examples/Surface_mesh_skeletonization/simple_mcfskel_example.cpp:72:  output.open("correspondance-poly.polylines.txt");
Surface_mesh_skeletonization/examples/Surface_mesh_skeletonization/simple_mcfskel_LCC_example.cpp:72:  output.open("correspondance-lcc.polylines.txt");
Surface_mesh_skeletonization/examples/Surface_mesh_skeletonization/simple_mcfskel_sm_example.cpp:51:  output.open("correspondance-sm.polylines.txt");
```
but as this in filenames I didn't change it.
2024-12-27 10:28:06 +01:00