Commit Graph

4449 Commits

Author SHA1 Message Date
Sebastien Loriot caecbe29c7
Replace boost::mpl (#7813)
- `boost::mpl::if_` --> `std::conditional`
- `boost::enable_if` -> `std::enable_if`
- `boost::mpl::and_` -> `&&`
- `boost::mpl::or_` -> `||`
- `boost::constant::bool_` -> `std::bool_constant`
- ...
2023-12-26 17:33:36 +01:00
Sébastien Loriot 15aa810876 Merge remote-tracking branch 'cgal/5.6.x-branch' 2023-12-22 17:16:49 +01:00
Sebastien Loriot eb659137e6
Mesh_3 - `edge_min_size` may cause hanging (#7863)
## Summary of Changes

When the criterion `edge_min_size` is set, the graph of features is
likely to be invalid or at least inconsistent with the input graph.
Checking its topology does not make any sense and could lead to hanging
when trying to compute polyline feature lengths (because it's trying to
walk on different curves, jumping from one to the other, etc).

This PR disables the check-features-after-protect step when
`edge_min_size` is used, since we anyway do not expect the feature graph
to be exactly matching the one of the input.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
2023-12-22 17:15:37 +01:00
Jane Tournois a66e78a672 when curves topology is valid, use curve_segment_length 2023-12-15 15:52:02 +01:00
Jane Tournois 3ef2ce9163 check_and_repopulate_edges() reactivated with minimal size
disabling it may give too bad results
change the arc_length computation when minimal size is used, instead,
by approximating it by the segment length
2023-12-15 14:44:33 +01:00
Jane Tournois 7fa2db8dfc add helper function minimal_weight() 2023-12-14 19:01:57 +01:00
Jane Tournois 85b8da120d constify more 2023-12-14 15:36:57 +01:00
Jane Tournois 54677b388c set default minimal_size_ to -1 and add helper function to check if it is set 2023-12-14 15:35:06 +01:00
Laurent Rineau ef881a1aa9 Merge pull request #7844 from janetournois/Mesh_3-remove_unused_criteria-GF
Mesh_3 - `Mesh_criteria_3` cleaning
2023-12-11 13:56:26 +01:00
Laurent Rineau b4820031eb Merge pull request #7911 from sloriot/M3-params_errors
Mesh_3: Fix copy/paste errors in parameters
2023-12-11 13:54:47 +01:00
Mael Rouxel-Labbé b4d465ce85 Add a test 2023-12-05 22:34:00 +01:00
Jane Tournois 8a4c99f19b remove unused variables
now there is only one possible sizing definition left, they have
become useless
2023-11-30 09:53:04 +01:00
Laurent Rineau 0744eba4bf Merge pull request #7754 from janetournois/Mesh_3-manifold_and_min_size-jtournois
Mesh_3 - use `manifold()` and `facet_min_size` together
2023-11-29 17:23:25 +01:00
Laurent Rineau 95b83b1214 Merge pull request #7845 from puneetmatharu/patch-cgal-dont-override-build-testing
Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject
2023-11-29 17:22:54 +01:00
Laurent Rineau eb59cc6105 Merge remote-tracking branch 'cgal/master' into Installation-ITK-jtournois 2023-11-24 10:50:26 +01:00
Laurent Rineau 9262c6a8b6 Re-add CGAL_ITK_support.cmake
That will allow to be compatible with ITK version 4.13 and 5.x.
2023-11-23 17:25:18 +01:00
Jane Tournois 7fdc36dbbe remove *_sizing_field criteria from test 2023-11-23 15:48:46 +01:00
Jane Tournois 4f2ec8abe0 increase facet size 2023-11-17 16:21:37 +01:00
Jane Tournois 850c99e0f2 make data match exactly at vertices
with no degenerate border edges
2023-11-17 16:18:04 +01:00
Sébastien Loriot cfac63f156 Merge remote-tracking branch 'cgal/master' into HEAD 2023-11-16 11:35:35 +01:00
Jane Tournois e4e13e2f57 do not check the graph of features after protection when minimal_size is set
when minimal_size is set, the graph of features is likely to be invalid

or at least inconsistent with the input graph
so checking its topology does not make any sense and could lead to
- assertions failing in debug mode,
- hanging in release mode
2023-11-14 12:28:18 +01:00
Jane Tournois 0b73361226 remove CGAL_ITK_support.cmake
and adapt the CMakeLists that were using it
2023-11-13 12:47:39 +01:00
Jane Tournois c85711d58f test cleaning 2023-11-03 09:50:25 +01:00
Puneet Matharu 7944441068 Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject. 2023-11-02 18:09:03 +00:00
Jane Tournois 5b6bf12745 use get_parameter_reference for all the possibly-field parameters 2023-11-02 14:39:34 +01:00
Jane Tournois 093660ce43 remove unused and undocumented criterion cell_radius_edge 2023-11-02 14:27:31 +01:00
Jane Tournois 361c5c5009 remove all the _sizing_field parameters that have never been used
they were removed from the documentation before being merged in the master branch
see SVN commit
1614a89e32
2023-11-02 14:13:07 +01:00
Jane Tournois f76161be3c store squared min_size instead of min_size 2023-11-02 09:27:27 +01:00
Laurent Rineau 51627e3505 Merge remote-tracking branch 'cgal/master' into CGAL-Qt6-GF
# Conflicts:
#	GraphicsView/demo/Bounding_volumes/CMakeLists.txt
2023-11-01 20:59:44 +01:00
Jane Tournois 3204b527e8 reduce perturb_mesh_3 angle bound to fit timeout on more platforms 2023-10-30 12:11:24 +01:00
Jane Tournois 4bbbc482cf reduce the target dihedral angle to fit in the testsuite timeout 2023-10-24 17:21:29 +02:00
Jane Tournois 99c0df22ad Merge remote-tracking branch 'cgal/master' into Mesh_3-manifold_and_min_size-jtournois
# Conflicts:
#	Polyhedron/demo/Polyhedron/resources/shader_c3t3.frag
2023-10-24 12:55:09 +02:00
Laurent Rineau 98a6bf7934 Merge pull request #7744 from lrineau/CGAl-fix_IO_oformat_iformat-GF
fix : iformat/oformat are in CGAL::IO
2023-10-16 11:13:21 +02:00
albert-github 6f560fcdce issue #7767 Problem with the documenation of Mesh_3
removing files that were removed by #7445 but reintroduced by #7395
2023-10-09 16:03:49 +02:00
Jane Tournois 2c0e04c4fd replace min_facet_size by squared version to avoid multiple redundant computations 2023-10-06 09:44:53 +02:00
Jane Tournois 7dc1f889e0 wip adding a test 2023-10-06 09:44:04 +02:00
Jane Tournois d46efd537f avoid computing twice the biggest incident facet 2023-10-02 16:59:42 +02:00
Jane Tournois 05b80838e7 check min_size before inserting facets or edges in refinement queues 2023-10-02 16:31:29 +02:00
Jane Tournois e8651b8a58 add min_radius_bound member and accessor 2023-10-02 16:30:21 +02:00
Jane Tournois 1d79ab5023 rename B_ 2023-10-02 16:28:04 +02:00
Jane Tournois eacc3ab4d1 add missing typedef 2023-10-02 12:13:54 +02:00
Laurent Rineau ebdfddbf5b add a link to TBB 2023-09-25 16:30:47 +02:00
Laurent Rineau 1d29a75c9a iformat/oformat are in CGAL::IO
The calls without the `IO::` namespace are deprecated.
2023-09-25 16:09:41 +02:00
Sébastien Loriot 8700394122 boost::mpl::if_ -> std::conditional 2023-09-24 22:57:20 +02:00
Laurent Rineau 28632f21fc Merge branch 'master' into CGAL-Qt6-GF
# Conflicts:
#	Installation/CHANGES.md
2023-09-14 17:40:05 +02:00
Laurent Rineau b05e1e9e46 Remove UseCGAL.cmake
and our old CMake macros `use_lib` and `use_component`.
2023-09-14 17:32:55 +02:00
Laurent Rineau 3cf928a4c7 Merge pull request #7704 from sloriot/Mesh_3-PCMD_in_domain_bug
Fix Is_in_domain potential infinite loop

# Conflicts:
#	Mesh_3/include/CGAL/Polyhedral_complex_mesh_domain_3.h
2023-09-13 16:16:23 +02:00
Sebastien Loriot b2c6cec8af
A missing ref
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2023-09-12 11:08:21 +02:00
Sébastien Loriot ed521e03b0 rename macro 2023-09-07 17:33:41 +02:00
Sébastien Loriot dd383da307 avoid an infinite loop in the case the source of the ray in on the face 2023-09-07 17:33:17 +02:00