Commit Graph

93973 Commits

Author SHA1 Message Date
Laurent Rineau 07cfbc21d8 Update all testsuite scripts, using master versions 2021-11-30 10:23:20 +01:00
Sébastien Loriot a6e555c2ac constructing a string from nullptr is undefined behavior
cherry-pick from 6680a6e6f9
2021-11-29 16:02:55 +01:00
Laurent Rineau c40e91c529 Merge pull request #6145 from sloriot/BGL-collapse_edges_with_cst
Fix collapse_edge bug when both edges to remove are constrained edges
2021-11-25 17:27:03 +01:00
Sébastien Loriot fc255614e4 fix warning 2021-11-24 15:08:11 +01:00
Laurent Rineau 3c562607f5 Merge pull request #6139 from sloriot/SMP-ambiguous
Fix ambiguity in function signature
2021-11-23 15:37:46 +01:00
Laurent Rineau 1ec00216c0 Merge pull request #6144 from MaelRL/BGL-Fix_METIS_npart_int-GF
Fix conversion error in METIS wrappers
2021-11-23 15:37:44 +01:00
Sébastien Loriot 7169811f60 remove extra ; and fix indentation 2021-11-23 10:21:20 +01:00
Sébastien Loriot d2be97b1eb fix bug when both edges to remove are constrained edges 2021-11-23 10:16:23 +01:00
Mael Rouxel-Labbé 4f02dd2fc2 Fix the previous, bad fix 2021-11-22 13:06:46 +01:00
Mael Rouxel-Labbé 3857c58324 Fix #part type 2021-11-22 12:38:53 +01:00
Sébastien Loriot c47ba58ca0 fix ambiguity in function signature 2021-11-19 13:42:11 +01:00
Laurent Rineau d6ffe7c0f3 Merge pull request #6118 from lrineau/Voronoi_diagram_2-fix_cpp20_warning-GF
Voronoi_diagram_2: fix C++20 warnings [-Wambiguous-reversed-operator]
2021-11-18 12:22:06 +01:00
Laurent Rineau 2e476304ed Fix warnings
> CGAL/Voronoi_diagram_2/Connected_components.h:103:19: warning: ISO C++20 considers use of overloaded operator '!=' (with operand types 'CGAL::VoronoiDiagram_2::Internal::Connected_components<...>::HAVC') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Wambiguous-reversed-operator]

I changed `operator==` into friend functions.
2021-11-10 09:35:10 +01:00
Sébastien Loriot 08d9ce3c8a Merge pull request #6038 from MaelRL/PM-Fix_pmaps_reference_types-GF
Various fixes for property maps (5.2)
2021-10-29 17:30:47 +02:00
Laurent Rineau 0b5a84b495 Merge pull request #6042 from sloriot/SMS-expensive_macros
Hide expensive assertions behind _expensive_ macros
2021-10-29 16:48:29 +02:00
Laurent Rineau e9c0217a6a Merge pull request #6048 from sloriot/Argt-null_rad
Avoid creating a circle with 0 radius
2021-10-29 16:48:27 +02:00
Laurent Rineau b65497a870 Merge pull request #6049 from danston/Number_types-rename_eigen_test-danston
Renamed Eigen Test in NT
2021-10-29 16:48:25 +02:00
Laurent Rineau d9a6062f87 Merge pull request #6051 from MaelRL/PMP-Forward_GT_orient_to_bound_volume-GF
PMP: Forward the geometric traits in `orient_to_bound_a_volume()`
2021-10-29 16:48:23 +02:00
Laurent Rineau 60fd5bfa67 Merge pull request #6066 from sloriot/Interpolation-warning
Remove c++17 deprecation warning
2021-10-29 16:48:20 +02:00
Laurent Rineau 861204d118 Merge pull request #6068 from sloriot/PMP-sampling_doc
Fix NPs and improve doc
2021-10-29 16:48:18 +02:00
Laurent Rineau 633f59389f Merge pull request #6074 from sloriot/SMS-GH_deg_faces
Workaround degenerate faces
2021-10-29 16:48:16 +02:00
Laurent Rineau eb101fc161 Merge pull request #6076 from danston/Documentation-fix_tuto_reconstruction-danston
Added Missing Call to the Remove Method in the Reconstruction Tutorial
2021-10-29 16:48:14 +02:00
Dmitry Anisimov 9fc7d9670e added missing call to the remove method 2021-10-21 17:33:29 +02:00
Sébastien Loriot 72b8f75f48 workaround degenerate faces 2021-10-21 11:21:04 +02:00
Sébastien Loriot b793e7cd90 fix NPs and improve doc 2021-10-19 17:38:12 +02:00
Sébastien Loriot 6f5c0edd5a remove c++17 deprecation warning 2021-10-19 15:11:04 +02:00
Mael Rouxel-Labbé 1ab6b44d7d Fix NP forwarding in volume_CC 2021-10-15 10:22:08 +02:00
Mael Rouxel-Labbé 1f73af6cc4 Drive-by cleaning 2021-10-14 11:09:04 +02:00
Mael Rouxel-Labbé 91e7f1d20c Forward the geom traits in orient_to_bound_a_volume 2021-10-14 11:06:04 +02:00
Dmitry Anisimov d9bd316750 renamed eigen test 2021-10-13 16:00:06 +02:00
Sébastien Loriot fb46a94682 avoid creating a circle with 0 radius 2021-10-12 10:15:01 +02:00
Mael Rouxel-Labbé 07948c7066 Constify the 'operator[]' of non-mutable lvalue pmaps with 'put()'s 2021-10-11 12:02:22 +02:00
Sébastien Loriot 75e6e4500f hide expensive assertions behind _expensive_ macros 2021-10-11 11:57:24 +02:00
Mael Rouxel-Labbé 480c14564a Don't base reference detection on lvalue_property_map_tag 2021-10-08 15:42:01 +02:00
Mael Rouxel-Labbé 2331eb7cf4 Fix comment 2021-10-08 15:41:54 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé 1660611e76 Use local typenames directly 2021-10-08 13:23:38 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Laurent Rineau c8eda9deca Merge pull request #6030 from MaelRL/CGAL-Minor_fixes-GF
Fix uninitialized id maps in heat method
2021-10-07 14:25:12 +02:00
Mael Rouxel-Labbé d5886187b4 Add a static assertion about the Heat Method mode 2021-10-05 12:14:03 +02:00
Mael Rouxel-Labbé 863ab7541c Various whitespace fixes 2021-10-05 12:14:03 +02:00
Mael Rouxel-Labbé 84d84278b9 Fix VPM type 2021-10-05 12:14:02 +02:00
Mael Rouxel-Labbé 8d7071352f Fix uninitialized id maps in SM_distance_3 2021-10-05 12:14:02 +02:00
Laurent Rineau c3da178b52 Merge pull request #5994 from MaelRL/PMP-Detect_sharp_edges_const-GF
Enhancements & fixes for PMP::detect_features
2021-09-29 11:44:19 +02:00
Laurent Rineau c369f357fb Merge pull request #6007 from lrineau/Installation-fix_CGAL_pointmatcher_support.cmake-GF
Fix CGAL_pointmatcher_support.cmake
2021-09-29 11:44:16 +02:00
Mael 4e5fbb6f22
Specify namespace
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2021-09-27 12:15:09 +02:00
Mael Rouxel-Labbé 878d94e299 Fix sign call 2021-09-24 09:47:33 +02:00
Laurent Rineau 0f0f6c2cc9 Merge pull request #5997 from gdamiand/GraphicsView-is_facet_convex-gdamiand
GraphicsView: Bug Fix in Buffer_for_vao::is_facet_convex()
2021-09-23 16:10:33 +02:00
Laurent Rineau 9e30160ad0 Fix CGAL_pointmatcher_support.cmake
Fix https://github.com/CGAL/cgal/issues/5346

The quotes around `${libpointmatcher_LIBRARIES}` are harmful.
2021-09-22 14:39:34 +02:00
Mael Rouxel-Labbé 2bc5643972 Fix comparison 2021-09-21 16:50:19 +02:00