Maxime Gimeno
0b2436d062
Clean-up after review
2018-05-29 15:59:54 +02:00
Sébastien Loriot
b81453868b
fix the handling of constrained vertices
2018-05-29 15:59:54 +02:00
Sébastien Loriot
5738a11841
swap halfedges to guarantee that constrained halfedges are kept
...
this is only requires in case prev(opposite(he)) is constrained
since if there is a constrained vertex it is vb.
2018-05-29 15:59:54 +02:00
Sébastien Loriot
abe346f8d2
consider any vertex incident to a constrained as constrained
2018-05-29 15:59:54 +02:00
Sébastien Loriot
de3d654a72
simplify the code collapsing edges
...
handles corner and constrained vertices
2018-05-29 15:59:10 +02:00
Sébastien Loriot
53164edc5a
a vertex of degree less than 3 is on the boundary
...
collapsing an edge incident to it should be controlled only
by the constrained status of the vertices
2018-05-29 15:59:10 +02:00
Sébastien Loriot
d3caff29dc
fix indentation
2018-05-29 15:59:10 +02:00
Sébastien Loriot
34a66797b5
the corner status of a vertex is already taken into account in the code
...
it is meaningful for collapse and smooth that are using is_corner function
2018-05-29 15:59:10 +02:00
Maxime Gimeno
a779db591c
Make Isotropic_remeshing keep the constrained vertices when collapsing an edge.
2018-05-29 15:58:19 +02:00
Sébastien Loriot
37bd8c1d84
fix typos
2018-05-28 17:37:47 +02:00
Sébastien Loriot
f29d8339fa
document corefine_and_compute_boolean_operations()
2018-05-28 17:37:46 +02:00
Sébastien Loriot
67ec602795
remove a restriction on the output vpm
...
they no longer requires to be of the same type.
This is particularly important especially since we might
ignore some of them.
2018-05-28 17:37:17 +02:00
Sébastien Loriot
d3a9f655af
replace bool parameter throw_on_self_intersection with a named parameter
...
used it at the same time in Boolean operation functions
2018-05-28 17:37:17 +02:00
Sébastien Loriot
eea53718bb
renaming
2018-05-28 17:37:17 +02:00
Sébastien Loriot
a097455ab3
doc update
2018-05-28 17:37:16 +02:00
Sébastien Loriot
3c382accca
document the default new face visitor
...
I have to move everything in the CGAL::PMP::Corefinement because
CGAL::Corefinement was strange for a publicly documented type
2018-05-28 17:37:16 +02:00
Sébastien Loriot
c554738ea1
update after Mael's review
2018-05-28 17:37:15 +02:00
Sébastien Loriot
20939d8a9a
test new face visitor in corefine and autorefine
2018-05-28 17:36:07 +02:00
Sébastien Loriot
699a43e47f
document the new named parameter
2018-05-28 17:36:07 +02:00
Sébastien Loriot
a207317cf5
add a parameter in corefinement functions to track the creation of new faces
2018-05-28 17:36:07 +02:00
Laurent Rineau
e86c3c4bba
Merge pull request #3102 from afabri/Property_map-empty_vector-GF
...
Property_map: Fix make_property_map(std::vector&) for an empty vector
2018-05-28 13:58:47 +02:00
Laurent Rineau
a7738b27c9
Merge pull request #3052 from maxGimeno/PMP-transform-GF
...
PMP: transform()
2018-05-28 13:58:16 +02:00
Laurent Rineau
851dfabd29
Merge pull request #2757 from maxGimeno/BGL-Add_facegraph_validity_check_function-GF
...
BGL: Add a FaceGraph validity check function
2018-05-28 13:58:07 +02:00
Maxime Gimeno
2adbfe0888
replace bool by cgal_no_property_::type in wrapper
2018-05-24 14:08:57 +02:00
Maxime Gimeno
57296468b1
Update doc for fimap
2018-05-24 12:46:16 +02:00
Maxime Gimeno
719033ad68
Create id-map on the fly if needed
2018-05-24 12:41:37 +02:00
Sébastien Loriot
f03f2176dd
do no collapse constrained edges
...
At the same time I removed halfedge_and_opp_removed since we don't
know prior to the collapse which edges are removed.
The only thing done by the function is to reset the status. This
is not an issue to remove it because halfedge_added is called
each time a new edge is created, thus a previous status cannot
be recovered by error.
2018-05-23 09:07:13 +02:00
Andreas Fabri
466a88077d
An empty soup is a mesh
2018-05-22 17:48:36 +02:00
Andreas Fabri
9abafecf9a
make the property map from the vector
2018-05-22 17:48:36 +02:00
Sébastien Loriot
be42fa9147
update ecmap_ during the remeshing
2018-05-18 17:07:14 +02:00
Sébastien Loriot
90faf5d060
simplify initialization of CC
2018-05-18 14:10:31 +02:00
Sébastien Loriot
42de73320a
only constrain edges split that were constrained before
2018-05-18 11:07:18 +02:00
Sébastien Loriot
43c6fd3635
make the projection optional
2018-05-18 10:59:26 +02:00
Sebastien Loriot
9938100097
Merge pull request #2955 from afabri/BGL-include_cleanup-GF
...
Do not include some BGL related header files
2018-05-15 22:21:42 +02:00
Laurent Rineau
5a5195a4f4
Merge branch 'master' into PMP-stitch_after_orient-GF
2018-05-15 16:11:14 +02:00
Andreas Fabri
077354f76e
Fix VC++ warning
2018-05-15 14:00:11 +01:00
Jane Tournois
76fd482cce
make collapse_constraints a parameter of collapse_short_edges
...
instead of a remesher global parameter
2018-05-15 12:52:32 +02:00
Sébastien Loriot
e08c1cdc4d
add an option to prevent the collapse of constrained edges
2018-05-15 12:21:05 +02:00
Jane Tournois
35125cd9a5
remove todo done by this PR
2018-05-15 11:23:46 +02:00
Jane Tournois
fbd982f7d8
document undocumented named parameters
...
and add extra info about split edges
2018-05-15 11:22:08 +02:00
Sébastien Loriot
73db555c5e
unconstrained an edge to be collapsed
2018-05-15 10:30:40 +02:00
Sébastien Loriot
ac8fbfd6aa
add a condition to make sure the flip does not create a non-manifold edge
2018-05-15 09:48:12 +02:00
Sébastien Loriot
6b601ccf80
update after Jane's review
2018-05-14 09:51:26 +02:00
Maxime Gimeno
9e78cb49c1
Rename Mesh in PolygonMesh for consistency with the rest of the package
2018-05-07 12:51:36 +02:00
Maxime Gimeno
ac5b0e73af
Fix warning
2018-05-07 12:51:36 +02:00
Maxime Gimeno
cb3b060d53
fix the doc
2018-05-07 12:51:36 +02:00
Maxime Gimeno
ca267506f8
Fix doc
2018-05-07 12:51:36 +02:00
Sébastien Loriot
b2fa6680d7
typo
2018-05-07 12:51:35 +02:00
Maxime Gimeno
3ca3d11512
Replace the tparam Transformation by any Functor with an operator()(Point_3) and use that operator instead of .transform() in the impl.
2018-05-07 12:51:35 +02:00
Maxime Gimeno
2f7d66e530
Clean-up
2018-05-07 12:50:41 +02:00
Maxime Gimeno
72c31ebfac
Add a function in PMP to apply a CGAL::Aff_transformation_3 to a mesh.
2018-05-07 12:50:41 +02:00
Sebastien Loriot
80acabc4b4
Merge pull request #3065 from maxGimeno/PMP-Do_intersect_with_different_vpm-GF
...
PMP: do_intersect() work with 2 types of VPM
2018-05-07 11:47:29 +02:00
Sebastien Loriot
1d6918ff4f
Merge pull request #2895 from kkatrio/triangulate_faces_fix
...
Triangulate faces : CDT2 / hole filling
2018-05-07 11:41:58 +02:00
Maxime Gimeno
9327e470c1
Fix doc
2018-05-04 16:11:25 +02:00
Maxime Gimeno
47635f11fe
Take fimap into account and add a test.
2018-05-03 14:55:49 +02:00
Andreas Fabri
991f3847e8
Do not include graph_traits_Polyhedron.h, properties_polyhedron.h and Polyhedron_iostream.h
2018-05-03 13:23:50 +02:00
Maxime Gimeno
9a77ece72f
Add a test
2018-05-03 12:50:30 +02:00
Maxime Gimeno
29e909b87b
Treat nm edges
2018-05-03 12:49:34 +02:00
Maxime Gimeno
861a6a16c5
Fixes
2018-05-03 12:49:34 +02:00
Maxime Gimeno
4a8375ce85
Optimize
2018-05-03 12:49:34 +02:00
Maxime Gimeno
68de1819cf
Move the code to the PMP functio nand document.
2018-05-03 12:49:34 +02:00
Maxime Gimeno
88899310ab
Fix massive typo in PMP test.
2018-05-03 12:03:14 +02:00
Maxime Gimeno
132cf694a0
remove is_valid() from the graph_traits
2018-05-03 12:03:14 +02:00
Maxime Gimeno
6dfa8d0ba3
replace CGAL_is_valid(Mesh) by CGAL::is_valid_polygon_mesh(Mesh)
2018-05-03 12:03:14 +02:00
Sébastien Loriot
c3255eee91
document projection functor named parameter
2018-05-01 14:15:27 +02:00
Sébastien Loriot
ec4675b451
do not build the aabb_tree and the cc map if not needed
2018-05-01 13:50:49 +02:00
Sébastien Loriot
54b6eb0fbc
handle case when there are no constrained edges
2018-05-01 13:50:43 +02:00
Maxime Gimeno
7e2255f797
do_intersect for 2 meshes work with 2 different types of VPM as long as their value_type is the same
2018-04-30 10:39:47 +02:00
Sébastien Loriot
ab9d668f52
first solution to correctly re-constrain edges refined
2018-04-29 13:13:58 +02:00
Sébastien Loriot
95d76709e8
isotropic remeshing can now use a user defined projection functor
...
you can pass it using a named parameter
2018-04-27 16:20:54 +02:00
Sébastien Loriot
742a615527
fix doc warnings triggered essentially by the improvement of doxygen
2018-04-25 23:36:21 +02:00
Laurent Rineau
92a7449cac
Merge pull request #3006 from sloriot/PMP_PSP-fixes_for_release
...
Pmp psp fixes for release
2018-04-24 17:34:21 +02:00
Laurent Rineau
dab01e9d20
Merge pull request #3020 from afabri/CGAL-VC2017permissive-GF
...
Fix compilation error with VC2017 and -permissive-
2018-04-24 17:33:05 +02:00
Andreas Fabri
37e677e989
Fix compilation error with VC2017 and -permissive- It looks like a compiler bug though
2018-04-13 12:01:23 +01:00
Andreas Fabri
c54a6a4980
Put CGAL::random_shuffle() in the subnamespace cpp98
2018-04-11 09:32:23 +01:00
Sébastien Loriot
348c0f92fa
do not overwrite output iterator, return it directly
2018-04-10 17:32:22 +02:00
Andreas Fabri
3955f031bd
Fix examples/tests/demos
2018-04-04 14:18:22 +01:00
Laurent Rineau
d057f6d9f1
Merge pull request #2958 from sloriot/PMP-coref_more_coplanar_fixes
...
Update incorrectly handled coplanar intersection computation
2018-03-28 17:46:24 +02:00
Laurent Rineau
237735ab73
Merge pull request #2946 from afabri/CGAL-dependencies-GF
...
Move properties from Mesh_3 to BGL, Polyhedron_3 and Surface_mesh
2018-03-27 10:35:23 +02:00
Sébastien Loriot
8553713885
update incorrectly handled coplanar intersection computation
...
follow up of 6bb6f470c4
2018-03-26 11:20:16 +02:00
Laurent Rineau
cd6fe20bd4
Merge branch 'releases/CGAL-4.11-branch'
2018-03-26 11:03:37 +02:00
Laurent Rineau
f1b94f0a2b
Merge pull request #2919 from sloriot/PMP-orient_handle_isolated_vertices
...
Handle isolated vertices
2018-03-26 10:56:05 +02:00
Laurent Rineau
1ef766c19b
Merge pull request #2932 from kkatrio/null-edge-hole-filling
...
PMP hole filling: null edge
2018-03-26 10:55:58 +02:00
Laurent Rineau
4b2e2db728
Merge pull request #2945 from sloriot/PMP-remove_si_improvements
...
Improvement of self-intersection removal using local remeshing
2018-03-26 10:55:51 +02:00
Laurent Rineau
0311d0063b
Fix deps
2018-03-22 17:29:00 +01:00
Andreas Fabri
8c41669fb7
move properties from Mesh_3 to BGL, Polyhedron_3 and Surface_mesh
2018-03-22 16:37:37 +01:00
Sébastien Loriot
640e78f92b
add an option to allow to change the genus
...
this is useful if the surface has some small artefact
that is not a topological disk
2018-03-22 11:15:47 +01:00
Sébastien Loriot
885f485ce1
use named parameter instead of default int and bool
2018-03-22 10:50:48 +01:00
Sébastien Loriot
56dca973be
add a debug function to dump faces of a cc into an OFF
2018-03-22 10:24:24 +01:00
Sébastien Loriot
6bb6f470c4
update incorrectly handled coplanar intersection computation
2018-03-21 16:51:24 +01:00
Sébastien Loriot
9240f29ff8
update test to check both combinaisons
2018-03-21 16:51:24 +01:00
Sébastien Loriot
dabd127d12
fix typo in the name of an internal function
2018-03-19 15:24:04 +01:00
Sébastien Loriot
d2e02c1eee
compactify the domain to be remeshed
...
we additional select faces that are incident to the selection
that are strictly inside the bounding box of the initial selection
2018-03-19 15:18:27 +01:00
Konstantinos Katrioplas
bec3227a00
add data test file
2018-03-16 15:13:42 +01:00
Konstantinos Katrioplas
0f14c1fad0
rm empty lines
2018-03-16 15:10:40 +01:00
Konstantinos Katrioplas
61735be71c
deny triangulation for input of 3 points or less when using all search space
2018-03-16 14:08:43 +01:00
Laurent Rineau
9708c41ad1
Off-topic, Mesh_3: fix a bug in detect_features
...
The commit cba3b1c20c from the PR #2336
was incomplete: there are two overloads of `sharp_call(..)` and it
fixed only one occurrence.
2018-03-15 15:27:07 +01:00
Sébastien Loriot
613eca7448
do not use Euler::add_face + reuse edges and faces scheduled for removal
2018-03-14 14:07:40 +01:00
Sébastien Loriot
0d8e21f25c
avoid recomputing self-intersections if not needed
2018-03-14 10:44:44 +01:00
Sébastien Loriot
5af7b56589
expand the selection only by CC (instead of globally)
2018-03-14 10:22:24 +01:00