Commit Graph

459 Commits

Author SHA1 Message Date
Laurent Rineau d309bc89ce fix typo "and and" 2025-09-30 17:11:15 +02:00
Laurent Rineau f4aa383177 add new runtime debug flags 2025-09-30 12:49:02 +02:00
Laurent Rineau b5a180d9df fix the confusion between `handle` and `const_handle` 2025-09-26 10:22:15 +02:00
Laurent Rineau 757cc8525d fix a warning
```
warning: array subscript 5 is outside array bounds of ‘std::array<const CGAL::Point_3<CGAL::Epick>*, 3> [1]’ [-Warray-bounds=]
```
2025-09-25 16:36:37 +02:00
Laurent Rineau 7df5c3a7bb fix warning: captured structured bindings are a C++20 extension [-Wc++20-extensions] 2025-09-25 16:26:13 +02:00
Laurent Rineau 3f088282c5 add comments
add comments
2025-09-24 18:32:39 +02:00
Laurent Rineau 44e3994c51 careful when the union-find has only one set 2025-09-24 18:31:20 +02:00
Laurent Rineau 1a2c061364 add another way to reduce to two sets with union-find 2025-09-24 18:29:42 +02:00
Laurent Rineau f6ebe208e9 extract a member function `detect_edges_and_cells_intersecting_region` 2025-09-24 16:59:32 +02:00
Laurent Rineau 5e80ca60bb fix when CGAL_CDT_3_CAN_USE_CXX20_FORMAT is false 2025-09-23 21:37:55 +02:00
Laurent Rineau 538c2721b3 add border_facet_above 2025-09-23 21:30:59 +02:00
Laurent Rineau 9a241b2a9d const-construct facets_of_border 2025-09-23 21:30:59 +02:00
Laurent Rineau 9726fb59bc const-construct vertex_above 2025-09-23 19:00:03 +02:00
Laurent Rineau 7267b3a347 refactor the definition of vertex_below_handle 2025-09-19 16:40:58 +02:00
Laurent Rineau 9d08d4087d missing is_marked 2025-09-19 16:40:12 +02:00
Laurent Rineau 92fab37129 add member fcts to handle vertex marks 2025-09-19 16:20:21 +02:00
Laurent Rineau c5ad5bb113 more concise code 2025-09-19 12:11:28 +02:00
Mael Rouxel-Labbé 0721be1a58 Use \link / \ref to add missing links of functions with parameters 2025-09-19 00:26:17 +02:00
Laurent Rineau 0b2ebbc23e extract debug output functions from construct_cavities 2025-09-18 16:57:54 +02:00
Laurent Rineau 0273049541 use if-constexpr instead of C++ preprocessor 2025-09-16 16:26:54 +02:00
Mael Rouxel-Labbé 3ccd3858ca Minor CDT3+tet remesh example improvements 2025-07-09 16:58:54 +02:00
Laurent Rineau 9e10beda8b protect a debug output 2025-07-03 11:04:25 +02:00
Laurent Rineau 7d828e506e fix headers 2025-07-02 15:36:03 +02:00
Jane Tournois 67fa8d6254 wip user manual round #8 2025-07-01 09:24:22 +01:00
Laurent Rineau e131dfc29d fix indentation 2025-06-26 18:28:03 +02:00
Sébastien Loriot 185bbd7cdd add missing tests 2025-06-26 18:13:37 +02:00
Laurent Rineau b60e378e27 WIP review 2025-06-26 10:28:30 +02:00
Jane Tournois b0e2dee7c9 doc 2025-06-25 17:42:25 +02:00
Jane Tournois d23fbd5b06 add a line about being planar 2025-06-23 16:51:23 +02:00
Jane Tournois 2e26fdcc5f Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-06-23 16:20:30 +02:00
Jane Tournois a281bddf6d doc fixes 2025-06-23 16:20:14 +02:00
Andreas Fabri 90a10dd7d6 Remove duplicate bibtex entry. The copy had no {} around the word to keep capitalized 2025-06-23 13:36:54 +01:00
Andreas Fabri 27da3eb559 Update Constrained_triangulation_3.txt 2025-06-23 14:11:26 +02:00
Jane Tournois ecfba4c9e7 consistency face/facet/polygon 2025-06-23 13:06:52 +02:00
Jane Tournois e53600f848 use new schonhardt polyhedron image 2025-06-23 12:38:11 +02:00
Jane Tournois 80ef4709cc wip review round 7 Monique 2025-06-23 12:27:30 +02:00
Jane Tournois 00dd38056c wip review round 7 Monique 2025-06-23 11:59:01 +02:00
Sebastien Loriot 200b4e4c4e typo 2025-06-20 13:44:54 +02:00
Jane Tournois 9b99d0e754 reorganize example and use non-manifold input 2025-06-19 12:00:26 +02:00
Sébastien Loriot b6bb23d81f Kernel recommandation proposal 2025-06-17 17:38:56 +02:00
Laurent Rineau df9b8f8390 reorganize the doc (Mael's review) 2025-06-16 17:40:52 +02:00
Laurent Rineau 0c8183c38f explain why Hang Si articles are used 2025-06-16 17:19:42 +02:00
Laurent Rineau 2be776e74f Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2025-06-16 17:14:32 +02:00
Laurent Rineau 0afe56dd8a "piecewise linear complex" in lowercase
Suggested by Andreas
2025-06-16 17:14:08 +02:00
Laurent Rineau e06a4c6f85 remove a duplicated sentence 2025-06-16 17:12:55 +02:00
Laurent Rineau 664e8dcd63 add section "Traits and Kernel Choice" 2025-06-16 17:09:54 +02:00
Jane Tournois 0860e790c4 Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-06-16 16:21:13 +02:00
Jane Tournois 57742e5a37 reset colors and remove screenshot with cutplane 2025-06-16 16:21:03 +02:00
Laurent Rineau a001ee036a better snippets for triangulation() 2025-06-16 15:04:20 +02:00
Laurent Rineau b305122323 "piecewise linear complex" in lowercase
Suggested by Andreas
2025-06-16 14:30:21 +02:00
Laurent Rineau 07b3574b19 add an intro to Triangulation_3 user manual 2025-06-16 12:08:21 +02:00
Jane Tournois 487c570eca trailing whitespaces 2025-06-13 19:45:09 +02:00
Jane Tournois ec02088928 doc fixes 2025-06-13 16:21:37 +02:00
Jane Tournois 9fb6dafd39 wip round 6 Mael 2025-06-13 16:17:36 +02:00
Jane Tournois 2675d5c0c1 merge preprocessing and corefinement examples 2025-06-13 15:58:04 +02:00
Jane Tournois fb898e9ab1 remove return_empty_on_invalid_input
and show in an example how to check preconditions
2025-06-13 14:30:05 +02:00
Jane Tournois 1323411457 doc 2025-06-12 17:56:14 +02:00
Jane Tournois 2a2651b343 doc (review round 6 Mael) 2025-06-12 17:42:00 +02:00
Jane Tournois e0324b6ff0 typo! 2025-06-12 17:20:32 +02:00
Jane Tournois 8ebfd91d8e review round 6 Mael (ref manual 1st part) 2025-06-12 13:53:34 +02:00
Sébastien Loriot 83c55db7f9 doc 2025-06-10 20:39:18 +02:00
Laurent Rineau 094f49f611 add a precision about "manifold" 2025-06-10 11:57:52 +02:00
Jane Tournois a27694ad44 doc
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-06-10 09:58:34 +02:00
Jane Tournois 7600e30fd4 fix doxygen warnings 2025-06-05 17:01:56 +02:00
Jane Tournois 0e3778ff1a face/facet vocabulary
the np is now plc_face_id
where "face" stands for "polygon" as in FaceListGraph for example
2025-06-05 16:10:21 +02:00
Jane Tournois 1120750e0c add link and use html list 2025-06-05 15:11:18 +02:00
Jane Tournois 6a08b3bdc9 user manual (review Monique + new cross image) 2025-06-05 14:55:59 +02:00
Jane Tournois f0715a5216 add links in user manual about examples, and smooth readability of examples 2025-06-05 12:35:48 +02:00
Jane Tournois 4f74701eee add link to CGAL::IO::write_MEDIT(ccdt) 2025-06-05 11:50:59 +02:00
Jane Tournois af7bbc6493 fix conversion warning 2025-06-05 09:58:05 +02:00
Jane Tournois 00c70004ec fix conversion warning (difference_type must be signed) 2025-06-04 16:17:06 +02:00
Laurent Rineau 08d39c959f bug-fix for Thingi-79020 2025-06-04 01:08:04 +02:00
Laurent Rineau 7a2f548768 a lambda function to factorize a piece of code 2025-06-04 00:52:38 +02:00
Laurent Rineau 2abdb4e6e4 fix the Doxygen link 2025-06-03 17:02:31 +02:00
Laurent Rineau 2cb68b7ce0 minor rephrases in the documentation 2025-06-03 16:59:11 +02:00
Jane Tournois 2bf182a302 add example to user manual and use plc_facet_id in output 2025-06-03 14:51:44 +02:00
Jane Tournois a910785202 keep on renaming NP and examples + document all examples
_from_soup.cpp's name was too long for msvc
2025-06-03 11:22:35 +02:00
Jane Tournois 1afaad6fdf use right named parameter name 2025-06-03 10:57:44 +02:00
Jane Tournois a75ddb4ba1 replace input with triangle mesh 2025-06-03 09:25:45 +02:00
Sébastien Loriot 99c70b1ef2 fix doc errors 2025-06-02 19:03:19 +02:00
Jane Tournois 2c06c028cf fix example 2025-06-02 17:04:05 +02:00
Jane Tournois c1bc60b067 rename example and change it to use planar patches
instead of patches that are separated by sharp edges (which may be non planar)
2025-06-02 15:41:07 +02:00
Jane Tournois fa45ad8943 rename example according to np `plc_facet_id` 2025-06-02 12:54:57 +02:00
Jane Tournois 19f10ea890 rename plc_face_id to plc_facet_id 2025-06-02 12:49:03 +02:00
Jane Tournois 08e0d6b839 replace face by facet wherever it makes sense 2025-06-02 12:15:39 +02:00
Jane Tournois 9efcb22083 fix include 2025-06-02 12:12:15 +02:00
Jane Tournois 2145617b2c replace assertion with exception 2025-06-02 12:03:23 +02:00
Jane Tournois ab8fed4841 use try/catch to pre-catch non-planar PLC facets when CDT_2 fails 2025-06-02 11:22:38 +02:00
Jane Tournois 1f3e98abac replace face_patch_map with plc_face_id
the patches actually correspond to PLC faces,
which must be planar, and do not match the "face patches"
of PMP::isotropic_remeshing for example

+ add a np to CGAL::IO::write_MEDIT(ccdt) to save the corresponding PLC ids,
or just "1" everywhere as patch id
2025-05-30 16:52:00 +02:00
Jane Tournois bbc534f0b3 wip review monique round 5 2025-05-30 14:57:45 +02:00
Laurent Rineau e955df4e28 fix the example 2025-05-28 10:21:38 +02:00
Jane Tournois b49dccb35d vocabulary
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-05-26 15:44:02 +02:00
Jane Tournois e0ea913a3f image fixes 2025-05-26 12:40:07 +02:00
Jane Tournois 6bd4573e99 Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-26 11:23:32 +01:00
Jane Tournois a5671fe445 change package description thumbnail 2025-05-26 12:23:14 +02:00
Jane Tournois 2349549633 change title image vase->pyramid 2025-05-26 12:01:06 +02:00
Sébastien Loriot d6cea063c1 do not repeat package name 2025-05-26 11:48:22 +02:00
Laurent Rineau b39b1a4a65 need Eigen 2025-05-23 16:44:43 +02:00
Laurent Rineau 17d4e5cfd5 fix the example 2025-05-23 16:34:50 +02:00
Jane Tournois 9be03bd2d2 fix image colors, and caption 2025-05-23 16:21:11 +02:00
Laurent Rineau 4e591900d1 fix a bug in get_remeshing_triangulation 2025-05-23 15:42:08 +02:00
Laurent Rineau ee487a8c42 add an example of fpmap with region growing 2025-05-23 15:41:28 +02:00
Laurent Rineau 5d4cc6cb07 output the intermediate mesh to a file 2025-05-23 12:31:05 +02:00
Laurent Rineau b3722b1885 rename convert_to_triangulation_3 2025-05-23 12:30:32 +02:00
Laurent Rineau 2db51dbc85 additional pass on the user manual
In particular, @sloriot, I have added the subsection _Representation of Piecewise
Linear Complexes_, to talk about face IDs, among other things.
2025-05-22 15:23:23 +02:00
Laurent Rineau bb61127254 always use read_polygon_mesh and write_MEDIT 2025-05-21 15:34:47 +02:00
Laurent Rineau 3db82de277 Tr_of_default/Tr 2025-05-21 14:00:34 +02:00
Sébastien Loriot ef989ee51f add dependencies added by PMP::triangulate_faces and PMP::does_self_intersect 2025-05-21 10:16:44 +02:00
Laurent Rineau 73fd95ab6b fix warnings 2025-05-20 16:49:14 +02:00
Laurent Rineau a94a768c04 refactor write_MEDIT
... and use it more in CDT_3 examples
2025-05-20 16:49:02 +02:00
Laurent Rineau 37463c9150 2D case 2025-05-20 16:41:08 +02:00
Laurent Rineau 7955df7f66 remove ccdt.convert_for_remeshing()
and inline it into `CGAL::convert_to_triangulation_3(ccdt)`
2025-05-20 16:24:27 +02:00
Laurent Rineau f880735a57 remove the trailing call to PMP::autorefine 2025-05-20 13:55:07 +02:00
Laurent Rineau fec07c6488 Tr_or_default/Tr 2025-05-19 18:49:45 +02:00
Laurent Rineau ae597dd2ea review Mael 2025-05-19 18:47:14 +02:00
Laurent Rineau 4d5876392d doc of convert_to_triangulation_3(ccdt) 2025-05-19 18:34:32 +02:00
Laurent Rineau f3f72fcbf3 review Mael 2025-05-19 17:59:56 +02:00
Laurent Rineau aca6fbe2ea reorganize doc of make_conforming_constrained_Delaunay_triangulation_3 2025-05-19 17:57:17 +02:00
Laurent Rineau 5db49a1b89 review Mael 2025-05-19 17:14:57 +02:00
Laurent Rineau 9203757f57 review Mael 2025-05-19 16:43:22 +02:00
Laurent Rineau 881ce6df5b review Mael 2025-05-19 16:33:11 +02:00
Laurent Rineau 578ff5bdc6 use read_polygon_(soup|mesh) 2025-05-19 16:16:51 +02:00
Laurent Rineau f540227441 review my Mael 2025-05-19 16:16:36 +02:00
Laurent Rineau f619c0cf58 face/polygon 2025-05-19 16:00:38 +02:00
Laurent Rineau e2e6db6c47 Conforming _Constrained_ Delaunay Triangulation 2025-05-19 15:57:39 +02:00
Laurent Rineau 7c3ac1bcd1 use the introduction by Mael (rephrased a bit) 2025-05-19 15:57:06 +02:00
Laurent Rineau 6d0931d6c8 remove (face) and (faces) 2025-05-19 15:46:20 +02:00
Laurent Rineau 713b5d8d57 fix Figures 2025-05-19 15:29:30 +02:00
Laurent Rineau 6e3baa07a6 add a reference to the doc chapter Triangulation_3 2025-05-19 15:23:42 +02:00
Laurent Rineau fd1e8cac9f fix " : " 2025-05-19 15:04:42 +02:00
Laurent Rineau d07dc0daad remove the lambda expression
maybe solve that issue:
```
    21>C:\CGAL_ROOT\CGAL-6.1-Ic-155\include\CGAL/Conforming_constrained_Delaunay_triangulation_vertex_data_3.h(82,1): error C2888: '==::<lambda_f8bc645280bb56be32d0268df7c48762>': symbol cannot be defined within namespace 'CGAL' [C:\CGAL_ROOT\CGAL-6.1-Ic-155\cmake\platforms\MSVC-2019-Community-Release\test\Constrained_triangulation_3_Examples\ccdt_3_preprocessing.vcxproj]
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-155/Constrained_triangulation_3_Examples/TestReport_Christo_MSVC-2019-Community-Release.gz
2025-05-16 16:33:03 +02:00
Laurent Rineau 679ecb8ced doc: fix link to CGAL::IO::write_MEDIT(ostream&, CDT_3 const&) 2025-05-15 10:59:49 +02:00
Jane Tournois d14b1fdd6b apply Andreas' doc review
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2025-05-15 10:22:13 +02:00
Laurent Rineau 77833e3513 fix doc (figs) 2025-05-14 10:48:36 +02:00
Laurent Rineau 8e398f0aa2 (max) 2025-05-14 10:38:12 +02:00
Laurent Rineau afed97a9c6 test one example with TBB 2025-05-13 17:33:35 +02:00
Laurent Rineau 2035e0c312 refactoring 2025-05-13 17:32:31 +02:00
Sébastien Loriot fba1b5068e be consistant 2025-05-13 15:24:36 +02:00
Sébastien Loriot dca12bcd6b simplify patch id copies 2025-05-13 15:12:59 +02:00
Sébastien Loriot b1634370ae use triangle soup after autorefine as non-manifold edge will result in self-intersections in a mesh 2025-05-13 14:50:03 +02:00
Sébastien Loriot 2887ee0a36 reuse existing map 2025-05-13 14:49:30 +02:00
Sébastien Loriot d6146730a8 fix condition 2025-05-13 13:51:19 +02:00
Sébastien Loriot 57524e12e4 fix rw_points type and construction 2025-05-13 13:43:30 +02:00
Sébastien Loriot e4bd0348a4 avoid precondition checking after creating the mesh from a soup 2025-05-13 13:42:25 +02:00
Laurent Rineau 89966ea79b fix `polygon_id_to_sm_face_map`
The name was wrong, because one needs actually the mapping in two sides.
2025-05-13 12:33:01 +02:00
Sébastien Loriot 9b6bf75b11 missing call to orient soup 2025-05-13 11:43:49 +02:00
Sébastien Loriot 317b64d705 add a macro to reduce dependencies 2025-05-13 11:32:31 +02:00
Sébastien Loriot f40c64ba13 rename np 2025-05-13 11:26:47 +02:00
Sébastien Loriot 0064ea9f3e add missing precondition check for soup + always assert in debug 2025-05-13 11:20:26 +02:00
Jane Tournois 45e9662fd4 remove cdt_3_full_preprocessing for now 2025-05-12 18:39:00 +02:00