Commit Graph

598 Commits

Author SHA1 Message Date
Lingjie Zhu 3fed202004 fix manual 2018-12-06 16:00:36 +08:00
Lingjie Zhu 31be6b11cb fix negative min_error_drop 2018-12-06 15:51:48 +08:00
Lingjie Zhu 1bef922510 skip dummy functions in the doc 2018-12-06 14:50:15 +08:00
Lingjie Zhu 7f7360aa44 free function parameter report 2018-12-06 14:18:27 +08:00
Lingjie Zhu dad6a07e00 remove optional
adjust parameters before init, unspecified / out-of-bounds parameters are treated equally
2018-12-06 11:39:24 +08:00
Sébastien Loriot 07b923383c avoid warning 2018-12-05 17:47:26 +01:00
Sébastien Loriot dd27f658ed get rid of optionals
@aboudev I removed one named parameter as it was not used.
         Was it a bug?
2018-12-05 16:22:41 +01:00
Lingjie Zhu 936d42aca8 fix teleport test
possible failed with no teleportation
2018-11-30 10:45:27 +01:00
Lingjie Zhu 7182f1b533 add rendering seeds item
expose Proxy_wrapper struct
2018-11-30 10:45:26 +01:00
Lingjie Zhu 738295b1f6 update workflow figure 2018-11-30 10:45:26 +01:00
Lingjie Zhu 35d823e487 fix property map type 2018-11-30 10:45:26 +01:00
Sébastien Loriot fd6d3f6e10 fix doc warnings 2018-11-30 10:45:25 +01:00
Lingjie Zhu 86370bd192 remote optional in named parameters 2018-11-30 10:45:25 +01:00
Sébastien Loriot 142d97ccbc fix doxygen warnings 2018-11-30 10:45:24 +01:00
Sébastien Loriot 1e6f408f2f fix errors and warnings 2018-11-30 10:45:24 +01:00
Sébastien Loriot 3f236f0a18 update pck dependancies 2018-11-30 10:45:24 +01:00
Lingjie Zhu d4c48ff8d3 add package info dependencies 2018-11-30 10:45:24 +01:00
Lingjie Zhu efc7d7e9aa fix CMakeLists project names 2018-11-30 10:45:24 +01:00
Sébastien Loriot cbbc6d842e package depends on Eigen (for PCA) 2018-11-30 10:45:24 +01:00
Sébastien Loriot bea5987551 update for new convention 2018-11-30 10:45:21 +01:00
Lingjie Zhu c38fffcee1 benchmark use Surface_mesh 2018-11-30 10:45:19 +01:00
Lingjie Zhu ae3986d4e5 minor fixes 2018-11-30 10:45:19 +01:00
Lingjie Zhu 0417398d2d example use Surface_mesh 2018-11-30 10:45:19 +01:00
Lingjie Zhu c8ce944eb5 fix tests 2018-11-30 10:45:19 +01:00
Lingjie Zhu 99e1903d5d fix correctness test 2018-11-30 10:45:19 +01:00
Lingjie Zhu 3513a4e60c fix num_xxxx error 2018-11-30 10:45:18 +01:00
Lingjie Zhu ebad196840 test remesh on the fly 2018-11-30 10:45:18 +01:00
Lingjie Zhu a6c32b6279 copy data 2018-11-30 10:45:18 +01:00
Lingjie Zhu 8fe76d2ab6 fix default GeomTraits 2018-11-30 10:45:18 +01:00
Sébastien Loriot 2ad5f03a70 add data remove after filtering 2018-11-30 10:45:05 +01:00
Lingjie Zhu add74d7a5e fix example cmake 2018-11-30 15:32:34 +08:00
Lingjie Zhu ff785eba9f svg workflow figure 2018-11-30 15:32:34 +08:00
Sébastien Loriot 342e815d85 improve doc 2018-11-30 15:32:34 +08:00
Sébastien Loriot 6424377a94 no longer depend on Polyhedron, use PMP function instead 2018-11-30 15:32:34 +08:00
Sébastien Loriot b91dc57fd2 approximate_mesh -> approximate_triangle_mesh 2018-11-30 15:32:34 +08:00
Sébastien Loriot 9b8f82ea60 rename user manual input file 2018-11-30 15:32:34 +08:00
Sébastien Loriot f8c7ef3090 rename namespace from VSA -> Surface_mesh_approximation 2018-11-30 15:32:34 +08:00
Sébastien Loriot fa0577a25a rename subdirectory 2018-11-30 15:32:34 +08:00
Sébastien Loriot 15c4fed427 add license headers 2018-11-30 15:32:34 +08:00
Sébastien Loriot c9d4ab26df update signature to be consistent 2018-11-30 15:32:34 +08:00
Sébastien Loriot ad964de61d remove trailing whitespaces 2018-11-30 15:32:34 +08:00
Sébastien Loriot e2c7c233f1 lower case verb in brief 2018-11-30 15:32:34 +08:00
Sébastien Loriot b095d8011d change return type of find_best_merge() and update doc 2018-11-30 15:32:34 +08:00
Sébastien Loriot 79347110d3 cosmetic renaming of parameters 2018-11-30 15:32:34 +08:00
Lingjie Zhu 17248e5ac8 fix doc 2018-11-30 15:32:34 +08:00
Lingjie Zhu aae47434f7 fix benchmark 2018-11-30 15:32:34 +08:00
Sébastien Loriot 7bf5cff4cf accomodate update from master 2018-11-30 15:32:34 +08:00
Lingjie Zhu 2221f818b9 fix doc 2018-11-30 15:32:34 +08:00
Sébastien Loriot 1ab4276b44 fix link issue
most probably a doxygen bug
2018-11-30 15:32:34 +08:00
Sébastien Loriot 99e09bba7a use uppercase for enums and rephrasing 2018-11-30 15:32:34 +08:00
Lingjie Zhu 4d5f2ee7ca change parameter order 2018-11-30 15:32:34 +08:00
Lingjie Zhu 0aa0eac88e fix naming 2018-11-30 15:32:34 +08:00
Lingjie Zhu 70ad3d2984 initialize seeds with named parameters 2018-11-30 15:32:34 +08:00
Lingjie Zhu 379daa1074 add directories reflecting the namespace 2018-11-30 15:32:34 +08:00
Lingjie Zhu 583c9f5912 list calling steps in the API 2018-11-30 15:32:34 +08:00
Lingjie Zhu e9ca4e5086 grouped named parameters in one page 2018-11-30 15:32:34 +08:00
Lingjie Zhu 128ed79997 fix benchmark 2018-11-30 15:32:34 +08:00
Lingjie Zhu 1c54d9660f fix compile issue 2018-11-30 15:32:34 +08:00
Lingjie Zhu 30d6058bf1 fix number to add in error diffusion 2018-11-30 15:32:34 +08:00
Lingjie Zhu e96a8a6d8e add output to example and test 2018-11-30 15:32:34 +08:00
Lingjie Zhu 095f2da2e7 add output function with named parameters in class interface
keep trivial output functions internal in the doc
2018-11-30 15:32:34 +08:00
Lingjie Zhu e1b5252f19 remove setup functions
get rid of set_mesh, set_metric, rebuild functions
2018-11-30 15:32:34 +08:00
Lingjie Zhu e27a6b2b51 remove default constructor 2018-11-30 15:32:34 +08:00
Lingjie Zhu 1f78b9590c grouping named parameters 2018-11-30 15:32:34 +08:00
Lingjie Zhu 3fdd1ee45b facet -> face everywhere 2018-11-30 15:32:34 +08:00
Lingjie Zhu 878e0f3ad0 facet -> face 2018-11-30 15:32:34 +08:00
Lingjie Zhu 4b03e9de89 seeding -> initialize_seeds 2018-11-30 15:32:34 +08:00
Lingjie Zhu b3c0cf16a5 facet_proxy_map -> face_proxy_map 2018-11-30 15:32:34 +08:00
Lingjie Zhu 851cf8c49a max_nb_proxies -> max_nb_of_proxies 2018-11-30 15:32:34 +08:00
Lingjie Zhu e91b469190 move free function and enumerations in namespace VSA 2018-11-30 15:32:34 +08:00
Lingjie Zhu 0711b40335 fix verbose level 2018-11-30 15:32:34 +08:00
Lingjie Zhu 201f3145bb fix template parameter, remove unnecessary grouping 2018-11-30 15:32:34 +08:00
Lingjie Zhu eabcfd2d08 never take a reference over a descriptor 2018-11-30 15:32:34 +08:00
Lingjie Zhu cfd47020bd switch parameter order in ErrorMetricProxy concept 2018-11-30 15:32:34 +08:00
Lingjie Zhu a8a0eb5aa8 fix citation 2018-11-30 15:32:34 +08:00
Lingjie Zhu 08a7c7595a add more references 2018-11-30 15:32:34 +08:00
Lingjie Zhu 4a9a1ae57e L21_metric_vector_proxy -> L21_metric_plane_proxy.h
better name for quadric surface
2018-11-30 15:30:51 +08:00
Lingjie Zhu a2b972b779 add note about parameters 2018-11-30 15:30:51 +08:00
Lingjie Zhu bdff796260 add error metric recommendation 2018-11-30 15:30:51 +08:00
Lingjie Zhu 0eeed88a85 fix tparam in manual 2018-11-30 15:30:51 +08:00
Lingjie Zhu 679cb1e1fa fix GeomTraits requirements 2018-11-30 15:30:51 +08:00
Lingjie Zhu 3e016af3b5 adjust test file naming 2018-11-30 15:30:51 +08:00
Lingjie Zhu a771e0903b fix todo: convert from soup to polyhedron mesh 2018-11-30 15:30:51 +08:00
Lingjie Zhu 2eff2a965d deal with degeneracy in examples 2018-11-30 15:30:51 +08:00
Lingjie Zhu 41ea383829 fix todo of segments iteration 2018-11-30 15:30:51 +08:00
Lingjie Zhu 7a52839028 fix clashing doxygen link
Polygon_mesh_processing named parameters has same doxygen tag
It is caused by the doxygen dependency
2018-11-30 15:30:51 +08:00
Lingjie Zhu ead51b5c07 add ref to PolygonSoups 2018-11-30 15:30:51 +08:00
Lingjie Zhu 3bcf533cf5 move named parameters under namespace VSA
both error metrics and parameters are in the same namespace
2018-11-30 15:30:51 +08:00
Lingjie Zhu 259a9bdb0c move input requirements to the top of user manual 2018-11-30 15:30:51 +08:00
Lingjie Zhu 991efc9034 fix typo and missing \tparam 2018-11-30 15:30:51 +08:00
Lingjie Zhu f5696aca49 fix naming
mesh_approximation to approximate_mesh
2018-11-30 15:30:51 +08:00
Lingjie Zhu 183a092e6b fix naming
class name VSA_approximation to Variational_shape_approximation
2018-11-30 15:30:51 +08:00
Lingjie Zhu c203a3a38f move file VSA_approximation.h to Variational_shape_approximation.h 2018-11-30 15:30:51 +08:00
Pierre Alliez b5beb48078 VSA doc:
rephrase triangulation.
minor changes.
2018-11-30 15:30:51 +08:00
Pierre Alliez 5b951d030e VSA: Minor changes on doc
Lingjie: one todo for you in example
2018-11-30 15:30:51 +08:00
Lingjie Zhu fe2bdbd5c9 fix clashed names with PMP named parameters
move named parameters from CGAL::internal_np to CGAL::Surface_mesh_approximation::internal_np
2018-11-30 15:30:51 +08:00
Lingjie Zhu 350c15a18a named parameter 'vsa' prefix to 'sma' 2018-11-30 15:30:51 +08:00
Lingjie Zhu 6560bab1ee fix unused parameter warning 2018-11-30 15:30:51 +08:00
Lingjie Zhu 5065974185 fix missing typename 2018-11-30 15:30:51 +08:00
Lingjie Zhu 5bf415fb31 fix ErrorMetricProxy
member function with face_descriptor and TriangleMesh parameter
FacetIterator to FaceRange template parameter
2018-11-30 15:30:51 +08:00
Lingjie Zhu da78cb080c fix ErrorMetricProxy concept 2018-11-30 15:30:51 +08:00
Lingjie Zhu 6d3abb2405 Compact_metric to precise Compact_metric_point_proxy 2018-11-30 15:30:51 +08:00
Lingjie Zhu 82d4501d92 remove area weighing l21 proxy 2018-11-30 15:30:51 +08:00
Lingjie Zhu 6f928384e8 add all_default named parameter 2018-11-30 15:30:51 +08:00
Lingjie Zhu 6ce0fe2ab5 tweak meshing named parameters
mesh_chord_error -> subdivision_ratio
is_relative_to_chord -> relative_to_chord
2018-11-30 15:30:51 +08:00
Lingjie Zhu 1f93c8558c update doc 2018-11-30 15:30:51 +08:00
Lingjie Zhu ee3c15e0fe optional extract mesh 2018-11-30 15:30:51 +08:00
Lingjie Zhu 74a8e9cfd5 add level of verbose 2018-11-30 15:30:51 +08:00
Lingjie Zhu 97372be65f l21 metric plane proxy to l21 metric vector proxy 2018-11-30 15:30:51 +08:00
Lingjie Zhu 73608d2510 extract_mesh with named parameters 2018-11-30 15:30:51 +08:00
Lingjie Zhu f679888c7e fix compilation error 2018-11-30 15:30:51 +08:00
Pierre Alliez b9be820b74 some TODOs 2018-11-30 15:30:51 +08:00
Pierre Alliez 9130cf7b63 more precise descriptions
more todos discussed with Sebastien
2018-11-30 15:30:51 +08:00
Pierre Alliez c5711852a4 massaging user manual 2018-11-30 15:30:51 +08:00
Pierre Alliez 8ca8794bda simpler named params. 2018-11-30 15:30:51 +08:00
Pierre Alliez c83079ac5a examples (simpler) 2018-11-30 15:30:51 +08:00
Pierre Alliez c50bb0593a named params 2018-11-30 15:30:51 +08:00
Pierre Alliez 64261f0acd shorter named parameters (code to update in accordance!)
namespace VSA for error metrics

file and classes renamed for error metrics (should be named xx_metric_yy_proxy)
2018-11-30 15:30:51 +08:00
Pierre Alliez 2d4a4c10fd named params 2018-11-30 15:30:51 +08:00
Pierre Alliez 455564ed56 Concepts
named params
2018-11-30 15:30:51 +08:00
Pierre Alliez 2bba817f39 massaging user manual 2018-11-30 15:30:51 +08:00
Pierre Alliez d67cf338a0 Error metric
user manual
2018-11-30 15:30:51 +08:00
Pierre Alliez 07cb9e4c52 cleanup examples 2018-11-30 15:30:51 +08:00
Pierre Alliez 1048255d6d massaging reference manual 2018-11-30 15:30:51 +08:00
Pierre Alliez fb4c41bcae massaging user manual 2018-11-30 15:30:51 +08:00
Pierre Alliez 4c227e134c simpler abstract 2018-11-30 15:30:08 +08:00
Lingjie Zhu a0937c4d01 fix manual 2018-11-30 15:30:08 +08:00
Lingjie Zhu 33913d6664 add_proxy_furthest -> add_to_furthest_proxies
maybe better name
2018-11-30 15:30:08 +08:00
Lingjie Zhu f5b27f3411 indexed triangle switch to CGAL::cpp11::array<std::size_t, 3> 2018-11-30 15:30:08 +08:00
Lingjie Zhu 11bcd9fa1e metric reference with groups 2018-11-30 15:30:08 +08:00
Lingjie Zhu 4bbda56a37 reference manual with groups 2018-11-30 15:30:08 +08:00
Lingjie Zhu 555c9ed342 ApproximationTraits to ErrorMetric 2018-11-30 15:30:08 +08:00
Lingjie Zhu a362d6d83a update doc 2018-11-30 15:30:08 +08:00
Lingjie Zhu 66f6c52a7b remove VSA_metrics.h 2018-11-30 15:30:08 +08:00
Lingjie Zhu 247ce2f858 switch demo/example/test/benchmark to Approximation traits 2018-11-30 15:30:08 +08:00
Lingjie Zhu b2d75c5879 add Approximation traits class 2018-11-30 15:30:08 +08:00
Lingjie Zhu f276cac096 remove Polyhedron output mesh
vsa_mesh_approximation + vsa_mesh_segmentation -> mesh_approximation
2018-11-30 15:30:08 +08:00
Lingjie Zhu 745f87e172 remove VSA namespace
CGAL::VSA::Metrics -> CGAL::Metrics
CGAL::VSA::parameters -> CGAL::Surface_mesh_approximation::parameters
2018-11-30 15:30:08 +08:00
Lingjie Zhu e94ee29de2 remove VSA namespace
CGAL::VSA::Mesh_approximation -> CGAL::VSA_approximation
2018-11-30 15:30:08 +08:00
Lingjie Zhu 2d9c6a1161 tm_in -> tm, FaceGraph -> FaceListGraph, remove hashable 2018-11-30 15:30:08 +08:00
Lingjie Zhu 74f5357120 remove free function VSA:: namespace 2018-11-30 15:30:08 +08:00
Lingjie Zhu 3fbad90a07 fix user manual
to Sebastien's review
2018-11-30 15:30:08 +08:00
Lingjie Zhu a34d2e651c fix error rounding up
code and document
2018-11-30 15:30:08 +08:00
Lingjie Zhu f2cc1a019b fix user manual
link to background of proxy
recommend for seeding
section not start with a figure
update workflow chart
2018-11-30 15:30:08 +08:00
Lingjie Zhu 9db2720d6f fix reference manual 2018-11-30 15:30:08 +08:00
Lingjie Zhu 2911a86b2f fix concept page 2018-11-30 15:30:08 +08:00
Lingjie Zhu b66c35aa83 remove get_ in member functions 2018-11-30 15:30:08 +08:00
Lingjie Zhu b593ef4622 fix proxy error update
should subtract error fitted to the original proxy not the new one
fix demo run m_iso_approx
2018-11-30 15:30:08 +08:00
Lingjie Zhu ae08e9a152 fix unused parameter warning 2018-11-30 15:30:08 +08:00
Lingjie Zhu b3a891e220 update demo cmake scripts
cmake version required update
optional verbose
get rid of include xx.cpp
fix duplicate optimize_anchor_location parameter and function name
2018-11-30 15:30:08 +08:00