Commit Graph

181 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 3ad1825359 Fix not being able to Rebind multiple time SMDS_3 / Tet Remesh Vb/Cb
If you have the following construct:

  class V : public Vb;

  class V_base
  {
    struct Rebind --> V;
  }

then you cannot rebind twice. More vicious, if Vb
can rebind twice multiple times (e.g. it's a T3 Vb),
then it'll silently drop V in the stack, and rebind
only up to the rebound Vb!

Rebinding multiple times happens for example in
Triangulation_hierarchy_3 (Delaunay_triangulation_3
with Fast_locate).
2023-07-21 09:55:01 +02:00
Mael Rouxel-Labbé 796baca1c5 Misc minor cleaning 2023-07-19 22:43:14 +02:00
Mael Rouxel-Labbé 4e824edf32 Improve doc of Simplicial_vertex_base_3 2023-07-19 22:35:56 +02:00
Mael Rouxel-Labbé e11bbab4f6 De-compactify Simplicial_mesh_cell_base_3
Give it a cell base instead of re-implementing everything.
2023-07-19 22:35:28 +02:00
albert-github 301728a8a9 issue #7395 Improvement of layout of model relations
- Completed the cgalModels part
2023-07-09 12:43:36 +02:00
Sébastien Loriot 54b7ae45cb add missing const 2023-06-28 13:41:08 +02:00
Andreas Fabri 57b2b7bceb Partial fix for SMDS_3. What is different for cells_in_complex() ? 2023-06-28 12:20:15 +01:00
Sébastien Loriot 640c98f21e add utility to avoid duplicate in variant + use it in SMDS_3 2023-06-15 11:34:14 +02:00
Sébastien Loriot 9cdfe70abb Merge remote-tracking branch 'sloriot/CGAL-toward_6.0' 2023-06-15 11:34:09 +02:00
Sébastien Loriot bbc48b2c7e more fixes
use Mesh_3::internal::get_index
std::dynamic_point_cast
std::get_if
2023-06-15 10:57:10 +02:00
Sébastien Loriot edc317d771 variant::which() => variant::index() + typos 2023-06-15 10:57:10 +02:00
Sébastien Loriot 9a0bdb5d96 boost::variant ---> std::variant 2023-06-15 10:57:10 +02:00
Laurent Rineau 08938cf326 Merge pull request #7480 from rdengate/appended_data_tag
Add missing AppendedData closing tag, so vtu binary file contains valid xml
2023-06-05 15:10:07 +02:00
Rebecca Dengate fb9f59d3a9 Adds missing AppendedData closing tag, so vtu binary file contains valid xml. 2023-05-30 16:35:10 +10:00
Mael 532b82cb9b
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-05-04 17:28:47 +02:00
Laurent Rineau 1dce90ee79 Merge remote-tracking branch 'cgal/master' into CGAL-allow_Epick_with_float-GF 2023-04-07 10:59:51 +02:00
Mael Rouxel-Labbé cd0c81a98a Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-03-20 10:14:27 +01:00
Jane Tournois e8e3eaa7b4 Merge remote-tracking branch 'cgal/master' into Mesh_3-triple_line_extraction-GF
# Conflicts:
#	Mesh_3/test/Mesh_3/CMakeLists.txt
2023-02-21 11:05:30 +01:00
Jane Tournois 9591cd6a94 vertices of 0 < dimension < 2 are removed as isolated
* corners and feature edges vertices are not removed (0 < dim < 2)
* far points (dim = -1) are removed as isolated vertices

the assertion
CGAL_assertion(far_vertices_.size() <= isolated.size());
started failing because of commit
3490fdd0c0
2023-02-07 11:39:53 +01:00
Sébastien Loriot 9e137bca24 Merge 'cgal/master' 2023-01-31 12:26:55 +01:00
Mael 8f703b54cb
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-01-27 21:48:32 +01:00
Laurent Rineau 7255c885bd Merge pull request #7139 from janetournois/SMDS_3-verbose_mode-jtournois
Tet_soup_to_c3t3 - reduce verbosity
2023-01-27 21:02:19 +01:00
Jane Tournois b7cd0f8538 doc
we keep vertices of dimension 0 and 1,
that may have a meaning for the user
2023-01-20 16:14:49 +01:00
Jane Tournois 3490fdd0c0 do not remove vertices of features (dimension 1 and 0) even if isolated
if the user has asked to insert these vertices, they should not be removed
2023-01-20 14:17:47 +01:00
Mael 4d22c90474
Merge branch 'master' into feature/bug_documentation_spell_20221113 2023-01-04 10:06:45 +01:00
Jane Tournois 2d04633e20 add if(verbose) when needed 2022-12-22 09:35:09 +01:00
Laurent Rineau cf04d506f3 Merge PR "Mesh_3, dump_c3t3: remove verbose flag" #7110 2022-12-14 10:28:21 +01:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Mael Rouxel-Labbé b115a680bf Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2022-12-06 09:47:46 +01:00
Mael Rouxel-Labbé 7789d060fb Minor code cleaning 2022-11-29 12:14:31 +01:00
Mael Rouxel-Labbé cf2b3cb4f1 Add some named parameters to read_MEDIT 2022-11-29 12:13:57 +01:00
Mael Rouxel-Labbé 0ae5cc28f9 medit IO improvements 2022-11-25 16:37:09 +01:00
Mael Rouxel-Labbé b5c21e1f5d Http -> https + update some dead links 2022-11-23 18:54:37 +01:00
Mael Rouxel-Labbé b10b84fb7f Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2022-11-18 16:47:07 +01:00
albert-github eed54a0ae5 spelling corrections
Some spelling corrections (Directories starting with `O`-`S` , first part),
some backward work
some forward work
2022-11-15 18:45:39 +01:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
Laurent Rineau 92d8d1c805 Merge remote-tracking branch 'cgal/master' into CGAL-allow_Epick_with_float-GF
# Conflicts:
#	Mesh_3/test/Mesh_3/test_meshing_3D_image.cpp
2022-11-08 12:11:06 +01:00
Laurent Rineau 8c9281f440 Merge pull request #6642 from sloriot/gsoc2022-boost_np
Replace usage of Boost parameters with CGAL named function parameters
2022-11-07 10:08:38 +01:00
Laurent Rineau d24b180293 Merge branch 'master' into gsoc2022-boost_np 2022-10-28 15:39:36 +02:00
Mael Rouxel-Labbé cb83e20ac7 Add a more generic check for non-manifoldness (it can be more than 4 inc cells) 2022-10-26 21:54:12 +02:00
Mael Rouxel-Labbé 9894286837 Fix returning failure if non-manifoldness is present but allowed 2022-10-26 21:53:40 +02:00
Mael Rouxel-Labbé 2a851b7ec4 Rename some variables / functions for clarity 2022-10-26 21:52:55 +02:00
Mael Rouxel-Labbé 3e2c8e0806 Fix debug messages not living behind a verbosity check 2022-10-26 21:50:42 +02:00
Mael Rouxel-Labbé ab360497ac Use a more generic way of getting the inf vertex position for clarity 2022-10-26 21:49:40 +02:00
Mael Rouxel-Labbé 41641086e0 Do not print "Error" if non-manifoldness is allowed
And clarify when this can happen
2022-10-26 21:49:31 +02:00
Mael Rouxel-Labbé 6852ad11ab Use emplace() / emplace_back() 2022-10-26 21:48:20 +02:00
Mael Rouxel-Labbé d30b5c1a7f Indentation fixes 2022-10-26 21:47:37 +02:00
Jane Tournois d279255f46 fix number type 2022-10-24 10:23:19 +02:00
Andreas Fabri c04dceb71d Merge master 2022-10-14 14:40:58 +01:00
Jane Tournois 66d448158c fix indentation 2022-10-13 12:44:09 +02:00
Jane Tournois a79239fc44 fix indices in ascii reader 2022-10-04 16:28:41 +02:00
Jane Tournois 95a8ee1912 move function up, before use 2022-10-04 14:45:17 +02:00
Jane Tournois a9f4ee7342 reorganize headers to separate tetrahedral and surface meshes IO 2022-10-04 14:22:54 +02:00
Jane Tournois 1f005793b0 add missing license header 2022-10-04 09:33:20 +02:00
Jane Tournois 8a05e4df23 move header outside demo 2022-10-03 16:00:41 +02:00
Jane Tournois 53d8734ad2 add tetrahedral mesh .tetra.am reader in C3t3_io_plugin 2022-10-03 15:31:14 +02:00
Jane Tournois 33816fa798 add verbosity 2022-10-03 12:33:32 +02:00
Sébastien Loriot 54a6462273 move code so that we can reinject mesh_3 parameters functions into NFP class 2022-09-26 20:09:58 +02:00
Mael Rouxel-Labbé 363d1daaef Some more conversions to non-package specific assertions 2022-09-23 15:20:24 +02:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Sébastien Loriot 861588abe1 Merge 'sloriot/CGAL-std_type_traits' into master 2022-08-03 20:19:51 +02:00
albert-github 5b31fc4579 SMDS_3 Incorrect link
We get the warning:
```
SMDS_3/include/CGAL/tetrahedron_soup_to_triangulation_3.h:210: warning: unable to resolve link to 'polygon_soup_to_polygon_mesh()' for \link command
```

see also:
- https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-5.6-Ic-16/logs_master/SMDS_3.log
- https://github.com/CGAL/cgal/pull/6645
2022-06-29 12:21:07 +02:00
Sébastien Loriot 05a6e2b150 workaround doxygen bugs 2022-06-20 10:57:50 +02:00
Sébastien Loriot fecc99535c fix typo 2022-06-20 10:04:44 +02:00
Jane Tournois 3656c632aa
Apply suggestions from Mael's code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:52:23 +02:00
Jane Tournois 55f853b9da
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:47:30 +02:00
Jane Tournois 15645e27a5
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:47:12 +02:00
Jane Tournois dc340f36fd
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:46:31 +02:00
Jane Tournois 0fbe473bc3
comma
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:46:07 +02:00
Jane Tournois 1efc36bf2a
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:45:19 +02:00
Jane Tournois b518ca1358
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:45:03 +02:00
Jane Tournois 477030b664
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:44:24 +02:00
Jane Tournois c50f323958
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:44:07 +02:00
Jane Tournois edcd0e5742
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:43:52 +02:00
Jane Tournois 42c1eb0496
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:43:31 +02:00
Jane Tournois c18c230947
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:43:08 +02:00
Jane Tournois de5298b820
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:30:04 +02:00
Jane Tournois 4e7535e16c
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:29:47 +02:00
Jane Tournois 2b4b30be8b
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:29:27 +02:00
Jane Tournois 2903333770
typo
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:28:53 +02:00
Jane Tournois 863dc0b5f0
add missing backticks
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:28:43 +02:00
Jane Tournois 8ac3417eb3
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:28:28 +02:00
Jane Tournois b1e2a0f127
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:28:17 +02:00
Jane Tournois 3ae3ce177b
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:27:59 +02:00
Jane Tournois dc9b081efd
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:27:46 +02:00
Jane Tournois 479c4c57e9
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:27:29 +02:00
Jane Tournois 56fff09944
doc
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-06-17 14:27:16 +02:00
Jane Tournois 2db4d016d7 rename graph->tmesh 2022-06-17 14:17:37 +02:00
Jane Tournois 572f1b5deb doc uniformization 2022-06-17 14:13:24 +02:00
Jane Tournois e696d30a21 undocument output_to_maya
only for the demo
2022-06-17 14:10:16 +02:00
Jane Tournois 4ed3519dcf typo 2022-06-17 11:36:41 +02:00
Jane Tournois c8b623a612 add missing links
they should be automatic, but not
2022-06-17 11:34:31 +02:00
Jane Tournois 02bcb6d521 apply Andreas' review 2022-06-17 11:31:56 +02:00
Jane Tournois a2f6d76a91 however/whether 2022-06-17 10:14:49 +02:00
Jane Tournois 41fb6d5eb2 whether/however 2022-06-14 17:19:13 +02:00
Jane Tournois 96466d75d7 there are three files:
a .node for the vertices,
a .ele for the cells, and
a .face for the triangles of the 2D complex.
2022-06-14 17:17:57 +02:00
Jane Tournois 7b30c01ff3 apply Laurent's review 2022-06-14 15:53:09 +02:00
Sébastien Loriot 51f08d1dbc use default for the functions 2022-06-08 23:25:54 +02:00
Jane Tournois b507b59d8a add default time stamps 2022-06-08 23:25:54 +02:00
Jane Tournois 811500529e P3T3 does not have range iterators 2022-06-08 23:25:54 +02:00