Commit Graph

113895 Commits

Author SHA1 Message Date
Laurent Rineau 89966ea79b fix `polygon_id_to_sm_face_map`
The name was wrong, because one needs actually the mapping in two sides.
2025-05-13 12:33:01 +02:00
Laurent Rineau eb696b07e8 Merge Triangulation_3-CDT_3-lrineau into lrineau/Triangulation_3-CDT_3-lrineau 2025-05-13 12:19:23 +02:00
Sébastien Loriot 9b6bf75b11 missing call to orient soup 2025-05-13 11:43:49 +02:00
Sébastien Loriot 317b64d705 add a macro to reduce dependencies 2025-05-13 11:32:31 +02:00
Sébastien Loriot f40c64ba13 rename np 2025-05-13 11:26:47 +02:00
Sébastien Loriot 0064ea9f3e add missing precondition check for soup + always assert in debug 2025-05-13 11:20:26 +02:00
Laurent Rineau 8798d15cfb Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2025-05-12 18:51:30 +02:00
Laurent Rineau 1ac837d236 fix warnings about uninitialized default-constructed values 2025-05-12 18:51:01 +02:00
Jane Tournois 45e9662fd4 remove cdt_3_full_preprocessing for now 2025-05-12 18:39:00 +02:00
Sébastien Loriot 6879158e32 typo 2025-05-12 17:50:47 +02:00
Sébastien Loriot 0aba404db4 workaround anchor issues by adding subgroups to disambiguate overloads 2025-05-12 17:47:53 +02:00
Jane Tournois f44cace75d add missing link to Basic_viewer 2025-05-12 17:05:49 +02:00
Jane Tournois abcc812ea4 fix compilation of tests 2025-05-12 16:20:47 +02:00
Jane Tournois dd27c1edf6 missing git add 2025-05-12 16:16:07 +02:00
Jane Tournois ebd9ecab58 documentation of check_preconditions, the new NP 2025-05-12 15:47:42 +02:00
Andreas Fabri 2a1b99ba5e Revert in FunctionObjectConcepts.h 2025-05-12 14:41:07 +01:00
Jane Tournois 270c507ce7 v0 of add named parameter check_preconditions()
optional parameter, to check a priori that preconditions are satisfied
2025-05-12 15:14:08 +02:00
Sébastien Loriot d60f2ce443 Merge remote-tracking branch 'cgal/6.0.x-branch' into `cgal/master` 2025-05-12 14:58:19 +02:00
Sébastien Loriot 149d1c2a3a add note about CGAL and pragma license messages 2025-05-12 14:47:25 +02:00
Andreas Fabri 206be8d951 more small fixes 2025-05-12 13:41:42 +01:00
Sebastien Loriot c6c9f77ae4
SMDS_3 - add `c3t3.set_triangulation()` (#8851)
When loading a .mesh file to a `Triangulation_3`, and then a `C3t3`, as
done in [this
example](https://doc.cgal.org/latest/SMDS_3/SMDS_3_2tetrahedron_soup_to_c3t3_example_8cpp-example.html)
leads to a `C3t3` for which `number_of_facets()` and `number_of_cells()`
return 0, because the internal counters have not been updated by
`c3t3.triangulation() = tr`.

It is not clear to the user why these numbers are 0, and the function
`rescan_after_load_of_triangulation()` (which fixes the counters) is not
documented.

## Summary of Changes

~~Add the use of `rescan_after_load_of_triangulation()` in an example.~~

~~The other option would be to use it automatically in the functions
that load a triangulation.~~

~~@lrineau @MaelRL do you have an opinion?~~

~~Todo : discuss the API~~

Add and document a function `c3t3.set_triangulation(const Tr& tr)` that
internally calls `rescan_after_load_of_triangulation()`, and is easier
to use

## Release Management

* Affected package(s): SMDS_3
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership: unchanged
2025-05-12 14:33:32 +02:00
Sébastien Loriot c1f034312d hide non-const version of the function in the doc 2025-05-12 14:31:43 +02:00
Andreas Fabri 91ee4fa605 Workaround for Visual 2017 2025-05-12 13:16:14 +01:00
Andreas Fabri 56f3e7a278 For testing refer to the wiki on github 2025-05-12 13:07:38 +01:00
Sebastien Loriot 88b04384ba
Basic viewer improvements (#8850)
_Please use the following template to help us managing pull requests._

## Summary of Changes

Some improvements to the basic viewer.

Following the GSOC 2024 project, see PR #8444, extract all the
modifications that concern the current basic_viewer qt (and keep in the
original PR the new basic viewer glfw that could be considered later).

## Changes to the documentation

- in `Graphics_scene`, functions to set/get default colors:
[diff](https://github.com/CGAL/cgal/pull/8850/files#diff-74c5383fef398c7cb3dbfaa8cbc836dbc5a3ad0a7b450442948e7e32d54ced47),
and
[documentation](https://cgal.github.io/8850/doc/Basic_viewer/classCGAL_1_1Graphics__scene.html)
- in `Basic_viewer`, same functions, plus functions for sizes:
[diff](https://github.com/CGAL/cgal/pull/8850/files#diff-cc9bfe7d72d61000248f90b7648c07decb71fd8a400ca54e3ecc8c808b0f70fa),
and
[documentation](https://cgal.github.io/8850/doc/Basic_viewer/classCGAL_1_1Qt_1_1Basic__viewer.html).

## Release Management

* Affected package(s): Basic_viewer
2025-05-12 14:06:35 +02:00
Jane Tournois 4083e353aa add an example with non-triangulated self-intersecting input 2025-05-12 13:00:32 +02:00
Andreas Fabri eaedf7661b Fix in Tutorial 2025-05-12 11:52:26 +01:00
Andreas Fabri 914b86b6b5 More trivial changes 2025-05-12 11:44:55 +01:00
Andreas Fabri bb9ebdff5a Developer Manual: trivial fixes 2025-05-12 11:14:13 +01:00
Jane Tournois edeac22b47 Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-12 12:12:51 +02:00
Jane Tournois ca1a5982b6 add an example with self-intersections and autorefinement 2025-05-12 12:12:32 +02:00
Sebastien Loriot 25d7076791
Avoid ambiguous overloads of operator= with optional and variant (#8879)
Does not replace #8854 that is a better implementation but currently not
fully compatible with older compilers.

Also loops around the issue with gcc-15, and fixes issue #8827.

See:
  - the CGAL https://github.com/CGAL/cgal/issues/8827,
- and the upstream gcc bug entry
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119859
2025-05-12 11:58:05 +02:00
Sébastien Loriot 190313e12a avoid ambiguous overloads of operator= with optional and variant
was showing up in inheritance of _or_drop_ version
2025-05-12 11:56:36 +02:00
Sébastien Loriot b366197efc missing deps 2025-05-12 11:45:24 +02:00
Sébastien Loriot 50716b777f do not use deprecated function 2025-05-12 11:36:53 +02:00
lvalque db44300956 Update Installation/CHANGES.md
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2025-05-12 11:36:21 +02:00
lvalque d4626c8fa2 Update Polygon_mesh_processing/benchmark/Polygon_mesh_processing/coplanar_cubes_autorefinement.cpp
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2025-05-12 11:28:11 +02:00
lvalque c53223576f Update Polygon_mesh_processing/benchmark/Polygon_mesh_processing/rotated_cubes_autorefinement.cpp
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2025-05-12 11:27:58 +02:00
Jane Tournois 144ec8de0f remove comment 2025-05-12 11:06:46 +02:00
Jane Tournois b70e78f22b document CGAL::IO::write_MEDIT 2025-05-12 10:52:19 +02:00
Jane Tournois 0c3b8b8b11 workaround static_assert for msvc <= 2019 2025-05-12 09:52:51 +02:00
Andreas Fabri 51a28c4d0a cleanup 2025-05-12 07:54:39 +01:00
Laurent Rineau 3409d4c974 fix warnings 2025-05-11 23:00:33 +02:00
Jane Tournois 71120ff1f2 fix cdt3 display 2025-05-09 16:52:24 +02:00
Laurent Rineau 7c2537b62a merge issue 2025-05-09 16:16:24 +02:00
Laurent Rineau e3190d62db other fixes for MSVC 2017 2025-05-09 16:14:18 +02:00
Jane Tournois 0830299bbf Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-09 16:04:33 +02:00
Jane Tournois 697101bf8e fix remeshing example and test
add edge_is_constrained_map to convert_to_triangulation_3()
similarly to what is done with a C3T3
2025-05-09 16:04:19 +02:00
Laurent Rineau c388b62f3b fixes for msvc 2017 2025-05-09 16:04:05 +02:00
Laurent Rineau a8fb8c5981 fix compilation of cdt_3_plugin 2025-05-09 15:29:01 +02:00