songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
101,484 Commits 3 Branches 156 Tags 959 MiB
Commit Graph

1224 Commits

Author SHA1 Message Date
Jane Tournois bccf3990f9 fix compilation 2022-11-08 11:36:07 +01:00
Jane Tournois 38fd07dfc4 differentiate has_normal_map() between const and non-const point set 2022-11-08 10:24:43 +01:00
Jane Tournois 0a43b5ff7d has_normals is const 2022-11-07 14:55:17 +01:00
Jane Tournois 826b2a19c4 Merge branch 'PSP-fix_has_normal_map-GF' of https://github.com/janetournois/cgal into PSP-fix_has_normal_map-GF 2022-11-07 13:15:55 +00:00
Jane Tournois 6555faf73f this is only for ranges, not for Point_set_3 2022-11-07 14:14:16 +01:00
Jane Tournois a24c6ac84c
Apply suggestions from Mael's code review 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2022-11-07 14:13:18 +01:00
Sebastien Loriot 04e4eec6fd
reuse static assertions 2022-11-07 10:44:02 +01:00
Sebastien Loriot 1a226ed877
Restore [revious API 2022-11-07 10:41:22 +01:00
Jane Tournois e99f442830 NP_helper::has_normal_map should not always return true 
look for a normal_map in the point set, and in the named parameters

# Conflicts:
#	BGL/include/CGAL/boost/graph/named_params_helper.h
#	Point_set_processing_3/include/CGAL/jet_estimate_normals.h
 2022-10-25 12:12:29 +02:00
Sebastien Loriot b0e4eeb841
Merge pull request #6556 from afabri/BGL-suppress_boost_warning-GF 
BGL: Suppress warning in boost
 2022-05-13 15:53:02 +02:00
Andreas Fabri 7e720deef4 The same for Point Set Processing 2022-05-04 17:00:19 +01:00
Mael Rouxel-Labbé 477353d5eb Merge parameters::Is_default and parameters::is_default_parameter 2022-04-20 16:01:02 +02:00
albert-github 772d26ac48 Point_set_processing_3: Missing end command for cgalParam 
A `\cgalParamEnd` was missing, resulting in an incorrect sequence of HTML tags (in the output just a small extra white space was shown)
 2022-03-14 19:36:37 +01:00
Sébastien Loriot 11c7c56718 Merge remote-tracking branch 'cgal/master' into HEAD 2022-01-18 09:11:52 +01:00
Sébastien Loriot 10b0af3092 rename macro since Named_function_parameter is part of STL_Extension 2022-01-13 14:43:34 +01:00
Sébastien Loriot 4fa826b3ed keep only the static version of is_default_parameter 2022-01-10 18:36:37 +01:00
Sébastien Loriot 75b03e6c0a use_default_values() -> default_values() 2022-01-10 18:36:37 +01:00
Sébastien Loriot 3d1f7e530e forgot to remove another default 2022-01-10 13:34:08 +01:00
Sébastien Loriot 6d3176e061 move Named_parameters class in STL_extension 
helpers stay in BGL because it depends on BGL tags
 2022-01-07 15:12:22 +01:00
Sébastien Loriot c8b0c157cc plane_index_map is not optional! 
update doc + cleaner static assert
 2022-01-07 14:03:41 +01:00
Sébastien Loriot 8d4e63bbe9 more simplification and use existing classes 2022-01-07 13:48:04 +01:00
Sébastien Loriot f7c8e4919a add static function to check for the presence of a normal map 2022-01-07 13:10:29 +01:00
Sébastien Loriot b6ac238355 missing ; 2022-01-07 10:12:29 +01:00
Sébastien Loriot 162225d9bb fix warnings 2022-01-07 09:25:31 +01:00
Sébastien Loriot 9112001f33 fix doc 2022-01-06 19:11:54 +01:00
Sébastien Loriot 821e7b79a2 remove some Point_set_processing specific helper classes 2022-01-06 18:53:46 +01:00
Sébastien Loriot 5f1803489b replaces overloads with default NamedParameters for Point_set_processing_3 
+enhancement of the NP for Point_set_processing_3
 2022-01-06 15:11:23 +01:00
Andreas Fabri c924cfdc00 merge master 2022-01-04 13:53:50 +00:00
Andreas Fabri fe3ca0e092 Remove callback (also from the named parameters) 2022-01-04 13:48:59 +00:00
Sébastien Loriot a6d9b99466 move macros in BaseDoxyfile 2022-01-04 11:10:09 +01:00
Andreas Fabri 65f97a599b representant -> representative and change < to <= 2021-12-28 10:21:05 +00:00
Laurent Rineau 5897f379ba Merge pull request #6133 from MaelRL/CGAL_IO-PWN_without_normals-GF 
Minor improvements for OFF/XYZ point set IO
 2021-12-20 18:06:41 +01:00
Mael Rouxel-Labbé ee1622e14a Don't write "NOFF" if there are no normals 2021-12-16 14:44:13 +01:00
Laurent Rineau 17a7d8cfbc Merge pull request #6130 from cjamin/patch-1 
Bug fix: `remove_outliers` was removing ALL points when no outliers were found
 2021-11-25 17:28:39 +01:00
Mael Rouxel-Labbé 27f55f1dcf Fix previous syntax error fix 2021-11-17 09:46:29 +01:00
Mael Rouxel-Labbé 862f3ee4f9 Misc minor enhancements 2021-11-17 09:46:17 +01:00
Mael Rouxel-Labbé 25f5b91de5 Return a reading error for NOFF without normals 2021-11-17 09:41:52 +01:00
Clément Jamin 7f72142818
Remove trailing whitespaces 2021-11-16 17:15:46 +01:00
Clément Jamin c5d341b960
If no outliers are found, just return the original range 2021-11-16 16:06:30 +01:00
Clément Jamin ffe7a6909a
Improve `std::partition` predicate 2021-11-16 15:48:48 +01:00
Clément Jamin 597970b368
Bug fix: `remove_outliers` was removing ALL points when no outliers were found 
Bug in current code: when no outliers are found, `f2r` is `sorted_points.end()`. So, `if (sit == f2r)` is never true, and `out` keeps its initial value, which is `points.begin()`.
 2021-11-16 12:06:32 +01:00
Sébastien Loriot 4eb1464aed fix Identity_map mutability and fix CGAL code using it 2021-11-09 11:37:24 +01:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps: 
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
 2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Laurent Rineau a36fbb85d8 Merge pull request #6018 from afabri/PSP-check_open_close-GF 
Unset fail bit and add assertions about the state of a stream
 2021-09-30 16:49:37 +02:00
Laurent Rineau 7fc986f581 Merge pull request #5992 from afabri/CGAL-safe_functions-GF 
Deal with memset, memcpy, fscanf...    and their safe equivalents
 2021-09-29 11:46:44 +02:00
Laurent Rineau ad79d37410 Merge pull request #6014 from MaelRL/CGAL-IO_Clarify_binary_text-GF 
CGAL IO: Clarify binary warning
 2021-09-29 11:46:30 +02:00
Andreas Fabri 716dcaf6c9
Apply suggestions from code review 
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
 2021-09-28 13:57:40 +02:00
Andreas Fabri 4d1f12d1e2 Unset fail bit and add assertions about the state of a stream 2021-09-28 10:41:50 +01:00