Commit Graph

1056 Commits

Author SHA1 Message Date
Laurent Rineau a10d75d2da remove compilation error 2023-07-17 15:46:03 +02:00
Sebastien Loriot 57b7edb6a3
Apply suggestions from code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2023-07-12 10:41:44 +02:00
Sébastien Loriot 560186b432 fix one more warning 2023-07-10 13:25:38 +02:00
Sébastien Loriot 4e6fe0c561 fix unused variable warnings 2023-07-06 18:06:03 +02:00
Laurent Rineau 4b18c7208a fix warnings 2023-06-27 17:29:37 +02:00
Laurent Rineau 28ab0b7c3e another bug-fix
Jane and I thought that case

  vertex-vertex with `ch_next != Cell_handle()`

was not possible. Let's patch that.
2023-06-21 10:19:39 +02:00
Laurent Rineau 4a7f9269dc another bug fix?! 2023-06-20 17:31:13 +02:00
Laurent Rineau 367466c434 Merge branch '5.5.x-branch' into Triangulation_3-fix_simplex_traverser-GF 2023-06-20 14:48:05 +02:00
Laurent Rineau 4f94c70740 typos 2023-06-19 17:15:42 +02:00
Laurent Rineau 6edb602729 factorize code when cells are traversed 2023-06-19 17:11:19 +02:00
Laurent Rineau 14ff8c6af5 fix bugs 2023-06-19 17:06:10 +02:00
Laurent Rineau f193744e66 walk_to_next_3: reformat to indentation by 2 space 2023-06-16 18:35:14 +02:00
Laurent Rineau dcfd783953 change/fix some oddities in the code 2023-06-16 18:07:22 +02:00
Laurent Rineau 5a0c09d667 factorize/reformat the code
The cases `chnext == {}` and `chnext != {}` were actually very
similar.
2023-06-16 17:48:32 +02:00
Laurent Rineau 6b835a1799 use triangulation().tds().has_vertex to avoid dummies 2023-06-16 15:35:18 +02:00
Laurent Rineau 5c81b975ae triangulation() is now a reference 2023-06-16 15:33:02 +02:00
Laurent Rineau 80a4064350 chprev/chnext 2023-06-16 15:23:50 +02:00
Laurent Rineau 169985ea96 fix remaining cases even with permutations
Now I am quite confident that the code is correct.
2023-06-16 12:37:08 +02:00
Laurent Rineau 42f8b92c1d add comments 2023-06-16 11:50:35 +02:00
Laurent Rineau 8207105503 fix accidental use of std::optional (boost:: instead) 2023-06-15 18:07:52 +02:00
Laurent Rineau c7130e0c58 fix test case 131I 2023-06-15 16:41:07 +02:00
Laurent Rineau 4f20dc0f44 fix case 31 2023-06-15 15:50:51 +02:00
Laurent Rineau 9f4b8d5785 fix case I232 2023-06-15 13:16:28 +02:00
Laurent Rineau 00aa91967b `prev` then `cur` is more logic 2023-06-15 12:33:00 +02:00
Laurent Rineau e574a3a191 fix case 132I 2023-06-15 12:32:35 +02:00
Laurent Rineau 9cd8f0e8e1 fix case 12 2023-06-15 11:32:41 +02:00
Laurent Rineau b9eea8ec0d bug-fix test case 121 2023-06-14 21:12:15 +02:00
Laurent Rineau d5f5a6e2cd buf-fix for case 032I 2023-06-13 17:19:03 +02:00
Laurent Rineau 67b2d1c770 bug-fix of case "230 with bbox" 2023-06-12 18:06:40 +02:00
Laurent Rineau 5048eb960d bug-fix!!
I have been working on that issue for a few days. Eventually I found
the bug.
2023-06-12 16:45:16 +02:00
Laurent Rineau 5dceac54ef cosmetic changes 2023-06-12 16:43:51 +02:00
Laurent Rineau 6ab1337951 Merge pull request #7496 from lrineau/Triangulation_3-fix_regular_with_TBB-GF
Regular_triangulation_3: fix another race-condition
2023-06-07 17:36:25 +02:00
Laurent Rineau 8cd8bc7b06 another fix of a race-condition 2023-06-04 20:49:02 +02:00
Laurent Rineau f09c70bb96 Merge branch '5.4.x-branch' into 5.5.x-branch 2023-05-19 18:26:49 +02:00
Jane Tournois c7f75a9030 wip fixes for simplex traverser
* test_segment_simplex_traverser_3 first failing test is now "032"
* the geometric intersection test fails because of doubles
2023-05-16 18:35:54 +02:00
Laurent Rineau 5a85381d4c remove a trailing whitespace
This time I think I managed to fix my VS Code  Insiders settings to fix that
issue permanently.
2023-05-16 16:13:05 +02:00
Laurent Rineau 97262bf0e9 Triangulation_3: fix a race-condition in regular
The race condition is in the batch insertion of a range
of points, with or without info.
2023-05-16 15:56:32 +02:00
Jane Tournois 4bf7c45c8b replace std::tuple Simplex with a struct
and then avoid all std std::get<i>(simplex), hard to read
2023-05-15 13:06:37 +02:00
Laurent Rineau 4e14700ab4 Remove cases of OUTSIDE_AFFINE_HULL 2023-05-12 16:57:25 +02:00
Jane Tournois 087492b72d replace dealing with OUTSIDE_AFFINE_HULL
with tests on cell_iterator == end()
2023-05-12 16:13:30 +02:00
Laurent Rineau f181a8b7f7 additional bug-fix 2023-05-11 18:08:16 +02:00
Laurent Rineau 2b94f06f57 Remove trailing whitespces 2023-05-11 16:32:34 +02:00
Laurent Rineau 7260a9497c Add debug tool
Protected by the macro CGAL_DEBUG_TRIANGULATION_SEGMENT_TRAVERSER_3
2023-05-11 16:18:16 +02:00
Laurent Rineau 6f22c113df WIP on the Triangulation_segment_cell_iterator_3 2023-05-11 15:13:16 +02:00
Laurent Rineau 59d7a6306b cosmetic changes 2023-05-11 11:53:13 +02:00
Laurent Rineau 7a2c543b06 replace assert(false) by CGAL_unreachable() 2023-05-11 11:49:57 +02:00
Laurent Rineau dd738bf029 bug fix for the simplex traverser 2023-05-04 14:58:05 +02:00
Laurent Rineau c2fa2cb9fe Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:18:57 +02:00
Laurent Rineau 14b582f83d More use our free of `outer_map` 2022-06-10 09:15:11 +02:00
Laurent Rineau f438a2ed3a Fix a use-after-free
In an `unordered_map`, any insertion can invalidate iterators,
when the load factor triggers a rehashing.
2022-06-08 15:52:01 +02:00