Commit Graph

1282 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Laurent Rineau a36fbb85d8 Merge pull request #6018 from afabri/PSP-check_open_close-GF
Unset fail bit and add assertions about the state of a stream
2021-09-30 16:49:37 +02:00
Laurent Rineau 7fc986f581 Merge pull request #5992 from afabri/CGAL-safe_functions-GF
Deal with memset, memcpy, fscanf...    and their safe equivalents
2021-09-29 11:46:44 +02:00
Laurent Rineau ad79d37410 Merge pull request #6014 from MaelRL/CGAL-IO_Clarify_binary_text-GF
CGAL IO: Clarify binary warning
2021-09-29 11:46:30 +02:00
Andreas Fabri 716dcaf6c9
Apply suggestions from code review
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2021-09-28 13:57:40 +02:00
Andreas Fabri 4d1f12d1e2 Unset fail bit and add assertions about the state of a stream 2021-09-28 10:41:50 +01:00
Mael Rouxel-Labbé 5578bf43ff Misc cleaning 2021-09-27 15:35:40 +02:00
Mael Rouxel-Labbé c8cc0747fa Clarify binary warning 2021-09-27 15:33:42 +02:00
Andreas Fabri 3b7754f796 CGAL_TRACE() -> CGAL_TRACE_STREAM 2021-09-23 17:00:10 +02:00
Sebastien Loriot 8d00945943
Merge pull request #5655 from danston/PSP-libpointmatcher_enhancements-danston
[Small Feature] Support for libpointmatcher::GenericDescriptorOutlierFilter
2021-08-12 10:10:13 +02:00
Mael Rouxel-Labbé 78ff9185b3 Harmonize ASCII usage across all packages 2021-06-23 23:34:32 +02:00
Mael Rouxel-Labbé a34debc92b Uniformize os/is/s/i stream parameter name in Stream_support/io
+ remove extra backticks in NP doc
2021-06-23 23:32:06 +02:00
albert-github 2a54687e77 Correction of hyperlinks
The link checker gave a number of redirects and incorrect links.
- the redirects have been solved ass far as possible
- the incorrect links have been checked and corrected where possible, others  have been reported through issues;
2021-06-04 13:52:14 +02:00
Laurent Rineau 59a0da4f13 Merge pull request #5692 from maxGimeno/CGAL_cpp11_atomic_and_threads-maxGimeno
CGAL:: Use std atomic and threads

# Conflicts:
#	Arrangement_on_surface_2/include/CGAL/Arr_counting_traits_2.h
2021-05-19 17:23:53 +02:00
Laurent Rineau 82bec8a1d6 Merge pull request #5692 from maxGimeno/CGAL_cpp11_atomic_and_threads-maxGimeno
CGAL:: Use std atomic and threads

# Conflicts:
#	Arrangement_on_surface_2/include/CGAL/Arr_counting_traits_2.h
2021-05-19 17:11:37 +02:00
Laurent Rineau d6b2c8d9dc Merge pull request #5671 from maxGimeno/CGAL_IO-Add_missing-deprecated_functions-maxGimeno
CGAL_IO: Add missing fallbacks

# Conflicts:
#	BGL/include/CGAL/boost/graph/IO/INP.h
#	Point_set_processing_3/include/CGAL/IO/write_xyz_points.h
2021-05-18 18:13:38 +02:00
Maxime Gimeno 17ac255108 Fix calls t cpp11:atomic stuff 2021-05-18 15:43:59 +02:00
Simon Giraudot f4f46a1d97 Fix typo 2021-05-10 14:52:45 +02:00
Simon Giraudot 4ced4d36d6 Update example + fix type 2021-05-10 13:40:15 +02:00
Simon Giraudot 5a0113892a Clean up code 2021-05-10 13:24:08 +02:00
Maxime Gimeno 9acf3d4b19 Add missing fallbacks for IO functions and result_of 2021-05-07 12:50:51 +02:00
Maxime Gimeno 33cefe1be7 remove calls to cpp11::sleep_for() 2021-05-07 11:13:03 +02:00
Maxime Gimeno e9b7595fff Deprecate CGAL headers for threads, atomic and result_of, and move their content to config.h as fallback 2021-05-07 11:09:24 +02:00
Simon Giraudot ae885f539c Documentation and plugin 2021-05-06 15:43:28 +02:00
Simon Giraudot 26d9014334 Implement grid simplify with outlier filtering (with no impact on original version) 2021-05-06 15:06:40 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot fbbf3863af remove extra IO 2021-05-04 18:25:16 +02:00
Sébastien Loriot 2060e0e352 move LAS_property in IO 2021-05-04 15:58:29 +02:00
Sébastien Loriot 12f0e412b5 write_vtu -> write_VTU 2021-05-04 15:12:36 +02:00
Sébastien Loriot 56025fb5f9 fix release number of depreciation 2021-05-04 14:38:47 +02:00
Sébastien Loriot fb6f703b55 IO namespace for files in IO directories 2021-05-04 14:36:06 +02:00
Dmitry Anisimov 3efa4316d1 added extra info to the scalar map NP and a comment in the example 2021-05-04 10:37:58 +02:00
Sébastien Loriot 8005f91c22 add IO namespace for Point_set_3 and Point_set_processing_3 packages 2021-05-03 19:21:57 +02:00
Dmitry Anisimov 0cdd91e98a
explained default value in the named parameters 2021-04-30 16:32:48 +02:00
Dmitry Anisimov 330a161e55 fixed uninitialized field warnings 2021-04-30 09:42:55 +02:00
Dmitry Anisimov cb0e72049b using constant property map instead of new get scalar value class 2021-04-29 18:07:01 +02:00
Dmitry Anisimov c8307dc0d6 added support for GenericDescriptorOutlierFilter to the CGAL libpointmatcher interface 2021-04-29 15:23:38 +02:00
Laurent Rineau e935a3d99b Merge pull request #5629 from sgiraudot/PSP-Fix_clustering_warning-GF
PSP: Fix conversion warnings in clustering
2021-04-28 15:24:10 +02:00
Laurent Rineau e562de0160 Merge pull request #5629 from sgiraudot/PSP-Fix_clustering_warning-GF
PSP: Fix conversion warnings in clustering
2021-04-28 15:22:43 +02:00
Simon Giraudot f7f781c2d2 Fix warning by explicitly casting to/from property map value type 2021-04-19 12:44:59 +02:00
Laurent Rineau 1b54449dc5 Merge pull request #4878 from danston/Kernels-decltypes-danston
Improve decltype/result_of/invoke_result
2021-04-06 15:13:21 +02:00
Laurent Rineau 343ef10367 Merge pull request #5547 from sgiraudot/Fix_stdpow_related_warnings-GF
Fix warning: std::pow(float, int) returns double instead of float in recent C++
2021-04-06 15:13:00 +02:00
Laurent Rineau 97f526878f Merge pull request #5547 from sgiraudot/Fix_stdpow_related_warnings-GF
Fix warning: std::pow(float, int) returns double instead of float in recent C++
2021-04-06 15:11:49 +02:00
Laurent Rineau 21755b1123 Merge pull request #5245 from GilesBathgate/create-assertions-fix
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
2021-03-24 15:05:41 +01:00
Laurent Rineau aea492ee49 Merge pull request #5536 from maxGimeno/Fix_ply_doc-maxGimeno
Documentation: Fix `read_ply_points_with_properties`
2021-03-24 15:00:22 +01:00
Simon Giraudot ab14acff77 Replace std::pow(x,2) by CGAL::square(x) 2021-03-23 13:14:41 +01:00
Simon Giraudot 91de37ec3a Fix warning: std::pow(float, int) returns double instead of float in recent C++ 2021-03-23 11:25:53 +01:00
Maxime Gimeno 5b397e9d6f Fix group name for read_ply_points_with_properties 2021-03-19 08:40:21 +01:00
Dmitry Anisimov 00c185b028
Merge branch 'master' into Kernels-decltypes-danston 2021-03-12 12:06:20 +01:00
Laurent Rineau 158495bdb5 Merge pull request #5444 from sgiraudot/Poisson-Kernel_compatibility-GF
[Poisson Reconstruction] Compatibility with Simple Cartesian
2021-03-10 10:39:37 +01:00
Laurent Rineau 92e024f123 Merge pull request #5444 from sgiraudot/Poisson-Kernel_compatibility-GF
[Poisson Reconstruction] Compatibility with Simple Cartesian
2021-03-10 10:33:14 +01:00
Laurent Rineau 3ab3b10d47 Merge pull request #5247 from MaelRL/SDG-Fix_doc-GF
Doc improvements for TDS-related classes
2021-03-03 17:38:18 +01:00
Laurent Rineau 3621aaaf3e Merge pull request #5426 from sgiraudot/PSP-RANSAC-Fix_warnings-GF
[PSP/RANSAC] Fix warnings
2021-03-03 17:33:05 +01:00
Laurent Rineau 45373bef84 Merge pull request #5426 from sgiraudot/PSP-RANSAC-Fix_warnings-GF
[PSP/RANSAC] Fix warnings
2021-03-03 17:10:18 +01:00
Mael Rouxel-Labbé 5efa544734 Merge remote-tracking branch 'cgal/master' into SDG-Fix_doc-GF 2021-02-22 17:19:40 +01:00
Laurent Rineau a72fdb7b3c Merge pull request #5352 from lrineau/CGAL-fix_CGAL_IO-GF
Fixes after the PR "CGAL I/O
2021-02-18 15:23:43 +01:00
Dmitry Anisimov 81d9556707 Merge remote-tracking branch 'upstream/master' into Kernels-decltypes-danston 2021-02-10 10:06:45 +01:00
Simon Giraudot 848aa7d8ab Fix compatibility of Poisson with Simple_cartesian<float> 2021-02-08 10:16:59 +01:00
Maxime Gimeno 2dac31f36f Clean-up and fix doc 2021-02-05 14:14:11 +01:00
Simon Giraudot 26793aeaea Fix conversion warnings in PSP 2021-02-04 08:49:06 +01:00
Maxime Gimeno 91f8b4a09f fix write_off_points() 2021-01-29 09:45:05 +01:00
Maxime Gimeno 7bf9c14f72 Factorization 2021-01-28 10:01:52 +01:00
Maxime Gimeno 2d59464b2b remove os.precision(6) as it is the default. 2021-01-27 15:49:42 +01:00
Maxime Gimeno 41c823c083 replace default value of stream precision 2021-01-27 15:44:02 +01:00
Mael Rouxel-Labbé 1f45360d7a Merge remote-tracking branch 'cgal/master' into SDG-Fix_doc-GF 2021-01-26 09:05:24 +01:00
Laurent Rineau 2fd1a0f668 Merge pull request #5324 from cjamin/patch-1
PSP_3: Remove debug output
2021-01-21 16:23:21 +01:00
Sébastien Loriot ad911271a9 Merge commit '6594e7549bd70923990d86c31e2aa267a79bb629' into HEAD 2021-01-15 10:12:17 +01:00
Sébastien Loriot bdd4efe3b3 Merge commit 'efc0c525e8b' into HEAD 2021-01-15 10:06:56 +01:00
Sébastien Loriot efc0c525e8 include non-deprecated header 2021-01-15 10:02:00 +01:00
Maxime Gimeno cf19fb2df9 Fixes 2021-01-08 09:35:35 +01:00
Clément Jamin 6fd1be99a6
Remove debug output
I think this output was for debug purpose
2021-01-05 18:01:06 +01:00
Maxime Gimeno d68f387b85 Try to silence false warning 2020-12-18 14:21:17 +01:00
Maxime Gimeno ad8fea2301 Fix read_LAS test 2020-12-09 16:07:07 +01:00
Mael Rouxel-Labbé 723890e388 Misc tiny doc fixes (broken links, grammar, etc.) 2020-12-05 11:49:27 +01:00
Giles Bathgate 5a36ff89b5 Drop NDEBUG it is already visible through CGAL_NO_ASSERTIONS 2020-12-04 19:42:21 +00:00
Maxime Gimeno 37b5928df2 Fixes of warnings and errors 2020-12-01 11:33:35 +01:00
Sébastien Loriot 3c15e412c4 fix warning
warning observed with g++ (Debian 10.2.0-16) 10.2.0 that looks like to a bug.
2020-11-19 13:28:06 +01:00
Maxime Gimeno 7cfb944afb Fixes 2020-11-19 12:11:51 +01:00
Maxime Gimeno 9f496e3e9d Fixes 2020-11-18 12:48:38 +01:00
Maxime Gimeno 3b70343590 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-11-16 16:19:43 +01:00
Simon Giraudot bce99e7768 Fix uncompiled doc 2020-11-09 08:36:45 +01:00
Simon Giraudot c472257f0e Fix unused using 2020-11-05 09:36:18 +01:00
Simon Giraudot 06cce4cc90 Fix Eigen error by passing matrix directly in constructor 2020-11-05 09:35:57 +01:00
Simon Giraudot 9fd32d1298 Remove useless using 2020-11-04 11:07:26 +01:00
Simon Giraudot d18609cb28 Fix max for windows 2020-11-04 11:06:12 +01:00
Maxime Gimeno bced6b13f3 Fix LAS I/O 2020-10-27 11:45:17 +01:00
Simon Giraudot c39ba1056e Add missing eigen include 2020-10-20 13:51:32 +02:00
Simon Giraudot e35fdf852b Add missing eigen include 2020-10-19 07:55:07 +02:00
Mael Rouxel-Labbé 4b28101397 Misc IO fixes 2020-10-14 21:46:18 +02:00
Mael Rouxel-Labbé 0583a4862e Add precision support to Geomview streams 2020-10-14 15:32:27 +02:00
Mael Rouxel-Labbé 5cb43ee8ea Add warnings about binary flags in i/o streams in lower level PLY IO functions 2020-10-14 11:02:08 +02:00
Mael Rouxel-Labbé 630d9eb2f6 Various fixes in IO tests (BGL/PS/PMP/SS) 2020-10-13 18:15:34 +02:00
Mael Rouxel-Labbé 13c221534d Include 'pwn' in generic point set readers 2020-10-13 18:06:51 +02:00
Mael Rouxel-Labbé ec71a79fdf Fix some missing flushers 2020-10-13 18:02:28 +02:00
Simon Giraudot 16b819aec9 Add Eigen macro conditions 2020-10-13 15:40:16 +02:00
Simon Giraudot f0f93f0e7e Typo fix 2020-10-13 14:35:41 +02:00
Simon Giraudot 613dc2ce38 Fix documentation 2020-10-13 14:05:41 +02:00
Simon Giraudot 43d4a5530a Use constant property maps and remove helpers 2020-10-13 14:02:59 +02:00
Simon Giraudot c453422a53 Update from review 2020-10-12 14:27:44 +02:00
Simon Giraudot 5370a50dd6 Update doc 2020-10-12 08:15:20 +02:00
Mael Rouxel-Labbé f55ef7dd50 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-10-09 18:36:17 +02:00
Simon Giraudot 45248526ca Better orientation of scanlines using PCA 2020-10-08 15:09:01 +02:00
Simon Giraudot e86003c5c6 Reference manual 2020-10-07 11:06:32 +02:00
Simon Giraudot a7e8d52b7d Better name for function 2020-10-07 09:22:32 +02:00
Simon Giraudot fd2f40a156 First version of scanline normal orientation 2020-10-07 09:13:15 +02:00
Sébastien Loriot 7d5bec6a7d use the distance for the split 2020-09-28 09:49:00 +02:00
Sébastien Loriot e37488d10a use property map in std::nth_element call 2020-09-25 10:51:35 +02:00
Mael Rouxel-Labbé 8682f9bafb Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-08-24 11:45:17 +02:00
Dmitry Anisimov 263ad6bc99 fixed ch3, inter3, otr2, psp, pmp, smsp, mesh3 + cleanup 2020-08-20 18:25:01 +02:00
Sébastien Loriot b6a5502288 Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' 2020-08-06 11:33:47 +02:00
Sébastien Loriot 335ddea58f Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' into HEAD 2020-08-06 11:32:52 +02:00
Mael Rouxel-Labbé 00ca0211e1 IO documentation fixes 2020-08-04 15:47:56 +02:00
Simon Giraudot ebe7168ece Remove outdated precondition 2020-08-04 14:19:17 +02:00
Mael Rouxel-Labbé 1d016ecc7e IO doc fixes 2020-07-28 15:38:19 +02:00
Mael Rouxel-Labbé 0d66e19361 IO documentation fixes
See @sloriot's review:

https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Polgyon_soup_mesh_IO/2nd_round/Answer_to_review

(+ some commits before and after this one)
2020-07-24 17:06:00 +02:00
Mael Rouxel-Labbé 2f0f61e104 Rephrase warning about std::ios::binary + add missing (LAS - always binary) 2020-07-24 09:40:13 +02:00
Mael Rouxel-Labbé 6acac6907a Add a note about letter case in generic I/O functions 2020-07-24 09:23:54 +02:00
Mael Rouxel-Labbé 69068ba28c Some more binary/ASCII fixes 2020-07-21 11:44:18 +02:00
Mael Rouxel-Labbé b08e1e0d8c Hide CGAL_DEPRECATED from the doc 2020-07-20 09:57:47 +02:00
Mael Rouxel-Labbé 3e9ce127b2 Misc CGAL IO doc fixes 2020-07-17 16:51:25 +02:00
Mael Rouxel-Labbé 26c930bc20 Uniformize whether std::string or const char* is used in the doc 2020-07-17 15:16:32 +02:00
Mael Rouxel-Labbé 6d6d959d4d Enhance doc for generic I/O functions 2020-07-17 13:37:37 +02:00
Mael Rouxel-Labbé f3659c5d96 Switch 3MF to bool return type and clarify \return doc for IO functions 2020-07-17 13:19:18 +02:00
Mael Rouxel-Labbé 93f1cd99ca Merge remote-tracking branch 'cgal/master' into CGAL-Improve_NP_doc_presentation-GF 2020-07-16 09:53:31 +02:00
Mael Rouxel-Labbé d567a0d9d0 Fix doc warnings 2020-07-16 09:52:32 +02:00
Mael Rouxel-Labbé 0d37cef30b Use std::ios::binary / CGAL::set_binary_mode for LAS 2020-07-13 16:56:53 +02:00
Laurent Rineau f203a58643
Merge pull request #4832 from sgiraudot/PSP-Fix_neighbor_query_fallback-GF
[PSP] Fix neighbor query fallback
2020-07-07 16:13:17 +02:00
Simon Giraudot 684f6e9086 Fix neighbor query fallback 2020-07-06 14:07:13 +02:00
Mael Rouxel-Labbé ae4c2aaa9e IO doc fixes 2020-06-26 16:08:02 +02:00
Mael Rouxel-Labbé 594eb97a22 Doc improvements 2020-06-25 21:01:04 +02:00
Mael Rouxel-Labbé 2b18b8d8be Fix broken doc references 2020-06-25 15:17:44 +02:00
Mael Rouxel-Labbé 04c3b647e9 Fix read_LAS extra/missing overloads 2020-06-25 15:14:53 +02:00
Mael Rouxel-Labbé 26355e2e32 Uniformize capital / third person usage of \brief 2020-06-25 15:13:47 +02:00
Mael Rouxel-Labbé 31044f8e1e Fix not opening binary input with ios::binary when reading/writing PLY 2020-06-24 18:26:16 +02:00
Laurent Rineau fafb3ca4e0 Merge pull request #4776 from sgiraudot/PSP-Fix_hierarchy_simplify_doc-GF
PSP: Fix documentation of hierarchy simplify point set
2020-06-23 18:50:14 +02:00
Laurent Rineau 84d7e9a696 Merge pull request #4776 from sgiraudot/PSP-Fix_hierarchy_simplify_doc-GF
PSP: Fix documentation of hierarchy simplify point set
2020-06-23 18:48:11 +02:00
Mael Rouxel-Labbé 8bdb454b44 Fix not checking for ifstream health 2020-06-23 18:25:06 +02:00
Mael Rouxel-Labbé 34ddacd5e7 Misc minor fixes 2020-06-23 11:56:12 +02:00
Mael Rouxel-Labbé 0ae0bd74d6 Fix missing / wrong header includes 2020-06-22 13:47:16 +02:00
Mael Rouxel-Labbé 28b50b0c5d General IO doc improvements 2020-06-22 13:45:29 +02:00
Mael Rouxel-Labbé ad67358146 Fix some broken links 2020-06-21 16:21:02 +02:00
Mael Rouxel-Labbé 99390110b5 Add missing overloads 2020-06-21 15:54:21 +02:00
Mael Rouxel-Labbé 52d50f7d79 Doc improvements 2020-06-21 13:30:53 +02:00
Mael Rouxel-Labbé 7f70e96830 Many fixes / improvements for PS_3 / PSP_3 IO 2020-06-21 11:50:00 +02:00
Mael Rouxel-Labbé e09eb39a80 Misc cleaning 2020-06-21 11:39:14 +02:00
Mael Rouxel-Labbé 6f8a895671 Merge remote-tracking branch 'mine/CGAL-Improve_NP_doc_presentation-GF' into CGAL_IO-maxGimeno 2020-06-18 15:21:27 +02:00
Maxime Gimeno ea53a8d70d Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-06-17 14:25:21 +02:00
Maxime Gimeno ff63531c3d fix extension detection 2020-06-11 16:17:32 +02:00