Commit Graph

283 Commits

Author SHA1 Message Date
Laurent Rineau 4fbf00fb8a CMake>=3.13: opt for for new policies up to 3.15 2019-06-19 14:34:59 +02:00
Andreas Fabri e2d19b0c8d Replace NULL and Nullptr_t with nullptr and nullptr_t 2019-06-04 23:45:44 +02:00
Laurent Rineau 90d6afdeb6 Merge pull request #3848 from afabri/Partition_2-Traits_with_state-GF
Partition_2:  Make it work for a traits class with state
2019-05-06 15:45:56 +02:00
Laurent Rineau 959ea27b4e Merge pull request #3889 from sloriot/CGAL-remove_link_to_old_demos
Remove link to old demos
2019-05-06 15:30:29 +02:00
Maxime Gimeno d7b85085fd Somehow silent the warning that was actually due to an optionnal in the circulatior type. 2019-05-03 11:01:52 +02:00
Andreas Fabri 7dabb4c47b Move variable in the ifdef/endif scope 2019-04-30 10:12:58 +02:00
Andreas Fabri 1c72c40b65 Try to fix warning 2019-04-30 08:39:01 +02:00
Sébastien Loriot c92996cd5a remove link to old Qt3 demos 2019-04-29 17:27:04 +02:00
Andreas Fabri c2fcd257c7 cleanup 2019-04-24 11:28:18 +02:00
Andreas Fabri 146dfce5fe Fix the definition of Partition_traits_2::Polygon_2 2019-04-24 10:34:25 +02:00
Andreas Fabri 8c6b512ca2 polish doc 2019-04-23 16:50:29 +02:00
Andreas Fabri c49382502b cleanup 2019-04-23 16:10:01 +02:00
Andreas Fabri 98c915f9c2 Add a PointPropertyMap to Partition_traits with as default Identity_property_map 2019-04-23 15:53:02 +02:00
Andreas Fabri 804184ba78 Do not copy the traits object 2019-04-18 11:33:10 +02:00
Andreas Fabri f6e3221d98 Easy fixes after Mael's review 2019-04-17 22:33:04 +02:00
Andreas Fabri a22bc68939 Fix warning 2019-04-17 09:19:07 +02:00
Andreas Fabri 70c115b1e9 Fix bug which was revealed through minkowski testsuite 2019-04-16 13:52:11 +02:00
Sébastien Loriot bd5ef7d9ea fix init order 2019-04-12 14:52:38 +02:00
Sébastien Loriot 30879a7145 Polygon_2 cannot be init with a initialization list 2019-04-12 14:51:57 +02:00
Andreas Fabri 7778b1057d remove \pre 2019-04-12 14:17:02 +02:00
Sebastien Loriot 57a2c4e809 Apply suggestions from code review
Co-Authored-By: afabri <andreas.fabri@geometryfactory.com>
2019-04-12 12:45:11 +02:00
Andreas Fabri fe9fce35f6 Remove typename 2019-04-12 10:31:29 +02:00
Andreas Fabri e5217dc67c polish doc 2019-04-11 12:05:38 +02:00
Andreas Fabri a9bb23ce64 cleanup 2019-04-11 11:53:33 +02:00
Andreas Fabri 76b3b92a43 Add example and implememntation history to the user manual 2019-04-11 11:26:11 +02:00
Andreas Fabri 66437517c9 cleanup 2019-04-11 10:54:00 +02:00
Andreas Fabri dd6691b2ce remove template parameter 2019-04-11 09:21:37 +02:00
Andreas Fabri a494bf3678 remove old example 2019-04-10 22:16:15 +02:00
Andreas Fabri d60ebe5d87 No need for constructions 2019-04-10 17:33:26 +02:00
Andreas Fabri 2bbfe86fe2 Remove unused code 2019-04-10 14:14:47 +02:00
Andreas Fabri e632bebdba Fixes so that the testsuite compiles again 2019-04-10 13:18:25 +02:00
Andreas Fabri 2458965c15 Default initialize 2019-04-10 12:18:57 +02:00
Andreas Fabri c7d55b72cf Get rid of construct_segment/construct_ray/intersect/assign in Vertex_visibility_graph 2019-04-09 17:38:40 +02:00
Andreas Fabri ff305562ff cleanup 2019-04-09 14:27:18 +02:00
Andreas Fabri dd292450a7 typos 2019-04-09 14:23:34 +02:00
Andreas Fabri b444bb2246 typos 2019-04-09 14:18:08 +02:00
Andreas Fabri 3fa3fc1ab0 typos 2019-04-09 14:18:08 +02:00
Andreas Fabri f42e8952f5
Merge branch 'master' into Partition_2-Traits_with_state-GF 2019-04-09 13:57:57 +02:00
Andreas Fabri 2ed0f2d94b Fixes and add documentation 2019-04-09 13:49:11 +02:00
Andreas Fabri 3d0674ed4f Add an example that used the traits adapter 2019-04-09 13:10:59 +02:00
Andreas Fabri ca161c5639 Partition_2: Make it work for a traits with state 2019-04-09 10:54:03 +02:00
Andreas Fabri 4ebeaf017d WIP - we first have to make it work for a traits class with state 2019-04-08 17:41:09 +02:00
Andreas Fabri baa2cf4e40 cleanup 2019-04-03 08:22:40 +02:00
Andreas Fabri 7127fa32ad It now works for all partitions.
Somebody should check if the change in
Partition_2/include/CGAL/Partition_2/Rotation_tree_2.h
is ok.
2019-04-02 15:55:45 +02:00
Andreas Fabri 4eeb1fa37f WIP towards making all partition methods work 2019-04-02 15:31:59 +02:00
Sébastien Loriot ecd818a3a7 remove cpp11 condition 2019-03-29 10:41:50 +01:00
Laurent Rineau 8693f95dac Merge pull request #3619 from albert-github/feature/bug_headers
Update of headers
2019-02-22 16:39:09 +01:00
Sébastien Loriot 59bc453b42 first batch of replacement for level 1 in classified ref man
command used:
grep -l  "##" */doc/*/PackageDescription.txt | xargs  sed -i  -E 's/\#\#\s*([[:print:]]+[[:alnum:]])\s*\#\#\s*$/\\cgalCRPSection{\1}/'
2019-02-14 10:32:39 +01:00
Laurent Rineau 49732a118c Merge remote-tracking branch 'cgal/master' into Ipelets-Fix_warning-GF 2019-02-13 16:27:54 +01:00
Laurent Rineau d97726ffe4 Fix a warning [-Wmaybe-uninitialized]
```
In file included from /mnt/testsuite/include/CGAL/Cartesian/Weighted_point_2.h:29,
                 from /mnt/testsuite/include/CGAL/Cartesian/Cartesian_base.h:34,
                 from /mnt/testsuite/include/CGAL/Cartesian.h:29,
                 from /home/cgal_tester/build/src/cmake/platforms/Fedora-rawhide-Release/test/Partition_2/approx_convex_partition_2_test_C.cpp:31:
/mnt/testsuite/include/CGAL/Handle_for.h: In function ‘bool CGAL::partition_appx_cvx_cuts_nonconvex_angle(Edge_circulator, Circulator, const Triangulation&, const Traits&) [with Edge_circulator = CGAL::Triangulation_ds_edge_circulator_2<CGAL::Triangulation_data_structure_2<CGAL::Triangulation_vertex_base_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Triangulation_ds_vertex_base_2<void> >, CGAL::Constrained_triangulation_face_base_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Triangulation_face_base_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Triangulation_ds_face_base_2<void> > > > >; Circulator = CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>; Triangulation = CGAL::Constrained_triangulation_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Default, CGAL::Default>; Traits = CGAL::Partition_traits_2<CGAL::Cartesian<double> >]’:
/mnt/testsuite/include/CGAL/Handle_for.h:313:12: warning: ‘*((void*)& next_ccw_pt_ref +40)’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  313 |     return *(h.Ptr());
In file included from /mnt/testsuite/include/CGAL/partition_2.h:30,
                 from /home/cgal_tester/build/src/cmake/platforms/Fedora-rawhide-Release/test/Partition_2/approx_convex_partition_2_test_C.cpp:33:
/mnt/testsuite/include/CGAL/Partition_2/partition_approx_convex_2.h:91:34: note: ‘*((void*)& next_ccw_pt_ref +40)’ was declared here
   91 |    typename Triangulation::Point next_ccw_pt_ref, prev_ccw_pt_ref;
      |                                  ^~~~~~~~~~~~~~~
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.14-Ic-122/Partition_2/TestReport_gimeno_Fedora-rawhide-Release.gz
2019-02-13 16:03:20 +01:00