Commit Graph

1355 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé b5dadc0c95 Fixed various Bare_point / Weighted_point usage across Mesh_3
Hopefully, this is the last batch
2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé a4503e7edc Moved facet dual computation functions from Mesh_3 to Regular_triangulation_3
... and improved them and gave them more overloads
2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 9518646be4 Moved up the force_exact test to avoid computing useless determinants 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 0a91dac5ed Removed useless includes 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé cb70dfb644 Cleaned uses of obsolete traits class Regular_triangulation_euclidean_traits 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 417057b6fe Removed useless semicolon 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé ce5660acbd Fixed (almost all) default constructed traits in Mesh_3
Also fixed constructing points/weighted_points not through the traits and
uses of point().point()
2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 96e053211e Fixed (remaining) Bare_point / Weighted_point wrong usages across Mesh_3 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 78ea055735 Removed Bare_point definition from Mesh_3's Robust_weighted_...etc..._traits
It is not for the traits to define Bare_point. It is defined in the regular
triangulation.

This commit breaks stuff, but it'll be fixed in the following commits.
2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 24994be80d Removed useless semicolon 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé d3a75a191c Minor doc improvement 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 67b0924ee0 Fixed compilation issues resulting from the removal of WP->P implicit conversion 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 5db27d88d2 Consistently grab the Bare_point typedef from the triangulation
instead of the geometric traits
2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé f7592fbbdd Fixed missing typedef
and removed some warnings due to unused typedefs
2017-06-15 10:32:03 +02:00
Jane Tournois 85e87d4f59 remove useless variables 2017-06-15 10:32:03 +02:00
Jane Tournois a7b92113c7 remove extra reference
this was leading to (fp == p), and no way to move back to the original
position of v0
2017-06-15 10:32:03 +02:00
Jane Tournois 04b2f4ea25 return type should be Bare_point 2017-06-15 10:32:03 +02:00
Jane Tournois 4db6afd2aa fix one more Bare_point 2017-06-15 10:32:03 +02:00
Jane Tournois 9d4b697503 make constructors of Weighted_point explicit
and fix compilation errors
2017-06-15 10:32:03 +02:00
Andreas Fabri 42509e2a1f make the Polyhedron demo mesh_3_plugin work 2017-06-15 10:32:03 +02:00
Jane Tournois ea970f5aa5 avoid using wp.point(), use Construct_point_3 instead 2017-06-15 10:29:26 +02:00
Jane Tournois 5180389e3a remove hybrid operators, that use Bare points and Weighted points in an ambiguous manner
this commit only fixes the testsuite of Mesh_3
2017-06-15 10:29:26 +02:00
Andreas Fabri 3f4286068c Now also the examples compile 2017-06-15 10:29:26 +02:00
Andreas Fabri 58c8d7cb1a WIP: test_meshing_polyhedron_with_features compiles and crashes in odt 2017-06-15 10:29:26 +02:00
Andreas Fabri 5a090c26a4 Consistently use Bare_point and Weighted_point 2017-06-15 10:29:26 +02:00
Andreas Fabri 80224bf2c8 Disable Point_3(const Weighted_point_3&) 2017-06-15 10:29:26 +02:00
Maxime Gimeno bd45c39ef3 Fix warnings 2017-06-14 09:32:13 +02:00
Laurent Rineau f6b8ad199d More the "compatibility" specializations after the others 2017-06-12 16:45:07 +02:00
Maxime Gimeno f61a0e39f6 Fix missing set include 2017-06-02 15:34:15 +02:00
Andreas Fabri 518c6cc1f4 Fix the demo 2017-05-31 21:16:00 +02:00
Andreas Fabri e77f1d4d78 Fix the demo 2017-05-31 19:50:02 +02:00
Andreas Fabri ac30f40f79 Move Mesh_3 specific properties to Mesh_3 2017-05-31 16:14:31 +02:00
Andreas Fabri d6816a7368 Move Mesh_3 specific properties to Mesh_3 2017-05-31 16:08:26 +02:00
Maxime Gimeno fcc081f95d make mesh_3_plugin work with surface_mesh.
Find why topoogy(int) is declared twice.
2017-05-29 13:24:07 +02:00
Laurent Rineau 7d34fc5dbd Add compatibility: support when Patch_id is Tag_true/Tag_false 2017-05-29 13:24:07 +02:00
Laurent Rineau 2c2ad9ff6d Move properties from <CGAL/Mesh_polyhedron_3.h>...
... to `<CGAL/boost/graph/PMP_properties_Polyhedron_3.h>`.
2017-05-29 13:24:06 +02:00
Maxime Gimeno 9a3dde95ba Fix missing headers and definitions, SFINAE problems and ambiguous specialisation. 2017-05-29 13:24:06 +02:00
Andreas Fabri 0f28155729 I had to change Detect_features_in_polyhedra as the property map must be retrieved for the polyhedron passed to a function 2017-05-29 13:24:05 +02:00
Maxime Gimeno 5db694c154 polyhedral domain with features works for Surface_mesh and cheese.off (Polyhedron does no longer :(
Conflicts:
	Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
	Surface_mesh/include/CGAL/boost/graph/PMP_properties_Surface_mesh.h
2017-05-29 13:22:37 +02:00
Maxime Gimeno 451af8f3ef bglize and add property maps. polyhedral domain with features works almost for Surface_mesh
Conflicts:
	Mesh_3/include/CGAL/Mesh_polyhedron_3.h
	Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
	Surface_mesh/include/CGAL/boost/graph/PMP_properties_Surface_mesh.h
2017-05-29 13:22:37 +02:00
Andreas Fabri 5a302c805d Make make_mesh_3() work for Surface_mesh 2017-05-29 13:22:37 +02:00
Maxime Gimeno b122889723 Make the Detect_sharp_edges_plugin work with a SM_item
- finished the BGL-ization of Detect_features_in_polyhedra.h
- added a feature edges visualization to the SM_item.

Conflicts:
	Polyhedron/demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt
	Polyhedron/demo/Polyhedron/Plugins/PMP/CMakeLists.txt
	Polyhedron/demo/Polyhedron/Plugins/PMP/Detect_sharp_edges_plugin.cpp
	Polyhedron/demo/Polyhedron/Scene_surface_mesh_item.h
2017-05-29 13:22:36 +02:00
Maxime Gimeno 8b9eae7f44 Fix rebase 2017-05-29 13:22:35 +02:00
Laurent Rineau d50e391577 Move properties from <CGAL/Mesh_polyhedron_3.h>...
...to `<CGAL/boost/graph/PMP_properties_Polyhedron_3.h>`.

Conflicts:
	Mesh_3/include/CGAL/Mesh_polyhedron_3.h
2017-05-29 13:20:41 +02:00
Maxime Gimeno d88dad8bef Clean-up and warning fix.
- Use constructor of sm descriptors instead of static_casts.
2017-05-29 13:20:41 +02:00
Maxime Gimeno 5e630f5c48 Move Detect_feature_edges to PMP 2017-05-29 13:20:40 +02:00
Maxime Gimeno 880b6e21a2 Fixes and Clean-up.
- Move the new properties in a file in PMP and remove them from the namespace boost.
- Move the surface mesh properties from properties_Surface_mesh.h to Scene_surface_mesh_item.h
2017-05-29 13:20:39 +02:00
Andreas Fabri a33e423d2e Add property maps to Mesh_polyhedron_3::type 2017-05-29 13:20:38 +02:00
Maxime Gimeno 7a3c096c72 fix detect_features 2017-05-29 13:20:38 +02:00
Maxime Gimeno 6b2a44c75e Link only with the right library in CMakeLists.txt 2017-05-29 13:20:36 +02:00