Commit Graph

17 Commits

Author SHA1 Message Date
Sébastien Loriot 107f3696dc boost::tie -> std::tie 2025-01-24 14:20:00 +01:00
Laurent Rineau 3072b93942 After review 2022-04-23 16:11:18 +02:00
Laurent Rineau 644b88924d Rewrite the tetst 2022-04-20 17:03:58 +02:00
Andreas Fabri 5098cad841 Test the move semantics 2022-04-19 16:52:18 +01:00
Sébastien Loriot 4a27ff5bf6 remove bind in Surface_mesh 2021-01-06 12:59:12 +01:00
Sébastien Loriot 590612a563 run the script to remove tabs and trailing whitespaces 2020-03-26 13:25:16 +01:00
Andreas Fabri 8e5df1efe9 An isolated point IS a border point 2017-03-29 19:10:47 +02:00
Andreas Fabri a890b3f221 Fix #1949 2017-03-06 08:55:51 +01:00
Laurent Rineau 7b2a150e84 Fix <CGAL/Surface_mesh/Properties.h> and its uses
The PR #1791 introduced `CGAL::Point_set_3`, and factorized the
`Property_map` implementation of `Surface_mesh` into a new class
template `CGAL::Properties::Property_map<Key, T>`.

The backward compatibility was supposed to be ensured by the fact that
`Surface_mesh<Point>::Property_map<Key,T>` had
`Properties::Property_map<Key, T>` as base class. But that compatibility
was only partial, and there could be ambiguities in the calls to `get`
and `put` with those property maps.

This commit/PR renamed `Properties::Property_map` to
`Properties::Property_map_base`, and added a third parameter, used as
the `Derived` class in the CRTP used by `boost::put_get_helper`. That
way, the `get` and `put` functions are defined directory on the real
class `Surface_mesh::Property_map<Key, T>` and not on its base class.

The same has been modified in `CGAL::Point_set_3`.

That makes the use of `Property_base_base` and `Property_container` a
little trickier, but that removes several ugly non-portable hacks, like
the `reinterpret_cast` that were used to convert a pointer to base class
of the pmap to the pointer the real pmap. Now that is a lot cleaner.

I have verified that the documentation is not modified. Actually, the
PR #1791 did modify the documentation of `Surface_mesh` (see the member
method `add_property_map` for example), and this PR fixes the situation:
the documentation of `Surface_mesh` is put back to the version in
CGAL-4.9.
2017-02-08 14:33:18 +01:00
Simon Giraudot bf157b4511 Propagate namespace change in test of Surface_mesh 2016-10-21 10:28:38 +02:00
Andreas Fabri 5110ff7754 Use CGAL_USE 2014-12-31 12:55:43 +01:00
Andreas Fabri 95af2ea357 don't use the boost testing framework 2014-12-23 16:08:25 +01:00
Sébastien Loriot ad1954afc4 fix warnings and compilation issues 2014-12-10 17:34:51 +01:00
Andreas Fabri 901c3829d0 add tests 2014-11-26 11:06:31 +01:00
Andreas Fabri d5f74fd542 fix surface_mesh_test.cpp 2014-11-25 18:28:50 +01:00
Andreas Fabri d8d9eb605b Add concept Index and change Vertex_descriptor to Vertex_index 2014-09-25 15:51:40 +02:00
Sébastien Loriot a158d13647 initial version of Surface_mesh package 2014-07-15 12:08:51 +02:00