Mael Rouxel-Labbé
544dbb441a
Add more information about index maps in BGL/PMP's NamedParameters.txt
2020-03-09 10:53:48 +01:00
Mael Rouxel-Labbé
e4ff489623
Get rid of GetVertex/FaceIndexMap
...
GetInitialized... should be used instead.
Complete removal instead of simply doing:
struct GetVertexIndexMap
: public GetInitializedVertexIndexMap
{ }
because there will anyway be a need to update code on the right side of
GetVertexIndexMap fim = ...
and it's more obvious if it breaks on the type directly.
2020-03-09 10:41:04 +01:00
Mael Rouxel-Labbé
bc84ca29a2
Remove obsolete comment
2020-03-09 10:18:43 +01:00
Mael Rouxel-Labbé
ec30ebb709
Move getter structs and global functions to appropriate BGL file
2020-03-09 10:18:19 +01:00
Mael Rouxel-Labbé
fd864b7d99
Add a performance warning when a dynamic property map is used as index map
2020-03-09 10:18:08 +01:00
Mael Rouxel-Labbé
5e0798c88f
Add a comment to clarify assertion
2020-03-06 18:16:12 +01:00
Mael Rouxel-Labbé
ad62f89a20
Use the new index map initializer functions and fix doc
2020-03-06 15:25:38 +01:00
Mael Rouxel-Labbé
798a476d63
Merge branch 'PMP-Default_pmap-maxGimeno-old' into PMP-Default_pmap-maxGimeno
2020-03-06 13:20:00 +01:00
Mael Rouxel-Labbé
4334e954c0
Parameter > PropertyTag for clarity
2020-03-05 17:30:15 +01:00
Mael Rouxel-Labbé
b0cfe5a96d
Don't necessarily initialize the halfedge index map in copy_face_graph
2020-03-05 15:31:03 +01:00
Laurent Rineau
79699f9fc2
Merge pull request #4259 from MaelRL/PMP-Snapping_improvements-GF
...
PMP: Improvements for snapping
2020-03-05 15:06:46 +01:00
Laurent Rineau
192792f524
Merge pull request #4531 from sloriot/BGL-selection_for_removal_BF
...
Bug fix in selection expansion for removal
2020-03-05 14:52:19 +01:00
Mael Rouxel-Labbé
e6584bd176
Implement initialized_index_map getter with non-const graph
2020-03-05 14:26:20 +01:00
Mael Rouxel-Labbé
18a7c6900f
Tiny alignment change
2020-03-05 13:23:41 +01:00
Mael Rouxel-Labbé
af47c608fc
Add missing &
2020-03-05 13:23:34 +01:00
Mael Rouxel-Labbé
1f7c96a660
Some constructors from () to {} for clarity
2020-03-05 11:42:30 +01:00
Mael Rouxel-Labbé
aa331c0f14
Add missing hash value function for Seam_mesh's edges
2020-03-05 11:30:29 +01:00
Mael Rouxel-Labbé
2d1f3266ea
Hide error message behind debug macro
2020-03-04 14:35:46 +01:00
Mael Rouxel-Labbé
432d5c724a
Improve usages of get_initialized_xxx_index_map
2020-03-04 13:37:09 +01:00
Mael Rouxel-Labbé
889108e253
Update get_initialize_xxx_index_map usages to new API
2020-03-04 12:58:42 +01:00
Mael Rouxel-Labbé
d6bbf2bb5f
Fix implementation of initialized index map getters
2020-03-04 11:56:50 +01:00
Mael Rouxel-Labbé
7e303f421f
Add 'Is_writable_property_map'
...
Note the following:
'lvalue_pmap_tag' is annoying, because the property map is allowed to be non-mutable,
but boost::lvalue_property_map_tag is !always! defined as:
struct lvalue_property_map_tag : public read_write_property_map_tag
so we can't just check that 'writable_property_map_tag' is a base of the the pmap's category.
Instead, this struct checks if the reference is non-const, which is not completely correct:
map[key] returning a non-const reference doesn't mean that 'put(map, key, val)' exists,
which is what a writable property map must define.
2020-03-04 09:02:13 +01:00
Mael Rouxel-Labbé
e94da7c669
Remove trailing whitespace
2020-03-02 14:00:11 +01:00
Maxime Gimeno
79c390eb6d
fix warning
2020-02-26 16:17:17 +01:00
Maxime Gimeno
9a454ca7e2
Changes after review
2020-02-21 11:43:08 +01:00
Maxime Gimeno
077a129216
Merge remote-tracking branch 'cgal/master' into PMP-Default_pmap-maxGimeno
2020-02-21 10:34:14 +01:00
Maxime Gimeno
195d43bc5e
Fix conversion warning
2020-02-20 16:49:54 +01:00
Maxime Gimeno
c999ce144f
Add the missing spe for Seam_mesh and dynamic_property_map
2020-02-19 10:07:53 +01:00
Maxime Gimeno
928f2bd2bb
Remove unused typedef
2020-02-19 09:16:55 +01:00
Maxime Gimeno
cf6fec2bbb
move using
2020-02-18 16:36:05 +01:00
Maxime Gimeno
aeb44510f1
Fix doc about boost/CGAL property tags
2020-02-18 15:27:34 +01:00
Maxime Gimeno
7ec84ae69c
replace the functor by overloads of a free function
2020-02-18 14:42:53 +01:00
Maxime Gimeno
7d11c830e4
add some typedefs to get_ndi_map
2020-02-18 11:38:08 +01:00
Maxime Gimeno
9459df666d
fix after review
2020-02-18 11:26:09 +01:00
Sébastien Loriot
e759011cb5
handle cases when the traversed faces is split by a border
...
a non-manifold vertex might be created in this case
2020-02-17 19:11:13 +01:00
Maxime Gimeno
b9a8d50b66
add missing include
2020-02-17 11:18:42 +01:00
Maxime Gimeno
5538786eff
Merge remote-tracking branch 'cgal/master' into PMP-Default_pmap-maxGimeno
2020-02-14 15:00:54 +01:00
Laurent Rineau
141eed441c
Merge pull request #4508 from MaelRL/BGL-Fix_graph_has_property_doc-GF
...
BGL: fix doc of graph_has_property
2020-02-14 14:39:16 +01:00
Maxime Gimeno
249eb85060
fixes
2020-02-14 14:25:28 +01:00
Maxime Gimeno
002a3ac218
refines the Is_pmap_writable to take the reference constness into account
2020-02-14 13:40:57 +01:00
Mael Rouxel-Labbé
754cf35342
Fix graph_has_property not showing up in documentation
...
Consequence of the doc being split between doc/CGAL and include/CGAL...
2020-02-07 16:11:22 +01:00
Mael Rouxel-Labbé
57a86afc3b
Merge branch 'PMP-Snapping_improvements-GF-old' into PMP-Snapping_improvements-GF
2020-01-15 18:18:24 +01:00
Laurent Rineau
ed4cf46ee0
Merge pull request #4065 from MaelRL/PMP-New_vertex_normal_computations-GF
...
PMP: add a new way to compute vertex normals
2020-01-15 17:24:02 +01:00
Laurent Rineau
631e383e20
Merge pull request #4132 from MaelRL/PMP-Remove_small_CCs
...
PMP: remove small connected components
2020-01-15 17:24:00 +01:00
Laurent Rineau
f37e107523
Merge pull request #4428 from sloriot/BGL-selection_border_case
...
Handle "border" case
2020-01-15 17:19:30 +01:00
Mael Rouxel-Labbé
a1115c2ef1
Merge branch 'PMP-Snapping_improvements-GF-old' into PMP-Snapping_improvements-GF
2020-01-15 10:44:49 +01:00
Mael
0f4986f82b
Merge branch 'master' into PMP-New_vertex_normal_computations-GF
2019-12-26 19:37:59 +01:00
Sébastien Loriot
e80f869147
Merge remote-tracking branch 'cgal/master'
2019-12-20 09:35:45 +01:00
Sébastien Loriot
056ce68477
handle "border" case
...
hard to put in a test because it depends on the starting
point of the iteration
2019-12-20 09:06:55 +01:00
Mael
7db5153f6d
Merge branch 'master' into PMP-Remove_small_CCs
2019-12-05 12:19:31 +01:00