Commit Graph

2368 Commits

Author SHA1 Message Date
Sébastien Loriot 9cdfe70abb Merge remote-tracking branch 'sloriot/CGAL-toward_6.0' 2023-06-15 11:34:09 +02:00
Sébastien Loriot edc317d771 variant::which() => variant::index() + typos 2023-06-15 10:57:10 +02:00
Sébastien Loriot 9a0bdb5d96 boost::variant ---> std::variant 2023-06-15 10:57:10 +02:00
Sébastien Loriot 604dcdc435 boost::optional => std::optional 2023-06-15 10:57:09 +02:00
Sébastien Loriot bbc4d08ee0 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 10:47:07 +02:00
Sébastien Loriot c8a88b9014 remove CGAL_static_assertion* 2023-06-15 10:42:10 +02:00
Efi Fogel 7ffda351d2 reverted back commented out statement 2023-06-11 17:36:59 +03:00
Efi Fogel ce02ab6632 Added support for drawing an arrangement on a sphere induced by geodesic arcs 2023-06-07 11:41:56 +03:00
Efi Fogel 3ade612d49 Merge branch 'gsoc2023-aos_sphere_demo-denizdiktas' of github.com:CGAL/cgal-public-dev into gsoc2023-aos_sphere_demo-denizdiktas 2023-06-03 15:43:55 +03:00
denizdiktas 81d4592766 style corrections 2023-06-02 12:24:21 +03:00
Efi Fogel 0477dfe2f3 Removed unnecessary (actually erroneous) member function definitions 2023-06-02 11:15:06 +03:00
denizdiktas 34b9a7d356 Removed std::vector from the algorithm, now outputting the approximation points directly to the output iterator. 2023-06-01 13:09:41 +03:00
denizdiktas fc9c993a23 Added std:: in front of math functions 2023-06-01 11:39:43 +03:00
denizdiktas 7a447d661a Code clean-up and style corrections 2023-06-01 11:33:58 +03:00
denizdiktas 01e6057017 Fixed approximation of arcs with theta>PI: atan2 was returning negative value, so I added 2*PI to make it in the range [0,2*PI) 2023-05-30 17:44:25 +03:00
denizdiktas 910e0437a0 changed the error type in the approximation function from double to Approximate_number_type 2023-05-30 15:40:31 +03:00
denizdiktas a079b5d572 Initial implementation of the approximation-function inside Approximate_2 2023-05-30 15:33:54 +03:00
Efi Fogel 2159476dc4 Fixed Approxinate_2::operator()(const Point_2&) 2023-05-29 17:44:16 +03:00
Efi Fogel facc5926e6 Fixed dependencies. (Moved Arr_extended_direction_3 definition to the front.) 2023-05-27 22:54:43 +03:00
Efi Fogel 9720911727 Ops (Approximate_point_2) 2023-05-26 18:33:25 +03:00
Efi Fogel f9b9591f04 Fixed some approximate operators 2023-05-26 18:32:12 +03:00
Laurent Rineau 9bafd13b00 Merge pull request #6721 from efifogel/Aos_2-conics-efif
Resurect The Conic Traits
2023-05-11 16:55:35 +02:00
Efi Fogel c1c1a51b6a Merge branch 'Aos_2-conics-efif' into gsoc2023-aos_sphere_demo-denizdiktas 2023-05-10 11:55:41 +03:00
Sébastien Loriot 1c277cdb06 fix warnings 2023-05-09 18:38:16 +02:00
Efi Fogel 92bc3de2de Fixed Approximate_2 for the geodesic traits. Fixed unused formal variables. 2023-05-05 18:43:10 +03:00
Efi Fogel 141731ec79 Fixed Approximate_2 2023-05-02 09:58:18 +03:00
Sébastien Loriot c1294a0eaa boost::integral_constant ---> std::integral_constant 2023-04-29 09:42:15 +02:00
Efi Fogel f6db4a6d94 Fixed argument to draw_point_imp1() 2023-04-27 14:02:29 +03:00
Efi Fogel ef7b62119b Add member operator() to Approximate() for point and segment approximation and used it to remove the compile-time-dispatching all together in the drawing function 2023-04-27 13:31:10 +03:00
Efi Fogel 3f65c37eda Implemented and alternative for compile time dispatching, which might work with MSVC 14. 2023-04-26 19:32:43 +03:00
Sébastien Loriot b039040f73 boost::is_convertible -> std::is_convertible 2023-04-23 22:37:07 +02:00
Sébastien Loriot a88af6c0c6 boost::array -> std::array 2023-04-23 22:37:07 +02:00
Sébastien Loriot 8b3acae1c7 boost::remove_reference -> std::remove_reference 2023-04-23 22:36:59 +02:00
Laurent Rineau ae3e2b6287 Merge pull request #7323 from efifogel/Aos_2-fixes-efif
Arrangement_on_surface_2 fixes
2023-03-31 11:10:52 +02:00
Andreas Fabri ef54ecb82c Fix Minkowski_sum_2 2023-03-22 15:28:15 +01:00
Efi Fogel 204cf9f815 Commented out unused variables 2023-03-21 09:58:28 +02:00
Efi Fogel eff6474fcf Added a parameter pack to the constructor and passed it to the underlying traits; disabled copy constructor. 2023-03-14 14:21:46 +01:00
Efi Fogel 22d35af320 Replaced copy-constructor of traits with simple conversion 2023-03-14 14:21:46 +01:00
Efi Fogel 11de0a7c79 Properly set the data of extended records using setters (set_data()) 2023-03-14 14:21:46 +01:00
Efi Fogel 6699397eb5 Added a parameter pack to the constructor and passed it to the underlying traits; Called are_mergeable_2 only if the base supports it. 2023-03-14 14:21:45 +01:00
Efi Fogel ec15089353 Fixed handling unbounded curves that are both infinite on the left and infinite at the top 2023-03-14 14:21:45 +01:00
Andreas Fabri 1c00c6490e Fix arrangement demo 2023-03-10 14:41:30 +00:00
Andreas Fabri a714a6f5db Fix Surface_sweep 2023-03-07 12:56:46 +00:00
Efi Fogel 2a8100bff6 Removed unused variables; Fixed color_generator parameter passing; pacified msvc 2023-02-22 14:49:49 +02:00
Efi Fogel b0b080e65e Replaced use of boost::hana with c++14 features to implement compile-time dispatching 2023-02-15 18:40:04 +02:00
Efi Fogel ccdb5a0b54 Merge remote-tracking branch 'cgal/master' into Aos_2-conics-efif 2023-02-15 14:36:44 +02:00
Andreas Fabri 50621a4258 reactivate code 2023-02-10 08:23:53 +00:00
Efi Fogel 6705b15fdb Added color generator; improved internal API 2023-02-09 01:03:33 +02:00
Andreas Fabri 2184d22c52 WIP [scip ci] 2023-02-07 21:18:31 +00:00
Andreas Fabri fb71e3937e Add numerator() and denominator() 2023-02-07 15:42:49 +00:00
albert-github 0ea013ea12 Spelling corrections
Some spelling corrections.
2023-02-03 12:07:03 +01:00
Sebastien Loriot 384377eda3
typo 2023-01-17 10:02:22 +01:00
albert-github 9c2f8ff60e Spelling correction in respect to function / variable names
As indicated in #7041 (Spelling corrections) theer were still some open corrections in respect to variables / functions, these have been addressed heer.
2023-01-13 18:51:28 +01:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Laurent Rineau 67b5c791e9 Merge pull request #7075 from MaelRL/CGAL-Fix_some_links-GF
Update some links + https
2022-12-05 12:22:06 +01:00
Mael Rouxel-Labbé b5c21e1f5d Http -> https + update some dead links 2022-11-23 18:54:37 +01:00
albert-github 9d709b12e5 spelling corrections
After review
2022-11-21 10:40:28 +01:00
albert-github 781f9a2943 spelling corrections
After review:
- outputhing -> outputting
- neighbour -> neighbor
2022-11-17 10:25:10 +01:00
albert-github 3674c937f7 spelling corrections
Some spelling corrections (Directories starting with `M`-` N`),
some backward work
some forward work
2022-11-15 15:21:01 +01:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
albert-github 014c06fd19 spelling corrections
Some spelling corrections (Directories starting with `A`)
2022-11-14 15:32:47 +01:00
Efi Fogel 9d905ec276 Merge remote-tracking branch 'cgal/master' into Aos_2-fixes-efif 2022-11-02 22:27:17 +02:00
Efi Fogel 03285a42cf Replaced std::uniform_int_distribution<unsigned char> with std::uniform_int_distribution<int> to pacify MSVC 2022-10-19 01:30:38 +03:00
Sébastien Loriot 215b2ea5c4 add missing config include 2022-10-18 18:06:29 +02:00
Sébastien Loriot ade16fc7d7 fix warnings 2022-10-17 14:12:41 +02:00
Sébastien Loriot b6bdac2847 add workaround to use boost hana with MSVC 2022-10-17 11:23:22 +02:00
Sébastien Loriot e1c7254ffb fix conversion warnings 2022-10-17 10:30:42 +02:00
Sébastien Loriot d8fb80551c fix warnings 2022-10-13 13:48:16 +02:00
Sébastien Loriot 8ab29c50b2 fix header 2022-10-13 13:42:10 +02:00
Efi Fogel 2639ef203f Used CGAL_PI 2022-09-28 12:20:25 +03:00
Efi Fogel c01b6b95ee Used boost::math::constants::pi<double>() instead of M_PI macro. 2022-09-28 11:19:16 +03:00
Efi Fogel fb36bde045 Declared an isolated-vertex iterator to pacify MSVC. Without it the implicit conversion from the iterator to the corresponding handle fails! 2022-09-28 10:59:25 +03:00
albert-github 81d78f7969 Some obvious missing quotes and typos
Some obvious missing quotes and typos
2022-09-24 18:47:33 +02:00
Efi Fogel 3485ce1a8a Fixed trimming and avoided using deprecated code. 2022-09-11 12:11:53 +03:00
Efi Fogel a99617aa09 Finished restating the code for backward compatibility. 2022-09-10 12:59:24 +03:00
Efi Fogel e0b44a3273 (Temporarily restated deprecated functions. 2022-09-07 20:02:55 +03:00
Efi Fogel f62a289d11 Fixed _check_isolated_for_vertical_ray_shoot() 2022-09-07 10:23:10 +03:00
Efi Fogel 0d69f62bee Initialized _m_location 2022-09-05 01:46:17 +03:00
Efi Fogel e09b73be59 Defined M_PI properly 2022-09-01 10:15:16 +03:00
Efi Fogel af11965842 Used the Multiplicitly type (instead of unsigned int) 2022-09-01 10:14:52 +03:00
Efi Fogel e2423af1ad Replaced call to member traits() with geometry_traits() and cleaned up 2022-08-25 19:11:07 +03:00
Efi Fogel d03c6bb9d2 dded getters to obtain the internally algebraic kernel, rational kernel, and nt traits. Also, refractored a bit so that it can be used by the envelope sphere traits. 2022-08-10 17:45:34 +03:00
Efi Fogel 90f74ea390 Changed the order of inclusion. 2022-08-10 17:44:57 +03:00
Sébastien Loriot 861588abe1 Merge 'sloriot/CGAL-std_type_traits' into master 2022-08-03 20:19:51 +02:00
Efi Fogel 10c0664207 Added missing include 2022-07-28 14:15:14 +03:00
Efi Fogel 480eb29169 Fixed typo 2022-07-26 17:46:03 +03:00
Efi Fogel efcca95f05 Intialized Arr_polyhedral_sgm_polyhedron_3_vertex::m_processed 2022-07-26 17:45:35 +03:00
Efi Fogel 8ab4747f4e Used predefined windo x and y dimensions 2022-07-25 12:18:37 +03:00
Efi Fogel 6acdff105d Merge branch 'master' into Aos_2-conics-efif. Updated changes made to the 2D Arrangement on Surface package 2022-07-25 11:23:09 +03:00
Efi Fogel 2aa04d9522 Fixed compile-time dispatching 2022-07-25 11:08:28 +03:00
Efi Fogel 72235f65d5 Added support for drawing arrangements induced by circular arcs and (linear) segment (Arr_circle_segment_traits_) 2022-07-25 00:05:09 +03:00
Efi Fogel 627c8d5953 Added code to prevent blocking when running the test suite 2022-07-23 15:55:30 +03:00
Efi Fogel 6b1315b620 Pacified some compilers, e.g., replaced specific type with 'auto'. 2022-07-22 13:05:17 +03:00
Efi Fogel 69be059b13 Last fix for is_in_face()... 2022-07-19 12:13:02 +03:00
Efi Fogel 5f8291ea82 One more fix for is_in_face() in the case where the point lies on the identification curve but the curves do not. 2022-07-19 11:58:56 +03:00
Efi Fogel 5a02c62a41 Fixed the case where left and right sides are identified, and the bottom and top sides have boundary conditions (but they are not identied). 2022-07-18 09:57:15 +03:00
Efi Fogel 7f88b72f81 Fixed some comments in English 2022-07-13 15:23:16 +03:00
Efi Fogel c92d65efbe Fixed the drawing of non-linear curves based on the correct pixel/GLuint ratio. 2022-07-13 02:26:32 +03:00
Efi Fogel 56020e6798 Fixed is_in_face() for the case where the point lies on the identification curve. 2022-07-10 15:57:02 +03:00
Efi Fogel 28f3f28144 Fixed a small bug in Is_between_cw_2 2022-07-04 09:03:28 +03:00
Efi Fogel 17906d39aa Fixed spelling in comment 2022-07-04 09:01:40 +03:00
Efi Fogel 5c40db8591 Implemented Compare_y_at_x_2 functor in the adapter; it takes boundary conditions into consideration. 2022-07-03 19:39:20 +03:00
Efi Fogel b390c0e3db Fixed typo in comment 2022-07-03 19:38:23 +03:00
Efi Fogel ed27ca760e Fixed spelling typo. 2022-07-03 19:37:39 +03:00
Laurent Rineau ac0a35f6df Merge remote-tracking branch 'cgal/master' into Aos_2-conics-efif
# Conflicts:
#	Installation/CHANGES.md
2022-06-28 11:12:23 +02:00
Andreas Fabri 55edc672ab Arrangement: Fix comment in Arr_segment_traits 2022-06-27 17:55:51 +01:00
Efi Fogel 6688e9b156 Cleaned up 2022-06-27 18:21:49 +03:00
Efi Fogel 597c1a96a4 Fixed density; added callback to capture window size 2022-06-26 16:04:17 +03:00
Efi Fogel 87b6a35b2e Fixed approximating conics 2022-06-26 16:03:48 +03:00
Sébastien Loriot c9c6b30cf0 Merge sloriot/CGAL-std_type_traits into master 2022-06-23 16:35:37 +02:00
Efi Fogel 8543ef5a25 Cleaned up; replaced typedef with using (when possible). 2022-06-23 15:42:17 +03:00
Efi Fogel 88113a7b82 Cleaned up 2022-06-22 18:21:39 +03:00
Efi Fogel 2ba0fc38b5 Fixed a couple of bugs 2022-06-22 09:38:55 +03:00
Efi Fogel 27d2bd5f21 More clean ups 2022-06-20 17:51:11 +03:00
Efi Fogel fefbe9abd2 More clean ups and small bug fixes 2022-06-20 13:44:23 +03:00
Efi Fogel 7988148710 Cleaned up 2022-06-19 12:39:43 +03:00
Sébastien Loriot 37580e9daf missing () in macro + typo fixes 2022-06-14 11:24:21 +02:00
Efi Fogel 3f8b2501ad Fixed x- and y- major parabolas 2022-06-11 19:58:48 +03:00
Laurent Rineau f4b1adefc7 Merge pull request #6638 from sloriot/Argt-no_boost_pool_alloc
Disable boost pool allocator
2022-06-10 16:45:35 +02:00
Laurent Rineau 4ea5251b9b Merge pull request #6638 from sloriot/Argt-no_boost_pool_alloc
Disable boost pool allocator
2022-06-10 16:44:17 +02:00
Sébastien Loriot 8ed2990381 use CGAL_static_assertion
static_assert(b) is only available in c++17
2022-06-10 10:10:12 +02:00
Sébastien Loriot 3fa436459d BOOST_MPL_ASSERT -> static_assert 2022-06-10 08:46:01 +02:00
Sébastien Loriot ac8b6d4731 boost::is_same --> std::is_same 2022-06-10 08:18:20 +02:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Efi Fogel e61d5eb52f Continued 2022-06-09 19:20:49 +03:00
Efi Fogel 2282f9f0e5 Continued. Fixed treating source and target vertices 2022-06-07 20:32:24 +03:00
Efi Fogel 4083266a4d Added trully random colors. Fixed face handling. 2022-06-07 20:31:50 +03:00
Sébastien Loriot 3d4ca1ae4e completely disable boost pool allocator
some regressions are observed in multithreaded env
2022-06-02 18:44:06 +02:00
Efi Fogel c7ddd44274 Continued 2022-05-31 20:48:23 +03:00
Efi Fogel 9c89ddb71e Continued 2022-05-31 19:36:40 +03:00
Efi Fogel ab52d337b7 Continued 2022-05-31 11:15:54 +03:00
Efi Fogel 00c5bd495d Continued cleaning up. 2022-05-30 18:59:54 +03:00
Efi Fogel d4471a5b07 Further clean up; suppress construction of local kernel, etc. 2022-05-26 20:18:09 +03:00
Efi Fogel d5f66f614e Fixed drawing 2D arrangements 2022-05-26 19:40:14 +03:00
Efi Fogel 1bb77e8ba9 Fixed drawing 2d arrangements 2022-05-26 11:48:39 +03:00
Efi Fogel 986746b1dd Fixed arrangement basic drawing code 2022-05-26 00:06:57 +03:00
Efi Fogel 151132c88e Fixed computation of approximate polyline 2022-05-25 10:49:32 +03:00
Efi Fogel ac0ea63bbe Cleaned up 2022-05-25 10:48:55 +03:00
Efi Fogel 8890a779eb ixed drawing of 2D arrangements 2022-05-25 10:48:14 +03:00
Efi Fogel a5a0c049cb Continued to move Conic_arc_2 constructors to the traits 2022-05-23 15:13:45 +03:00
Efi Fogel 70d21e5a39 Move conic construction to the (conic) traits and elliminated the constructions of local kernel objects. 2022-05-23 11:01:11 +03:00
Efi Fogel a5e015a8a3 Cleaned up 2022-05-19 23:57:42 +03:00
Efi Fogel 2429950bdd Finished handling flags 2022-05-19 23:36:29 +03:00
Efi Fogel 9353296bcb Cleaned up 2022-05-19 23:36:08 +03:00
Efi Fogel 5329c37bc7 Updated 2022-05-19 17:43:08 +03:00
Efi Fogel 5021b828e9 updated 2022-05-19 17:22:07 +03:00
Efi Fogel 81b67b0708 Started to use std::bitset for the info field 2022-05-19 16:44:12 +03:00
Efi Fogel e8eb85d5dc Drew faces in the correct order (from unbounded to inner). 2022-05-18 14:04:52 +03:00
Efi Fogel d1b05fd144 Cleaned up 2022-05-18 13:37:17 +03:00
Efi Fogel 418e2b0c6b descended to inner ccbs 2022-05-18 13:25:18 +03:00