Commit Graph

2368 Commits

Author SHA1 Message Date
Efi Fogel b64818cc99 Drawing arrangement (1st rev.) and basic cleanup conic traits 2022-05-18 10:08:10 +03:00
Andreas Fabri 380704bf67 Arrangement and update documentation 2022-05-03 15:31:09 +01:00
Laurent Rineau 7d4a8e5469 Merge pull request #6408 from efifogel/Aos_2-geodesic_traits-efif
Aos 2 geodesic traits efif

# Conflicts:
#	Installation/CHANGES.md
2022-04-06 09:12:02 +02:00
Sebastien Loriot c6898b8491
Avoid unused typedef warning 2022-04-04 09:31:07 +02:00
Efi Fogel e27627e06f Computing the sign of the x-component of the cross product of two directions efficiently. 2022-03-21 11:30:28 +02:00
Efi Fogel 5456f266c0 Fixed typo in a comment: queves => curves 2022-03-14 13:37:55 +02:00
Efi Fogel b743aa66ce Removed useless comment and used a meaningful variable name 2022-03-14 13:36:01 +02:00
Efi Fogel 198e12c7c2 Fixed parameter decleration is compare_y_at_x_left 2022-03-13 14:48:02 +02:00
Efi Fogel 468a7cabcf Fixed and added tests for compare_y_at_x_left 2022-03-13 14:39:50 +02:00
Efi Fogel 97b35b7e36 Fixed make_x_monotone functor 2022-03-13 11:52:42 +02:00
Laurent Rineau 258d704a90 Merge pull request #6209 from sloriot/PMP-std_instead_of_boost
Use features available in std instead of boost
2022-02-24 19:57:17 +01:00
Laurent Rineau fa3527c54f Merge pull request #6183 from efifogel/Aos_2-construct_curve_2-efif
Aos 2 construct curve 2 efif
2022-02-08 23:44:41 +01:00
Efi Fogel 5b269e908a Fixed Compare_y_near_boundary and added correspondings tests 2022-02-08 22:25:30 +02:00
Efi Fogel bb2e831382 Fixed Intersect_2 and Compare_y_at_x_left geodesic-arc traits and introduced correspondings tests 2022-02-08 16:23:21 +02:00
Efi Fogel a7aeee4600 Fixed comapre_y_at_x_right of geodesic traits and added a corresponding test 2022-02-07 18:46:16 +02:00
Sébastien Loriot 4ffc949199 replace boost::unordered by std::unordered
but in T3, Mesh_3, TDS_3, P3[TM]3
2022-02-03 19:11:12 +01:00
Efi Fogel 295e9b971e Commented out unused variables 2022-02-02 15:44:48 +02:00
Sébastien Loriot c169c41240 Merge remote-tracking branch 'maxGimeno/PMP-Example_of_new_mp_function-maxGimeno' into HEAD 2022-01-12 13:33:49 +01:00
Efi Fogel 774e353c46 Should be Geometry_traits_2 and not Traits; used auto instead. 2022-01-11 11:32:50 +02:00
Sébastien Loriot 6d3176e061 move Named_parameters class in STL_extension
helpers stay in BGL because it depends on BGL tags
2022-01-07 15:12:22 +01:00
Efi Fogel 1081a67647 Fixed typeos ('!=' instead of '|=') 2022-01-05 19:42:15 +02:00
Efi Fogel fe06974730 Added missing 'const' 2022-01-04 16:17:34 +02:00
Efi Fogel c0838c533a Added Construct_curve_2. This is used by the (generic) code of the polyline traits. 2021-12-16 16:33:43 +02:00
Efi Fogel 5f436125e6 moved two redundant constructors that do not even compile 2021-12-16 16:33:02 +02:00
Efi Fogel 54b423c81b Used traits to construct curve 2021-12-16 11:13:12 +02:00
Sébastien Loriot 993a7b29b0 fix warnings about arithmetic operations on enum
cherry-pick of 364009
2021-11-29 17:59:12 +01:00
Laurent Rineau e683686055 Merge pull request #6094 from sloriot/AOS_2-remove_fast_pool_allocator
Fix issues with new containers for arrangement cells

# Conflicts:
#	Arrangement_on_surface_2/include/CGAL/Arr_dcel_base.h
2021-11-18 12:31:39 +01:00
Andreas Fabri a2ae7d8e13 Addess -Wdeprecated-anon-enum-enum-conversion 2021-11-10 08:22:46 +00:00
Sébastien Loriot c1d2fe3758 readd fast_pool allocator 2021-11-09 14:54:58 +01:00
Sébastien Loriot 5da848dbd3 rollback on changing the dcel to Compact_container
the freelist being not clear is actually an issue
when small arrangement are created out of large one
2021-11-09 14:50:09 +01:00
Sébastien Loriot 69f91992ee improve delete_all()
use Compact_container::clear() that will deallocate by blocks
and clear the freelist
2021-11-04 15:38:25 +01:00
Sébastien Loriot f0c94afce0 use default allocator that introduce a huge regression in some cases 2021-10-29 18:01:07 +02:00
Laurent Rineau 1ba982096a Merge pull request #5094 from sgiraudot/Boolean_operations-Use_GPS_based_polylines-GF
[Small Feature] Boolean Operations: Use polyline-based GPS
2021-10-07 14:27:23 +02:00
Mael Rouxel-Labbé 521c72d57e Fix typos 2021-10-04 13:34:07 +02:00
Mael Rouxel-Labbé 625848e629 Fix missing ':' in various namespaces 2021-10-04 13:21:47 +02:00
Laurent Rineau 0f26960174 Merge pull request #6019 from sloriot/CGAL-enum_arithm_w
Fix warnings about arithmetic operations on enum
2021-09-29 16:59:31 +02:00
Sébastien Loriot 3640099261 fix warnings about arithmetic operations on enum 2021-09-28 15:36:51 +02:00
Andreas Fabri c3d4306cb2 Replace sprintf with stringstream 2021-09-23 17:00:10 +02:00
Andreas Fabri e537c80442 Replace sprintf with stringstream 2021-09-23 17:00:09 +02:00
Andreas Fabri 055f87de26 Use std::array and avoid mem_set 2021-09-23 16:57:35 +02:00
Andreas Fabri 637d61c974 Fix in Arr_counting_traits_2.h 2021-09-23 16:57:34 +02:00
Sébastien Loriot 0ef13b30bf fix author 2021-09-23 11:10:43 +02:00
Sébastien Loriot 36249c0fa0 Merge remote-tracking branch 'cgal/master' into HEAD 2021-09-23 11:07:06 +02:00
Sebastien Loriot 4610cf3c66
Merge pull request #5904 from sloriot/CGAL-remove_config_flags
Replace macros with inline functions and remove a config flag
2021-09-10 17:38:50 +02:00
Sébastien Loriot 4afc249100 do not hide type definitions 2021-09-09 15:58:00 +02:00
Sébastien Loriot 6e1fc8a4e5 Merge remote-tracking branch 'cgal/master' into HEAD 2021-09-02 16:53:07 +02:00
Sébastien Loriot 5be3a41f26 try to silence warnings 2021-08-30 15:08:47 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Efi Fogel c3022226d7 Replaced unsigned with the correct integral type (which resolved some warnings) 2021-08-19 13:59:28 +03:00
Efi Fogel d14cece4ca Commenting out unused formal variables 2021-08-19 13:27:46 +03:00
Sébastien Loriot d4c7e220c1 Merge remote-tracking branch 'cgal/5.3.x-branch' 2021-08-13 18:27:28 +02:00
Sébastien Loriot b0a85960bf Merge remote-tracking branch 'cgal/5.2.x-branch' into HEAD 2021-08-13 18:27:07 +02:00
Sébastien Loriot fa2c353fff move impl outside of the class 2021-08-12 10:35:39 +02:00
Efi Fogel 8d95fb809b Pacify msvc 2021-08-11 18:37:30 +03:00
Efi Fogel 54b301cc56 handled unused variable (only used in debug mode). 2021-08-10 12:38:31 +03:00
Efi Fogel bfc5b7e6f8 Clean ups; Removed unused types and variables; Fixed limit => boundary terminology 2021-08-10 10:49:11 +03:00
Efi Fogel 5e73fe1eba Merge remote-tracking branch 'cgal/master' into Aos_2-boundary_objects-efic 2021-08-04 12:22:09 +03:00
Sébastien Loriot a3d04af49c fix issue in case an overlapping curve is split
in case an arrangement is updated and an overlap curve
is on an existing halfedge, the incident halfedge
to an event has to be updated after the split.
This is done by checking all left events in parent subcurves
of the overlapping subcurve.
2021-07-28 16:47:13 +02:00
Sébastien Loriot 5985db1fe8 fix typos 2021-07-28 16:47:12 +02:00
Maxime Gimeno 97cac65a86 Fix __GNUC__ tests 2021-07-23 10:59:49 +02:00
Maxime Gimeno a3d1765ab4 Merge remote-tracking branch 'cgal/master' into CGAL-Clean_up_boost_versions-maxGimeno 2021-07-19 14:18:40 +02:00
Mael Rouxel-Labbé 78ff9185b3 Harmonize ASCII usage across all packages 2021-06-23 23:34:32 +02:00
Laurent Rineau 59a0da4f13 Merge pull request #5692 from maxGimeno/CGAL_cpp11_atomic_and_threads-maxGimeno
CGAL:: Use std atomic and threads

# Conflicts:
#	Arrangement_on_surface_2/include/CGAL/Arr_counting_traits_2.h
2021-05-19 17:23:53 +02:00
Laurent Rineau 82bec8a1d6 Merge pull request #5692 from maxGimeno/CGAL_cpp11_atomic_and_threads-maxGimeno
CGAL:: Use std atomic and threads

# Conflicts:
#	Arrangement_on_surface_2/include/CGAL/Arr_counting_traits_2.h
2021-05-19 17:11:37 +02:00
Laurent Rineau 26ad68e486 Merge pull request #5649 from sloriot/CGAL-no_boost_shared_ptr
Replace internal use of boost shared_ptr
2021-05-18 18:14:12 +02:00
Maxime Gimeno e6c767d5c9 Simplify the GNUC versions tests 2021-05-12 15:45:07 +02:00
Maxime Gimeno 393ae7dae6 Clean-up boost_version reqs 2021-05-12 15:03:53 +02:00
Maxime Gimeno 3e03d50b8a replace usages of CGAL::cpp11::atomic and thread by std:: calls 2021-05-07 11:10:30 +02:00
Maxime Gimeno e9b7595fff Deprecate CGAL headers for threads, atomic and result_of, and move their content to config.h as fallback 2021-05-07 11:09:24 +02:00
Efi Fogel ac8a07ca77 Fixed test data format; Added tests for (full) great circles; fixed construction of (full) great circles. 2021-05-05 21:23:53 +03:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot fb6f703b55 IO namespace for files in IO directories 2021-05-04 14:36:06 +02:00
Sébastien Loriot 755693ba45 IO namespace in Arrangement package 2021-05-03 13:27:31 +02:00
Efi Fogel 2abf0c0f5b Added back the missing constructor of an x-monotone full great circle. 2021-04-29 16:36:41 +03:00
Efi Fogel 45d0050322 Fixed construction of full circles and other minor changes 2021-04-29 12:14:28 +03:00
Sébastien Loriot 1faa0e2992 replace internal use of boost::shared_ptr by std::shared_ptr 2021-04-28 10:55:26 +02:00
Efi Fogel ba8aec60f2 Small text fixes 2021-04-21 13:24:05 +03:00
Efi Fogel 9c7c9830c6 Fixed the move of curves from the top face 2021-04-07 09:49:14 +03:00
Efi Fogel f8f0e64ef4 Fixed the handling of a case where a spherical arc is added to an arr that already has an arc that lies on the identification curve; added a test. 2021-03-31 13:38:36 +03:00
Efi Fogel 9e5385d0bf Fixed the computation of the red and blue north face s 2021-03-25 15:49:58 +02:00
Efi Fogel 2d1e009209 Cleaned up 2021-03-25 12:53:48 +02:00
Simon Giraudot 3cf1853832 Rebase 2021-03-25 10:03:35 +01:00
Laurent Rineau 21755b1123 Merge pull request #5245 from GilesBathgate/create-assertions-fix
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
2021-03-24 15:05:41 +01:00
Simon Giraudot 3448035fc6 Fix CC_iterator by making constructor from pointer explicit 2021-03-24 08:25:29 +01:00
Efi Fogel fd18c19b99 Fixed wrong conflic-resolving in previous merge. 2021-03-22 15:34:44 +02:00
Efi Fogel 30da4ebae2 Merge remote-tracking branch 'cgal/master' into Aos_2-boundary_objects-efic 2021-03-22 13:35:23 +02:00
Laurent Rineau dc36cee2d5 Merge pull request #5166 from sgiraudot/Arrangement_2-Enhanced_ccb_merge-GF
Arrangement 2: Enhanced CCB Merging for Surface Sweep
2021-03-10 11:53:16 +01:00
Laurent Rineau 06cd9422e4 Merge pull request #5166 from sgiraudot/Arrangement_2-Enhanced_ccb_merge-GF
Arrangement 2: Enhanced CCB Merging for Surface Sweep
2021-03-10 10:33:19 +01:00
Efi Fogel 74a0e95430 Added missing include 2021-03-03 11:01:18 +02:00
Efi Fogel 12a85a919b Merge remote-tracking branch 'cgal/master' into Aos_2-boundary_objects-efic 2021-03-01 15:39:36 +02:00
Efi Fogel f9208ac7ae Replaced increment and decrement operators with superior std::next() and std::prev() 2021-03-01 15:32:21 +02:00
Efi Fogel 37dc35d8bf Used increment and decrement operators rather than addition and subtraction 2021-03-01 14:39:02 +02:00
Efi Fogel 5192d00a68 Removed obsolete make_curve_2 2021-03-01 00:06:52 +02:00
Efi Fogel e96a65bb74 Cleaned up and enhanced Construct_curve_2 2021-02-28 19:18:11 +02:00
Efi Fogel 1683b8d39c Cleaned up 2021-02-28 12:05:43 +02:00
Efi Fogel fb1d6dea5a Merge remote-tracking branch 'cgal/master' into Boolean_operations-Use_GPS_based_polylines-GF 2021-02-24 12:54:13 +02:00
Mael Rouxel-Labbé 5efa544734 Merge remote-tracking branch 'cgal/master' into SDG-Fix_doc-GF 2021-02-22 17:19:40 +01:00
Laurent Rineau a735e849c0 Merge pull request #5152 from sloriot/CGAL-remove_bind
Replace usages of boost::bind
2021-02-05 16:14:04 +01:00
Sébastien Loriot 32b31fdc9b use one lambda 2021-02-02 11:09:46 +01:00
Sébastien Loriot 5311c150f5 boost transform iterator cannot use raw lambdas as begin/end iterator types must be identicals 2021-01-29 18:40:01 +01:00
Simon Giraudot 2e98995b29 Clean up and use fast pool allocator (faster) 2021-01-28 14:24:07 +01:00
Simon Giraudot 80e99153dc Use Compact Container in DCEL base instead of in place list 2021-01-28 10:30:55 +01:00
Mael Rouxel-Labbé 1f45360d7a Merge remote-tracking branch 'cgal/master' into SDG-Fix_doc-GF 2021-01-26 09:05:24 +01:00
Dmitry Anisimov 269a47d773
Merge branch 'master' into CGAL-clang_warnings_fix-danston 2021-01-14 16:51:13 +01:00
Dmitry Anisimov af94033a64 arrangement on surface 2 unused variables warning fixed 2021-01-07 16:39:03 +01:00
Sébastien Loriot 0d16ef14c5 replace bind in Arrangement_on_surface_2 2021-01-06 12:59:12 +01:00
Mael Rouxel-Labbé 6b87fe393d Fix various grammar issues 2020-12-05 11:11:33 +01:00
Giles Bathgate 07120b82fa Add missing header includes 2020-12-04 19:42:21 +00:00
Giles Bathgate 5a36ff89b5 Drop NDEBUG it is already visible through CGAL_NO_ASSERTIONS 2020-12-04 19:42:21 +00:00
Simon Giraudot becf548ee1 Update from review 2020-11-17 08:27:03 +01:00
Simon Giraudot 2f9cdd068b Sweep mode for Arrangement_2 2020-11-17 08:27:03 +01:00
Simon Giraudot 2341612609 Add chain of inner CCB handling to Arr_dcel_base 2020-11-17 08:27:03 +01:00
Maxime Gimeno 3b70343590 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-11-16 16:19:43 +01:00
Efi Fogel 6b64dc8def Merge branch 'master' into Aos_2-boundary_objects-efic 2020-11-11 09:38:55 +02:00
Laurent Rineau f33d835d2e Merge pull request #4939 from sgiraudot/Polygon-Vertex_pair_iterator-GF
Arrangement: Avoid constructing Segment_2/Line_2 objects when possible
2020-11-10 08:45:35 +01:00
Efi Fogel c596073ffc Un-deprecated bbox() (for now) 2020-11-05 10:43:47 +02:00
Laurent Rineau 10f399c1fd Merge pull request #5091 from sgiraudot/Arrangement-Fix_polycurve_intersection-efif-GF
[Arrangement] Fix polycurve overlap intersection
2020-11-04 20:46:07 +01:00
Laurent Rineau d4082e00f9 Merge pull request #5091 from sgiraudot/Arrangement-Fix_polycurve_intersection-efif-GF
[Arrangement] Fix polycurve overlap intersection
2020-11-04 20:44:24 +01:00
Efi Fogel bc83b00a2e Cleaned up and deprecated Arr_segment_2::bbox(), which was left by mistake... 2020-11-04 15:55:04 +02:00
Efi Fogel 9e9e572013 Fixed the intersection op. for the case where the 2 input curves have opposite directions 2020-10-28 11:38:45 +02:00
Efi Fogel 65d4593479 defined construct_opposite only if CGAL_ALWAYS_LEFT_TO_RIGHT 2020-10-27 17:47:39 +02:00
Laurent Rineau d08d6ca552 Merge branch '5.1.x-branch' 2020-10-23 16:06:55 +02:00
Laurent Rineau a7cd94f82f Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' into 5.1.x-branch 2020-10-23 16:06:46 +02:00
Simon Giraudot c02ffb762b Use 2 booleans instead of an enum 2020-10-21 13:31:21 +02:00
Simon Giraudot adef28b496 Add assertions and fix bug 2020-10-21 10:12:51 +02:00
Efi Fogel 3f623d99df Construct opposite only if CGAL_ALWAYS_LEFT_TO_RIGHT 2020-10-21 08:40:51 +02:00
Simon Giraudot 615a8768dd Fix inverted segments 2020-10-21 08:40:51 +02:00
Simon Giraudot fcbbea5e0d Better handling of invertions 2020-10-21 08:40:51 +02:00
Simon Giraudot 7588d8803d Cache overlaps and dump at the end (inverted if needed) 2020-10-21 08:40:51 +02:00
Simon Giraudot 3e17be2b30 Merge branch 'Arrangement-Fix_polycurve_intersection-efif-GF' into Boolean_operations-Use_GPS_based_polylines-GF 2020-10-20 10:34:46 +02:00
Simon Giraudot 0b70318c51 Merge remote-tracking branch 'mine/Polygon-Vertex_pair_iterator-GF' into Polygon-Vertex_pair_iterator-GF 2020-10-20 09:01:29 +02:00
Simon Giraudot 8f1d611dda Fix inverted segments 2020-10-19 13:34:31 +02:00
Simon Giraudot 4e25e0c650 Better handling of invertions 2020-10-19 11:47:14 +02:00
Simon Giraudot 4ff6c4952e Cache overlaps and dump at the end (inverted if needed) 2020-10-15 11:59:30 +02:00
Mael Rouxel-Labbé f55ef7dd50 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-10-09 18:36:17 +02:00
Ahmed Essam 32093e6ea3 Merge branch 'master' of https://github.com/CGAL/cgal into gsoc2020-aos_demo-theartful 2020-10-03 20:55:38 +02:00
Sebastien Loriot 03ff1a667f
Merge pull request #4784 from efifogel/Aos_2-remove_object-efif
Aos_2: Change Make_x_monotone_2 return type from legacy CGAL::Object to boost::variant
2020-10-02 15:19:36 +02:00
Ahmed Essam 1ae6f3f495 Fix past the "beginning" bug
This caused assertion error in msvc debug mode while running the demo
2020-10-01 15:56:44 +01:00
Ahmed Essam aa2bc8d05f Fix msvc min/max conflict (hopefully for the last time!) 2020-10-01 19:40:54 +01:00
Ahmed Essam 1fb65b6ea8 Fix msvc warning 2020-10-01 18:35:00 +01:00
Simon Giraudot 4f0648d17b Use Point_2/Point_2 constructor so that it also works with Arr_non_caching_segment_traits 2020-10-01 08:54:47 +02:00
Simon Giraudot 1d3c289481 Fix outdated variable name 2020-09-30 15:41:05 +02:00
Ahmed Essam f2115d534b Fix min/max macro conflict 2020-09-30 10:53:02 +02:00
Jane Tournois 5c8df6672a remove CGAL_CFG_MATCHING_BUG_ variants
the "matching bug" of msvc has been fixed since at least vs 2015
2020-09-25 14:25:14 +02:00
Ahmed Essam b238db17ae Merge remote-tracking branch 'cgal/master' into gsoc2020-aos_demo-theartful 2020-09-24 20:46:06 +02:00
Ahmed Essam 885759ff05 Fix compilation error with msvc2017
Fixes the compilation error in x64_Cygwin-Windows10_MSVC2017-Debug-64bits
platform.
CXXFLAGS=/DWIN32 /D_WINDOWS /W3 /GR /EHsc -D_CRT_SECURE_NO_DEPRECATE
-D_SCL_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS
-D_SCL_SECURE_NO_WARNINGS
-D_SILENCE_CXX17_ADAPTOR_TYPEDEFS_DEPRECATION_WARNING /fp:strict
/fp:except- /wd4503 /bigobj /permissive- /std:c++17 /D_DEBUG /MDd /Ob0
/Od /RTC1
LDFLAGS=/machine:x64 /debug /INCREMENTAL
Curve_renderer_2.h(1753): error C2760: syntax error: unexpected token
'identifier', expected ')'
Produced the error locally and for some reason adding the extra parenthesis
fixed the problem. Most probably a bug with msvc2017 with these flags.
2020-09-23 18:19:24 -07:00
Efi Fogel 92801f4f8f Chenged back size_t to unsigned int (at some point all Multiplicity types should be defined as size_t) 2020-09-23 14:27:53 +03:00
Efi Fogel 3f1647345b Initialized m_is_directed_right in default constructor 2020-09-23 14:27:22 +03:00
Mael Rouxel-Labbé 4694a48913 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-09-22 11:35:25 +02:00
Efi Fogel 70f5d0eede Removed redundant typedefs 2020-09-22 10:08:47 +03:00
Efi Fogel 3600f6ccd5 Updated 2020-09-16 15:32:04 +03:00
Efi Fogel b41988aa70 Merge remote-tracking branch 'cgal/master' into Aos_2-remove_object-efif 2020-09-15 17:18:34 +03:00
Laurent Rineau 6cf203f5ca Merge pull request #4861 from sgiraudot/Arrangement_2-Small_enhancements-GF
Arrangement 2: Small Enhancements
2020-09-11 15:07:50 +02:00
Efi Fogel 7cd3a2663b Updated 2020-09-08 17:46:08 +03:00
Simon Giraudot 2992fcc508 Add CGAL::Single to create range of one isolated element 2020-08-25 12:50:30 +02:00
Simon Giraudot 0678c996e5 Add option to close the curve 2020-08-25 12:38:25 +02:00
Simon Giraudot d09d4079cf Add function to make Curve_2 from range of points 2020-08-25 11:32:46 +02:00
Efi Fogel 23a02ff441 Pacify Windows msvc (definition of casting operator). 2020-08-25 11:48:20 +03:00
Mael Rouxel-Labbé 8682f9bafb Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-08-24 11:45:17 +02:00
Efi Fogel 58fb204e97 Placed back the bbox() function. (Will be deprecated in a separate commit.) 2020-08-24 11:52:27 +03:00
Simon Giraudot 267e7316f1 Fix: compute orientation before checking if segment is vertical 2020-08-24 09:41:43 +02:00
Efi Fogel b4e7a4ad02 Reverted the bbox computation optimization as it turns out it doesn't help 2020-08-22 21:04:40 +03:00
Efi Fogel a857651c21 Optimized the bbox construction in do_bboxes_overlap() 2020-08-20 20:39:50 +03:00
Ahmed Essam 48e0fee7dd Rebase fixes 2020-08-20 19:34:50 +02:00
Ahmed Essam 489499f081 Solve compiler warnings 2020-08-20 19:30:16 +02:00
Ahmed Essam 4e3c64f488 Fix some compiler warnings 2020-08-20 19:30:16 +02:00
Ahmed Essam 4bc9d2bff2 Add missing break 2020-08-20 19:30:16 +02:00
Ahmed Essam 087005d7c0 Fix warnings in algebraic traits 2020-08-20 19:30:16 +02:00
Ahmed Essam 78af28d4c5 Revert all changes outside the demo 2020-08-20 19:30:16 +02:00
Ahmed Essam e1ea14b461 some update 2020-08-20 19:26:10 +02:00
Ahmed Essam 2f0a283139 Use new originator constructor 2020-08-20 19:26:10 +02:00
Ahmed Essam 4ee591f500 Intersection points can be due to 2 or more points
to reproduce this bug, try upper envelope operation on the arrangement
by Jeb
2020-08-20 19:26:10 +02:00
Ahmed Essam 8b78d0e790 Fix bug with self intersecting curves 2020-08-20 19:26:10 +02:00
Ahmed Essam a2bc6227c3 Temporary change to be backward compatible with bezier serialization 2020-08-20 19:23:25 +02:00
Ahmed Essam 94ea08a2c4 Bezier serialization 2020-08-20 19:17:06 +02:00
Ahmed Essam 669b975f60 Unbounded faces, snapping and more! 2020-08-20 19:17:06 +02:00
Ahmed Essam e026e0b435 Revert "Add Approximate_number_type to Arr_circular_arc_traits"
This reverts commit 7db9e267b3d7d11f4372e00b0b4329d4412b5eb4.
2020-08-20 19:17:05 +02:00
Ahmed Essam 6b85115679 Add Approximate_number_type to Arr_circular_arc_traits 2020-08-20 19:17:05 +02:00
Ahmed Essam a19207b957 Clean up and big fixes 2020-08-20 19:17:05 +02:00
Ahmed Essam ac72f408a0 Move EnvelopeCallback class implementation to cpp file 2020-08-20 19:17:05 +02:00
Efi Fogel 9d6d9929ec Cleaned up. Moved some operations from the the curve (Arr_segment_2) to the traits and declared the former deprecated. Optimized further the Intersect_2 functor. 2020-08-20 19:53:52 +03:00
Simon Giraudot 3656be09c6 Only compute line if needed 2020-08-19 16:11:14 +02:00
Sébastien Loriot ae62039df3 remove used variable 2020-08-18 14:10:16 +02:00
Efi Fogel d309bdf2ca Used ..._object() member function to obtain functor objects and cleaned up formatting. 2020-08-18 12:16:27 +03:00
Simon Giraudot 7d23ac99e2 Update internal doc from review 2020-08-17 10:26:08 +02:00
Simon Giraudot 36a210065f Fix for cases where red and blue handles are differently typed 2020-08-17 10:11:28 +02:00
Simon Giraudot 4f99fe893d Use vertex pair iterator in GPS to avoid constructing Segment_2 objects 2020-08-13 15:37:33 +02:00
Simon Giraudot 901f52018c Some fixes + internal doc for indexed sweep 2020-08-13 09:52:47 +02:00
Simon Giraudot b7583f43d5 Add indexed sweep with isolated points 2020-08-13 09:19:50 +02:00
Simon Giraudot 6022a74ac8 Only use indexed sweep for curves with bottom(/top) side NOT contracted 2020-08-13 08:47:33 +02:00
Simon Giraudot acb96cba86 Get rid of index using pointer squatting + before/after functions 2020-08-12 15:56:46 +02:00
Ahmed Essam 3dc2804b9e Move _inc_to_right != cv._inc_to_right assertion to its right location 2020-08-11 13:23:08 +02:00
Ahmed Essam ff93e2b3bd Curve params "s" and "t" are interchangeable with self intersections 2020-08-11 13:18:30 +02:00
Ahmed Essam 6d949cd14f Fix bug with self intersecting bezier curves 2020-08-08 17:29:55 +02:00
Simon Giraudot caf5b31af6 Indexed sweep in overlay (WIP: triggers assertions in some tests) 2020-08-04 15:42:26 +02:00
Efi Fogel 5b6a8e83e3 Updated 2020-08-01 15:23:11 +03:00
Efi Fogel 6642407d60 Merge remote-tracking branch 'cgal/master' into Aos_2-boundary_objects-efic 2020-07-29 18:08:32 +03:00
Efi Fogel f0f0856679 Updated 2020-07-26 00:06:56 +03:00
Mael Rouxel-Labbé 0d66e19361 IO documentation fixes
See @sloriot's review:

https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Polgyon_soup_mesh_IO/2nd_round/Answer_to_review

(+ some commits before and after this one)
2020-07-24 17:06:00 +02:00
Simon Giraudot becb663e39 Use fast pool allocator 2020-07-21 11:46:25 +02:00
Simon Giraudot 94155bd89e Fix assertion with explicit boolean conversion 2020-07-21 11:23:24 +02:00
Simon Giraudot a43b994425 Use specialized do_intersect + early ending 2020-07-21 10:19:06 +02:00
Simon Giraudot 4ee8f532b7 Early intersection ending with bbox 2020-07-21 10:19:06 +02:00
Efi Fogel 11c51142a4 Fixed zone computation 2020-07-21 10:04:04 +03:00
Efi Fogel e00e4adfa8 Cleaned up 2020-07-21 09:59:28 +03:00
Efi Fogel 87a3cf9458 Cleaned up 2020-07-21 09:57:34 +03:00
Efi Fogel b2bda2e603 Cleaned up 2020-07-21 09:56:13 +03:00
Efi Fogel ff20707e2f cleaned up 2020-07-21 09:52:09 +03:00
Efi Fogel 16f6196076 Merge branch 'Aos_2-boundary_objects-efic' of github.com:CGAL/cgal-public-dev into Aos_2-boundary_objects-efic 2020-07-21 09:51:17 +03:00
Efi Fogel 598a988fd5 cleaned up 2020-07-21 09:47:34 +03:00
Efi Fogel 372e838d73 Missing include of CGAL/assertions.h 2020-07-06 11:32:32 +03:00
Laurent Rineau cdfbe3b0df Merge branch 'releases/CGAL-5.0-branch' 2020-07-03 16:21:42 +02:00
Laurent Rineau bf88dfcc80 Merge pull request #4820 from sloriot/Argt-missing_it_cstr
Add constructor from base
2020-07-03 16:20:22 +02:00
Efi Fogel 09ad8ab1dc Replaced legacy CGAL::Object with modern variant 2020-07-02 19:12:43 +03:00
Efi Fogel 2aa0c9cefb Cleaned up 2020-07-02 19:11:30 +03:00
Efi Fogel 7cf9a11936 Cleaned up 2020-07-02 19:11:07 +03:00
Efi Fogel 89e5200b5b Cleaned up 2020-07-02 19:10:56 +03:00
Efi Fogel 5298ff114e Cleaned up 2020-07-02 19:10:29 +03:00
Efi Fogel 3d83f95897 Cleaned up 2020-07-02 19:10:21 +03:00
Efi Fogel 89ad70a2de Cleaned up 2020-07-02 19:10:08 +03:00
Efi Fogel 1b23ac2b08 Cleaned up 2020-07-02 19:10:00 +03:00
Efi Fogel d08f8b4ca1 Cleaned up 2020-07-02 19:09:51 +03:00
Efi Fogel e0c80487a7 Replaced legacy CGAL::Object with modern variant 2020-07-02 14:08:08 +03:00
Efi Fogel d58b971e85 Replaced legacy CGAL::Object with modern varian 2020-06-30 23:21:55 +03:00
Efi Fogel 436ba5fa35 Left over of replacing legacy CGAL::Object with variant 2020-06-30 21:23:16 +03:00
Efi Fogel 3c5552b14a Replaced legacy CGAL::Object with variant in vertical decomposition 2020-06-30 21:22:40 +03:00
Laurent Rineau e439aaf30c Merge pull request #4556 from theartful/arrangments_bugfix
Fix Bezier intersection bug around the boundaries (issue #3381)

# Conflicts:
#	Arrangement_on_surface_2/include/CGAL/Arr_geometry_traits/Bezier_cache.h
2020-06-30 16:39:17 +02:00
Laurent Rineau cba160f7f0 Merge pull request #4556 from theartful/arrangments_bugfix
Fix Bezier intersection bug around the boundaries (issue #3381)
2020-06-30 16:37:01 +02:00
Sébastien Loriot 3a53d241c8 add constructor from base 2020-06-30 09:51:05 +02:00
Mael Rouxel-Labbé 26355e2e32 Uniformize capital / third person usage of \brief 2020-06-25 15:13:47 +02:00
Efi Fogel 33b8d552e7 Fixed a bug of non-linear curves (when make-x-monotone produces more than one item) 2020-06-15 20:12:11 +03:00
Efi Fogel f73d067658 acified clang 2020-06-15 20:11:46 +03:00
Efi Fogel fdffdef85e Introduced Make_x_monotone_2 functor to convert CGAL::Object objects obtained from the circular kernel to variant 2020-06-15 17:21:17 +03:00
Efi Fogel e8f81ff4fc Cleaned up 2020-06-15 17:21:02 +03:00
Efi Fogel 03a2d28026 Further eliminated CGAL::Object 2020-06-14 10:47:45 +03:00
Efi Fogel c92f3b6fcf Cleaned up 2020-06-14 10:46:41 +03:00
Efi Fogel 8d1ff43997 Fixed comment 2020-06-14 10:45:50 +03:00
Efi Fogel 7ad0ffa012 Added missing Multiplicity typedef definition 2020-06-14 10:45:27 +03:00
Efi Fogel ecb632a056 Fixed comment 2020-06-14 00:43:16 +03:00
Efi Fogel 3849f5e154 Further eliminating CGAL::Object 2020-06-14 00:41:25 +03:00
Efi Fogel 40152a2582 Continues to eliminate CGAL::Object 2020-06-13 16:43:09 +03:00
Efi Fogel 708469fb5e MFurther eliminating CGAL::Object 2020-06-12 14:06:58 +03:00
Efi Fogel 0626eb0a2e First stage elliminating CGAL::Object 2020-06-11 12:32:33 +03:00
Laurent Rineau 319383c963 Revert "Merge pull request #4519 from lrineau/Kernel_23-Epeck_objects_in_Compact_container-lrineau_gdamiand"
This reverts commit bcab082f82, reversing
changes made to 2d3e126450.
2020-05-20 09:47:58 +02:00
Laurent Rineau 3d3788925b Merge pull request #4607 from efifogel/Aos_2-intersection-efif
Arrangement_on_surface_2: change intersection return types (from legacy CGAL::Object to variants)

# Conflicts:
#	Installation/CHANGES.md
2020-05-19 10:55:30 +02:00
Sebastien Loriot 5ccfdbe9e4
Merge pull request #4230 from efifogel/Aos_2-small_fixes-efif
Aos 2 small fixes efif
2020-05-05 14:26:20 +02:00
Sebastien Loriot bcab082f82
Merge pull request #4519 from lrineau/Kernel_23-Epeck_objects_in_Compact_container-lrineau_gdamiand
Enable the use of Lazy objects in Compact_container
2020-04-29 13:56:59 +02:00
Efi Fogel 4e19667750 Fixed unused local variable 2020-04-29 12:58:02 +03:00
Sebastien Loriot 0325219ce6
Merge pull request #4671 from maxGimeno/DGAL-Fix_MIN_MAX_issues-maxGimeno
CGAL: Min-max errors on windows
2020-04-27 09:46:04 +02:00
Sebastien Loriot 74d44ff97f
Merge pull request #4672 from maxGimeno/CGAL_Fix_MIN_MAX_5_0-maxGimeno
CGAL: Fixes for min/max 5.0
2020-04-27 09:45:35 +02:00
Sebastien Loriot 1c05c79244
Merge pull request #4673 from maxGimeno/CGAL_Fix_MIN_MAX_4_14-maxGimeno
CGAL: Fixes for min/max 4.14
2020-04-27 09:45:16 +02:00
Sébastien Loriot c5af2b25f3 Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' 2020-04-22 13:27:29 +02:00
Sébastien Loriot 157bdbda08 Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-04-22 13:26:52 +02:00
Sebastien Loriot b02bf1c6e7
Merge pull request #4577 from theartful/bezier_bugfix
Fix bug in point_position in the bezier traits
2020-04-22 13:05:47 +02:00
Efi Fogel 5d37a1bbf8 Initialized some fileds of _Linear_object_cached_2 2020-04-22 00:31:33 +03:00
Efi Fogel 6fcbee1fa9 Removed redundant typedef statements 2020-04-21 17:12:21 +03:00
Maxime Gimeno 5b2d46cfa0 Fixes for min/max 2020-04-21 12:04:45 +02:00
Maxime Gimeno 50766d9d03 Fixes for min/max 2020-04-21 11:52:56 +02:00
Maxime Gimeno e9d41d7b7d Fixes for min/max 2020-04-21 11:38:37 +02:00
Efi Fogel 6eefda4e6d Added missing include <boost/variant.h> 2020-04-06 15:34:28 +03:00
Efi Fogel 4158542c86 Fixed intersection result 2020-04-01 12:31:51 +03:00
Efi Fogel 58276edba3 Cleaned up and Fixed intersection return type 2020-03-31 18:34:28 +03:00
Efi Fogel 523fcfdbc5 Cleaned up 2020-03-31 17:32:38 +03:00
Efi Fogel c1fed0bd0b Cleaned up 2020-03-31 17:30:55 +03:00
Efi Fogel 11059b4f84 Fixed typo 2020-03-29 13:33:08 +03:00
Efi Fogel dc0cab62a4 Fixed Intersect_2 to return optional of variant (instead of CGAL::Object) 2020-03-29 13:31:26 +03:00
Efi Fogel 077829724a Cleaned up; used result_of when computing intersections. 2020-03-29 13:25:18 +03:00
Efi Fogel f5f3440fc0 Used correct result of intersection 2020-03-29 13:02:24 +03:00
Efi Fogel 04adcb982f Cleaned up 2020-03-29 12:34:33 +03:00
Ahmed Essam 30104c6032 Fix bug in matching roots 2020-03-27 08:34:04 +01:00
Sébastien Loriot 97e46accad extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:26:37 +01:00
Sébastien Loriot 34ce87be56 Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:26:15 +01:00
Sébastien Loriot 180c06146f Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:10:41 +01:00
Sébastien Loriot 8b153fb495 Merge branch 'cgal/releases/CGAL-5.0-branch'
whitespace+tab removal, merged with option -Xignore-space-change
2020-03-26 14:22:32 +01:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sébastien Loriot 0a46621dc6 Merge branch 'cgal/releases/CGAL-4.14-branch'
whitespace+tab removal, merged with option -Xignore-all-space
2020-03-26 13:28:46 +01:00
Sébastien Loriot 590612a563 run the script to remove tabs and trailing whitespaces 2020-03-26 13:25:16 +01:00
Sébastien Loriot 2419170514 be resilient to the absence of trailing whitespace in input 2020-03-26 13:24:27 +01:00
Ahmed Essam a7eb7cfe04 Fix bug in point_position in the brazier traits 2020-03-12 23:14:42 +02:00
Guillaume Damiand 5c9bb6f016 Rename PTR into PTR.p following the modifs in Handle.h 2020-02-14 11:30:56 +01:00
Efi Fogel c3c15948e6 Removed wrong comment 2019-12-18 09:06:18 +02:00
Efi Fogel b0c3c8492f Fixed typo 2019-12-18 09:05:45 +02:00
Efi Fogel 9d2ef0ed9a Commented out print out 2019-12-17 13:26:20 +02:00
Efi Fogel f25e420e65 Moved in_between complete implementation to the adapter class 2019-12-17 13:24:37 +02:00
Efi Fogel bac045d269 Used c++11 features to remove clutter 2019-12-17 13:24:06 +02:00
Efi Fogel 966bd50f9d Used c++11 features to remove clutter 2019-12-14 19:48:11 +02:00
Efi Fogel 33ffd8a0e0 Fixed is_in_x_range_2---handled the case where one of the curves is on the left or right boundary 2019-12-14 19:46:44 +02:00
Efi Fogel 70f7cb84b0 Used auto ro remove clutter 2019-12-14 19:45:01 +02:00
Efi Fogel 19f19f7dcb Cleaned up; added cprecondition 2019-12-14 19:44:30 +02:00
Efi Fogel d91194f469 Fixed documentation of Arrangement_2 (exploited inheritance). 2019-12-02 21:22:25 +02:00
Efi Fogel d1b33ff238 Cleaned up 2019-12-02 13:37:01 +02:00
Efi Fogel a47858ee25 Cleaned up 2019-12-02 13:36:52 +02:00
Efi Fogel 5408fdb115 Fixed is_betweein_imp() and do_overlap_impl() 2019-12-02 02:16:27 +02:00
Sébastien Loriot c662a59645 avoid a construction
this helps the sweep working with EPICK in case no
new construction are needed
2019-11-26 17:00:59 +01:00
Efi Fogel 2a3fbc0ee8 Merge remote-tracking branch 'cgal/master' into Aos_2-boundary_objects-efic 2019-11-19 09:47:44 +02:00
Laurent Rineau 092cf8e2c5 Merge pull request #4284 from sloriot/Sweep_surface_2-derecursive_overlaps_5.0
Derecursification of overlaps detection on the right of event - [5.X]
2019-10-25 16:26:17 +02:00
Sébastien Loriot 47c092557f Merge remote-tracking branch 'sloriot/Sweep_surface_2-derecursive_overlaps' into HEAD 2019-10-21 13:04:25 +02:00
Sébastien Loriot 52164b1fba First pass on removing license notice in header for LGPL files 2019-10-19 15:40:30 +02:00
Sébastien Loriot 254d60f642 First pass on removing license notice in header for GPL files 2019-10-19 15:23:19 +02:00
Sébastien Loriot 7356421d80 introduce Commercial license SPDX tag 2019-10-19 12:15:19 +02:00