Commit Graph

120 Commits

Author SHA1 Message Date
Sébastien Loriot ecd818a3a7 remove cpp11 condition 2019-03-29 10:41:50 +01:00
Laurent Rineau 49732a118c Merge remote-tracking branch 'cgal/master' into Ipelets-Fix_warning-GF 2019-02-13 16:27:54 +01:00
Laurent Rineau d97726ffe4 Fix a warning [-Wmaybe-uninitialized]
```
In file included from /mnt/testsuite/include/CGAL/Cartesian/Weighted_point_2.h:29,
                 from /mnt/testsuite/include/CGAL/Cartesian/Cartesian_base.h:34,
                 from /mnt/testsuite/include/CGAL/Cartesian.h:29,
                 from /home/cgal_tester/build/src/cmake/platforms/Fedora-rawhide-Release/test/Partition_2/approx_convex_partition_2_test_C.cpp:31:
/mnt/testsuite/include/CGAL/Handle_for.h: In function ‘bool CGAL::partition_appx_cvx_cuts_nonconvex_angle(Edge_circulator, Circulator, const Triangulation&, const Traits&) [with Edge_circulator = CGAL::Triangulation_ds_edge_circulator_2<CGAL::Triangulation_data_structure_2<CGAL::Triangulation_vertex_base_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Triangulation_ds_vertex_base_2<void> >, CGAL::Constrained_triangulation_face_base_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Triangulation_face_base_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Triangulation_ds_face_base_2<void> > > > >; Circulator = CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>; Triangulation = CGAL::Constrained_triangulation_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Default, CGAL::Default>; Traits = CGAL::Partition_traits_2<CGAL::Cartesian<double> >]’:
/mnt/testsuite/include/CGAL/Handle_for.h:313:12: warning: ‘*((void*)& next_ccw_pt_ref +40)’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  313 |     return *(h.Ptr());
In file included from /mnt/testsuite/include/CGAL/partition_2.h:30,
                 from /home/cgal_tester/build/src/cmake/platforms/Fedora-rawhide-Release/test/Partition_2/approx_convex_partition_2_test_C.cpp:33:
/mnt/testsuite/include/CGAL/Partition_2/partition_approx_convex_2.h:91:34: note: ‘*((void*)& next_ccw_pt_ref +40)’ was declared here
   91 |    typename Triangulation::Point next_ccw_pt_ref, prev_ccw_pt_ref;
      |                                  ^~~~~~~~~~~~~~~
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.14-Ic-122/Partition_2/TestReport_gimeno_Fedora-rawhide-Release.gz
2019-02-13 16:03:20 +01:00
Laurent Rineau 896d5a7bd9 Quiet a warning [-Wmaybe-uninitialized]
```
[ 50%] Building CXX object CMakeFiles/test_exact_offset.dir/test_exact_offset.cpp.o
/usr/local/bin/c++  -DCGAL_TEST_SUITE=1 -DCGAL_USE_CORE=1 -DCGAL_USE_GMP -DCGAL_USE_MPFR -isystem /usr/include/x86_64-linux-gnu -I/home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2 -I/home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/include -I/mnt/testsuite/include  -DDONT_USE_BOOST_PROGRAM_OPTIONS -Wall -Wextra -O3 -DCGAL_NDEBUG -frounding-math   -Wall -frounding-math -o CMakeFiles/test_exact_offset.dir/test_exact_offset.cpp.o -c /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2/test_exact_offset.cpp
In file included from /mnt/testsuite/include/CGAL/Cartesian/Weighted_point_2.h:29,
                 from /mnt/testsuite/include/CGAL/Cartesian/Cartesian_base.h:34,
                 from /mnt/testsuite/include/CGAL/Cartesian.h:29,
                 from /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2/test_exact_offset.cpp:16:
/mnt/testsuite/include/CGAL/Handle_for.h: In function 'OutputIterator CGAL::partition_approx_convex_2(InputIterator, InputIterator, OutputIterator, const Traits&) [with InputIterator = __gnu_cxx::__normal_iterator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >*, std::vector<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >, std::allocator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> > > > >; Traits = CGAL::Partition_traits_2<Rat_kernel>; OutputIterator = std::back_insert_iterator<std::__cxx11::list<CGAL::Polygon_2<Rat_kernel, std::__cxx11::list<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >, std::allocator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> > > > >, std::allocator<CGAL::Polygon_2<Rat_kernel, std::__cxx11::list<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >, std::allocator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> > > > > > > >]':
/mnt/testsuite/include/CGAL/Handle_for.h:313:12: warning: '*((void*)& target +40)' may be used uninitialized in this function [-Wmaybe-uninitialized]
  313 |     return *(h.Ptr());
In file included from /mnt/testsuite/include/CGAL/partition_2.h:30,
                 from /mnt/testsuite/include/CGAL/Minkowski_sum_2/Decomposition_strategy_adapter.h:31,
                 from /mnt/testsuite/include/CGAL/Polygon_convex_decomposition_2.h:27,
                 from /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2/test_exact_offset.cpp:22:
/mnt/testsuite/include/CGAL/Partition_2/partition_approx_convex_2.h:173:23: note: '*((void*)& target +40)' was declared here
  173 |    Circulator source, target, before_s, after_s;
      |                       ^~~~~~
```

It seems sufficient to declare the variables at a smaller
scope. Strange...
2019-02-11 14:50:50 +01:00
Laurent Rineau afc3de2894
Merge branch 'master' into Stream_support-Color-GF 2019-01-23 09:37:08 +01:00
Andreas Fabri 561d689142 Fix Partition_2 2019-01-18 16:07:32 +01:00
Sébastien Loriot 0685423ae8 update from cgal/master 2018-11-02 11:32:31 +01:00
Andreas Fabri b33ab791e1 Disable a warning. Fix an allocator call 2018-05-15 15:37:51 +02:00
Andreas Fabri 955b6a89e6 fix includes 2018-05-04 09:00:11 +02:00
Andreas Fabri 97b5c37b6e Fix includes 2018-05-04 09:00:11 +02:00
Laurent Rineau f2391a30a5 Merge pull request #2562 from afabri/Filtered_kernel-Do_intersect_2-GF
Add Static Filters for the Exact Construction Kernel
2017-12-19 16:29:53 +01:00
Sébastien Loriot ee57fc2d6c add SPDX identifier for files under the GPL-3+ license 2017-11-12 10:17:51 +01:00
Laurent Rineau f175ed6702 Fix a runtime error
The adaptation of that part of the code was plain wrong.
2017-10-31 10:25:36 +01:00
Laurent Rineau 2b7bd7c4b8 Fix compilation errors 2017-10-30 17:24:51 +01:00
Andreas Fabri a2fc6e1830 Make Partition_2 work with g++ 2017-10-30 12:55:21 +01:00
Andreas Fabri 1d332f5de3 Downcast to Point_2 in order that functions match 2017-10-30 12:28:57 +01:00
Mael Rouxel-Labbé 54be2d8206 Add Construct_point_2 to Triangulation_indirect_traits_2
Needed to satisfy the TriangulationTraits_2 concept
2017-06-28 10:15:30 +02:00
Sébastien Loriot 50510c05ea add include directive for license of all GPL header files
done using:
ack-grep "^GPL" */package_info/*/license.txt -l | awk -F "/" '{print $1}' > /tmp/gpl_packages
for i in `cat /tmp/gpl_packages | \
          grep -v Operations_on_polyhedra | \
          grep -v Algebraic_kernel_for_circles | \
          grep -v Algebraic_kernel_for_spheres | \
          grep -v Polyhedron_IO`;
do
  echo $i
  python Scripts/developer_scripts/add_license_in_pkg_header.py $i
done
python Scripts/developer_scripts/add_license_in_pkg_header.py Operations_on_polyhedra Polygon_mesh_processing
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_circles Circular_kernel_2
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_spheres Circular_kernel_3
python Scripts/developer_scripts/add_license_in_pkg_header.py Polyhedron_IO Polyhedron
2017-01-19 15:20:25 +01:00
Andreas Fabri 6d25c01c5c push warning in Partition_2 2016-01-28 16:17:51 +01:00
Sébastien Loriot 69eff06691 add a default constructor to Primitive_vertex to make it work with Lazy
also add a test showing the issue
2014-01-13 19:12:20 +01:00
Andreas Fabri 6c547e5663 Mainly added includes 2013-09-13 22:24:30 +02:00
Philipp Möller 465c5b265a Shuffle two undocumented headers backwards.
Also change the 2 places they were used in.
2012-11-17 02:16:32 +01:00
Laurent Rineau db194534c7 First big patch to fix -Wunused-local-typedefs
-Wunused-local-typedefs is a new warning flag of gcc-4.7, and it will enabled
 by -Wall since gcc-4.8 (not yet released).

The fix is a big set of removals of unused typedefs (or comments, or moves,
depending on the context).
2012-08-01 13:29:16 +00:00
Laurent Rineau 8f59fd9592 Turn QPL into LGPLv3+ 2012-01-13 16:33:35 +00:00
Andreas Fabri 6bd785124a Add static_cast for size_t to unsigned int as the package will never be able to solve huge problems 2010-09-23 16:35:43 +00:00
Laurent Rineau 8679a3911e Merged revisions 56835,56864-56870,56876,56895-56897 via svnmerge from
svn+ssh://lrineau@scm.gforge.inria.fr/svn/cgal/branches/CGAL-3.6-branch

........
  r56835 | lrineau | 2010-06-17 12:56:52 +0200 (Thu, 17 Jun 2010) | 6 lines
  
  Remove the constructor Gmpfr(long double) on Microsoft Visual C++. A big
  comment in the source code explains why.
  
  The testsuite will check that the construction of Gmpfr from a long double
  on MSVC still works and produces the right Gmpfr.
........
  r56864 | afabri | 2010-06-18 11:04:47 +0200 (Fri, 18 Jun 2010) | 1 line
  
  Use tie from boost::
........
  r56865 | afabri | 2010-06-18 11:11:49 +0200 (Fri, 18 Jun 2010) | 1 line
  
  Use bind from boost::
........
  r56866 | afabri | 2010-06-18 11:38:50 +0200 (Fri, 18 Jun 2010) | 1 line
  
  Use bind from boost:: (detected in Mesh_3 VC10 testsuite)
........
  r56867 | lrineau | 2010-06-18 11:39:24 +0200 (Fri, 18 Jun 2010) | 3 lines
  
  cmake-2.8.2rc2 is out.
  /bigobj is necessary
........
  r56868 | afabri | 2010-06-18 11:52:37 +0200 (Fri, 18 Jun 2010) | 1 line
  
  Add #include <fstream>
........
  r56869 | afabri | 2010-06-18 11:55:33 +0200 (Fri, 18 Jun 2010) | 1 line
  
  Shorten filename as with path it exceeds easily 256 letters which poor Visual C++ can't handle
........
  r56870 | afabri | 2010-06-18 12:24:30 +0200 (Fri, 18 Jun 2010) | 1 line
  
  Use tie from boost::
........
  r56876 | lrineau | 2010-06-18 16:40:36 +0200 (Fri, 18 Jun 2010) | 3 lines
  
  New try to fix the issue of Gmpfr(long double) with MSVC and libmpfr-1.dll
  compiled by Mingw.
........
  r56895 | lrineau | 2010-06-20 23:16:40 +0200 (Sun, 20 Jun 2010) | 3 lines
  
  Using boost::bind is not sufficient" "bind" without qualifier was
  ambiguous, according to MSVC2010, with std::bind (from C++0x).
........
  r56896 | lrineau | 2010-06-20 23:18:29 +0200 (Sun, 20 Jun 2010) | 3 lines
  
  Qualify "bind" with "boost::", to avoid the ambiguity (according to
  MSVC2010), with std::bind (C++0x).
........
  r56897 | lrineau | 2010-06-20 23:19:17 +0200 (Sun, 20 Jun 2010) | 2 lines
  
  Stupid typo!
........
2010-06-20 21:48:20 +00:00
Andreas Fabri a17043ab9a Add this and using for ansi compliance 2010-05-11 07:12:41 +00:00
Andreas Fabri 41f63c8d31 Add 'this->' for ansi-compliance 2010-05-10 07:25:16 +00:00
Sylvain Pion 85dc12f2a7 Remove empty lines at beginning and end of files
(apply Scripts/developer_scripts/remove_empty_lines.pl).
2010-02-01 12:55:28 +00:00
Stéphane Tayeb 8dceee4164 Add include<CGAL/assertions.h> in *_assertion files. 2009-10-07 13:16:13 +00:00
Stéphane Tayeb 770492c1c7 Use new version of script create_assertions.sh to generate *_assertions.h files.
Diffs are:
 * #undef added
 * in old files, (void)0 is replaced by static_cast<void>(0)
 * in old files, lines as "#  define CGAL_xxx_assertion 1" are added
 * in point_set_processing_assertions.h, surface_mesh_parameterization_assertions.h, surface_reconstruction_points_assertions.h, "|| defined(CGAL_NDEBUG)" is replaced by "|| defined (NDEBUG)"
 * protective macros (if any) are removed
 * included files if any (<CGAL/assertions.h>, <CGAL/trace.h>) are removed
2009-10-07 07:49:44 +00:00
Sylvain Pion 8573fe26ce Rename CGALi to internal. 2009-08-24 17:10:04 +00:00
Efi Fogel 4fb38dd560 removed redundant test (collinear_are_ordered_along_line()), and used generic code (orientation_2_object()) instead of global function (collinear()) 2009-05-24 14:30:10 +00:00
Efi Fogel 16285c57a5 replaced Polygon_2::Vertex_iterator with Polygon_2::Vertex_const_iterator. (The former is not even in the concept.) 2009-05-24 14:16:41 +00:00
Ophir Setter e1453b6fb9 using *_object() to construct functors 2009-02-15 15:07:03 +00:00
Andreas Fabri 64181a9d1c No need to use the CGAL vector 2008-10-01 19:40:41 +00:00
Sylvain Pion 02c88564aa Use Boost.Bind instead of CGAL/functional.h . 2008-07-23 07:17:34 +00:00
Sylvain Pion 2eb0d8f9e9 certainly() -> possibly(). 2008-07-14 11:16:41 +00:00
Sylvain Pion 9d7a609ff2 Make assertions trigger an error only for *certain* conditions (using CGAL::certainly()).
This is useful for interval arithmetic code.
(replay of r44002 with the header order hopefully fixed)
2008-07-10 21:49:17 +00:00
Sylvain Pion 2b4ebf01f7 Undo r44002 as it's buggy 2008-07-06 20:47:29 +00:00
Sylvain Pion 514a17ad4f Improve the interaction of assertions and interval computations.
Things like "CGAL_assertion(denominator != 0)" produced assertion failures for no gain.
So now, the assertion is triggered only if the condition is certain, using CGAL::certainly().
That is, change the following in all assertion files :
  ((EX)?(static_cast<void>(0)): ::CGAL::assertion_fail( # EX , __FILE__, __LINE__))
to :
  (CGAL::certainly(EX)?(static_cast<void>(0)): ::CGAL::assertion_fail( # EX , __FILE__, __LINE__))
2008-07-06 17:05:47 +00:00
Sylvain Pion 4d1b8d63e3 Remove workarounds and support for the BORLAND compiler. 2008-01-20 20:24:20 +00:00
Sylvain Pion b24108f5fd Remove #include <cassert> from everywhere under include/CGAL/.
CGAL code has to use CGAL assertions instead.
2008-01-20 18:47:19 +00:00
Sylvain Pion 5c551050a5 Remove obsolete VC++ 6 specific code. 2008-01-20 15:27:47 +00:00
Sylvain Pion cfa600f93e Fix previously erronously removed closing curly brace... 2008-01-03 22:01:37 +00:00
Sylvain Pion 284cfd9468 More removal of SUNPRO+RW's STL obsolete workarounds:
CGAL_CFG_RWSTD_NO_MEMBER_TEMPLATES
2008-01-03 15:19:39 +00:00
Sylvain Pion 88ed563f44 Remove some workarounds for SunPRO + RW's STL:
CGAL_CFG_MISSING_TEMPLATE_VECTOR_CONSTRUCTORS_BUG
CGAL_CFG_RWSTD_NO_MEMBER_TEMPLATES  (partially so far)
CGAL_make_vector
CGAL_make_list
2008-01-03 14:50:13 +00:00
Sylvain Pion dc36f95429 Remove warning for empty body of for loop 2007-12-30 15:11:49 +00:00
Sylvain Pion d49e006c53 Remove default argument "0" to calls to assertion_fail() et al,
as the default is now the empty string "".
It should fix the problem that we have lost the assertion messages
(seeing "what():  basic_string::_S_construct NULL not valid" instead),
for packages that use package-specific assertion macros.
2007-12-21 21:58:27 +00:00
Marc Glisse a9a80e947e Fix RWSTD workaround. 2007-08-24 14:29:39 +00:00
Camille Wormser 5a8c4f8280 Adds the Equal_2 predicate to the Partition_2 traits
to fulfill the new requirements of is_convex_2
2007-06-28 08:46:53 +00:00
Efi Fogel 83f773cf28 cleanup - added parentheses to pacify some come compiler 2007-04-07 09:39:45 +00:00
Andreas Fabri 5639250769 initialization must be in the nested namespace 2007-04-03 10:28:28 +00:00
Fernando Cacciola 9905e5ab77 Fixed singular iterator issue using new safe circulator 2007-04-02 19:10:52 +00:00
Andreas Fabri e52bf7fec5 fixed template parameter for SunPro 2007-03-30 15:21:02 +00:00
Andreas Fabri f28d552ad8 copy constructor without deep copy but safe initialization 2007-03-30 11:05:27 +00:00
Fernando Cacciola ec9a2507a2 Fixed singular iterator in Partition_vertex 2007-03-21 14:51:42 +00:00
Sylvain Pion d7a6a0f560 Add missing CGAL:: (spotted by g++ 4.3) 2007-03-01 10:44:59 +00:00
Andreas Fabri 72f5159ec9 Put Edge_list in a subnamespace as it collides with Apollonius_graph's Edge_list 2007-02-23 14:35:16 +00:00
Sylvain Pion f672e83fd5 macros must be prefixed by CGAL_ 2007-02-15 21:29:22 +00:00
Sylvain Pion 26e1954d53 remove g++ 4.3 warning 2007-02-11 22:44:29 +00:00
Marc Glisse 4d7829ad71 can't do: typedef A<B> A
instead: typedef C::A<B> A
2007-02-09 19:14:20 +00:00
Fernando Cacciola e6ddc1f499 VC8 STL Fixes 2007-01-15 14:08:48 +00:00
Ron Wein 4774049577 Added this-> before inherited member-functions. 2006-08-21 06:40:13 +00:00
Ron Wein 3cea9dd951 Fixed a renaming problem. 2006-06-04 15:21:22 +00:00
Ron Wein 3d2ed6cbb4 Changed the *.C files to *_impl.h files. Also moved all non-interface include
files under the folder Partition_2.
2006-05-29 08:30:22 +00:00
Sylvain Pion 44bec1b413 - Flatten code structure to remove warning. 2006-03-27 09:13:37 +00:00
Laurent Saboret db6a8f948c Change CVS keywords to SVN style 2006-02-16 14:30:13 +00:00
Laurent Saboret 1aad55d4cb Change CVS keywords to SVN style 2006-02-14 10:08:15 +00:00
Laurent Saboret 7ca4a37690 Move packages to trunk root 2006-02-14 08:58:18 +00:00