Commit Graph

6554 Commits

Author SHA1 Message Date
Léo Valque c41a0c7b9f correct Indexes_range constructor 2025-04-29 15:04:55 +02:00
Léo Valque ba2dbce574 add internal in copy protection macro of triangle_soup_snap_rounding 2025-04-29 15:04:55 +02:00
Léo Valque f0bdb950f2 avoid copy in indexes_range constructor 2025-04-29 15:04:55 +02:00
Léo Valque 89c559f088 simplify constexpr test of NT is a fraction 2025-04-29 15:04:55 +02:00
Léo Valque a1bc4c474a avoid copy of the input in double_ceil 2025-04-29 15:04:55 +02:00
lvalque fbbd635b6a Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-29 14:51:22 +02:00
lvalque ccde78e64e Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-29 14:50:38 +02:00
lvalque 9a04f2dee4 Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-29 14:49:35 +02:00
Léo Valque 9c42d3c7de solved conflict on the documentation of autorefinement 2025-04-29 14:17:56 +02:00
lvalque fdcd4b6838 Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/autorefinement.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-29 14:14:19 +02:00
lvalque 2d96e2af23 Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-29 14:11:58 +02:00
lvalque 61295296fd Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/autorefinement.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-29 14:11:00 +02:00
lvalque 54bb86af41 Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/autorefinement.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-29 14:08:39 +02:00
lvalque 7868d68902 Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/autorefinement.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-29 14:01:36 +02:00
lvalque f39de8cb66 Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/autorefinement.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-29 14:00:42 +02:00
Léo Valque 54b27f8d90 Delete unused includes and solve a compilation error on some testing 2025-04-29 10:17:00 +02:00
Léo Valque cdfd8de6a5 reduce running time of test_snap_rounding, add a full test version 2025-04-28 18:34:09 +02:00
Léo Valque e0cea67e6c modified example of cmd 2025-04-28 16:41:21 +02:00
Léo Valque 13c21b6cb6 move experiments with rotated cubes in benchmark 2025-04-28 16:40:43 +02:00
Léo Valque d9e53aa232 some cleaning 2025-04-28 14:36:02 +02:00
Léo Valque de0c054c27 add specialization of repair_triangle_soup for indexes_range of array 2025-04-28 14:21:27 +02:00
Léo Valque 4aa96bee99 less verbose test and add another test file 2025-04-28 12:00:05 +02:00
Léo Valque c4b1667b13 simplify the example code of snap_rounding 2025-04-28 11:51:19 +02:00
Léo Valque f03faa7298 Solve mistake in test_snap_rounding.cmd 2025-04-25 17:35:04 +02:00
Léo Valque dd63fd28ca update cmakelist to compile examples with rotated cubes 2025-04-25 17:34:15 +02:00
Léo Valque d37fcb16f6 Test for snap rounding 2025-04-25 17:33:23 +02:00
Léo Valque 32075dbdba add data for snap rounding test 2025-04-25 17:32:53 +02:00
Léo Valque b926bec8fa remove visitor of example snap_polygon_soup 2025-04-25 17:23:01 +02:00
Léo Valque 94eb667a9a Experiment with iterative rotated along all axis cubes 2025-04-25 17:21:07 +02:00
Léo Valque e2a1c276fc Experiment with iterative rotated around x cubes 2025-04-25 17:20:17 +02:00
albert-github 136a63ddf3 Spelling correction.
Spelling correction.
(Entire documentation here looks a bit incomplete seen the words `TODO`)
2025-04-25 11:30:19 +02:00
Sébastien Loriot cb747e8201 Merge pull request #8721 from sloriot/PMP-new_clip
Add refine_with_plane and new fast clip method
2025-04-24 20:43:26 +02:00
Sébastien Loriot ce2c04600e fix default value (doc bug) 2025-04-23 13:19:59 +02:00
Sébastien Loriot f975f7e4e0 Merge remote-tracking branch 'cgal/6.0.x-branch' into master 2025-04-16 18:53:38 +02:00
Sébastien Loriot 6a56496c84 Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch 2025-04-16 18:51:44 +02:00
Sebastien Loriot 820d4decda
Fix for foldovers so that they are not considered as coplanar (#8734)
It is still not clear to me if we want to support those configurations
as they are self-intersections.
2025-04-16 18:49:11 +02:00
Sébastien Loriot c5c535e796 fix warning 2025-04-16 18:43:07 +02:00
Sébastien Loriot d2c07e03ae fix warning 2025-04-16 18:39:45 +02:00
Sébastien Loriot 1211a5ee22 fix visitor call in clip + add tests 2025-04-15 09:52:07 +02:00
Jane Tournois a52afd8800 setting status of edges that will disappear is cheaper than checking status 2025-04-14 11:30:44 +02:00
Jane Tournois 5b3356dbc6 fix halfedge status for opposite edges when removing border degenerate faces 2025-04-14 11:14:49 +02:00
Sébastien Loriot dc024f7e03 add backward compatible visitor calls 2025-04-13 19:26:20 +02:00
Sébastien Loriot 6d1c2da4c8 update call 2025-04-11 16:35:20 +02:00
Sébastien Loriot 6727894231 restrict shared vertices on the boundary 2025-04-11 14:30:52 +02:00
Andreas Fabri eeb4decd2a Use named parameter helper 2025-04-11 10:46:23 +02:00
Sébastien Loriot c5ab9f9adc Merge remote-tracking branch 'cgal/6.0.x-branch' into cgal/master 2025-04-10 18:19:14 +02:00
Sebastien Loriot b33204d5f2
Spatial_search: Duplicate point handling (#8705)
## Summary of Changes

stop splitting nodes if the contained points are only duplicates

## Release Management

* Affected package(s): dD Spatial Searching
2025-04-10 18:08:30 +02:00
Léo Valque 09f7df8127 add missing reserve for the visitor 2025-04-08 10:53:03 +02:00
Léo Valque cb7bc4f64d use macro to define snap version 2025-04-08 10:53:03 +02:00
lvalque 26de563455 Update Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-08 10:52:18 +02:00
lvalque f588a1506b Update Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-08 10:52:05 +02:00
lvalque 2cf7cef912 Update Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPAutorefinementVisitor.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-04-08 10:39:53 +02:00
albert-github c6e12be212 Spelling corrections
Spelling corrections
2025-04-04 09:48:20 +02:00
Sébastien Loriot cc77715588 Merge pull request #6849 from JulyCode/gsoc2022-isosurface
Isosurfacing_3 (new package)
2025-04-03 21:41:22 +02:00
Léo Valque 3cdcc73201 clone test_autorefinement.cmd to test_snap_rounding.cpp to test snap_rounding 2025-04-03 19:32:13 +02:00
Léo Valque 9055d56e1f use the new internal function of the visitor of autorefinement for the wrapp_visitor of snap_rounding 2025-04-03 18:40:51 +02:00
Sébastien Loriot 7ff41a8950 Merge pull request #7837 from hoskillua/gsoc2023
GSoC2023 - ACVD for Simplification & Remeshing
2025-04-03 18:00:57 +02:00
Mael Rouxel-Labbé e001c7ce53 Misc minor doc changes 2025-04-03 17:08:26 +02:00
Mael Rouxel-Labbé 29505552ee Regroup related named parameters 2025-04-03 16:55:10 +02:00
Sébastien Loriot b6719fc3be Merge remote-tracking branch 'cgal/6.0.x-branch' into cgal/master 2025-04-03 16:09:51 +02:00
Sébastien Loriot f516c12c5b Merge remote-tracking branch 'cgal/5.6.x-branch' into 6.0.x-branch 2025-04-03 16:09:15 +02:00
Sebastien Loriot c5a809ad30
Spelling correction (#8813)
Spelling correction
2025-04-03 16:05:14 +02:00
Léo Valque a28b294f08 add internal_new_subtriangle to Visistor of autorefinement 2025-04-03 15:14:48 +02:00
Léo Valque a2a76cf874 add zhou and naive version 2025-04-03 14:31:04 +02:00
Léo Valque 80265d0e54 factorize snap_polygon_soup 2025-04-03 11:42:31 +02:00
Léo Valque d48a003069 Solve bug with macro that skip repair_polygon_soup 2025-04-03 10:26:22 +02:00
Sébastien Loriot 60b4b19ba4 add more potentially missing include directives 2025-04-02 09:10:51 +02:00
Sébastien Loriot 25f7014350 in some case with needle, some non-manifold faces can be created even with a decent nb of points 2025-04-01 14:42:46 +02:00
Sébastien Loriot 9ff2696011 split at the midpoint to avoid patterns leading to infinite loop 2025-03-31 20:27:27 +02:00
Sébastien Loriot 9c6452dfaf do not take references to points stored in an internal vector that could be resized!
also fix debug function
2025-03-31 17:41:13 +02:00
Sébastien Loriot 5ed3b0d266 Merge remote-tracking branch 'cgal/6.0.x-branch' in master 2025-03-31 15:32:56 +02:00
Sébastien Loriot a838073ec7 Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch 2025-03-31 15:31:19 +02:00
Sebastien Loriot bcaeb64f54
Warning / compilation fixes for 5.6.x (#8798)
## Summary of Changes

Fixes warnings/errors. Quite a few are just cherry picking fixes that
were done in master.

## Release Management

* Affected package(s): Various
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2025-03-31 10:18:14 +02:00
Sébastien Loriot 9285e5c230 add empty line 2025-03-31 09:01:38 +02:00
Mael Rouxel-Labbé e38e29f279 dont > don't 2025-03-28 20:52:22 +01:00
Mael Rouxel-Labbé 7970fb99e7 later > latter 2025-03-28 20:41:37 +01:00
Mael Rouxel-Labbé e5dce8d04b More ouput > output 2025-03-28 20:37:48 +01:00
Sébastien Loriot 2a25a6080e use exception 2025-03-27 18:51:01 +01:00
Sébastien Loriot 0a462f3b90 address more review points 2025-03-27 18:15:51 +01:00
Sébastien Loriot e3b813389d rename 2025-03-27 16:11:18 +01:00
Sébastien Loriot b99c75acaf rename function 2025-03-27 14:45:11 +01:00
Sébastien Loriot 0e8bfaacc3 take review into account 2025-03-27 14:33:23 +01:00
Sébastien Loriot fc3299462d improve description and update function name 2025-03-27 13:50:31 +01:00
Sébastien Loriot b6ed04c883 hide concurrency flag 2025-03-26 09:42:26 +01:00
Sébastien Loriot 84ee1f4f13 hide visitor and special traits in the doc 2025-03-26 00:11:26 +01:00
Sébastien Loriot 86bf5305c8 add a way to collect input coplanar faces after corefinement 2025-03-25 23:47:51 +01:00
Sébastien Loriot 546f823b48 replace split with plane with new implementation based on clip_with_plane 2025-03-25 22:25:42 +01:00
Sébastien Loriot 15da6dab19 replace clip with plane with new implementation based on clip_with_plane 2025-03-25 21:41:53 +01:00
Sébastien Loriot 9a4809e8d3 wording 2025-03-25 18:08:16 +01:00
Mael Rouxel-Labbé 691fd789f9 Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2025-03-24 21:34:55 +01:00
Mael Rouxel-Labbé ad7f8d3041 Remove unused variables 2025-03-23 23:54:35 +01:00
albert-github 009a7963a8 Spelling correction
Spelling correction
2025-03-23 23:47:04 +01:00
Andreas Fabri dd99f3d526 PMP: Initialize to avoid warning 2025-03-23 23:46:50 +01:00
Sébastien Loriot 8abe5b0c23 make it work with Polyhedron 2025-03-19 19:47:08 +01:00
Sébastien Loriot 2e070b304a qem required Eigen 2025-03-19 16:50:52 +01:00
Sébastien Loriot 113079a8f8 add test 2025-03-19 16:45:41 +01:00
Léo Valque fddc0aa400 Change name of internal functions 2025-03-19 11:35:42 +01:00
Léo Valque 32f07e7d7a Move the mutex inside the class Indexes_range who using it 2025-03-19 11:12:13 +01:00
Léo Valque 0009f99680 Debug the visitor of triangle_soup_snap_rounding 2025-03-19 09:52:54 +01:00
Léo Valque 3a0c0980ee add delete_triangle function to the visitor of test_autorefinement 2025-03-18 15:50:16 +01:00
lvalque cc593c35d8 Merge branch 'CGAL:master' into PMP_triangle_soup_rounding-GF 2025-03-18 15:47:50 +01:00
Mael Rouxel-Labbé d56fe72d33 Avoid some copies in loop iterating over maps 2025-03-18 09:33:46 +01:00
lvalque 26debef54a Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/autorefinement.h
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2025-03-18 09:03:20 +01:00
Mael Rouxel-Labbé 1c3ecfa2dd Update API from linear_subdivision to Loop/CatmullClark + NP 2025-03-17 17:14:51 +01:00
Léo Valque aa765c2332 Add variant where cluster of points are round to the closest of them to the voxel center instead of the voxel center 2025-03-14 13:58:45 +01:00
Léo Valque 5404b37aa2 correct typo in function name 2025-03-13 19:04:13 +01:00
Léo Valque ebbd529ef6 Modify soup_triangles_snap_rounding to support a visitor 2025-03-13 18:57:12 +01:00
Sébastien Loriot 1860c08586 address more review points 2025-03-04 13:51:06 +01:00
Léo Valque 765aa430a2 Fix warnings and compile error 2025-03-04 11:41:29 +01:00
Sébastien Loriot dbee57b896 protect macro 2025-03-04 10:01:46 +01:00
Sébastien Loriot d4fa45f376 add test from the issue 2025-03-03 20:43:54 +01:00
Sébastien Loriot 0b55dc477d look for a feature edge around the vertex 2025-03-03 20:37:08 +01:00
Léo Valque 4200d928ff Reduce default number of iterations 2025-03-03 16:03:55 +01:00
Léo Valque f615b6537d missing word in the doc 2025-03-03 15:33:36 +01:00
Léo Valque 15e80b0a78 solved conflict 2025-03-03 15:26:25 +01:00
lvalque b99ae574d1 Clean doc autorefine snap_grid_size description
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-02-28 11:45:47 +01:00
lvalque 05ecac919d Clean doc autorefine return description
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-02-28 11:45:00 +01:00
lvalque 88bad8a2e5 Clean doc autorefine
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-02-28 11:44:23 +01:00
Léo Valque 3b29156f29 Bug solved: Shift before ceil was in the wrong direction 2025-02-25 09:41:09 +01:00
Léo Valque 5d3ec39dd1 Add more soup information in snap_polygon_soup.cpp 2025-02-24 15:25:22 +01:00
Mael Rouxel-Labbé a1763eee4e Use linear mask/subdivision 2025-02-20 11:10:19 +01:00
Mael Rouxel-Labbé 4719b55db6 Tiny doc fixes 2025-02-20 10:06:25 +01:00
Mael Rouxel-Labbé b0be5427a4 edge_length needs a gt too 2025-02-20 10:06:09 +01:00
Léo Valque 20e54eb8fd reintroduced #ifdef CGAL_LINKED_WITH_TBB 2025-02-20 09:14:01 +01:00
Sébastien Loriot fc10777397 lost Mael's rewriting suggestion 2025-02-20 07:48:12 +01:00
Sébastien Loriot 58b494da37 auto -> Mesh 2025-02-20 07:32:04 +01:00
Sébastien Loriot 399c46bc7f more clean-up 2025-02-20 07:28:30 +01:00
Sébastien Loriot 0a17d90841 use edge_length 2025-02-20 06:53:08 +01:00
Sébastien Loriot 3e34b08746 clean up 2025-02-20 06:50:23 +01:00
Sébastien Loriot ee034985c3 fix missing include for CI 2025-02-20 06:33:57 +01:00
Léo Valque 0bbaa2a661 replace #ifdef CGAL_LINED_WITH_TBB by constexpr 2025-02-19 17:33:57 +01:00
Mael Rouxel-Labbé 08e9a749b5 Complete headers 2025-02-19 11:53:40 +01:00
Mael Rouxel-Labbé 6956f56416 Clean code 2025-02-19 11:53:31 +01:00
Léo Valque 09239da179 rename snap_polygon_soup to triangle_soup_snap_rounding and fix bug in snap_polygon_soup.cpp 2025-02-19 11:36:20 +01:00
Sébastien Loriot a26733aeed cosmetic cleanup + dynamic 2025-02-19 08:18:28 +01:00
Sébastien Loriot 10f542d889 remove seeds 2025-02-19 08:18:07 +01:00
Sébastien Loriot faa93e2894 paste some comments from Sebastien Valette 2025-02-19 07:48:10 +01:00
Léo Valque 139e047595 remove trailing whitespace 2025-02-17 18:14:42 +01:00
Léo Valque 9b84d4c73c rename do_snap to apply_iterative_snap_rounding, remove trailing whitespace 2025-02-17 18:09:04 +01:00
Léo Valque ac7bf3c45f Doc modification of autorefine and Polygon mesh processing 2025-02-17 15:44:10 +01:00
Léo Valque d4e66753ad made snap polygon soup an option of autorefine_triangle_soup 2025-02-17 14:17:45 +01:00
Sébastien Loriot b920c18b73 fix compilation error 2025-02-14 23:24:50 +01:00
Sébastien Loriot 9f7dd164f8 left over after example renaming 2025-02-14 23:19:17 +01:00
Sébastien Loriot 7eae4f36e6 comment on topology 2025-02-14 23:01:54 +01:00
Sebastien Loriot 471f357785 Apply suggestions from code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2025-02-14 22:49:52 +01:00
Sébastien Loriot bf1d859b7b remove empty line 2025-02-14 22:47:43 +01:00
Sébastien Loriot c1c6bd2ead add macro to hide debug 2025-02-14 22:44:24 +01:00
Sébastien Loriot a67a43b4be cosmetic changes from the review 2025-02-14 22:36:56 +01:00
Sébastien Loriot 1aed5d6c9e move example + accomodate reviews 2025-02-14 22:23:26 +01:00
Sebastien Loriot bc3412cd24 Apply suggestions from code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2025-02-14 21:56:29 +01:00