songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
113,925 Commits 3 Branches 156 Tags 959 MiB
Commit Graph

2854 Commits

Author SHA1 Message Date
Sébastien Loriot 5254404517 Merge remote-tracking branch 'cgal/master' into HEAD 2024-03-27 22:25:41 +01:00
Guillaume Damiand 9a0b8eb824 Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2024-03-26 16:25:29 +01:00
Mael Rouxel-Labbé 5e38ed54df Fix double "Figure" in doc 2024-03-22 17:33:43 +01:00
Laurent Rineau de34b83d26 cleanup 2024-03-22 10:53:18 +01:00
Laurent Rineau 3d14707b0c reimplement does_first_triangle_intersect_second_triangle_interior 
Now use a modified code of the original predicate `do_intersect(Tri_3, Tri_3)`.
 2024-03-22 10:52:17 +01:00
Laurent Rineau 379bb331cf optimizations about vtuning 2024-03-18 17:22:37 +01:00
Laurent Rineau 44b6c51828 introduce Intel ITT for debug interaction with vtune 2024-03-18 15:03:29 +01:00
Laurent Rineau 5c8a7ea1e7 5.1 degrees seems right 2024-03-13 14:59:43 +01:00
Laurent Rineau 9c763033c6 new debug output: all borders of merged facets 2024-03-10 19:14:36 +01:00
Laurent Rineau 199ece2b10 new options/criteria to choose which facets to merge 2024-03-10 19:14:19 +01:00
Laurent Rineau 7ec2873f9a fix the almost-coplanar regions detector 
1e-14 was way too small
 2024-03-07 12:58:49 +01:00
Jane Tournois a02ce9ea21 fix dependencies by removing Random_numbers where it's not needed anymore 2024-03-07 09:36:59 +01:00
Laurent Rineau fccbeaed59 change the distance check between constraint segment and vertex 
Now it is done up-front, and not during the execution of the process.
 2024-03-06 16:26:45 +01:00
Laurent Rineau a7f97ca017 fix a debug message 2024-03-06 14:21:39 +01:00
Laurent Rineau 8127850dca fix for 90224.stl 
-> a face restricted to one point (its 2D triangulation is dimension 0)
 2024-03-04 10:11:25 +01:00
Laurent Rineau d968bc3f4a fix for data/113344-min3.off 
There was a hole in the cavity: the set of intersecting cells was not simply connected.
There was a sliver, in the interior of the cavity, that was not intersecting the region.
 2024-03-01 16:24:35 +01:00
Laurent Rineau 2fbad9aa4e fix for error_mesh-p_not_equal_0-min2 2024-02-27 16:52:51 +01:00
Laurent Rineau 283c1a2116 More debug message in cdt.is_valid(true) 2024-02-27 16:39:56 +01:00
Sébastien Loriot 910945eb5f undo dependency changes + always use core if not disabled 2024-02-27 16:19:28 +01:00
Sébastien Loriot 3b30756cd3 do not depend on CGAL_Core 2024-02-27 14:46:18 +01:00
Laurent Rineau c000b66db5 two new buggy data sets 2024-02-26 18:07:37 +01:00
Laurent Rineau e27e5a4541 tweaks of CMake 2024-02-23 17:59:44 +01:00
Laurent Rineau d1b945fef9 assert/CGAL_assertion 
That throws an assertion, instead of calling `abort()`.
 2024-02-23 17:59:12 +01:00
Andreas Fabri e4558a4d4b Merge branch 'master' into CORE-boost_mp_number-GF 2024-02-23 17:04:37 +01:00
Laurent Rineau 7393922e2e minor debug modifications 2024-02-22 17:01:24 +01:00
Laurent Rineau eb9672d5be T_3:::copy_triangulation_into_hole postpone *cit++ 
If the output iterator is a function-output-iterator, then the cell is already
correctly constructed.

Also, rename `fit` to `cit`
 2024-02-22 16:13:58 +01:00
Laurent Rineau 6c6d0ed8ff fix for data/106884-min1.off 2024-02-22 15:01:18 +01:00
Laurent Rineau 5601539bb2 add a data set that is not currently working 2024-02-20 16:42:42 +01:00
Laurent Rineau 1bffff78b8 documentation options 2024-02-20 16:42:21 +01:00
Andreas Fabri dbb848deb1 Triangulation 2/3: fstream -> sstream 2024-02-16 08:00:02 +00:00
Laurent Rineau 2468ca956e add --debug-validity 2024-02-15 13:05:23 +01:00
Laurent Rineau 4957209967 better debugging with --debug--regions 2024-02-15 11:57:36 +01:00
Laurent Rineau fca87120b1 remove debugging lines 2024-02-15 11:46:34 +01:00
Laurent Rineau 0fc61e6b3f fix the assertions 
That makes `1435440-min2.off` pass.
 2024-02-15 11:45:55 +01:00
Laurent Rineau 2da7b21865 stupid bug 2024-02-15 11:45:08 +01:00
Laurent Rineau 12626fd4b8 add another data ste 2024-02-15 11:44:56 +01:00
Laurent Rineau 228bad53d8 use a border edge of the region to orient the cavity (above/below) 2024-02-14 12:04:14 +01:00
Laurent Rineau b810fbc118 add new test cases (from previous fixed bugs) 2024-02-14 11:36:39 +01:00
Laurent Rineau 9979b88f1a small bug fix 2024-02-13 22:50:10 +01:00
Laurent Rineau 411fe9deab add option --use-new-cavity-algorithm 
That option allows to use, or not, the previous implementation of the cavity construction, to compare.
 2024-02-13 22:45:07 +01:00
Laurent Rineau 81d7fce5bc new markers for vertices 2024-02-13 14:06:16 +01:00
Laurent Rineau 7903e5d41f new debug flag 2024-02-13 13:40:15 +01:00
Laurent Rineau 4bef1ac665 move With_point_and_info_tag to Compact_container.h 2024-02-13 13:04:13 +01:00
Laurent Rineau 30149d3a4f wip 2024-02-11 22:56:51 +01:00
Laurent Rineau f428cad11c rename from set_Steiner_vertex_on_face to set_Steiner_vertex_in_face 2024-02-09 15:20:17 +01:00
Laurent Rineau b51f3af912 WIP: cells markers 2024-02-09 15:11:19 +01:00
Laurent Rineau 9bfbf53fbb small fix for CDT_3 ctest 2024-02-09 15:07:55 +01:00
Laurent Rineau ba66191b30 better handling of polygon vertices markers 2024-02-09 14:52:05 +01:00
Laurent Rineau a195631f1c fix a bug: use a real marker 2024-02-03 17:36:19 +01:00
Laurent Rineau 66eb2cff14 add --no-repair 2024-02-03 17:31:46 +01:00
Laurent Rineau 69abbc0c6f Add debug_regions(bool) 2024-02-03 17:29:39 +01:00
Laurent Rineau a75f4cdaa5 fix for Thingi 243014.stl 2024-01-31 16:50:43 +01:00
Laurent Rineau 3d493adfef "merge facets" is not by default 2024-01-31 12:26:26 +01:00
Laurent Rineau 27de164679 fix my previous commit about Thingi 243014 2024-01-31 12:25:03 +01:00
Laurent Rineau 3c1359589b add a test case 2024-01-31 11:32:11 +01:00
Laurent Rineau eaa5c98289 better debugging message 2024-01-31 11:31:32 +01:00
Laurent Rineau d46d51d08e partial fix for Thingi 243014 2024-01-30 22:54:33 +01:00
Laurent Rineau e8f6b60350 Add debug_missing_region() at runtime 2024-01-30 14:51:38 +01:00
Laurent Rineau d6ac147b4d cosmetic renaming of a parameter (during code review with Jane) 
plus use of `tr.vertices(Edge)` instead of home-made function.
 2024-01-30 14:50:32 +01:00
Laurent Rineau 3cfa54ce1a proper class encapsulation for CDT_vb_3 2024-01-30 14:50:24 +01:00
Laurent Rineau bbc45c01fa rename to polygon_border_vertices 2024-01-29 09:34:31 +01:00
Laurent Rineau a5cf779795 debug debugging of missing faces from cavities 2024-01-26 16:36:31 +01:00
Laurent Rineau 37c5f131ac add an cmdline option to debug Steiner points 
That replaces debug macros.
 2024-01-26 16:35:52 +01:00
Laurent Rineau fb70d9dfb7 fix a bug in the dichotomy process to minimize a buggy input 2024-01-25 12:11:00 +01:00
Laurent Rineau 1b24edec3f re-add the merging of exactly coplanar faces 2024-01-25 10:56:46 +01:00
Laurent Rineau 6336e5b08a use region growing to detect almost coplanar patches 2024-01-22 23:05:07 +01:00
Sebastien Loriot 722e3825bb
Triangulation_2: Make IO save by changing file names (#7957) 
## Summary of Changes

Change file names to avoid interaction between test cases.

@MaelRL I noticed that the RT test does not read back. 

## Release Management

* Affected package(s): Triangulation_2
* Issue(s) solved (if any): fix
[testsuite](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-141/Triangulation_2/TestReport_gimeno_ArchLinux-clang.gz)
* License and copyright ownership:  unchanged
 2024-01-19 11:42:43 +01:00
Laurent Rineau d7032f5e57 new useful debugging messages 2024-01-16 15:28:44 +01:00
Laurent Rineau 73c5a2cf5f Add With_offset_tag 2024-01-16 15:27:48 +01:00
Laurent Rineau f753446633 oformat(x, tag) passed the tag value to the Output_rep 
That allows to pass an integral offset to the displayed time stamps.

The goal is to set it to -1, to display vertices IDs that are identical to the input vertices indices of `the Surface_mesh`.
 2024-01-15 09:45:25 +01:00
Laurent Rineau 939fbef9e6 new way to output after conforming 
This new way ensures that the order of vertices in the output is also the order of vertices in the CDT.
 2024-01-15 09:28:00 +01:00
Laurent Rineau 289d475ee6 vertices_in_constraint_end is bidirectional 
That allows to speed up `constraint_extremities(Constraint_id c_id)`.
 2024-01-14 20:41:17 +01:00
Laurent Rineau c6ac1e890d Add timestamps to base classes 2024-01-14 20:40:30 +01:00
Guillaume Damiand 3bc56024d3 Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2024-01-11 14:08:05 +01:00
Laurent Rineau 2838441b6a cosmetic change 2024-01-09 17:26:34 +01:00
Laurent Rineau f422541cb8 faster visitor implementation during the conforming 2024-01-09 17:26:20 +01:00
Laurent Rineau de6c5f2895 change the loop pattern when there are PLC errors 
That gave a direct improvement for the four PLC error case from Thingi:

```
            name status       time     error new status   new time new error
Thingi10K_104400 FAILED   1.710520 PLC_error     FAILED   1.243950 PLC_error
Thingi10K_162100 FAILED   1.970900 PLC_error     passed   1.018690
Thingi10K_285604 FAILED  13.096400 PLC_error     FAILED   4.543940 PLC_error
Thingi10K_464846 FAILED 321.774000 PLC_error     FAILED  16.658500 PLC_error
```

One case `Thingi10K_162100` passed. And the other three got runtime
improvement before they reach the error.
 2024-01-05 16:59:55 +01:00
Laurent Rineau 06288f3f04 improve the code reproducibility 2024-01-05 16:38:53 +01:00
Laurent Rineau c25f443368 fix a regression in speed 2024-01-04 18:17:31 +01:00
Laurent Rineau ba7725ffd7 fix the CDT testsuite 
in particular test_CDT_3_insert_constrained_edge_from_EDG_file
 2024-01-04 18:08:17 +01:00
Laurent Rineau 3cb8f4dd28 restore compilation with Epeck 2024-01-04 17:18:57 +01:00
Laurent Rineau ad38e7ac29 Add diagnostic "constrained segment is too close" 2024-01-04 16:27:37 +01:00
Laurent Rineau 09de2165a8 improve diagnostic "Min distance between vertices" 2024-01-04 14:51:10 +01:00
Laurent Rineau c36bd7559d extract function encroaching_vertices(va, vb) 2024-01-04 14:50:19 +01:00
Laurent Rineau 7d9e84e685 dump region in case of a fatal PLC error 2024-01-04 14:49:31 +01:00
Laurent Rineau 87f6a352d1 factorize a lambda function 2024-01-04 14:47:45 +01:00
Laurent Rineau 9b843a901d minor improvement of debug messages 2024-01-04 14:46:53 +01:00
Laurent Rineau 6a7c2fee3c missing const 2024-01-04 14:45:47 +01:00
Laurent Rineau ee77fa000f indentation 2024-01-04 14:43:58 +01:00
Laurent Rineau 96fa9c7d95 CDT_vb_3: regroup data members 2024-01-04 14:42:25 +01:00
Sébastien Loriot c99b69a0e7 add missing license headers 2024-01-04 13:50:15 +01:00
Sébastien Loriot e7c26349f2 move header in a package to GPL 2024-01-04 13:36:34 +01:00
Andreas Fabri e610677ee2 The same for 3D 2024-01-02 17:09:24 +00:00
Sebastien Loriot caecbe29c7
Replace boost::mpl (#7813) 
- `boost::mpl::if_` --> `std::conditional`
- `boost::enable_if` -> `std::enable_if`
- `boost::mpl::and_` -> `&&`
- `boost::mpl::or_` -> `||`
- `boost::constant::bool_` -> `std::bool_constant`
- ...
 2023-12-26 17:33:36 +01:00
Laurent Rineau 62e3e8dc12 port back to C++17 
The lack of `std::set::contains` is a real pain! Using `count()`
instead reduces the readability of the code.
 2023-12-13 16:56:03 +01:00
Laurent Rineau c41a55f99b fix indentation 2023-12-13 15:44:51 +01:00
Laurent Rineau 2a74954de9 add timing displays and a --quiet option 2023-12-13 15:00:23 +01:00
Laurent Rineau 0b9133fba3 reduce timings in cases of PLC errors 2023-12-13 14:57:27 +01:00
Laurent Rineau 4297466869 add `--failure-expression` 
That avoids having to hardcode the assertion expression in the code
 2023-12-13 14:56:22 +01:00
Laurent Rineau 10fc714df9 add options to set the epsilon values (in particular to make them 0) 2023-12-13 14:45:58 +01:00
Laurent Rineau 5a628ec88a Merge pull request #7881 from afabri/Poisson-enable_structural_filtering-GF 
Poisson Surface Reconstruction: Enable Structural Filtering
 2023-12-11 13:56:08 +01:00
Laurent Rineau 3f42717b5a remove a spurious assertion 2023-12-08 16:05:07 +01:00
Laurent Rineau 934e65cd35 fix the assertion `v->nb_of_incident_constraints < 0` 2023-12-07 11:33:55 +01:00
Guillaume Damiand bd04b2a68d Remove space in doc 2023-12-06 17:01:34 +01:00
Laurent Rineau 7037df170e backup this script change 2023-12-06 14:58:08 +01:00
Guillaume Damiand 03ff679df4 doc draw: move advanced blocks 2023-12-05 14:10:25 +01:00
Laurent Rineau 6e613e08bb Better labels for Thingi10K test cases 2023-12-05 13:21:32 +01:00
Laurent Rineau 0c8697168f detect small distances 2023-12-05 13:20:46 +01:00
Guillaume Damiand df2b9ad172 doc draw pwh 2023-12-05 13:16:54 +01:00
Guillaume Damiand 5b7f499fc1 doc draw polygon 2023-12-05 12:58:30 +01:00
Guillaume Damiand d2f007d0df doc draw t3 2023-12-05 10:35:07 +01:00
Guillaume Damiand a204073c08 draw t3 2023-12-01 10:00:03 +01:00
Laurent Rineau 75a08ce746 Thingi10k: add a way to run a test case with merge_facets only 
Now CTest displays:
```
    Start 5393: execution   of  cdt_3_from_off --merge-facets Thingi10K_106789
    Start 5392: execution   of  cdt_3_from_off Thingi10K_106789
4/6 Test #5392: execution   of  cdt_3_from_off Thingi10K_106789 ..................***Not Run (Disabled)   0.00 sec
5/6 Test #5393: execution   of  cdt_3_from_off --merge-facets Thingi10K_106789 ...   Passed    0.10 sec
```
 2023-11-30 12:44:24 +01:00
Guillaume Damiand f8a487d9ef update dependencies 2023-11-29 18:12:09 +01:00
Laurent Rineau 95b83b1214 Merge pull request #7845 from puneetmatharu/patch-cgal-dont-override-build-testing 
Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject
 2023-11-29 17:22:54 +01:00
Guillaume Damiand 0655006622 Merge with master: now viewers use Qt6 2023-11-29 14:36:38 +01:00
Laurent Rineau 5fd8333a52 more debug messages 2023-11-28 19:51:24 +01:00
Andreas Fabri 8f8280ce34 Add structural filtering to Robust circumcenter traits 2023-11-23 19:37:23 +00:00
Sébastien Loriot 16de47d1e6 more fixes 2023-11-23 14:55:30 +01:00
Laurent Rineau 223454ab57 Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3-lrineau 2023-11-16 16:01:01 +01:00
Laurent Rineau 5a5a5618f8 [_, inserter] = set.insert... Use .second instead 
That addresses a TODO from Jane's review.
 2023-11-16 11:40:42 +01:00
Laurent Rineau bbf2e8da31 simplify those lines 2023-11-16 11:38:29 +01:00
Sébastien Loriot cfac63f156 Merge remote-tracking branch 'cgal/master' into HEAD 2023-11-16 11:35:35 +01:00
Laurent Rineau a31fed66f1 construct_cavities: turn into vectors 2023-11-16 11:35:05 +01:00
Laurent Rineau 446d842586 insert_in_CDT_3: mirror facets directly 
Facets are pushed directly as mirror facets, on the border of the cavity
so that they are seen from the exterior of the cavity.

That avoids a copy of a vector of facets.
 2023-11-16 11:26:13 +01:00
Laurent Rineau 06e630287b another fix 
Now it seems to work!
 2023-11-16 10:32:14 +01:00
Laurent Rineau 1f75f30ab2 WIP: more fix 2023-11-16 10:32:14 +01:00
Laurent Rineau cc98a40424 WIP : fix 2023-11-16 10:32:14 +01:00
Laurent Rineau c9540b13c5 WIP: add insert_in_cdt_3 2023-11-16 10:32:14 +01:00
Laurent Rineau 4f50a45374 Extract inner_map_of_cavity to a member function 2023-11-16 10:32:14 +01:00
Laurent Rineau 569aeb33f4 fix a bug? 
The code review found that as a bug, but it never showed.
 2023-11-16 10:32:14 +01:00
Laurent Rineau 16171923c7 extract the lambda register_facet_to_be_constrained 
to a member function
 2023-11-16 10:32:14 +01:00
Laurent Rineau dc95d1ac59 fix typos (detected by spell-checker) 2023-11-16 10:32:14 +01:00
Laurent Rineau 0e34940a2d verify that CDT_3 works also with Epeck 2023-11-16 10:32:14 +01:00
Andreas Fabri 1dee4f8fff Fix conversion warning in T3 demo 2023-11-16 07:33:25 +00:00
Laurent Rineau 01f021d532 Merge pull request #7808 from janetournois/Triangulation_3-vertices_array-jtournois 
Triangulation_3 - add `vertices()` helper functions
 2023-11-15 15:44:22 +01:00
Jane Tournois 47477277d3 use initializer list 2023-11-13 13:58:05 +01:00
Jane Tournois 5974f2ca32 replace Vertex_triple by std::array<Vertex_handle, 3> 2023-11-13 13:48:05 +01:00
Andreas Fabri 97721a0c12 namespace fixes 2023-11-13 11:11:46 +00:00
Sébastien Loriot 2277013d84 replace boost::mpl::and_ 2023-11-10 16:19:26 +01:00
Laurent Rineau f46654ef8c more a function 
Now the two functions are adjacent:
- `try_to_insert_circumcenter_in_face_or_return_encroached_edge` and
- `insert_mid_point_in_constrained_edge`
 2023-11-09 19:39:47 +01:00
Laurent Rineau 255178644d `inner_map_of_cavity` uses `this` as const and nothing else 
That means it could be replaced by a const member function
 2023-11-09 19:38:46 +01:00
Laurent Rineau d1c513ac0d result of the review with Jane 2023-11-09 19:38:01 +01:00
Laurent Rineau 92aabb00ad use std::invoke (C++17) for IILE 
*Immediately Invoked Lambda Expression*

Now that CGAL can use C++17 , switch to `std::invoke`
that is more readable that the two small characters `()`
hidden somewhere a few lines below.

With `std::invoke`, we understand straight away that the lambda is
called immediately.

Ref:

https://www.cppstories.com/2016/11/iife-for-complex-initialization/
 2023-11-09 19:36:53 +01:00
Laurent Rineau 5997b70327 `triangulate_cavity` is a fct without side effect 
(but the debug outputs)
 2023-11-08 16:39:56 +01:00
Laurent Rineau 4d7a2fee64 Extract map_cavity_vertices_to_ambient_vertices 
- make it const,
 - and simplify the reuse of the API.
 2023-11-08 15:52:20 +01:00
Laurent Rineau 25de4ee6b7 Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3-lrineau 2023-11-07 15:02:43 +01:00
Puneet Matharu 7944441068 Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject. 2023-11-02 18:09:03 +00:00
Laurent Rineau 51627e3505 Merge remote-tracking branch 'cgal/master' into CGAL-Qt6-GF 
# Conflicts:
#	GraphicsView/demo/Bounding_volumes/CMakeLists.txt
 2023-11-01 20:59:44 +01:00
Sébastien Loriot ca0f9acbe0 Merge remote-tracking branch 'cgal/5.6.x-branch' 2023-10-25 17:43:16 +02:00
Jane Tournois 655a86a3f6 of/in 2023-10-24 12:32:41 +02:00
Laurent Rineau eb1ab88c04 Adapt triangulate_cavity 
that will allows its reuse by the function `insert(Point)`
 2023-10-24 11:39:58 +02:00
Guillaume Damiand 761fde02be add_in_graphics_scene -> add_to_graphics_scene; plus remove template parameter NumberType 2023-10-23 01:52:38 +02:00
Guillaume Damiand 6daa2a0c3b Graphics_scene is no more templated 2023-10-23 01:30:57 +02:00
Jane Tournois 6785c5cb7b document the order of vertices 2023-10-20 15:57:58 +02:00
Jane Tournois a9e1fb885c apply Monique's review 2023-10-20 15:09:31 +02:00
Jane Tournois 47e17d0a2c remove vertices(vertex) that is useless 2023-10-19 11:53:56 +02:00
Sébastien Loriot 9cefb1a481 fix out-of-bound warnings 2023-10-19 11:40:35 +02:00
Jane Tournois fbfcbe43d8 add documentation for the `vertices()` functions 2023-10-19 11:18:41 +02:00
Jane Tournois 152e473458 test vertices() helper functions 2023-10-19 11:13:47 +02:00
Jane Tournois c799051e2b add vertices() function for every dimension of simplex in T3 
returns a std::array of vertices
 2023-10-19 11:13:28 +02:00
Laurent Rineau afce4db325 commit more debug code 2023-10-17 18:06:18 +02:00
Laurent Rineau 5c633c2f0b extra assertion 
Check that the triangulation is still Delaunay after the conforming.
 2023-10-17 16:07:33 +02:00
Laurent Rineau 0186e9add9 add another option 
this one is to dump the input surface with the extra Steiner points
of the conforming.

And add a --help option as well.
 2023-10-17 16:05:35 +02:00
Laurent Rineau 762c8461f2 more options 2023-10-16 17:26:58 +02:00
Laurent Rineau 446ba43b25 factorize the handling of options 
so that I can introduce new ones more easily
 2023-10-16 09:51:06 +02:00
Laurent Rineau 4380273203 fix the number of added vertices in a cavity 2023-10-13 16:50:30 +02:00
Laurent Rineau d1e76c2099 fix typo 2023-10-13 16:48:48 +02:00
Laurent Rineau 265d3ba8fe reimplement brute_force_border_3_of_region 2023-10-04 16:16:33 +02:00
Laurent Rineau e3c132a675 --ratio: Adjust nb_of_bucket when only one face is skipped 2023-10-02 12:13:13 +02:00
Laurent Rineau 634992dc9b Replace ERROR by NOTE because those were not errors 2023-10-02 11:46:10 +02:00
Laurent Rineau 0f8539c0ad fix another bug in construct_Steiner_point 
@MaelRL This is the bug of Saddle-1CC.
 2023-10-02 11:45:47 +02:00
Laurent Rineau e910b9f550 remove m.collect_garbage(); 
`Surface_mesh::collect_garbage` uses swaps, and this it modifies the
order of elements of the mesh.
 2023-09-29 15:20:50 +02:00
Laurent Rineau 32903bd0fb allow the compilation with Epeck 2023-09-29 15:10:37 +02:00
Laurent Rineau a17542f29a with --ratio 0.1, iterate on all buckets in order 
... instead of applying random selection of buckets.
 2023-09-29 15:09:21 +02:00
Guillaume Damiand a5ee74cb66 Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2023-09-29 08:36:37 +02:00
Guillaume Damiand 9f22d67ed0 Rename Graphic_storage in Graphics_scene (Andreas and Sebastien review) 2023-09-28 12:49:00 +02:00
Laurent Rineau c05d48b945 Add 4291 data sets from Thingi10K 
For the moment, I selected:
  - num_vertices < 10000 and
  - "solid"

As for the meaning of "solid", quoting Zhou, Qingnan, et al.
"Mesh arrangements for solid geometry."
ACM Transactions on Graphics (TOG) 35.4 (2016): 1-15.:
> Solid meshes are free of self-intersections, degenerate triangles
> or duplicate triangles, and their generalized winding number field
> is either zero or one.
 2023-09-28 12:46:39 +02:00
Laurent Rineau 21c4aec8b5 Allow to open more that OFF files 
The files are even repaired on the fiy.
 2023-09-28 12:38:18 +02:00
Guillaume Damiand fd115bd321 Rename Graphic_storare into Graphics_scene (Andreas and Sebastien review) 2023-09-28 11:06:53 +02:00
Guillaume Damiand 5cf89dadd9 Rename Drawing_functor in Graphics_scene_options (following Andreas and Sebastien review) 2023-09-28 09:51:12 +02:00
Laurent Rineau 7d35d64f1e add another selection of HexiCosPot 2023-09-26 17:46:36 +02:00
Laurent Rineau 2d87d4172d fix code when CGAL_NDEBUG or NDEBUG is defined 2023-09-26 15:34:17 +02:00
Laurent Rineau a1ac93b529 fix a warning 2023-09-26 15:33:44 +02:00
Laurent Rineau 38e836c963 oformat is in CGAL::IO:: 2023-09-26 13:00:20 +02:00
Laurent Rineau 0cdb022027 fix a bug in dimension 2 
There was a warning:
```
Triangulation_3/include/CGAL/Constrained_Delaunay_triangulation_3.h:1841:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
[build]  1841 |     } // dim 2
[build]       |     ^
```
and for once that was a warning about a real bug!
 2023-09-26 12:50:56 +02:00
Laurent Rineau c114e5d579 remove unused variable 2023-09-26 12:49:00 +02:00
Laurent Rineau 5b1248f910 unless CGAL_TRIANGULATION_CHECK_EXPENSIVE 2023-09-26 12:43:46 +02:00
Laurent Rineau 4be93760d1 try to workaround MSVC2022 error 
```
2>C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\include\type_traits(143,19): error C2338: static_assert failed: 'Calling declval is ill-formed, see N4917 22.2.6 [declval]/2.'
2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311): message : see reference to function template instantiation 'Segment &&std::declval<Segment>(void) noexcept' being compiled
2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311,57): message : see reference to function template instantiation 'std::vector<std::vector<Point,std::allocator<Point>>,std::allocator<std::vector<Point,std::allocator<Point>>>> segment_soup_to_polylines<_Ty&>(Range_of_segments)' being compiled
```
 2023-09-26 12:42:33 +02:00
Laurent Rineau 49836e1485 error message about unknown options 2023-09-26 12:41:22 +02:00
Laurent Rineau 091878f592 those debug function must be const 2023-09-25 18:58:35 +02:00
Laurent Rineau 6340d3508c insert the "bbox" iff cdt.dimension()==2 2023-09-25 18:56:38 +02:00
Laurent Rineau 49c52a00f0 better fix for cheese23 
The data set was not coplanar, but a few vertices were missing from the
initial CDT.
 2023-09-25 18:55:57 +02:00
Laurent Rineau 212228bf3a dump outputs with --merge-facets 2023-09-25 18:47:45 +02:00
Laurent Rineau 1b769b6e5b fix the bug of cheese23.off 
Actually, that was not a bug. The issue is that the simplex traverse
in 2D is currently buggy. With a bbox, that passes.
 2023-09-25 18:41:01 +02:00
Laurent Rineau 5bc5ec4f46 fix cheese18 --merge-facets 
The explanation of the bug:
`split_graph_into_polylines` can reverse the orientation of a polygon
 2023-09-25 17:58:03 +02:00
Sébastien Loriot 8700394122 boost::mpl::if_ -> std::conditional 2023-09-24 22:57:20 +02:00
Laurent Rineau 616cdfbc7a fix implementation of constraint_from_extremities 
It fixes `HexiCosPot-1.off`.
 2023-09-22 14:28:53 +02:00
Laurent Rineau 819f02d698 fix fandisk.off --merge-facets 2023-09-22 09:09:35 +02:00
Laurent Rineau aa09a28df8 Merge remote-tracking branch 'cgal/master' into STL_extension-Fix_Prevent_deref-GF 2023-09-19 16:22:49 +02:00