Commit Graph

288 Commits

Author SHA1 Message Date
albert-github 36c8b7589d Spelling corrections
Last batch (for now) of spelling corrections in doxygen and normal comments
2024-05-31 19:05:34 +02:00
Laurent Rineau 70464ea107 Merge remote-tracking branch 'afabri/STL_extension-Fix_Prevent_deref-GF' into pr/lrineau/8170 2024-05-21 18:55:11 +02:00
Laurent Rineau 797c056577 Prevent_deref, major changes
Now the second parameter is the `reference` type and no longer the `value_type`.
2024-05-21 08:53:48 +02:00
Laurent Rineau e96aaf37ad Merge branch 'master' into pr/afabri/7410 2024-05-17 23:03:55 +02:00
Laurent Rineau 90b2aa5d8f T_3:::copy_triangulation_into_hole postpone *cit++
If the output iterator is a function-output-iterator, then the cell is already
correctly constructed.

Also, rename `fit` to `cit`
2024-04-26 16:57:14 +02:00
Laurent Rineau 52393d19a2 small factorization with a lambda expression 2024-04-26 16:56:46 +02:00
Laurent Rineau 3f92648e1a add T_3::is_facet(u, v, w) 2024-04-26 16:52:40 +02:00
Laurent Rineau 3fda4e64c0 Triangulation_3: rewrite the code a little
that avoids code like `o_vt_f_pair.second.first`

Backport: master
2024-04-26 16:51:45 +02:00
Laurent Rineau 952d34c6ea cosmetic changes (indent, spaces, naming) 2024-04-26 13:09:05 +02:00
Andreas Fabri 53b438eeeb STL_extension: Add parameter for value type to Prevent_deref 2024-04-26 13:08:06 +02:00
Sebastien Loriot caecbe29c7
Replace boost::mpl (#7813)
- `boost::mpl::if_` --> `std::conditional`
- `boost::enable_if` -> `std::enable_if`
- `boost::mpl::and_` -> `&&`
- `boost::mpl::or_` -> `||`
- `boost::constant::bool_` -> `std::bool_constant`
- ...
2023-12-26 17:33:36 +01:00
Jane Tournois 47477277d3 use initializer list 2023-11-13 13:58:05 +01:00
Jane Tournois 5974f2ca32 replace Vertex_triple by std::array<Vertex_handle, 3> 2023-11-13 13:48:05 +01:00
Sébastien Loriot 2277013d84 replace boost::mpl::and_ 2023-11-10 16:19:26 +01:00
Jane Tournois 47e17d0a2c remove vertices(vertex) that is useless 2023-10-19 11:53:56 +02:00
Jane Tournois c799051e2b add vertices() function for every dimension of simplex in T3
returns a std::array of vertices
2023-10-19 11:13:28 +02:00
Sébastien Loriot 8700394122 boost::mpl::if_ -> std::conditional 2023-09-24 22:57:20 +02:00
Laurent Rineau aa09a28df8 Merge remote-tracking branch 'cgal/master' into STL_extension-Fix_Prevent_deref-GF 2023-09-19 16:22:49 +02:00
Laurent Rineau 2a41598bd7 cosmetic changes (indent, spaces, naming) 2023-04-27 12:04:02 +02:00
Andreas Fabri 68261eb0f1 STL_extension: Add parameter for value type to Prevent_deref 2023-04-26 10:55:59 +01:00
Sébastien Loriot b039040f73 boost::is_convertible -> std::is_convertible 2023-04-23 22:37:07 +02:00
Laurent Rineau 3b79468b13 another USBAN error, about uninitialized bool 2023-04-13 17:26:44 +02:00
Laurent Rineau 029b5bead5 Triangulation_3.h: Rewrite/factorize
New functions:
  - `create_hole_outer_map`,
  - `create_triangulation_inner_map`.
  - `copy_triangulation_into_hole`,
  - `fill_auxiliary_triangulation_with_vertices_around_v`
2023-02-06 10:02:25 +01:00
Laurent Rineau 686aff651d Triangulation_3.h: Factorize the two versions of make_hole_3D 2023-02-06 10:02:20 +01:00
Laurent Rineau d940c3ae3f Triangulation_3.h: make_vertex_triple can be static 2023-02-06 10:02:15 +01:00
albert-github c32b1f4127 spelling corrections
Some spelling corrections (Directories starting with `S` rest - `W`),
2022-11-16 13:22:39 +01:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Mael Rouxel-Labbé 43378edd1f Minor speed up for T3::operator== 2022-09-02 14:29:15 +02:00
Mael Rouxel-Labbé 7d9d7844b1 Fix T23::operator== for dimension 0 2022-09-02 13:42:33 +02:00
Sébastien Loriot c9c6b30cf0 Merge sloriot/CGAL-std_type_traits into master 2022-06-23 16:35:37 +02:00
Laurent Rineau 782bd1b106 Merge pull request #6622 from kda/initialize
initialize some stack variables
2022-06-15 10:20:55 +02:00
Laurent Rineau 2feb9a29ce Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:20:48 +02:00
Laurent Rineau 14b582f83d More use our free of `outer_map` 2022-06-10 09:15:11 +02:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Kevin Athey a40be70ff7 change initialized value to -1. 2022-06-08 15:28:25 -07:00
Laurent Rineau f438a2ed3a Fix a use-after-free
In an `unordered_map`, any insertion can invalidate iterators,
when the load factor triggers a rehashing.
2022-06-08 15:52:01 +02:00
Kevin Athey ff749f7fd6 initialize some stack variables 2022-05-27 11:46:34 -07:00
Laurent Rineau ceb41bf206 Fix crash during binary I/O of Triangulation_3 2022-04-27 14:19:21 +02:00
Laurent Rineau bac0822298 Merge pull request #5199 from GilesBathgate/fix-uninitialized-member-triangulation3
Fix uninitialized member in Triangulation_3.h
2021-09-29 11:46:53 +02:00
Sébastien Loriot 5945e48a3e restore sub-directories accidently removed in 98e471849b 2021-09-17 08:14:06 +02:00
Maxime Gimeno d4b0b49f33 Use "real" extensions and fix loading. 2021-08-30 15:41:52 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot 1e249afdb3 remove some boost::bind 2021-01-06 12:59:11 +01:00
Giles Bathgate b95de74a7a Fix uninitialized member in Triangulation_3.h 2020-11-18 21:26:59 +00:00
Jane Tournois b87e226ebb Simplex_3 can be dereferenced in range-for-loop (not Cell_handle)
this error was found thanks to a clang warning :
warning: loop variable 's' has type 'const Simplex &' (aka 'const Triangulation_simplex_3&')
but is initialized with type
'CGAL::Triangulation_segment_simplex_iterator_3' resulting in a copy [-Wrange-loop-construct]
2020-11-03 18:53:02 +01:00
Jane Tournois 57250ce637 Merge remote-tracking branch 'cgal/master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF
# Conflicts:
#	Installation/CHANGES.md
2020-09-28 16:01:05 +02:00
Laurent Rineau 022b1a71d0 Merge branch 'releases/CGAL-5.0-branch' 2020-07-21 15:27:49 +02:00
Laurent Rineau 2e8a59d570 Merge branch 'releases/CGAL-4.14-branch' into releases/CGAL-5.0-branch 2020-07-21 15:25:54 +02:00
Laurent Rineau 1e6a5ac636 Fix the use of Construct_point_3::result in Periodic_3 2020-07-16 15:11:23 +02:00