The `facet_surface_center` of facet was not always restored correctly,
after an aborted move, and that eventually led to use of uninitialized
memory... and a crash.
In issue #2453:
> I am trying to mesh in the demo a given Polyhedron (the problem is the same with Surface_mesh with a very small tetrahedron size, and the output mesh is always more or less the same, with very few simplices compared to what I expect.
Actually, the demo uses a loop:
```C++
while( !mesher->is_algorithm_done() )
mesher->one_step();
```
Because of that bug in `one_step()`, `is_algorithm_done()` could return
`true` even before the cells mesher level has scanned the triangulation
for bad cells. That will be fixed, now.
The bug and the fix are known for six weeks (found while working on
another project):
> commit 15d1f864c4bb68cc9e267c3be3610296e5fa9212
> Author: Laurent Rineau <laurent.rineau@cgal.org>
> Date: Fri Feb 17 12:17:18 2017 +0100
>
> Refactoring of Sizing_field_with_aabb_tree (API breakage too)
but we forgot to include the fix in CGAL.
The bug and the fix are known for six weeks (found while working on
another project):
> commit 15d1f864c4bb68cc9e267c3be3610296e5fa9212
> Author: Laurent Rineau <laurent.rineau@cgal.org>
> Date: Fri Feb 17 12:17:18 2017 +0100
>
> Refactoring of Sizing_field_with_aabb_tree (API breakage too)
but we forgot to include the fix in CGAL.
Skip the reading of the existing binary file, for
- 32bits platforms (actually any non-64bits platform),
- and big endian platforms.
... because we know the binary file is incompatible (for the moment).
```
/usr/bin/c++ -DCGAL_TEST_SUITE -DCGAL_USE_GMP -DCGAL_USE_MPFR -DCGAL_USE_ZLIB -I/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/../../../AABB_tree/include -I/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/../../include -I/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3 -I/home/cgal_tester/build/src/cmake/platforms/CentOS7/include -I/mnt/testsuite/include -Wall -frounding-math -o CMakeFiles/test_c3t3_io.dir/test_c3t3_io.cpp.o -c /home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/test_c3t3_io.cpp
In file included from /usr/include/boost/assert.hpp:50:0,
from /usr/include/boost/archive/archive_exception.hpp:20,
from /usr/include/boost/multi_index/detail/index_node_base.hpp:21,
from /usr/include/boost/multi_index/detail/node_type.hpp:23,
from /usr/include/boost/multi_index/detail/index_base.hpp:21,
from /usr/include/boost/multi_index/detail/base_type.hpp:21,
from /usr/include/boost/multi_index_container.hpp:33,
from /usr/include/boost/bimap/detail/bimap_core.hpp:34,
from /usr/include/boost/bimap/bimap.hpp:61,
from /mnt/testsuite/include/CGAL/Mesh_complex_3_in_triangulation_3.h:39,
from /home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/test_c3t3_io.cpp:4:
/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/test_c3t3_io.cpp: In member function 'bool Test_c3t3_io<Mesh_domain>::operator()(const char*) const':
/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/test_c3t3_io.cpp:387:43: error: 'type name' declared as function returning a function
assert(CGAL::Get_io_signature<C3t3>()() ==
^
```
Laurent Rineau
Maxime Gimeno
Jane Tournois
Sebastien Loriot