Commit Graph

589 Commits

Author SHA1 Message Date
Sebastien Loriot 8730ff5d55
Shape_detection: using proper triangulated polygonal faces for linear_least_squares (#8314)
## Summary of Changes

Polygonal faces are now triangulated and face normals are calculated
using PMP::compute_face_normal.

The calculated face normals and triangulations are buffered in
Least_squares_plane_fit_region. However, Least_squares_plane_fit_sorting
is independent and does not benefit from that buffered data.

## Release Management

* Affected package(s): Shape_detection
* Issue(s) solved (if any): fix #7992
2024-08-19 11:22:41 +02:00
Sébastien Loriot 6e5f37474f bad type 2024-08-14 17:20:06 +02:00
Sébastien Loriot e931d1258b add missing include 2024-08-14 16:52:42 +02:00
Sébastien Loriot 7d0969d15f use dynamic property maps 2024-08-14 16:10:53 +02:00
Sébastien Loriot 8c70d6120f hide PMP usage behind a macro 2024-08-14 15:26:33 +02:00
Sven Oesau 05ba6a2644 fixed warnings
handling of degenerate faces
2024-07-03 10:12:07 +02:00
Sven Oesau 22732a9ae3 using proper triangulated polygonal faces for linear_least_squares 2024-06-27 10:55:33 +02:00
Sven Oesau e84a054cd8 Removing leftover from deprecated Shape_detection_traits 2024-06-21 11:34:57 +02:00
Sébastien Loriot 3bfc61af58 pass the VPM to polyline graph 2024-03-12 10:39:28 +01:00
Sébastien Loriot 7431715e96 improve doc 2024-01-22 18:02:48 +01:00
Sébastien Loriot 95e56a77e9 remove invalid end of group 2023-08-30 10:13:35 +02:00
Sébastien Loriot ab023626e0 init the corner id map 2023-08-28 09:05:03 +02:00
Sébastien Loriot caa1daa98e bug fix in neighbor query to accomodate constraints in remesh with common interface 2023-08-28 08:33:47 +02:00
Sébastien Loriot 6ac6cf0ff5 fix debug 2023-08-28 08:27:57 +02:00
Sébastien Loriot 3a98df102a avoid calling RG on an empty range 2023-08-28 08:27:28 +02:00
Andreas Fabri 8682331d6b Remove unused variable 2023-05-19 12:27:18 +01:00
Sébastien Loriot 43f44acf6b missing one removal 2023-05-18 17:10:00 +02:00
Sven Oesau 42454cf470 adapted concept to removed parameter 2023-05-17 15:07:36 +02:00
Sven Oesau 67f615ccbc fixed documentation 2023-05-17 15:00:13 +02:00
Sven Oesau a60ad376bf removed unused parameter 2023-05-17 14:43:25 +02:00
Sébastien Loriot 7f2ca4cfb7 fix more warnings 2023-04-27 15:52:52 +02:00
Laurent Rineau 594682dde3 Merge pull request #5461 from sloriot/PMP-decimation
Add coplanar decimation
2023-04-17 10:14:07 +02:00
albert-github 8a0b21461d Unexpected backtick
- Corrected some more redundant / missing backticks
- correctes a spelling error (Boolean_set_operations_2/doc/Boolean_set_operations_2/CGAL/Boolean_set_operations_2/Gps_default_dcel.h)
2023-04-11 17:38:37 +02:00
Sébastien Loriot 007733511f wrong map 2023-04-04 14:52:09 +02:00
Sébastien Loriot b05755b876 init ecm to false 2023-04-04 14:11:50 +02:00
Sébastien Loriot 8609e45f02 remove duplicated code 2023-03-31 14:39:33 +02:00
Sven Oesau 47b7be9758 bugfix 2023-03-20 11:41:30 +01:00
Sven Oesau 4f2758777d removed internal storage of regions and access function 2023-03-20 10:49:54 +01:00
Sébastien Loriot 41c9f6de7e fix converson warning 2023-03-14 14:28:01 +01:00
Sébastien Loriot 7ff85c0444 fix warnings and typo 2023-03-14 14:22:21 +01:00
Sébastien Loriot 36b448912e add a first simple post-processing step 2023-03-13 12:00:45 +01:00
Sven Oesau 41b1a655e6 bugfix region_map 2023-03-10 10:58:10 +01:00
Sven Oesau bdf1a8271d region vectors are now moved into the OutputIterator instead of copied
added an alternative detect method that only fills internal data structures
2023-03-08 14:18:45 +01:00
Sven Oesau 7c69d0f491 typo 2023-03-08 14:16:59 +01:00
Sébastien Loriot 33c868818f fix property map for region primitives 2023-03-07 17:55:28 +01:00
Sébastien Loriot 33227d5396 recover plane normals from the primitives 2023-03-07 13:20:32 +01:00
Sébastien Loriot afb88fb459 add max distance in the demo plugin 2023-03-03 09:35:54 +01:00
Sébastien Loriot 648377f127 fix np name + plug region growing in decimation plugin + change cosinus sign in decimate + update doc 2023-03-02 19:08:10 +01:00
Sébastien Loriot bdf6714b4c add missing type 2023-02-23 09:46:46 +01:00
Sébastien Loriot 99de3fdefc remove pipo 2023-02-16 17:58:41 +01:00
Sébastien Loriot 31f5ce1f6a fix PMP code 2023-02-16 17:28:12 +01:00
Sébastien Loriot 9362ff1ee8 typo 2023-02-16 14:54:52 +01:00
Sébastien Loriot 640910288b Merge remote-tracking branch 'cgal/master' into Region_growing-revision-soesau 2023-02-16 14:18:17 +01:00
Sébastien Loriot 36deff06d5 add the possibility to use an external region map 2023-02-16 14:01:01 +01:00
Sébastien Loriot 0fc0c8eefc explicit NP type 2023-02-16 11:30:49 +01:00
Sébastien Loriot c1165a79aa rename named parameter 2023-02-16 11:25:23 +01:00
Sébastien Loriot 05d6e2ede9 more changes from review 2023-02-16 10:58:52 +01:00
Sebastien Loriot 2ccaee0d8a
Code review from Mael
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2023-02-16 10:35:17 +01:00
Sébastien Loriot 92309aac3e fix typo 2023-02-09 15:00:20 +01:00
Sébastien Loriot 31827e15af typo and compilation issues after renaming 2023-02-07 15:38:02 +01:00