Commit Graph

4600 Commits

Author SHA1 Message Date
Andreas Fabri c716539b2a CGAL: Do not include basic.h in examples 2025-02-23 08:25:11 +00:00
Sebastien Loriot 8c8618ad04
Remove check doc todos (#8738)
We can consider them as done now
2025-02-19 07:13:33 +01:00
Sébastien Loriot 66965f3a07 remove todo 2025-02-14 11:03:32 +01:00
Laurent Rineau e19e5b7025 do not require `Boost_FOUND` 2025-02-11 15:36:44 +01:00
Laurent Rineau 8eefb7f173 Merge branch 'master' into pr/lrineau/8273 2025-02-07 16:10:52 +01:00
Laurent Rineau e5001d1a50 update our CMake version 3.18...3.31
That will suppress the warnings about `CMP0167` (from CMake 3.30):

```
CMake Warning (dev) at cmake/modules/display-third-party-libs-versions.cmake:37 (find_package):
  Policy CMP0167 is not set: The FindBoost module is removed.  Run "cmake
  --help-policy CMP0167" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.
```
2025-02-04 14:32:37 +01:00
Sébastien Loriot b19515e1f8 Merge remote-tracking branch 'cgal/6.0.x-branch' 2025-01-24 08:09:18 +01:00
Sébastien Loriot 7720caa9dc Merge remote-tracking branch 'cgal/5.6.x-branch' into HEAD 2025-01-24 08:08:33 +01:00
Sébastien Loriot d8106aab4b we now use ctest for testing + extra clean up 2025-01-22 11:42:50 +01:00
Sebastien Loriot 76321c4be1
Aos 2 fixes efif (#8666)
## Fixed the Landmark point-location strategy of the Aos_2 package, so
that it can be applied to arrangements on a sphere.

The title says it all.
I slightly changed one paragraph in the user manual. 
Here is the new version:

The arrangement attached to the landmark strategy must be either (i) an
instance of the `Arrangement_2]<Geom,Dcel>` class template, where the
`Traits` parameter is substituted by a geometry-traits class that models
the `ArrangementLandmarkTraits_2` concept, or (ii) an instance of the
`Arrangement_on_surface_2<GeomTraits,TopolTraits>` class template, where
the `GeometryTraits` is similarly substituted; see Section The Landmark
Concept for details about this concept.

## Release Management

* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): NA
* Feature/Small Feature (if any): NA
* Link to compiled documentation: Changed one paragraph; see above.
* License and copyright ownership: TAU
2025-01-20 10:05:42 +01:00
Efi Fogel f6b935401e Further pacify msvc; replaced auto with actual type (Inner_ccb_const_iterator) 2025-01-16 19:05:22 +02:00
Laurent Rineau d4e6ffddf4 fix protection against min/max macros
The regular expression I used was:

```
((?!(?:^.*(\/\/|\/\*).*|^ *\* .*|^[^"]*"(?:"[^"]*"|[^"])*))^(?:.*[ ,\(]|))(\b(?:(?:[A-Za-z]+::)*)(?:max|min))\b *\(
```
2025-01-14 16:12:34 +01:00
Efi Fogel de7c24ad03 Pacify msvc; replaced auto with actual type (Isolated_vertex_const_iterator) 2025-01-09 20:34:12 +02:00
Efi Fogel df1179889c Made the Base type public and fixed the Approximate_2 operator that operates on x-monotone curves 2024-12-30 00:57:16 +02:00
albert-github 18de530a00 Add missing closing grouping commands
For consistency also updated Arrangement_on_surface_2/include/CGAL/Arr_conic_traits_2.h
2024-12-26 11:06:24 +01:00
albert-github aaa6adb7c1 In a number of cases the command `@{` (or `\{`) is not closed by a corresponding closing command (`@}`). For the `\=name` command this is apparently not necessary but it is better to have corresponding open and close commands.
(also corrected a split in a line that I noticed in Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Arr_conic_traits_2.h)
2024-12-25 15:09:57 +01:00
Efi Fogel 604bac4dad Activate the landmark point-location 2024-12-18 17:25:26 +02:00
Efi Fogel 98b1fd8063 Removed erroneous and useless construct 2024-12-18 17:25:02 +02:00
Efi Fogel 52e8d15de2 Enhanced the description of the landmark point-location strategy 2024-12-17 23:12:04 +02:00
Efi Fogel 8570eb2cfa Merge branch 'master' into Aos_2-fixes-efif 2024-12-17 21:48:30 +02:00
Sebastien Loriot 68705288b0
LaTeX compliance for formulas and errors in bibliography (#8636)
Correction of incorrect usage of LaTeX in formulas and bibliography
altough MatHJax and bibtex.pl doesn't always signal it.
- Incorrect biblio entry (missing `,` and `}`)
  - Documentation/doc/biblio/geom.bib
- `&nbsp` is not correct LaTeX has to be `~`
-
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt
  - Documentation/doc/Documentation/Developer_manual/Chapter_intro.txt
- Incorrect formula regarding usage of `\left` and `\right` (also
signaled by MathJax
-
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt
- `DeclareMathOperator` is a command that should be in the preamble,
alternatively the command `\operatorname` can be used explicitly (as
done here as it is only used once)
-
Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/Kinetic_surface_reconstruction.txt
- Latex has problems with `_` in a `text...` command so it should be
escaped though this gives problems with MathJax hence the extra hook.
MathJax reference:
https://groups.google.com/g/mathjax-users/c/wSh6-hSIUpQ/m/KmzZhQQGslgJ
  - Documentation/doc/resources/1.10.0/CGAL_mathjax.js
  - Documentation/doc/resources/1.8.13/CGAL_mathjax.js
  - Documentation/doc/resources/1.9.6/CGAL_mathjax.js
  - Weights/include/CGAL/Weights/authalic_weights.h
2024-12-10 16:28:03 +01:00
albert-github ad4c681782 Spelling correction
Spelling correction
2024-12-04 14:19:02 +01:00
Sebastien Loriot ca8898c156
Aos 2 metadata traits decorators efif (#8592)
## Summary of Changes

Introduces two traits decorators, namely `Arr_tracing_traits_2` and
`Arr_counting_traits_2`, which can be used to extract debugging and
informative metadata about the traits in use while the program is being
executed. They have been part of the CGAL distribution for several years
now . (Probably more than a decade.) I gave it a face lift, wrote the
necessary documentation, and added a small example program called
count_and_trace.cpp.

## Release Management

* Affected package(s): 2D Arrangements (Arrangement_on_surface_2)
* Issue(s) solved (if any): NA
* Feature/Small Feature (if any): Aos 2 Metadata Traits Decorators --
**Pre-approval date 2024/11/12**
* Link to compiled documentation (obligatory for small feature)
[Manual](https://www.cs.tau.ac.il/~efif/doc_output9/Arrangement_on_surface_2/)
* License and copyright ownership: TAU
2024-12-04 14:06:12 +01:00
Sebastien Loriot de60668b83
typo 2024-12-04 13:56:39 +01:00
albert-github 5c98f77ba2 LaTeX compliance for formulas and errors in bibliography
Correction of incorrect usage of LaTeX  in formulas and bibliography altough MatHJax and bibtex.pl doesn't always signal it.
- Incorrect biblio entry (missing `,` and `}`)
  - Documentation/doc/biblio/geom.bib
- `&nbsp` is not correct LaTex has to be `~`
  - Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt
  - Documentation/doc/Documentation/Developer_manual/Chapter_intro.txt
- Incorrect formula regarding usage of `\left` and `\right` (also signaled by MathJax
  - Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt
- `DeclareMathOperator` is a command that should be in the preamble, alternatively the command `\operatorname` can be used explicitly (as done here as it is only used once)
  - Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/Kinetic_surface_reconstruction.txt
- Latex has problems with `_` in a `text...` command so it should be escaped though this gives problems with MathJax hence the extra hook.
  MathJax reference: https://groups.google.com/g/mathjax-users/c/wSh6-hSIUpQ/m/KmzZhQQGslgJ
  - Documentation/doc/resources/1.10.0/CGAL_mathjax.js
  - Documentation/doc/resources/1.8.13/CGAL_mathjax.js
  - Documentation/doc/resources/1.9.6/CGAL_mathjax.js
  - Weights/include/CGAL/Weights/authalic_weights.h
2024-12-02 14:58:15 +01:00
Laurent Rineau 2b0c79e85a update reuse to v5 2024-11-26 10:14:17 +01:00
Efi Fogel 54a05c2a1f Fixed for arrangement on sphere; cleaned up. 2024-11-16 22:12:56 +02:00
Efi Fogel 8e5b107abc Specifically used "unsigned long long" to store the flags. 2024-11-14 12:08:46 +02:00
Efi Fogel ddeaeb497a Cleaned up 2024-11-13 18:35:18 +02:00
Efi Fogel 462532edab Fixed tense on manual of functions 2024-11-13 03:51:10 +02:00
Efi Fogel 85667b524d Fixed typo 2024-11-13 03:25:54 +02:00
Efi Fogel 7819ffa00b Merge branch 'Aos_2-metadata_traits_decorators-efif' of github.com:efifogel/cgal into Aos_2-metadata_traits_decorators-efif 2024-11-12 15:31:11 +02:00
Efi Fogel f9213fafdd Basic fixes 2024-11-12 15:30:50 +02:00
Sébastien Loriot 982ca628e2 remove tabs 2024-11-12 13:57:53 +01:00
Efi Fogel 661b7185f1 Fixed comments: added code-escape and latex-escape symbols. 2024-11-10 12:31:22 +02:00
Efi Fogel bb16c9b1e8 Fixed typos (pointed out by Sebstien) 2024-11-07 19:21:40 +02:00
Efi Fogel 5a672aadbc Fixed return type 2024-11-06 17:29:21 +02:00
Efi Fogel c9f343eb50 Merge branch 'master' into Aos_2-metadata_traits_decorators-efif 2024-11-06 17:29:09 +02:00
Sébastien Loriot 3d2d1782cd Merge remote-tracking branch 'cgal/6.0.x-branch' 2024-11-05 17:09:53 +01:00
Sebastien Loriot 317700680e
Fixed the code that computes intersection (#8525)
Fixed the code that computes intersections in the polycurve traits
(Arr_polycurve_traits_2).

## Summary of Changes

The code of the Intersection_2 functor was developed from scratch.
The old code only supported polylines (by mistake), that is, chains of
segments.
The new code supports intersections of chains of any type of sub-curves.
It turns out that the new code is ~15% more efficient.
While at it, I replaced 'typedef' statements with modern 'using'
statements.

## Release Management

Apparently, there is no "CHANGES.md" file yet for 6.1, so I'll add an
entry that informs about this fix after it is introduced (to 'master'
and 'master' is merged to this branch.)

* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): fix #8468
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership: TAU
2024-11-05 17:09:09 +01:00
Sebastien Loriot 1690619625
CGAL: Modernize CMakeLists.txt (#8528)
## Summary of Changes

- Changed `PUBLIC` to `PRIVATE`  in the `target_link_libraries()`
- ~~Link against `Boost::<COMPONENT>`~~ as we do more than just linking
and must use the `CGAL::_.._support`
- Use `target_compile_definitions()` and `add_compile_definitions()`

More to be done.

## Release Management

* Affected package(s): all
* Issue(s) solved (if any): fix one item of  #4815
* License and copyright ownership: unchanged
2024-10-31 10:32:25 +01:00
Sébastien Loriot fb605cdd39 remove -D that is not compatible with "older" cmake versions 2024-10-22 08:19:49 +02:00
Sébastien Loriot b10841c72b Merge pull request #8532 from afabri/CGAL-duplicateLines-GF
Duplicate Lines
2024-10-21 19:18:02 +02:00
Sébastien Loriot 7c4badc67c Merge pull request #8501 from afabri/CGAL-assert-GF
assert() ->  CGAL::assertion()
2024-10-21 19:17:21 +02:00
Sébastien Loriot ba70570ba4 Merge pull request #8492 from afabri/AoS-mix_pre_post_conditions-GF
Arrangements:  Unify mix of pre and post condition macros
2024-10-21 19:15:57 +02:00
Laurent Rineau fb2a9eac90 Merge remote-tracking branch 'cgal/master' into pr/afabri/8528 2024-10-21 16:32:51 +02:00
Sébastien Loriot 1937666efe Merge pull request #8477 from efifogel/Aos_2-polygeodesic-efif
Poly-geodesic arc Handling
2024-10-18 18:01:20 +02:00
Laurent Rineau 96cd3e6f09 Merge remote-tracking branch 'cgal/master' into pr/afabri/8528 2024-10-17 00:25:24 +02:00
Sebastien Loriot ef659a464b
fix typo
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2024-10-15 09:29:48 +02:00
Andreas Fabri 2e4cff1586 Change _check_pt_arcno_and_coprimality(q, -1, c); 2024-10-09 17:17:26 +01:00