5e2fbcf707
Merge pull request #8691 from lrineau/CGAL-Github-use-ubuntu-22.04-GF
...
FOR 5.6.x ONLY: use ubuntu-22.04 as Github runner
2025-01-17 18:47:28 +01:00
fe88db2bb3
workaround issue with file command
2025-01-17 18:46:13 +01:00
ea22cc086f
Use the same generator for reproducible runs ( #8683 )
...
Ref:
```
------------------------------------------------------------------
- Tetrahedral_remeshing/ProgramOutput.execution of test_tetrahedral_remeshing_of_one_subdomain
------------------------------------------------------------------
CGAL::Random()::get_seed() = 1736397916
CGAL Random seed = 1736397916
valid data structure
valid triangulation
Tetrahedral remeshing (nb_iter = 1, protect = false)
Init tetrahedral remeshing...done.
# Iteration 1 #
Split long edges... done (2449 splits, in 0.0591981 sec).
Collapse short edges... done (0 collapses, in 0.077903 seconds).
Flip edges...
Flip edges... done (83/2946 surface/volume flips done, in 0.336761 seconds).
Smooth vertices... done (0/760/1915 vertices smoothed, average move = 0.083582, in 0.128201 seconds).
# Iteration 1 done : 3449 vertices #
Flip edges...
Flip edges... done (32/2958 surface/volume flips done, in 0.318584 seconds).
Smooth vertices... done (0/415/1307 vertices smoothed, average move = 0.0443012, in 0.153528 seconds).
# Iteration 2 (flip and smooth only) done : 3449 vertices #
Flip edges...
Flip edges... done (19/2333 surface/volume flips done, in 0.297889 seconds).
Smooth vertices...CGAL error: assertion violation!
Expression :
File : /Users/geometryfactory/CGAL/testsuite/CGAL-6.1-Ic-59/include/CGAL/Intersections_3/internal/Ray_3_Triangle_3_intersection.h
Line : 382
Explanation:
Refer to the bug-reporting instructions at https://www.cgal.org/bug_report.html
libc++abi: terminating due to uncaught exception of type CGAL::Assertion_exception: CGAL ERROR: assertion violation!
File: /Users/geometryfactory/CGAL/testsuite/CGAL-6.1-Ic-59/include/CGAL/Intersections_3/internal/Ray_3_Triangle_3_intersection.h
Line: 382
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-59/Tetrahedral_remeshing/TestReport_monet_macOS-x86_64-core_boost_backend.gz
2025-01-17 18:37:33 +01:00
026700f989
PMP::isotropic_remeshing() - Fix removal of boundary degenerate faces ( #8685 )
...
## Summary of Changes
update status of border edges when removing a (degenerate) border face
## Release Management
* Affected package(s): PMP
* License and copyright ownership: unchanged
2025-01-17 18:36:58 +01:00
3b5be6693f
Merge remote-tracking branch 'cgal/master' into HEAD
2025-01-17 17:51:28 +01:00
679cd8cd23
workaround issue with file command
2025-01-17 17:15:49 +01:00
bc64faaab3
Laurent's review
2025-01-17 16:22:24 +01:00
796a7bd066
more types
2025-01-17 15:09:38 +01:00
7cf6793117
issue #8689 Regression documentation build
...
- compare doxygen version with the available directories on disk and (try to) use the most appropriate one
- give a warning when there are more directories than expected (already present), though `FATAL` should probably be `FATAL_ERROR` though the latest will give problems when adding a new version to the directory list for testing. Changed the message to a `WARNING`
2025-01-17 10:31:54 +01:00
72520db3a8
Use std::optional::reset
...
Co-authored-by: Anirudh Lakhanpal <91114837+SharonIV0x86@users.noreply.github.com>
2025-01-17 09:15:36 +01:00
f6b935401e
Further pacify msvc; replaced auto with actual type (Inner_ccb_const_iterator)
2025-01-16 19:05:22 +02:00
cf815b823f
doc fix: add that iterators are all bidirectional
2025-01-16 14:14:38 +01:00
cf50ad8b13
document the breakng change
2025-01-16 13:47:33 +01:00
e1b7c4726e
Replace boost::optional with std::optional
...
See https://github.com/CGAL/cgal/pull/7526
2025-01-16 13:45:12 +01:00
8fe8a8c904
Fix compilation of traverser benchmark
2025-01-16 11:03:06 +01:00
2869ad810b
fix compilation errors with C++<20
2025-01-15 19:08:01 +01:00
2a93bed377
Merge branch 'SLS-API_fixes-GF' into SLS-API_fixes-6.0.x-GF
2025-01-15 17:44:58 +01:00
d5d01a4d32
refactor: remove duplicate header file inclusion
2025-01-15 23:34:10 +08:00
170952b927
FOR 5.6.x ONLY: use ubuntu-22.04 as Github runner
...
`ubuntu-latest` was recently turned from 22.04 to 24.04. And 5.6.x is
not ready for that.
See the run
https://github.com/CGAL/cgal/actions/runs/12787411585/job/35648286539?pr=8688#step:3:46
DO NOT MERGE INTO `6.0.x` or `master`.
2025-01-15 14:35:28 +01:00
22dd382e26
Do not use c++17 in 5.6.x
2025-01-15 12:31:25 +01:00
155be97d4a
Merge branch 'SLS-API_fixes-GF' into SLS-API_fixes-6.0.x-GF
2025-01-15 12:28:32 +01:00
92e31b7859
Misc tiny fixes
2025-01-15 11:55:50 +01:00
baeed4a77f
Add more tests
2025-01-15 11:55:07 +01:00
56a6053b94
Don't use C++17 yet
2025-01-15 01:02:37 +01:00
46ab7efe83
Add missing default
2025-01-15 01:02:25 +01:00
d4e6ffddf4
fix protection against min/max macros
...
The regular expression I used was:
```
((?!(?:^.*(\/\/|\/\*).*|^ *\* .*|^[^"]*"(?:"[^"]*"|[^"])*))^(?:.*[ ,\(]|))(\b(?:(?:[A-Za-z]+::)*)(?:max|min))\b *\(
```
2025-01-14 16:12:34 +01:00
13e8428cae
Add a lot of API tests for non-weighted skeletons
2025-01-14 15:32:04 +01:00
97bde2a8b3
Clarify type
2025-01-14 15:31:38 +01:00
4d62746395
Fix typo
2025-01-14 15:12:50 +01:00
595ad9f883
Fix using wrong types when converting the offset value
2025-01-14 15:11:32 +01:00
2f7db1db74
Consistency between doc & code, use OutPolygon if provided, factorize code
2025-01-14 15:10:23 +01:00
06e970d886
Move towards honoring the concepts
2025-01-14 15:07:02 +01:00
60e5e1570c
Fix compilation
2025-01-14 15:04:01 +01:00
56c0696476
Add an alias for deduced (or not) return types
2025-01-14 15:03:18 +01:00
59e1ca53ac
Clarify comment
2025-01-14 15:02:28 +01:00
0ed7e3041b
Various fixes in the documentation of template parameters
2025-01-14 15:02:00 +01:00
1f70e59210
doc bug-fix
2025-01-14 14:11:08 +01:00
b76596a450
Fix wrong parameter order in documentation
2025-01-14 00:15:08 +01:00
aac8c49956
Remove extra parentheses
2025-01-14 00:14:53 +01:00
dd86cd1f60
Fix doc group
2025-01-14 00:13:59 +01:00
2805eec7bf
Add missing backticks
2025-01-14 00:12:39 +01:00
766040a0a8
Fix wrong tparam name
...
How was there no doxygen warning?...
2025-01-14 00:09:34 +01:00
eafa97a862
major cleanup of Polyline_constraint_hierarchy_2
...
- remove all mentions of `Edge` and `Constraint`
- `Subconstraint_iterator` is renamed `Subconstraint_and_contexts_iterator` (because of its value type)
- a new `Subconstraint_iterator`, with value type `Subconstraint`
- a few unused/untested and uncompilable functions are removed from the code
- a lot of internal renamings
== Breaking changes ==
For `Constrained_triangulation_plus_2`, there are a few breaking changes...
- The value type of `subconstraints_begin()`, `subconstraints_end()`, of the range `subconstraints()` has changed to `Subconstraint` (a simple `std::pair` of vertex handles). That is actually a kind of bug-fix, because it was documented as such in the user manual.
- The new member functions `subconstraints_and_contexts_begin()`, `subconstraints_and_contexts_end()`, `subconstraints_and_contexts()` are created get the old value type (`std::pair<const Subconstraint, std::list<Context>*>`).
- A few range types have changed from `CGAL::Iterator_range<It>` to `unspecified_type`, for efficiency reasons.
- Doc fixes.
== Determinism ==
Even if it was not documented, the range `subconstraints()` is deterministic (used by Mesh_2), and `subconstraints_and_contexts()` is not.
2025-01-13 17:06:58 +01:00
926bb0cf89
hierarchy: remove two undefined member functions
2025-01-13 11:36:05 +01:00
d468962663
hierarchy: remove `remove_Steiner(T v, T va, T vb)`
...
That code was never used nor tested, and cannot compile anyway.
2025-01-13 11:36:05 +01:00
93ac1845fa
CDT_plus_2 hierarchy: add Edge_iterator, that is deterministic
...
That uses Boost.STLInterfaces from Boost >= 1.74.
2025-01-13 11:36:05 +01:00
e03ba91f54
Boost >= 1.74 is now required
2025-01-13 11:36:05 +01:00
56bb4191ed
cleanup existing code
2025-01-13 11:24:30 +01:00
e5807ca048
TWS
2025-01-10 14:45:51 +01:00
8e0ebb9a39
update status of border edges when removing a (degenerate) border face
2025-01-10 13:42:33 +00:00
Sébastien Loriot
Jane Tournois
albert-github
Mael
Efi Fogel
Laurent Rineau
zfb132
Jane Tournois