Commit Graph

105359 Commits

Author SHA1 Message Date
Andreas Fabri 965d4fd48d WIP: When we delete a face we have to transfer its isolated vertices 2023-08-22 17:01:46 +01:00
Andreas Fabri e7198a0d65 Add test case that triggers an assertion 2023-08-22 15:08:42 +01:00
Andreas Fabri 7e50a90a4c Check #isolated vertices 2023-08-22 13:59:44 +01:00
Efi Fogel aba2d147f8 Merge remote-tracking branch 'cgal/master' into Aos_2-fixes-efif 2023-08-22 13:41:57 +03:00
Andreas Fabri 7f1d36c514 More fixes 2023-08-22 10:34:51 +01:00
Andreas Fabri c11711e728 More fixes 2023-08-22 10:29:04 +01:00
Andreas Fabri 55ea7ba7ec More fixes 2023-08-22 10:21:46 +01:00
Andreas Fabri 6f4804fd1e More fixes 2023-08-22 10:02:18 +01:00
Andreas Fabri b48ef206d9 Arrangement: small doc fixes 2023-08-22 09:11:09 +01:00
Sebastien Loriot f879c68155
Test earlier
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2023-08-21 11:32:12 +02:00
Efi Fogel 3b84bd05f8 Reported the fix in PR #7644 2023-08-18 13:45:53 +03:00
Efi Fogel 51fc8aa18d Removed unused variable 2023-08-18 13:38:34 +03:00
Efi Fogel de459faa76 Fixed the Approximate_2::operator() that returns a sequence of points that approximate a curve; in particular, respected the l2r parameter. 2023-08-18 13:35:00 +03:00
Efi Fogel 7b00717eab Fixed comment 2023-08-18 12:49:32 +03:00
albert-github 93001308f4 Merge branch 'master' into feature/issue_7395
# Conflicts:
#	Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrangementPointLocation_2.h
#	Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrangementVerticalRayShoot_2.h
2023-08-18 11:10:42 +02:00
Sebastien Loriot b2be6dbbef fix istream for optional
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2023-08-18 09:35:45 +02:00
Sebastien Loriot 5a962eb198
Using c++17 standard library (#7526)
use std::shared_ptr, std::optional, std::variant, ...

These are important changes since they appear in the CGAL API and thus
are breaking changes.

includes #7416
2023-08-18 09:35:22 +02:00
Sébastien Loriot 5cc58a4080 don't do collinear test for a triangle to be collapsed 2023-08-17 15:02:48 +02:00
Sébastien Loriot 73cf624d0f be more permessive
do not throw an error but return SMALLER
The collinearity check being already do in the predicate it
would be more expensive to do it also before calling the
predicate
2023-08-16 09:59:44 +02:00
Sébastien Loriot d6c04e3b8a do not use ref wrapper 2023-08-16 09:17:58 +02:00
Sébastien Loriot f1f6126f1c add missing IO namespace 2023-08-16 09:11:30 +02:00
Sébastien Loriot d8a6478b57 remove another use of deprecated API 2023-08-16 09:02:28 +02:00
Sébastien Loriot 28f904f4e2 Merge remote-tracking branch 'cgal/master' 2023-08-15 07:16:14 +02:00
Sébastien Loriot eada3ee8ca Merge branch 'master' into 'sloriot/CGAL-using_c++17_stl' 2023-08-14 14:19:25 +02:00
Sebastien Loriot b534d12620
Locate.h: Use Face_location / Barycentric_coordinates everywhere (#7638)
## Release Management

* Affected package(s): `PMP`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2023-08-14 14:11:02 +02:00
Sébastien Loriot ed71cfdaa0 Merge pull request #7445 from afabri/Mesh_3-doc_fixes-GF
Mesh_3: Improvements of the Documentation
2023-08-14 14:06:16 +02:00
Sébastien Loriot 5db243629a try working around an error with MSVC2017
`error C2338: Sorry: std::any doesn't support over-aligned types at this time.`
2023-08-14 14:02:39 +02:00
Sebastien Loriot 65764b5c6f
Minor improvements to the documentation of `PMP::orient_polygon_soup()` (#7639)
## Release Management

* Affected package(s): `PMP`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2023-08-14 12:00:31 +02:00
Sebastien Loriot 464930ec2b
Fix connect infinite loop in heat method plugin (#7605)
## Summary of Changes

The proper fixes would be to prevent the "reset colors" and the creation
of a selection item from emitting "item changed": in neither case the
item changed. Future work...

## Release Management

* Affected package(s): `Polyhedron`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2023-08-14 11:58:26 +02:00
Sebastien Loriot bdbba81ea9
Spelling corrections (#7624)
Spelling corrections `a e...` -> `an e...`
2023-08-14 11:57:58 +02:00
Sebastien Loriot c5cf3d9915
Edge insertion for CMap/GMap (#7409)
_Please use the following template to help us managing pull requests._

## Summary of Changes

Added the function `insert_cell_1_between_two_cells_2()` into
`GenericMap` concept, which allows users to insert an edge between two
different faces allowing to create faces with holes.

## Release Management

* Affected package(s): CMap/GMap
* Feature/Small Feature (if any):
https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Insert_edge_CMap/GMap
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership:
2023-08-14 11:55:26 +02:00
Sébastien Loriot 44e143e931 Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/master' 2023-08-14 11:54:13 +02:00
Sebastien Loriot d0b188bf41
patch to support PowerPC and Windows 32 bits (#7635)
## Summary of Changes

Patch required for the acceptance of CGAL-5.6 in vcpkg. The CI system
tests on `x86_windows` (32 bits), and there was an error:
```
D:\installed\x86-windows\include\CGAL/cpp_float.h(30): error C3861: '_BitScanForward64': identifier not found
D:\installed\x86-windows\include\CGAL/cpp_float.h(42): error C3861: '_BitScanReverse64': identifier not found
```
See
https://github.com/microsoft/vcpkg/pull/32896#issuecomment-1662117705

The solution is do disable support for Boost MP on Windows 32 bits. That
patch has been tested with the vcpkg CI, and it worked.

## Release Management

* Affected package(s): Number_types
* Issue(s) solved (if any): patch required by
https://github.com/microsoft/vcpkg/pull/32896
2023-08-14 11:53:29 +02:00
Sebastien Loriot 2f3588b156
Add `CGAL/version_checker.h` (#7528)
## Summary of Changes

Following discussion #7525 I added the header `version_enforcer.h`

In the general case, it has nothing to check. If the user includes his
own fork of `version_enforcer.h` with a given number of CGAL version,
then the check happens.

## Release Management

* Affected package(s): Installation
2023-08-14 11:50:58 +02:00
Sébastien Loriot db9b8e70b3 Merge remote-tracking branch 'cgal/5.5.x-branch' into 'cgal/5.6.x-branch' 2023-08-14 10:22:35 +02:00
Sebastien Loriot c5902cbcd4
reproject barycenter to avoid boundary shrinking (#7633)
Fixes #7631
2023-08-14 10:21:45 +02:00
Sebastien Loriot 0a11c725b5
Apollonius_graph: Fix return type in the documentation (#7619)
## Summary of Changes

Fix the return type. Document the third template parameter of
`Apollonius_graph_vertex_base_2`.

## Release Management

* Affected package(s): `Apollonius_graph_2`
* Issue(s) solved (if any): fix #7582 and #7579
* Link to compiled documentation:
[link](https://cgal.github.io/7619/v0/Apollonius_graph_2/classCGAL_1_1Apollonius__graph__2.html#a6e6e1b20ab5018c96e4b0ed2c0f0ee00)
and [here
](https://cgal.github.io/7619/v0/Apollonius_graph_2/classCGAL_1_1Apollonius__graph__vertex__base__2.html#acbabb6d26d4d8938bde5bbd6c6e467eb)for
the vertex base.
* License and copyright ownership:  unchanged
2023-08-14 10:21:28 +02:00
albert-github 0ce82c0bd5 Better showing of `#include`
Getting a better (and consistent) output for the include file to be used with some functions.
Normally `#include` are sown as in a typewrite font, but the `#include` in these cases were shown in a code block way.
2023-08-13 18:22:07 +02:00
Efi Fogel 0762a30400 Fixed is_intersection_valid_impl() and added test case 2023-08-10 21:38:52 +03:00
Sébastien Loriot 2549f47191 fix other warnings 2023-08-10 17:29:28 +02:00
Efi Fogel ada39fdfae Cleaned up and dispatched is_intersection_valid_impl() properly 2023-08-09 19:10:16 +03:00
Efi Fogel afa58a9426 Cleaned up 2023-08-09 17:46:35 +03:00
Efi Fogel 46c4246570 Cleaned up 2023-08-09 17:37:01 +03:00
Efi Fogel a9625eb17c Enhanced drawing---added support for arrangement on spheres indiced by geodesic arcs 2023-08-09 14:03:14 +03:00
Efi Fogel 6b62d1d9b4 Introduced is_intersection_valid() to check the validity of a new intersection point. Perhaps, a similar fix is required for validity of overlapping intersections 2023-08-09 10:48:54 +03:00
Sébastien Loriot 71347f28a8 remove unused variable 2023-08-09 09:00:38 +02:00
Sébastien Loriot 99066b4363 hide unused type 2023-08-09 08:59:26 +02:00
Sébastien Loriot b7cebad9d3 do not use deprecated API 2023-08-09 08:56:50 +02:00
Sébastien Loriot 10c1796c2a fix unused variable warnings 2023-08-09 08:49:42 +02:00
Sébastien Loriot 6b24eed462 try resolving ambiguity 2023-08-09 08:46:34 +02:00