I just needed to added a constructor where the approximate predicates and exact
one needed to be provided (which is reasonable and cannot hurts thanks to the
explicit)
Wextra results in a dreadful wall of yellow in the test-suite and is
scary when using CGAL. Reduce some of the noise by silencing the
obvious cases with CGAL_USE or comments.
-Wunused-local-typedefs is a new warning flag of gcc-4.7, and it will enabled
by -Wall since gcc-4.8 (not yet released).
The fix is a big set of removals of unused typedefs (or comments, or moves,
depending on the context).
This seems required. At least the Intel Compiler version 12 gives a set of errors
(not even warnings!). Here is one of them:
/home/lrineau/CGAL/CGAL-4.0-Ic-248/include/CGAL/Periodic_3_triangulation_ds_cell_base_3.h:192:29: error: non-constant-expression cannot be narrowed from type 'int' to 'unsigned int' in initializer list
unsigned int off0[3] = {(o0>>2)&1,(o0>>1)&1,(o0&1)};
^~~~~~~~~
/home/lrineau/CGAL/CGAL-4.0-Ic-248/include/CGAL/Periodic_3_triangulation_ds_cell_base_3.h:192:29: note: override this message by inserting an explicit cast
unsigned int off0[3] = {(o0>>2)&1,(o0>>1)&1,(o0&1)};
^~~~~~~~~
static_ca)t<unsigned int>(
| ------------------------------------------------------------------------
| r58079 | mcaroli | 2010-08-15 20:28:30 +0200 (Sun, 15 Aug 2010) | 2 lines
| Changed paths:
| M /trunk/Periodic_3_triangulation_3/include/CGAL/Periodic_3_triangulation_traits_3.h
|
| minor fix
|
| ------------------------------------------------------------------------
The issue is that Periodic_3_triangulation_traits_3<K> needs to be
specialized for Filtered_kernel, but
CGAL::Exact_predicates_inexact_constructions_kernel is no longer a typedef
for Filtered_kernel<Simple_cartesian<double> >: it is now a class
CGAL::Epick, equivalent to Filtered_kernel<...>.
The solution is to partially specialize
Periodic_3_triangulation_traits_3<K> for CGAL::Epick too. But, for that, I
needed to make Periodic_3_triangulation_filtered_traits_base_3 have a
second template parameter Offset, like Periodic_3_triangulation_traits_3<K>
(Offset has a default value), to avoid an instantiation loop.
The revision 58079 above was just a patch that showed that
Periodic_3_triangulation_filtered_traits_base_3 was no longer used with the
EPIC kernel.
by namespace CGAL { and } //namespace CGAL. in all .h and .cpp files
in a directory.
Apply it to all packages in the trunk
Remove macro definition from the config.h file.
Laurent Rineau
Sébastien Loriot
Philipp Möller
Philipp Möller
Laurent Rineau
Andreas Fabri
Sébastien Loriot
Manuel Caroli
Mikhail Bogdanov
Sylvain Pion