Commit Graph

1206 Commits

Author SHA1 Message Date
Laurent Rineau 7776720ca9 Merge pull request #1752 from lrineau/Mesh_3-various_fixes_and_improvements-lrineau
Fix the patch from #1524
2016-12-28 16:12:14 +01:00
Laurent Rineau bbf430b0b1 Merge pull request #585 from afabri/Kernel-Weighted_point-GF
Introduce Kernel::Weighted_point_3 together with functors
2016-12-20 19:52:02 +01:00
Laurent Rineau acc9581342 Split angle: from 135° to 90°. 2016-12-07 11:24:28 +01:00
Laurent Rineau 49053ee10b Improve display_corner_incidences()
Now the method also displays the points of corners.
2016-12-07 11:24:28 +01:00
Laurent Rineau 6214312575 For CGAL_MESH_3_PROTECTION_DEBUG 2016-12-07 11:24:28 +01:00
Laurent Rineau 0e59869580 Add a CGAL_error_msg when the sizing is locally zero 2016-11-23 11:59:53 +01:00
Jane Tournois 9187318744 Revert "convert weighted points to bare points when needed"
This reverts commits 19dadd6d58
and 137fe12b6b

We now use Kernel functors instead of Construct_point_3 converters,
because they work with both Point_3 and Weighted_point_3
2016-11-04 15:41:00 +01:00
Jane Tournois 19dadd6d58 convert weighted points to bare points when needed 2016-11-04 12:27:56 +01:00
Jane Tournois 137fe12b6b convert weighted points to bare points 2016-11-03 17:02:34 +01:00
Andreas Fabri 2c7bed8b92 Use ->point(), because a weighted point no longer derives from Point_3 2016-11-03 14:53:54 +01:00
Andreas Fabri ad9d2c369c Rename tests following Olivier's recommendations 2016-11-03 14:53:54 +01:00
Andreas Fabri f488b9baf9 Changes after Laurent's review 2016-11-03 14:53:15 +01:00
Laurent Rineau c0ae994d14 Fix Mesh_3 plugin, from the polyhedron demo 2016-11-03 13:10:00 +01:00
Andreas Fabri 59cedfc7dd Fix Mesh_3 2016-11-03 13:08:31 +01:00
Andreas Fabri 9e94ee6178 Change the Power_test 2016-11-03 13:07:17 +01:00
Andreas Fabri 1375cd5c0a Rename Compute_critical_squared_radius_3 to Compute_power_distance_to_power_sphere_3 2016-11-03 13:07:17 +01:00
Andreas Fabri 95027822f5 move predicates and constructions in Kernel packages 2016-11-03 13:07:17 +01:00
Andreas Fabri 9eca152dca No need for a Weighted_converter 2016-11-03 13:06:02 +01:00
Andreas Fabri be1b2f9231 Do not construct from a string 2016-11-01 11:19:43 +01:00
Laurent Rineau 0eb09e96ba Merge pull request #1611 from MaelRL/Mesh_3-fix_medit_io_redundant_find_calls-GF
Avoid some unnecessary set/map's find() calls in Mesh_3's medit output
2016-10-26 14:39:24 +02:00
Laurent Rineau c6cf01c7f6 Merge pull request #1562 from afabri/Kernel_Compute_dihedral_angle-GF
Add doc of functor class and concept corresponding to dihedral_angle()
2016-10-20 09:48:05 +02:00
Laurent Rineau d43ac6d667 Merge pull request #1586 from janetournois/Mesh_3-protection_deterministic-GF
Mesh_3 : make features protection deterministic again
2016-10-20 09:47:45 +02:00
Laurent Rineau e92075ab0d Deal with implicit fallthrough
That was a bug in the PR #1564. Actually, the code has the right
behavior, but the implicit fallthrough was not intended.
2016-10-17 16:21:19 +02:00
Jane Tournois 6c9da8b572 re-introduce determinism of protection with protecting balls
use vecS instead of setS for vertices, to have a consistent order on the
list of vertices
2016-10-17 14:48:09 +02:00
Laurent Rineau 6be3772654 Fix calls to dihedral_angle() 2016-10-17 14:43:15 +02:00
Laurent Rineau 6a72c4749f Merge pull request #1564 from lrineau/Mesh_3-fix_an_old_bug__issue_1554-lrineau
Fix issue #1554
2016-10-17 10:01:17 +02:00
Andreas Fabri 423242be31 dihedral_angle() -> approximate_dihedral_angle() 2016-10-11 15:35:20 +02:00
Laurent Rineau 0f4661087b Fix issue #1554
Fix a runtime error. The `Intersect_3` functor of
`Robust_intersection_traits_3_new` was ignored cases in the intersection
between a segment and a triangle.

In `ts_intersection`, if one of the extremities of the segment was
coplanar with the triangle, the empty object was always returned.

This bug of mines was introduced in CGAL-4.3 by
56d733b254.

(Fix #1554.)
2016-10-10 18:01:20 +02:00
Laurent Rineau 02b22f216e Fix a compilation error
There was a compilation error if
`CGAL_MESH_3_NO_LONGER_CALLS_DO_INTERSECT_3` was undefined.
2016-10-10 18:01:20 +02:00
Laurent Rineau 7b57c42e51 Merge pull request #1524 from lrineau/Mesh_3-split_graph_into_polylines_determinism-lrineau
Make split_graph_into_polylines deterministic
2016-10-05 15:13:19 +02:00
Laurent Rineau 223c1cf5a4 Merge pull request #1530 from lrineau/Installation-compute_dependencies-GF
Compute and fix packages dependencies
2016-10-05 13:11:04 +02:00
Laurent Rineau 745cdaeba5 Merge pull request #1524 from lrineau/Mesh_3-split_graph_into_polylines_determinism-lrineau
Make split_graph_into_polylines deterministic
2016-10-05 13:03:36 +02:00
Laurent Rineau 7b6addbb55 Merge pull request #1519 from lrineau/Mesh_3-fix_conversion_warnings-lrineau
Mesh_3: fix conversion warnings
2016-10-05 13:03:15 +02:00
Laurent Rineau 1c19028e5b Merge pull request #1267 from maxGimeno/Random_generator-GF
Random generator
2016-10-05 13:02:29 +02:00
Laurent Rineau 31b3ae37f0 Merge pull request #1506 from lrineau/Mesh_3-fix_issue_1501-lrineau
Mesh_3: fix issue #1501 - about degenerate cases in initialization
2016-10-05 13:02:28 +02:00
Laurent Rineau 9ba4132a38 No helper.update_restricted_facets() with dim 2! 2016-10-04 16:15:17 +02:00
Laurent Rineau 12cc3a6cc9 Fix another compilation error
`dihedral_angle` has been moved to the CGAL kernels
2016-10-03 11:37:53 +02:00
Laurent Rineau bc95c778b3 Add missing includes 2016-09-30 15:23:15 +02:00
Andreas Fabri c58582b5ec Add global function dihedral_angle() 2016-09-30 15:23:15 +02:00
Laurent Rineau c22dcd0e2c Missing includes 2016-09-30 15:23:15 +02:00
Andreas Fabri 6caea9384f Fix package Mesh_3: include headers 2016-09-30 15:22:30 +02:00
Laurent Rineau 1391a3ca83 Merge pull request #1506 from lrineau/Mesh_3-fix_issue_1501-lrineau
Mesh_3: fix issue #1501 - about degenerate cases in initialization
2016-09-30 11:04:16 +02:00
Laurent Rineau de3d1f4459 Fix compilation of mesh_3_plugin
... after the last merge commit.
2016-09-30 10:05:59 +02:00
Laurent Rineau e4ae38ae97 Merge pull request #1514 from janetournois/Mesh_3-fix_small_angles_in_input_features-GF
Mesh_3 - deal with sharp angles inside input sharp features
2016-09-29 17:42:31 +02:00
Laurent Rineau 5bd65fba58 Make split_graph_into_polylines deterministic
- There is a new argument, `Less`, that allows to sort the `std::set` of
  vertex descriptors with a deterministic sort functor.

- The header `<CGAL/Mesh_3/polylines_to_protect.h>` defines and use such
  a functor.
2016-09-29 17:41:32 +02:00
Jane Tournois f3ea115db9 check nb of facets in c3t3
the issue is not the dimension of the triangulation,
but the nb of facets that are in the c3t3 after the initialization of features

it is necessary to start the refinement procedure that this nb is > 0
2016-09-29 15:35:03 +02:00
Laurent Rineau 7dbc756d42 Mesh_3: Fix other conversion warnings 2016-09-29 14:39:11 +02:00
Jane Tournois 9c181d7860 Angles < 135 deg (90 in theory) should be counted as terminal vertices,
otherwise protection may fail by refining protecting balls endlessly,
getting closer and closer to the input sharp angle
2016-09-29 10:43:11 +02:00
Laurent Rineau 100a4ceb10 Fix #1501
Even if the `dimension()` of initial triangulation is 3, the initial
c3t3 can be empty, even with a non-empty domain. Let's use more initial
points.
2016-09-28 15:20:37 +02:00
Maxime Gimeno 8469c45336 Enhance Prevent_deref API and use it. 2016-09-28 10:48:07 +02:00