Commit Graph

128 Commits

Author SHA1 Message Date
Sébastien Loriot eada3ee8ca Merge branch 'master' into 'sloriot/CGAL-using_c++17_stl' 2023-08-14 14:19:25 +02:00
Sébastien Loriot 0ecba6b9b9 const& should not be in the get 2023-08-04 14:24:58 +02:00
albert-github 40c7765ffb Spelling corrections
Corrections based on review
2023-07-30 17:54:10 +02:00
Sébastien Loriot b66afab814 Merge remote-tracking branch 'sloriot/CGAL-using_c++17_stl' into HEAD 2023-07-05 11:29:35 +02:00
Sébastien Loriot edc317d771 variant::which() => variant::index() + typos 2023-06-15 10:57:10 +02:00
Sébastien Loriot 9a0bdb5d96 boost::variant ---> std::variant 2023-06-15 10:57:10 +02:00
Sébastien Loriot cf45dd3d5b boost::is_base_of -> std::is_base_of 2023-04-23 22:37:07 +02:00
Sébastien Loriot 99e7f4806a boost::int -> std::int 2023-04-23 18:43:10 +02:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
Andreas Fabri c04dceb71d Merge master 2022-10-14 14:40:58 +01:00
Mael Rouxel-Labbé cf12f90cbf Fix broken is_hyperbolic(face/edge) framework
The previous code tries to handle finite/infinite and hyperbolic/non-hyperbolic
with a single flag, which caused errors to get stuff like finite
but non-hyperbolic edges (see e.g. https://github.com/CGAL/cgal/issues/6869).

In addition, it used tds_data(), which is something that now also
exists in the triangulation_ds_face_base_2 class.

Hence, completely re-implement the hyperbolic stack / query.

 #	../../../../Installation/CHANGES.md.orig
2022-09-26 16:08:43 +02:00
Mael Rouxel-Labbé 145a817cc1 Remove (broken) HDT2::insert(p, lt, li) from documentation
The 'lt' is documented to be HDT2::Locate_type, which is wrong, the function's
signature uses HDT2::DT2::Locate_type, and that's for a precise reason:
HDT2::locate() returns location based on hyperbolic simplicies, and not
the underlying DT2 triangulation. So, one might retrieve "OUTSIDE_CONVEX_HULL"
if a query is on a non-hyperbolic Delaunay face, but a finite underlying DT2
face. In that configuration, it'd break the triangulation to do an insertion
with "OUTSIDE_CONVEX_HULL".

The documentation could be fixed, but it is too dangerous so it's best
to just remove it. (Maybe it should also be simply removed
from the triangulation class.)
2022-09-26 16:07:52 +02:00
Mael Rouxel-Labbé a7eedb0c74 Fix `ensuring_hyperbolic_face_handle` not doing anything (dim > 2 is 'false') 2022-09-26 15:15:35 +02:00
Mael Rouxel-Labbé 25df7a7565 Misc tiny improvements 2022-09-26 15:14:29 +02:00
Mael Rouxel-Labbé 98b6b95054 Fix issues in HDT2::locate():
- Fix not setting up 'li' when landing on a non hyperbolic face but hyperbolic
  edge
- Fix returning Face_handle()s for some EDGE cases
2022-09-26 15:11:38 +02:00
Mael Rouxel-Labbé c2cbac1a3f Remove unused code/typedefs 2022-09-26 14:07:10 +02:00
Mael Rouxel-Labbé 816fb2a1c1 Simply return enums 2022-09-24 23:29:24 +02:00
Mael Rouxel-Labbé a1752b8b27 Misc cleaning 2022-09-24 23:29:03 +02:00
Mael Rouxel-Labbé 94900beec6 Do not return point copies in HT2::point() 2022-09-24 16:48:15 +02:00
Mael Rouxel-Labbé c8e029438b Remove superfluous call to ensure_hyperbolic_face_handle() (insert() does it) 2022-09-24 16:46:07 +02:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Andreas Fabri 440a8dfb7b Fix file name 2022-02-03 08:41:04 +00:00
Andreas Fabri 735752bec9 Do the remaining changes after Laurent's check 2022-02-03 08:02:11 +00:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Mael Rouxel-Labbé 275d73e6c1 Fix missing license include 2020-06-23 19:02:19 +02:00
Mael Rouxel-Labbé e1e2428abe Fix missing _H in guard + missing license include 2020-06-22 13:42:39 +02:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sébastien Loriot 254d60f642 First pass on removing license notice in header for GPL files 2019-10-19 15:23:19 +02:00
Sébastien Loriot 7356421d80 introduce Commercial license SPDX tag 2019-10-19 12:15:19 +02:00
Sébastien Loriot 9bd9c68b83 update LGPL[23]+ and GPL[23]+ SPDX tags
ack -l --no-svg "SPDX-License-Identifier: GPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-3.0+/SPDX-License-Identifier: GPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-3.0+/SPDX-License-Identifier: LGPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: GPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-2.0+/SPDX-License-Identifier: GPL-2.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-2.0+/SPDX-License-Identifier: LGPL-2.0-or-later/"
2019-10-18 21:57:54 +02:00
Andreas Fabri 4581f1b7a8 Morte replacements 2019-06-05 08:39:55 +02:00
Andreas Fabri 9061510d86 Fix Periodic_4_hyperbolic_triangulation_2 2019-03-26 17:44:22 +01:00
Iordan Iordanov 8e1dfa329e Fixes for a few more warnings in the testsuite 2019-01-16 16:46:56 +01:00
Iordan Iordanov 9792b241dd Changes to replace Cartesian<Expr> with EPICK_with_sqrt, plus code cleanup, plus documentation fixes 2019-01-14 18:29:42 +01:00
Iordan Iordanov f84a4b0405 Bugfix for operator= test 2019-01-10 13:57:55 +01:00
Iordan Iordanov 38ec4cf946 A couple of fixes for the hyperbolic vertex circulator; (failed) attempt to fix operator= 2019-01-09 20:41:06 +01:00
Iordan Iordanov 843ce26596 Fixed to hyperbolic vertex circulator (used for 'adjacent_vertices') 2019-01-08 17:24:50 +01:00
Iordan Iordanov c0f0d474a9 Bugfix for 'locate' function 2019-01-08 12:31:02 +01:00
Iordan Iordanov a4a44553b8 Fixed wrong member name in traits class 2019-01-08 08:42:35 +01:00
Mael Rouxel-Labbé 3ba22c866c Minor fixes 2019-01-07 09:42:14 +01:00
Iordan Iordanov e9abcec1df Removed old traits class (moved to branch INRIA/Periodic_2g_hyperbolic_triangulation_2-IIordanov) 2019-01-02 14:01:38 +01:00
Iordan Iordanov 71327aad01 Modified CK traits class to follow the modifs made by Mael; factorized code in the two traits classes 2018-12-30 22:19:18 +01:00
Iordan Iordanov 3e8f19bc7c Changed declaration of Construct_segment_2 object (plus _object() function) 2018-12-30 18:14:25 +01:00
Iordan Iordanov 21b841c9f4 Added new functions point(Vertex_handle) and point(Face_handle, int) 2018-12-30 17:47:29 +01:00
Iordan Iordanov e5eab9fe46 Resolved a few todo's 2018-12-30 17:21:15 +01:00
Iordan Iordanov 3e9ad7ea94 Added missing functions (todo list in documentation) 2018-12-27 20:54:52 +01:00
Mael Rouxel-Labbé 94e9ae9667 Cleaned P4HT2 tests 2018-12-20 10:20:21 +01:00
Mael Rouxel-Labbé 5084e6db5b Fixed Periodic/Weighted triangulation tags 2018-12-20 09:48:07 +01:00
Mael Rouxel-Labbé 0055cb5a0b Added missing functors for in HDTTraits (needed by P4HT2) 2018-12-20 09:29:48 +01:00