Commit Graph

110205 Commits

Author SHA1 Message Date
Laurent Rineau 37f3bcfaab Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3-lrineau 2024-09-09 10:57:33 +02:00
Sebastien Loriot abd0a58338
Installation - update `FindOpenMesh.cmake` (#8332)
## Summary of Changes

This PR updates CGAL's `FindOpenMesh.cmake`, accordingly with the one
provided by OpenMesh 11.0, and introducing the target
`OpenMesh::OpenMesh`

## Release Management

* Affected package(s): Installation
* License and copyright ownership: unchanged
2024-09-06 13:26:41 +02:00
Sebastien Loriot 368d6010cb
Update CHANGES.md (#8457)
Some changes for Mesh 3 are in the wrong place.

_Please use the following template to help us managing pull requests._

## Summary of Changes

_Describe what your pull request changes to CGAL (this can be skipped if
it solves an issue already in the tracker or if it is a Feature or Small
Feature submitted to the CGAL Wiki)._

## Release Management

* Affected package(s):
* Issue(s) solved (if any): fix #0000, fix #0000,...
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership:
2024-09-04 15:29:00 +02:00
Laurent Rineau 7c633af8d5
Document boost mp as a possible gmp replacement (#8438) 2024-09-04 15:21:34 +02:00
Sébastien Loriot 248f648118 do not doc internal variable 2024-09-04 15:11:37 +02:00
Sébastien Loriot 4cf1f4b214 CONFIG options is only needed if a FindXXX.cmake exists 2024-09-04 14:48:07 +02:00
Guillaume Damiand a0276c9d74
Update CHANGES.md
Some changes for Mesh 3 are in the wrong place.
2024-09-04 08:15:02 +02:00
Sebastien Loriot eac5679444
Fix exception double free in Convex decomposition (#8433)
## Summary of Changes

Change the order of delete in External_structure_builder.h to avoid a
double free in the exception case

## Release Management

* Affected package(s): Convex_decomposition_3
* Issue(s) solved (if any): fix #422 
* Feature/Small Feature (if any): bugfix
* License and copyright ownership: Returned to CGAL authors
2024-09-03 18:32:27 +02:00
Sébastien Loriot dc1763a4d4 Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-09-03 17:27:23 +02:00
Sébastien Loriot 3b531094df Merge remote-tracking branch 'cgal/5.5.x-branch' into HEAD 2024-09-03 17:26:18 +02:00
Sebastien Loriot 7425bc4654
Handle nested holes in convex decomposition (#8442)
Fixes #8379
2024-09-03 17:23:28 +02:00
Sebastien Loriot f693844a48
Ridges 3 bug fix doc pougetma (#8440)
## Summary of Changes

Add a rep example/data with 2 off files

## Release Management

Solves issue 8327 
https://github.com/CGAL/cgal/issues/8327
2024-09-03 17:22:58 +02:00
Sebastien Loriot c211a3d1d9
simple fix to remove the segfault with Qt>=6.7 (#8453)
## Summary of Changes

This should fix #8232. I have tested locally. I hope that does not 


## Release Management

* Affected package(s): GraphicsView, Qt6
* Issue(s) solved (if any): fix #8232
* License and copyright ownership: bug fix
2024-09-03 16:21:56 +02:00
Sebastien Loriot 761dab975d
added test for formerly unused OutputIteratorValueType (#8439)
## Summary of Changes

Follow-up of #8155. Added test.

The issue was only merged into master, but it also should have been
applied to cgal5.6

## Release Management

* Affected package(s): Point_set_processing_3 IO
* Issue(s) solved (if any): fix #8163
2024-09-03 16:21:10 +02:00
Sebastien Loriot ce544fbbba
Pass random instance to GeneratorOnObject in Generic_random_point_generator for consistency (#8420)
## Summary of Changes


[sample_triangle_mesh](https://doc.cgal.org/latest/Polygon_mesh_processing/group__PMP__distance__grp.html#ga6307a4504382c46dc3b0e578ca1f7a3b)
was passed a random seed but did not produce stable results.

Pass random instance to GeneratorOnObject in
Generic_random_point_generator for consistency

## Release Management

* Affected package(s): PMP
2024-09-03 16:20:40 +02:00
Laurent Rineau 93dd87c3cc simple fix to remove the segfault with Qt>=6.7 2024-09-02 17:51:06 +02:00
Sebastien Loriot aaede41f81
Spelling corrections (#8451)
Spelling corrections
2024-09-02 13:01:09 +02:00
albert-github 37218301bb Spelling corrections
Spelling corrections
2024-09-02 12:32:30 +02:00
Sébastien Loriot b67bb2529d use assert in test 2024-09-02 09:03:30 +02:00
Sébastien Loriot 24ca2df2b3 do not mention data that does not exist 2024-08-30 15:35:47 +02:00
POUGET Marc ee4dbad0b3 doc fix 2024-08-30 15:34:33 +02:00
Sébastien Loriot abd99b68eb handle nested holes in convex decomposition 2024-08-29 10:10:20 +02:00
Sébastien Loriot 38871d9b12 Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-08-29 09:31:54 +02:00
Sébastien Loriot afb52e937d Merge remote-tracking branch 'cgal/5.5.x-branch' into HEAD 2024-08-29 09:31:12 +02:00
Sébastien Loriot fdd8f7f374 data dir does not exist 2024-08-29 09:08:14 +02:00
Sven Oesau 6917edd697 added test for formerly unused OutputIteratorValueType 2024-08-28 16:16:25 +02:00
Sébastien Loriot af8e134aa6 doc boost mp as gmp replacement 2024-08-28 14:04:57 +02:00
Sébastien Loriot 63d6e6505f backport of https://github.com/CGAL/cgal/pull/7382 2024-08-28 11:58:03 +02:00
Sébastien Loriot 706c5f12ae backport of https://github.com/CGAL/cgal/pull/7499 2024-08-28 11:49:45 +02:00
Laurent Rineau 12f278e431 Merge branch '5.6.x-branch' 2024-08-28 11:46:19 +02:00
Sebastien Loriot 21c75a1f0b
[PSR] Fixed example saving paths (#8437)
## Summary of Changes

Results of examples were using a file path with a folder.

## Release Management

* Affected package(s): Polygonal Surface Reconstruction
2024-08-28 11:45:41 +02:00
Laurent Rineau dc25703d6f Merge branch '5.5.x-branch' into 5.6.x-branch 2024-08-28 11:44:36 +02:00
Laurent Rineau 377e2f11bc create_new_release with SELinux: call restorecon 2024-08-28 11:37:57 +02:00
Sébastien Loriot 860f60b090 need c++17 2024-08-28 11:23:06 +02:00
Sven Oesau 4eb51f79d0 fixed saving paths 2024-08-28 10:46:59 +02:00
Laurent Rineau 261bf3aa81 try to create bug-fixes releases 2024-08-27 17:53:22 +02:00
Jane Tournois b5fc288336 update Linear_cell_complex benchmark wrt OpenMesh 2024-08-27 14:06:46 +02:00
Jane Tournois 3f6083e6ff use CGAL::OpenMesh_support in examples and tests 2024-08-27 14:06:16 +02:00
Jane Tournois 603f6a5a03 OpenMesh >= 10.0 have a OpenMeshConfig.cmake file
so we do not need FindOpenMesh.cmake anymore

We add the target CGAL::OpenMesh_support to make it uniform with other dependencies
2024-08-27 14:00:46 +02:00
Jane Tournois 328c919d67 wip CGAL_OpenMesh_support 2024-08-27 11:01:32 +02:00
Laurent Rineau 62cb850d5b create_new_release with SELinux: call restorecon 2024-08-26 15:39:02 +02:00
Sebastien Loriot e432e6558d
reformat the REUSE.toml file (readability), add natvis files (#8431)
## Summary of Changes

Simple reformating of those files.

## Release Management

* Affected package(s): Installation

No need to test in testsuite: test only the CI Action "REUSE" .
2024-08-26 15:25:29 +02:00
Sebastien Loriot 9ded34f6dd
Mesh_3 - bug fixes for `edge_distance` and `edge_min_size` (#8405)
## Summary of Changes

While experimenting on self-intersecting polyhedral surfaces, I met two
bugs:
* `edge_min_size` was not enough taken into account in
`Protect_edges_sizing_field`,
* `edge_distance` was missing the information of which `curve_id` the
edge belongs to (available using internal code)
causing crashes.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
2024-08-26 15:24:29 +02:00
Sebastien Loriot fb9120fb30
Remove outdated Qt version checks (#8402)
## Summary of Changes

This PR removes outdated conditional blocks that check for specific Qt
versions since CGAL now uses Qt6 exclusively.

## Release Management

* Issue(s) solved (if any): #8381
2024-08-26 15:23:54 +02:00
Sébastien Loriot 1805701903 Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-08-26 15:23:41 +02:00
Sébastien Loriot b682c47c56 Merge remote-tracking branch 'cgal/5.5.x-branch' into HEAD 2024-08-26 15:22:53 +02:00
Sebastien Loriot 5791f2115c
Nef_3: Fix conversion to a FaceGraph (#6727)
## Summary of Changes

Fix the case of surfaces with borders. Then they may be incident to only
the unbounded volume which so far was ignored.

## Release Management

* Affected package(s): Nef_polyhedron_3
* Issue(s) solved (if any): fix #6423
2024-08-26 15:21:47 +02:00
Sebastien Loriot 9dea168da5
Fix for Line_3 Ray_3 do_intersect (#8398)
## Summary of Changes

Some non intersection is wrongfully detected as an intersection for the
Line_3 Ray_3 combination. Here is an illustration:


![image](https://github.com/user-attachments/assets/f18fd662-5ad6-4a01-9a49-a8d0c62cf7fe)

The base code is :
```cpp
  if(!do_intersect(l, r.supporting_line()))
    return false;

  typename K::Coplanar_orientation_3 pred = k.coplanar_orientation_3_object();
  CGAL::Orientation p0p1s = pred(l.point(0), l.point(1), r.source());
  if(p0p1s == COLLINEAR)
    return true;

  CGAL::Orientation stp0 = pred(r.source(), r.second_point(), l.point(0));
  if(stp0 == COLLINEAR)
    return Ray_3_has_on_collinear_Point_3(r,l.point(0),k);

  return (p0p1s != stp0);
```

The supporting line of the ray intersects the line, and then nothing is
collinear, so we check L0,L1,R1 vs R0,R1,L0, which are of opposite sign
so there is an intersection... but there is none.

This check is very similar to what is done in Ray_3-Ray_3, where it is
correct.

I did a naive fix for now: without loss of generality we can go to the
configuration below


![image](https://github.com/user-attachments/assets/5f004941-7f58-4bf3-8416-7dc2144a891f)

and so we have an intersection as long as the ray "points" in the other
slab wrt to the line. And so, in coplanar orientation checks, if the
orientation L0,L1,R0 differs from L0, L1, (L0 + (R1-R0)).

I feel like I could probably skip at least a translation by having
something like Coplanar_orientation(P3, P3, P3, V3), and maybe even
more...

## Release Management

* Affected package(s): `Intersections_3`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2024-08-26 15:21:21 +02:00
Sebastien Loriot 51c2cd9e90
Avoid creating degenerate planes (#8416) 2024-08-26 15:20:57 +02:00
Sebastien Loriot f32c7b015d
run_doxygen_testsuite: fix SELinux contexts so that the web server can offer the files (#8432) 2024-08-26 15:20:40 +02:00