Commit Graph

386 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 3a0a4a6067 Do not forbid any non-fundamental type conversion:
This is because kernel converters are required before type equality
is established, and so one needs conversion for e.g. PointC3.

That could be added and then non-fundamental types could be forbidden
in parameters of converters, but that's for another time...
2021-12-17 12:22:40 +01:00
Mael Rouxel-Labbé 71cbd212dc Converters now simply forward fundamental types, forbid others 2021-12-03 16:48:51 +01:00
Mael Rouxel-Labbé 5aa34c9106 Add Aff_transformation_2 conversion, simplify Aff_tr_3's 2021-12-02 20:11:18 +01:00
Mael Rouxel-Labbé caba3482a6 Disable fundamental type conversions (other than potentially K1::RT / K1::FT) 2021-11-16 16:38:49 +01:00
Mael Rouxel-Labbé ad0378b648 Remove superfluous const& 2021-11-15 08:13:04 +01:00
Mael Rouxel-Labbé 9f1fef3408 Add a test 2021-11-10 16:24:22 +01:00
Mael Rouxel-Labbé c39ea7965f Do not cast fundamental types into bool in NT_converter
Instead, try to construct a NT1 from them. If it fails, give a compilation error.

This is to avoid converters silently doing nasty things like
Cartesian_converter<SC<CORE::Expr>, SC<double> >(2.) ==> 1 (bool true)
because there is no implicit conversion from double to SC<CORE::Expr>, so it
preferes using Enum_converter(bool) (with a double -> Boolean implicit
conversion...).
2021-11-10 15:56:48 +01:00
Mael Rouxel-Labbé 57c240980f Use some const& to avoid copies 2021-11-10 15:40:18 +01:00
Laurent Rineau 1fb32e70b4 Merge pull request #5978 from janetournois/Mesh_2-add_predicate_for_lloyd-jtournois
Mesh 2 and Kernel - add predicate oriented_side_2(segment, triangle)
2021-10-27 17:20:28 +02:00
Sébastien Loriot 65ea1e3621 use initial code in the function 2021-09-29 16:55:36 +02:00
Mael Rouxel-Labbé e424356ffa Add Construct_projected_point_3(P3, P3) + correct parameter order
Not a kernel requirement
2021-09-28 15:34:51 +02:00
Jane Tournois b3a0beb366 make implementation more consistent with the other functions in the same file 2021-09-21 10:58:45 +02:00
Jane Tournois b9de94de93 add assertions to avoid degenerate inputs 2021-09-10 14:10:11 +02:00
Jane Tournois 8bb7e62c1c apply review 2021-09-10 13:56:12 +02:00
Jane Tournois 7e3af5cbda move the implementation of segment_hides_circumcenter() to the kernel
to use filtered predicates
2021-09-10 11:26:53 +02:00
Mael Rouxel-Labbé 8a92d51601 Merge branch 'Distance_3-Add_Tri_Tri-GF-old' into Distance_3-Add_Tri_Tri-GF 2021-09-02 17:26:44 +02:00
Sebastien Loriot e5279db7fb
Merge pull request #5777 from MaelRL/AABB-Dont_call_global_do_intersect-GF
Misc fixes for Intersections_3 + related
2021-09-02 15:44:53 +02:00
Sebastien Loriot 92d90a4a11
Merge pull request #5667 from afabri/Kernel-compare_slopes-GF
Kernel: Add compare_slope with 4 points
2021-08-12 10:12:26 +02:00
Laurent Rineau 0f906ae606 Merge pull request #5545 from Dig-Doug/segment-midpoint
Segment_2/Segment_3 midpoint()
2021-07-07 14:37:38 +02:00
Mael Rouxel-Labbé 03ab79899b Fix Construct_radical_plane_3 for Homogeneous_kernel 2021-06-29 09:24:53 +02:00
Mael Rouxel-Labbé 084a1efe2d Merge remote-tracking branch 'cgal/master' into Distance_3-Add_Tri_Tri-GF 2021-06-23 22:30:03 +02:00
Mael Rouxel-Labbé 4a301448fe Comment an assertion that requires an exact kernel 2021-06-23 17:37:47 +02:00
Laurent Rineau 4a2f016f6a Merge pull request #5617 from afabri/Nef_3-translation-GF
Nef_3: Add Aff_transformation_3::is_translation()
2021-05-18 18:14:17 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Andreas Fabri 6aeb4eea08 remove trailing whitespace 2021-05-03 16:42:30 +02:00
Andreas Fabri 4e1ebec30a untabify 2021-05-01 17:04:52 +02:00
Andreas Fabri 20d1629e1b Add compare_slope with 4 points 2021-04-30 17:39:57 +02:00
Laurent Rineau c091c7f86e Merge pull request #5532 from lrineau/Kernel_23-Do_interesect__without_division-GF
Remove operator/ from CGAL::Mpzf and implement Do_intersect_3 with RT only (without division)
2021-04-28 15:24:15 +02:00
Andreas Fabri c238e9dab5 Merge remote-tracking branch 'cgal/master' into Nef_3-translation-GF 2021-04-27 15:23:56 +01:00
Andreas Fabri e73b8de89f Add the 2D stuff. In homogeneous add Scaling_repH3 2021-04-22 21:17:24 +01:00
Andreas Fabri d3b26a60cb The free function must call the functor 2021-04-22 17:35:27 +01:00
Sebastien Loriot b8bc56ca12
Merge pull request #4421 from MaelRL/Triangulation_on_sphere_2-GF
new package: Triangulation on the sphere
2021-04-21 15:24:45 +02:00
Mael 8226666398
Merge branch 'master' into Triangulation_on_sphere_2-GF 2021-04-17 11:22:30 +02:00
Andreas Fabri 153413e8d5 Add code for translation of Plane_3 and move generic code down to the rep 2021-04-15 13:58:33 +01:00
Andreas Fabri 91ea4909c2 Fixes 2021-04-15 13:36:58 +01:00
Andreas Fabri 01cc9ec653 Scaling a plane means scaling Plane_3::d() 2021-04-15 13:14:42 +01:00
Andreas Fabri ac9b5b2fbd Add Aff_transformation_3::is_translation() which checks the rep 2021-04-13 19:38:28 +01:00
Mael Rouxel-Labbé fba303341f Merge remote-tracking branch 'cgal/master' into Distance_3-Add_Tri_Tri-GF 2021-04-12 15:33:14 +02:00
Mael Rouxel-Labbé 5deb509374 Move to Distance_3/X_Y.h rather than squared_distance_X_Y.h (as Intersections) 2021-04-12 14:42:44 +02:00
Sébastien Loriot 68dc09b3d9 optimize filter failures
cmp_epeck_points.cpp runtime goes from 23s. to 5s.

based on mglisse suggestion
2021-04-10 07:12:25 +02:00
Maxime Gimeno fe5f6556b9 add a comment 2021-03-29 15:23:24 +02:00
Maxime Gimeno 2019309288 Replace Rep by a boost::tuple 2021-03-24 15:31:43 +01:00
Andreas Fabri a4c57e6f66 Keep the old solve() 2021-03-21 19:35:41 +01:00
Andreas Fabri ae945cd329 Avoid division for bounded side test 2021-03-18 14:18:11 +01:00
Andreas Fabri be39ec02fa Add a solve that 'returns' the denominator instead of making the division 2021-03-18 14:18:11 +01:00
Mael Rouxel-Labbé ede18b776c Merge remote-tracking branch 'cgal/master' into Triangulation_on_sphere_2-GF 2021-03-18 10:42:52 +01:00
Mael Rouxel-Labbé 596f3e3013 Fix namespaces 2021-03-12 14:34:36 +01:00
Mael Rouxel-Labbé 2adddeacc1 Add missing includes 2021-03-12 13:08:16 +01:00
Mael Rouxel-Labbé 6b0459c686 Re-organize squared_distance_3_x.h into squared_distance_O1_O2.h
+ minor improvements (missing overloads, obvious improvements, etc.)
2021-03-12 12:51:59 +01:00
Laurent Rineau 216560554e Merge pull request #5112 from sloriot/Kernel_23-bisector_sqrt
Allow an inexact version of bisector when no sqrt is available.
2021-02-18 15:26:51 +01:00