songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
105,252 Commits 3 Branches 156 Tags 959 MiB
Commit Graph

105252 Commits

Author SHA1 Message Date
Sébastien Loriot 3abe02075b GMP is not always available 2025-02-01 23:11:25 +01:00
Sébastien Loriot ca17f813b6 fix debug 2025-01-31 08:57:21 +01:00
Sébastien Loriot f20af1a946 fix the value used creating the infimax box used for pairing halfedges 
without the abs the intersection line of x=-1 and z=-1 would be on the box
leading to invalid behavior (and degenerate halfedges)
 2025-01-31 08:54:42 +01:00
Andreas Fabri f7a57a6c41 Add smaller failing issue 2025-01-31 08:54:29 +01:00
Sebastien Loriot 9a7755b31f
Fix bad detection of warnings + remove outdated scripts (#8704) 
for examples/tests a warning might be reported as `t`
 2025-01-24 08:06:52 +01:00
Sébastien Loriot 88ed74a164 script not used 2025-01-22 14:42:00 +01:00
Sébastien Loriot d8106aab4b we now use ctest for testing + extra clean up 2025-01-22 11:42:50 +01:00
Sebastien Loriot 6d458bbd31
Triangulation_3 traverser benchmark and doc fixes (#8708) 
## Summary of Changes

Use the public API of traverser, fix compilation and documentation of
`Triangulation_simplex_3<Tds>`

This PR follows #8694

## Release Management

* Affected package(s): Triangulation_3, TDS doc
 2025-01-22 10:50:41 +01:00
Jane Tournois fbaccdb075 fix compilation on msvc and use public API 2025-01-21 15:55:25 +01:00
Jane Tournois b721064782 fix doc of Triangulation_simplex_3 (the template param is TDS) 2025-01-21 15:54:49 +01:00
Sébastien Loriot f9b6f0227a remove no longer used action 2025-01-21 11:31:41 +01:00
Sébastien Loriot e4adcceaad more clean up 2025-01-21 11:30:48 +01:00
Sébastien Loriot 40c8d76834 remove no longer used scripts 2025-01-21 11:26:01 +01:00
Sébastien Loriot ebe9c3af98 also report warnings in example and test files 2025-01-21 11:21:57 +01:00
Sébastien Loriot 81076472b1 try to fix CI 2025-01-17 19:05:39 +01:00
Sebastien Loriot 01647a0019
Fix compilation of T3 traverser benchmark (#8694) 
## Release Management

* Affected package(s): `Triangulation_3`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): - 
* License and copyright ownership: no change
 2025-01-17 19:00:50 +01:00
Sébastien Loriot 5e2fbcf707 Merge pull request #8691 from lrineau/CGAL-Github-use-ubuntu-22.04-GF 
FOR 5.6.x ONLY: use ubuntu-22.04 as Github runner
 2025-01-17 18:47:28 +01:00
Sébastien Loriot fe88db2bb3 workaround issue with file command 2025-01-17 18:46:13 +01:00
Mael Rouxel-Labbé 8fe8a8c904 Fix compilation of traverser benchmark 2025-01-16 11:03:06 +01:00
Laurent Rineau 170952b927 FOR 5.6.x ONLY: use ubuntu-22.04 as Github runner 
`ubuntu-latest` was recently turned from 22.04 to 24.04. And 5.6.x is
not ready for that.

See the run
https://github.com/CGAL/cgal/actions/runs/12787411585/job/35648286539?pr=8688#step:3:46

DO NOT MERGE INTO `6.0.x` or `master`.
 2025-01-15 14:35:28 +01:00
Sebastien Loriot 8be09c9cc4
Handle copy of non manifold umbrella in a Face_filtered_graph (#8682) 2025-01-09 19:06:36 +01:00
Sébastien Loriot 1e06a8813f handle special case when FFG has a non-manifold mesh and not all umbrellas are selected 2025-01-08 17:31:21 +01:00
Sebastien Loriot 06fa730c75
Flip it if you can't collapse it (#8609) 
if a needle is also a cap, it will be handled as a needle only. But if
we can't collapse the edge, a flip will not be tried. Try the flip too.

Note that this will slow down the method as the status of a triangle is
tested twice.

Fix #8605
 2024-12-23 09:34:33 +01:00
Sebastien Loriot b55bdc0103
Fix link to replacement function (#8657) 
## Release Management

* Affected package(s): `Polygon_mesh_processing`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
 2024-12-23 09:33:22 +01:00
Sebastien Loriot 50ca5f1833
Fix Coref Boolean for identical nested patches (#8668) 2024-12-23 09:32:04 +01:00
Sébastien Loriot 8bc0b888b8 clean up patch and make filling lazy 2024-12-18 11:42:10 +01:00
Sébastien Loriot dfb77dde96 add test 2024-12-18 11:42:05 +01:00
Sébastien Loriot a6f7b3c163 WIP handle nested coplanar CC 2024-12-18 11:37:14 +01:00
Mael Rouxel-Labbé 4efaa1e9cb Fix link to replacement function 2024-12-13 11:57:30 +01:00
Sebastien Loriot 289a8bda49
`PMP::isotropic_remeshing()` - fix relaxation of constrained vertices (#8604) 
## Summary of Changes

Constrained vertices, and constrained edges were not properly protected
during the smoothing step.

## Release Management

* Affected package(s): PMP
* Issue(s) solved (if any): fix #8388
* License and copyright ownership: unchanged
 2024-12-10 16:30:25 +01:00
Sebastien Loriot 7c3e2f55d7
Bug-fix speeding up coplanar case (#8649) 
The new node propagation status only needs to be done the first time the
node is seen, the classification will always be the same and propagation
is already done.
 2024-12-10 16:27:25 +01:00
Sébastien Loriot 0737a8f99b do not put all the faces of the mesh in the hash map 2024-12-10 15:58:53 +01:00
Sébastien Loriot c3e4e32fb7 factorize cap checks 2024-12-10 15:37:53 +01:00
Sébastien Loriot 116c0ec5d9 only use one container for the next loop 
--> make the output of the function idempotent
 2024-12-10 15:18:24 +01:00
Mael Rouxel-Labbé e9de7e88ad Fix test pretty much never testing envelope tests + read all formats 2024-12-07 23:34:58 +01:00
Mael Rouxel-Labbé eb668da9ea Misc cleaning 2024-12-07 23:34:23 +01:00
Mael Rouxel-Labbé fda7b1ae6a Avoid a lot of useless shape predicate calls 
Here are some changes:
- Avoid a lot of redundant calls of is_it_a_needle / is_it_a_cap
  - Do not test for cap-ness if it's already a needle
  - Do not fill both ranges at the beginning, but fill
    with everything: on the first round, needle-ness will
    be tested, and the exit towards cap-ness will happen
  - Wait for a needle to no longer be a needle, or not be
    treatable to actually test cap-ness
- When the mesh is modified, do not test everything immediately,
  just put them in the queue of the next iteration

Result: Fewer calls to shape predicates

- master -
needle calls = 828 668
cap calls = 803 330

- PR -
needle calls = 803 554
cap calls = 795 317

Should be fewer but two effects are balacing each other for the calls:
- much fewer calls to shape predicates (is_it_a_needle, is_it_a_cap)
  by not calling until absolutely necessary (but still checking at pop time).
- when we modify the mesh, I no longer fill the CURRENT cap and needle
  ranges, but the next ones. The point is to really prioritize all caps
  BEFORE treating needles, whereas otherwise we would treat some needles
  at the current iteration while there are still caps to treat.
So there are more iterations which add more useless calls (see below)
 2024-12-07 23:31:57 +01:00
Mael Rouxel-Labbé a4cb48a145 Fix never trying again a user-rejected cap 2024-12-07 23:29:04 +01:00
Mael Rouxel-Labbé eb5ff9b33e Fix collect_badly_shaped_triangles not actually filling both ranges 2024-12-07 23:28:20 +01:00
Sébastien Loriot cac285d097 no need to redo new node propagation if it was already been done once 2024-12-06 17:19:01 +01:00
Sebastien Loriot e6c6f223c8
Use default_random (#8616) 
Fix the seeding to try to reproduce [this
error](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-22/Tetrahedral_remeshing/TestReport_gimeno_Ubuntu-Latest-NO_DEPRECATED_CODE.gz)
 2024-12-04 13:58:37 +01:00
Sebastien Loriot de5dc287f3
fixed mandatory code in CGAL_assert (#8635) 
## Summary of Changes

Some code was embedded in CGAL_assert so was only working in Debug mode.
The mandatory code is now also outside the assert
This is a bug-fix

## Release Management

* Affected package(s): Hyperbolic_triangulation_2
 2024-12-04 13:58:15 +01:00
Sébastien Loriot b33ce790b8 remove tabs 2024-12-04 13:49:56 +01:00
Sébastien Loriot 08320bc1b7 declare only once 2024-12-04 13:49:56 +01:00
POUGET Marc 469434d8a6 applied Seb suggestion 2024-12-04 13:49:56 +01:00
POUGET Marc 400e4a9d42 fixed mandatory code in CGAL_assert 2024-12-04 13:49:56 +01:00
Sébastien Loriot 0b3c27e584 swap the parameters also here 2024-11-21 09:04:17 +01:00
Sébastien Loriot 41d37ac2a9 split badly shaped triangle check and delay the check calls 2024-11-20 09:40:13 +01:00
Sébastien Loriot b60b203c56 add missing cap collection in case of non-collapsed edge 2024-11-20 09:11:48 +01:00
Sebastien Loriot 80a65639d8
Ceres and OSQP doc in Thirdparty (#8608) 
Documented Eigen3 version requirement of Ceres
Documented use of OSQP in Shape Regularization package

## Release Management

* Affected package(s): Documentation
 2024-11-20 08:51:21 +01:00