Commit Graph

337 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Laurent Rineau 9d699e45fb Merge pull request #5552 from sloriot/Classif-RF_warning
Fix deprecated include path
2021-04-06 15:11:45 +02:00
Simon Giraudot e0ee8aaf42 Fix memory leak by resetting unique ptr instead of releasing 2021-03-31 13:15:36 +02:00
Sébastien Loriot 6ba3a6bae0 fix deprecated include path 2021-03-25 13:26:56 +01:00
Maxime Gimeno e01b9fb6ad add missing include 2021-03-19 15:59:10 +01:00
Simon Giraudot fba2e1fc45 Remove false (outdated) dependency to Boost IO Stream / Serialization in code 2021-01-25 15:48:42 +01:00
Simon Giraudot 250ab87886 Fix warning using doxygen command instead of markdown 2020-10-12 08:10:41 +02:00
Simon Giraudot 7599bbede7 Better names for 32b size_t IO 2020-10-01 13:53:02 +02:00
Simon Giraudot d5df9c1a94 Use binary_file_io.h and fix size_t ambiguity 2020-10-01 13:27:05 +02:00
Simon Giraudot 627584fd73 Add missing includes 2020-09-30 08:38:45 +02:00
Simon Giraudot c7cd9cbea4 Fix conflicting type name 2020-09-30 08:36:15 +02:00
Simon Giraudot 2d7e15b996 Fix C2563 error on Windows 2020-09-30 08:32:50 +02:00
Simon Giraudot 19004a7432 Merge remote-tracking branch 'mine/Classification-Simpler_IO_for_ETHZ_Random_forest-GF' into Classification-Simpler_IO_for_ETHZ_Random_forest-GF 2020-08-04 13:41:48 +02:00
Simon Giraudot 93d64d108a Specify constness of iterators 2020-08-04 13:16:54 +02:00
Simon Giraudot 0e934b1673 Fix brief first letter in lowercase 2020-08-04 13:16:13 +02:00
Simon Giraudot 5c8df1034c Few fixes from review 2020-07-15 14:56:51 +02:00
Simon Giraudot 12a027b027 Add function to check validity of ground truth + preconditions 2020-06-29 14:04:56 +02:00
Sebastien Loriot c602038db9
Merge pull request #4559 from sgiraudot/Spatial_searching-Parallelize_kd_tree_build-GF
[Small Feature] Parallelize KD Tree build
2020-05-05 14:35:02 +02:00
Sebastien Loriot fea3a179bf
Merge pull request #4505 from sgiraudot/Tutorials-GIS-GF
[Small Feature] GIS Tutorial
2020-04-29 15:15:55 +02:00
Simon Giraudot 7702f57620 Merge remote-tracking branch 'mine/Spatial_searching-Parallelize_kd_tree_build-GF' into Spatial_searching-Parallelize_kd_tree_build-GF 2020-04-27 10:24:28 +02:00
Maxime Gimeno e9d41d7b7d Fixes for min/max 2020-04-21 11:38:37 +02:00
Simon Giraudot c03e69d5ae Fix get<>() error on windows 2020-04-20 08:56:08 +02:00
Simon Giraudot 95b9f05a28 Merge remote-tracking branch 'mine/Spatial_searching-Parallelize_kd_tree_build-GF' into Spatial_searching-Parallelize_kd_tree_build-GF 2020-04-16 17:03:44 +02:00
Simon Giraudot a08a1e950d Merge remote-tracking branch 'mine/Tutorials-GIS-GF' into Tutorials-GIS-GF 2020-04-16 16:56:13 +02:00
Simon Giraudot 30e8ac4f7c Improve doc 2020-04-07 14:11:26 +02:00
Simon Giraudot ed25fd2e04 Allow classification package to be used without Boost IO Stream and Serialization 2020-04-07 11:42:56 +02:00
Simon Giraudot 7cfe6df8e3 Allow classification package to be used without Boost IO Stream and Serialization 2020-04-07 11:02:16 +02:00
Simon Giraudot 9e2ce819f0 Merge remote-tracking branch 'mine/Tutorials-GIS-GF' into Tutorials-GIS-GF 2020-04-07 10:15:50 +02:00
Simon Giraudot eee66c5ee7 Fix outdated alpha expansion call 2020-04-07 10:04:05 +02:00
Simon Giraudot 6d0cc18902 Merge remote-tracking branch 'mine/Classification-Simpler_IO_for_ETHZ_Random_forest-GF' into Classification-Simpler_IO_for_ETHZ_Random_forest-GF 2020-04-07 09:54:37 +02:00
Simon Giraudot 59f86419bf Remove trailing whitespaces 2020-04-07 09:51:40 +02:00
Simon Giraudot 2d2fd37799 Small changes 2020-04-07 09:45:00 +02:00
Simon Giraudot f2ca827a5f Split generator function in subfunctions 2020-04-06 11:08:58 +02:00
Simon Giraudot deb64dfd40 Update doc 2020-04-06 10:49:32 +02:00
Simon Giraudot 39ca0f3bf7 Extended labels with indices and colors 2020-04-06 10:25:21 +02:00
Simon Giraudot a51ce12aa5 Use syntaxic sugar for transform iterators / counting ranges 2020-04-02 11:19:01 +02:00
Simon Giraudot d9b5f4f1e5 Use CGAL::for_each in classify functions 2020-04-02 10:44:15 +02:00
Simon Giraudot 43014baa91 Modernize/refresh code with C++11/14 2020-04-02 10:28:50 +02:00
Simon Giraudot daa7983aa1 Merge branch 'master' into Classification-Simpler_IO_for_ETHZ_Random_forest-GF 2020-04-02 08:29:18 +02:00
Simon Giraudot dfee57ab3d Make evaluation comply with Range concept 2020-04-02 08:01:23 +02:00
Simon Giraudot 92bba3c700 Make classifiers comply with Range concept 2020-04-02 08:01:00 +02:00
Sébastien Loriot d42113bbaf extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:35:20 +01:00
Sébastien Loriot f1e5569404 Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:35:02 +01:00
Sébastien Loriot 47027d6f5b extra run of the script to remove tabs and trailing whitespaces 2020-03-26 18:59:19 +01:00
Sébastien Loriot 4421fff65f Update branch from master after trailing whitespaces and tabs removal 2020-03-26 18:58:50 +01:00
Sébastien Loriot 8bb22d5b2c extra run of the script to remove tabs and trailing whitespaces
right after the merge of the 5.0 release branch

+ manual fix of the files (indentation was changed in the meantime):
   * Spatial_sorting/include/CGAL/Multiscale_sort.h
   * Spatial_sorting/test/Spatial_sorting/test_multiscale.cpp
2020-03-26 14:26:59 +01:00
Sébastien Loriot 8b153fb495 Merge branch 'cgal/releases/CGAL-5.0-branch'
whitespace+tab removal, merged with option -Xignore-space-change
2020-03-26 14:22:32 +01:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Mael 855003baa1
Merge branch 'master' into BGL-Alpha_expansion_graphcut-GF 2020-03-24 08:18:23 +01:00
Simon Giraudot fe90d1ca1f Include parallel KD tree build in classification 2020-03-05 14:35:24 +01:00