Mael Rouxel-Labbé
590ddf8015
Various fixes for pmaps:
...
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
a reference (to avoid `typename PM::reference r = get(m, k)`,
which will take a ref to a temporary if the `reference`
typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
**mutable** property map: the `put()` is `map[k] = v`, which
is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
not a reference in `get(map, key)`. You can have a readable property map
returning a reference through its `get(map, key)`, but if there is
no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
* `value_type& operator[](key&)`
* `ref get(map, const key&)`
* `put(map, const key&, const value_type&)`
and non-mutable lvalue pmap:
* `const value_type& operator[](const key&)`
* `ref get(map, const key&)`
but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé
df560987a6
Whitespace & cleaning changes
2021-10-08 12:13:43 +02:00
Laurent Rineau
82bec8a1d6
Merge pull request #5692 from maxGimeno/CGAL_cpp11_atomic_and_threads-maxGimeno
...
CGAL:: Use std atomic and threads
# Conflicts:
# Arrangement_on_surface_2/include/CGAL/Arr_counting_traits_2.h
2021-05-19 17:11:37 +02:00
Maxime Gimeno
17ac255108
Fix calls t cpp11:atomic stuff
2021-05-18 15:43:59 +02:00
Maxime Gimeno
33cefe1be7
remove calls to cpp11::sleep_for()
2021-05-07 11:13:03 +02:00
Maxime Gimeno
e9b7595fff
Deprecate CGAL headers for threads, atomic and result_of, and move their content to config.h as fallback
2021-05-07 11:09:24 +02:00
Laurent Rineau
e562de0160
Merge pull request #5629 from sgiraudot/PSP-Fix_clustering_warning-GF
...
PSP: Fix conversion warnings in clustering
2021-04-28 15:22:43 +02:00
Laurent Rineau
5e20081197
Merge pull request #5629 from sgiraudot/PSP-Fix_clustering_warning-GF
...
PSP: Fix conversion warnings in clustering
2021-04-28 15:22:11 +02:00
Simon Giraudot
f7f781c2d2
Fix warning by explicitly casting to/from property map value type
2021-04-19 12:44:59 +02:00
Sébastien Loriot
cbd95907cd
Merge remote-tracking branch 'cgal/5.1.x-branch' into HEAD
2021-04-17 11:11:28 +02:00
Laurent Rineau
97f526878f
Merge pull request #5547 from sgiraudot/Fix_stdpow_related_warnings-GF
...
Fix warning: std::pow(float, int) returns double instead of float in recent C++
2021-04-06 15:11:49 +02:00
Simon Giraudot
ff2675dc61
Fix pointmatcher example
2021-04-06 10:40:53 +02:00
Laurent Rineau
aea492ee49
Merge pull request #5536 from maxGimeno/Fix_ply_doc-maxGimeno
...
Documentation: Fix `read_ply_points_with_properties`
2021-03-24 15:00:22 +01:00
Simon Giraudot
ab14acff77
Replace std::pow(x,2) by CGAL::square(x)
2021-03-23 13:14:41 +01:00
Simon Giraudot
91de37ec3a
Fix warning: std::pow(float, int) returns double instead of float in recent C++
2021-03-23 11:25:53 +01:00
Maxime Gimeno
5b397e9d6f
Fix group name for read_ply_points_with_properties
2021-03-19 08:40:21 +01:00
Laurent Rineau
92e024f123
Merge pull request #5444 from sgiraudot/Poisson-Kernel_compatibility-GF
...
[Poisson Reconstruction] Compatibility with Simple Cartesian
2021-03-10 10:33:14 +01:00
Laurent Rineau
45373bef84
Merge pull request #5426 from sgiraudot/PSP-RANSAC-Fix_warnings-GF
...
[PSP/RANSAC] Fix warnings
2021-03-03 17:10:18 +01:00
Simon Giraudot
848aa7d8ab
Fix compatibility of Poisson with Simple_cartesian<float>
2021-02-08 10:16:59 +01:00
Simon Giraudot
26793aeaea
Fix conversion warnings in PSP
2021-02-04 08:49:06 +01:00
Laurent Rineau
ba7919ce36
Merge pull request #5323 from sgiraudot/PSP-Fix_binary_tag_for_windows-GF
...
Point Set Processing - Fix missing std::ios::binary tag in some examples
2021-01-21 16:19:08 +01:00
Laurent Rineau
52bb68c012
Merge pull request #5356 from sloriot/CGAL-boost_function_output-5.2
...
Include non-deprecated header (5.2)
2021-01-21 16:18:55 +01:00
Laurent Rineau
6511f95999
Merge pull request #5323 from sgiraudot/PSP-Fix_binary_tag_for_windows-GF
...
Point Set Processing - Fix missing std::ios::binary tag in some examples
2021-01-21 16:09:46 +01:00
Laurent Rineau
dce5ed14b7
Merge pull request #5355 from sloriot/CGAL-boost_function_output-5.1
...
Include non-deprecated header (5.1)
2021-01-21 16:09:39 +01:00
Sébastien Loriot
f4935dc199
Merge branch 'CGAL-Eigen3_support-5.1'
2021-01-15 10:54:02 +01:00
Sébastien Loriot
eecb00534e
fix macro name to be consistent with find_package
2021-01-15 10:43:34 +01:00
Sébastien Loriot
bdd4efe3b3
Merge commit 'efc0c525e8b' into HEAD
2021-01-15 10:06:56 +01:00
Sébastien Loriot
efc0c525e8
include non-deprecated header
2021-01-15 10:02:00 +01:00
Simon Giraudot
64795b14c8
Fix missing std ios binary tag
2021-01-05 13:37:38 +01:00
Laurent Rineau
49e7ddccc9
Merge pull request #4243 from maxGimeno/Cmake_improvements-maxGimeno
...
General CMake improvements
2020-11-13 15:43:54 +01:00
Simon Giraudot
bce99e7768
Fix uncompiled doc
2020-11-09 08:36:45 +01:00
Simon Giraudot
c472257f0e
Fix unused using
2020-11-05 09:36:18 +01:00
Simon Giraudot
06cce4cc90
Fix Eigen error by passing matrix directly in constructor
2020-11-05 09:35:57 +01:00
Simon Giraudot
7f7e732745
Add missing data set
2020-11-04 11:53:26 +01:00
Simon Giraudot
9fd32d1298
Remove useless using
2020-11-04 11:07:26 +01:00
Simon Giraudot
d18609cb28
Fix max for windows
2020-11-04 11:06:12 +01:00
Simon Giraudot
c39ba1056e
Add missing eigen include
2020-10-20 13:51:32 +02:00
Maxime Gimeno
bebd60c12b
Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno
2020-10-20 09:53:54 +02:00
Simon Giraudot
e35fdf852b
Add missing eigen include
2020-10-19 07:55:07 +02:00
Simon Giraudot
16b819aec9
Add Eigen macro conditions
2020-10-13 15:40:16 +02:00
Simon Giraudot
f0f93f0e7e
Typo fix
2020-10-13 14:35:41 +02:00
Simon Giraudot
613dc2ce38
Fix documentation
2020-10-13 14:05:41 +02:00
Simon Giraudot
43d4a5530a
Use constant property maps and remove helpers
2020-10-13 14:02:59 +02:00
Simon Giraudot
c453422a53
Update from review
2020-10-12 14:27:44 +02:00
Simon Giraudot
5370a50dd6
Update doc
2020-10-12 08:15:20 +02:00
Simon Giraudot
45248526ca
Better orientation of scanlines using PCA
2020-10-08 15:09:01 +02:00
Simon Giraudot
b26aa59049
User manual
2020-10-07 12:03:32 +02:00
Simon Giraudot
e86003c5c6
Reference manual
2020-10-07 11:06:32 +02:00
Simon Giraudot
a7e8d52b7d
Better name for function
2020-10-07 09:22:32 +02:00
Simon Giraudot
fd2f40a156
First version of scanline normal orientation
2020-10-07 09:13:15 +02:00