Otherwise we have a lot of warnings like:
```
CMake Warning at /usr/lib64/cmake/Qt6/QtPublicWalkLibsHelpers.cmake:284 (message):
When trying to collect dependencies of target
'Constrained_Delaunay_triangulation_2', the non-existent target 'Qt6::Svg'
was encountered. This can likely be fixed by moving the find_package call
that pulls in 'Qt6::Svg' to the scope of directory
'/home/lrineau/Git/cgal-testsuite-dockerfiles/testsuite/CGAL-6.0-Ic-66/test/Triangulation_2_Demo'
or higher. This warning can be silenced by setting
QT_SILENCE_MISSING_DEPENDENCY_TARGET_WARNING to ON.
Call Stack (most recent call first):
/usr/lib64/cmake/Qt6/QtPublicWalkLibsHelpers.cmake:320 (__qt_internal_print_missing_dependency_target_warning)
/usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:609 (__qt_internal_collect_all_target_dependencies)
/usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:709 (_qt_internal_finalize_executable)
/usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:564:EVAL:1 (qt6_finalize_target)
test/Triangulation_2_Demo/CMakeLists.txt:DEFERRED
```
The issue was that `find_package(Qt6) ...` is required in any
sub-directory, because imported targets like `Qt6::Svg` are
local to the directory scope.
_Please use the following template to help us managing pull requests._
## Summary of Changes
Added the function `insert_cell_1_between_two_cells_2()` into
`GenericMap` concept, which allows users to insert an edge between two
different faces allowing to create faces with holes.
## Release Management
* Affected package(s): CMap/GMap
* Feature/Small Feature (if any):
https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Insert_edge_CMap/GMap
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership:
## Summary of Changes
Following discussion #7525 I added the header `version_enforcer.h`
In the general case, it has nothing to check. If the user includes his
own fork of `version_enforcer.h` with a given number of CGAL version,
then the check happens.
## Release Management
* Affected package(s): Installation
https://reuse.software/
The directories `.reuse/` and `LICENSES/` are for the Git layout.
The same directories in `Installation/` are for the tarball layout.
I have verified that with this patch `v5.5.2` and its release tarball
are compliant with the REUSE specifications.
The shady part is the file `.reuse/DEP5`, kind of equivalent to that
paragraph in `LICENSE.md`:
> A lot of files in the Git repository are not distributed in the source
> tarballs, for examples all the files in the `doc/` and `test/`
> sub-directories of CGAL packages. For all those files, unless they
> have an explicit license notice, the license is the
> Creative Commons CC0 1.0.
We should review the list of files corresponding to the pattern in that
file `.reuse/DEP5`.
- [x] Add missing links from last PRs (master doc not yet built)
- [x] Integrate changes from small features yet to be integrated
- [x] Check all pull requests to find what is worth mentioning and has
not been
- [x] Link to news
- [x] Check all links
## Release Management
[Preview](https://github.com/MaelRL/cgal/blob/CGAL-Prepare_CHANGES.md_5.6-GF/Installation/CHANGES.md)
* Affected package(s): `Installation`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no changes
## Summary of Changes
- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization
ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement
Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e
## Release Management
* Affected package(s): `Mesh_3`, `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix#6997, Fix#7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
Laurent Rineau
Efi Fogel
Mael Rouxel-Labbé
Sébastien Loriot
hoskillua
Andreas Fabri
albert-github
Jane Tournois
Guillaume Damiand