songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
113,745 Commits 3 Branches 156 Tags 958 MiB
Commit Graph

827 Commits

Author SHA1 Message Date
Sébastien Loriot 09564a6d7b do not use result_type 2025-04-03 16:13:27 +02:00
Sébastien Loriot a4170b1fb9 Merge pull request #8586 from MaelRL/Kernel_23-Fix_dangling_ref_in_CC3-GF 
Do not rely on result_type definitions in kernels
 2025-04-03 16:12:09 +02:00
Sébastien Loriot b6719fc3be Merge remote-tracking branch 'cgal/6.0.x-branch' into cgal/master 2025-04-03 16:09:51 +02:00
Mael Rouxel-Labbé b4422374a0 Fix Compare_xy_2 for the generic 3D projection traits 
The previous implementation defined Compare_xy_2 as
simply Compare_xyz_3. This does define an order
over the projected points, but it has a strong downside:
it ignores the direction of the normal, so its order
can be the opposite of the lexicographical order
would give. This new order is in conflict with
the existing Compare_x_2 and Compare_y_2, which
take the normal's direction into account.

(Also with the Less_x_2, Less_y_2, and Less_xy_2
family, which also exist for the projection traits).
 2025-03-28 12:51:07 +01:00
Mael Rouxel-Labbé 0c35489bbe Merge remote-tracking branch 'cgal/master' into Kernel_23-Fix_dangling_ref_in_CC3-GF 2025-03-27 12:28:35 +01:00
Mael Rouxel-Labbé 7bc1bbd842 Add a comment 2025-03-18 12:05:06 +01:00
Mael Rouxel-Labbé 1ae7960a43 Simplify and enhance Type_mapper 
There is also a stronger need because now we really need to map
types whereas before it could rely on result_type's to avoid
some tricky cases like CGAL::Sphere_point
 2025-03-16 21:45:23 +01:00
Mael Rouxel-Labbé a98d5149de Remove useless header includes 2025-03-16 13:33:44 +01:00
Mael Rouxel-Labbé f9001833b1 Merge remote-tracking branch 'cgal/master' into Kernel_23-Fix_dangling_ref_in_CC3-GF 2025-03-15 14:09:28 +01:00
Léo Valque 91f29df106 Cleaning of the files, remove useless comments, correct indent and tab 2025-02-28 13:58:12 +01:00
Léo Valque 0436efa118 macro for global_function_distance 2025-02-19 19:26:09 +01:00
Léo Valque d7c9cce0b9 Compare squared distance with point 2025-02-19 12:03:06 +01:00
Mael Rouxel-Labbé 2f84ba4aea Fix compilation 2025-01-17 13:41:44 +01:00
Mael Rouxel-Labbé 06f862eee7 Misc post-merge fixes 2025-01-17 12:27:21 +01:00
Mael Rouxel-Labbé 3b7a4ed21e Merge remote-tracking branch 'cgal/master' into Kernel_23-Fix_dangling_ref_in_CC3-GF 2025-01-16 11:52:34 +01:00
Mael Rouxel-Labbé 98201c6ecc Point_3 is no different from other kernel objects 2025-01-16 10:41:16 +01:00
Mael Rouxel-Labbé 604103d035 Regroup definitions of operator<=> for kernel objects + add missing 2025-01-16 10:39:21 +01:00
Mael Rouxel-Labbé 2f825080d5 Use the kernel's Boolean and enums 2025-01-16 10:37:38 +01:00
Mael Rouxel-Labbé b7de40afce Update enum_cast<Uncertain> calls to new API 2025-01-08 17:17:55 +01:00
Mael Rouxel-Labbé 7b6886ed17 Misc cleaning 2024-12-20 16:16:26 +01:00
Mael Rouxel-Labbé 9c517a47a2 Fix bad return types 2024-12-20 16:14:40 +01:00
Mael Rouxel-Labbé 4d4549cad6 Get rid of result_type in Kernels + fix some bad return types (wip) 2024-12-20 16:13:35 +01:00
Mael Rouxel-Labbé 778ae1b9c8 Remove unused class 2024-12-20 15:25:03 +01:00
Mael Rouxel-Labbé 20115d3dcb Use std::clamp 2024-12-10 17:09:54 +01:00
Mael Rouxel-Labbé 2838ad24d9 Delay to_double call 2024-12-10 17:09:31 +01:00
Mael Rouxel-Labbé b02776b504 Remove wrong result_type (WIP: does not compile anymore) 2024-11-06 11:26:50 +01:00
Mael Rouxel-Labbé 181ccd2275 More instances of result_type --> dcltype(auto) 2024-11-06 11:25:47 +01:00
Mael Rouxel-Labbé ee451ed469 Fix dangling reference in Construct_center_3(Circle_3) 
This fixes the issue, but it could still be broken e.g. by a kernel
that is based on a CGAL kernel, but redefines the Sphere_3 and
with Sphere_3-functor that would not return a const& (or in that
case the custom kernel needs to define the appropriate functors
too...)

But so much breaks into this configuration, that it's out of scope
for this fix.
 2024-11-03 18:09:45 +01:00
albert-github f7320ae1c1 Spelling corrections 
Spelling corrections
 2024-09-13 17:53:05 +02:00
Mael Rouxel-Labbé d2475215bb Use the kernel functor for vector constructions 2024-07-04 18:51:58 +02:00
Mael Rouxel-Labbé 16ea300ab6 Add Compare_angle_3 overload and missing global functions 2024-07-04 18:34:09 +02:00
Laurent Rineau b8022cbe9f Revert "experiment adding tuple-like support for Segment_3" 
This reverts commit ac47f30cd8.
 2024-05-22 13:06:39 +02:00
Laurent Rineau 70464ea107 Merge remote-tracking branch 'afabri/STL_extension-Fix_Prevent_deref-GF' into pr/lrineau/8170 2024-05-21 18:55:11 +02:00
Laurent Rineau e9fb0190c3 Merge pull request #7373 from sloriot/Kernel-Perfect_forwarding 
Add some perfect forwarding in the Kernel
 2024-05-15 16:12:23 +02:00
Laurent Rineau ac47f30cd8 experiment adding tuple-like support for Segment_3 2024-04-26 14:44:37 +02:00
Laurent Rineau cfb8722861 add comments on Compare_angle_3 2024-04-26 14:37:21 +02:00
Laurent Rineau 4adf7e786b fix Compare_angle_3 with six points 2024-04-26 14:37:21 +02:00
Laurent Rineau 15d4d788e6 add Compare_angle_3 with 6 points 2024-04-26 14:37:04 +02:00
Laurent Rineau e313fdc697 Add Compare_xy_2 to TriangulationTraits_2 
This enables customization of projection traits for CDT_2s and
facilitates unification with the predicates utilized in
3D triangulations.
 2024-04-26 12:13:35 +02:00
Laurent Rineau f305159a26 Merge remote-tracking branch 'cgal/master' into pr/sloriot/7373 2024-04-23 14:37:29 +02:00
Sven Oesau ffba6279c9 Merge remote-tracking branch 'cgal/master' into AABB_tree-2d_and_3d 2024-04-19 08:47:54 +02:00
Andreas Fabri aad631a533 fixes after review 2024-04-11 10:40:46 +01:00
Laurent Rineau d5ae0c9b94 add a test, and the new class template NT_wrapper 2024-03-28 15:44:47 +01:00
Laurent Rineau 1926ffd619 Merge remote-tracking branch 'cgal/master' into Kernel-Perfect_forwarding 2024-03-27 17:00:45 +01:00
Laurent Rineau d6c39e52bd fixes 
Use:
  - perfect forwarding in objects of the kernel (`Point_2`, `Point_3`,
    `Vector_2`, `Vector_3`), and also in `PointC2`, and `PointC3`
    (that forward to the equivalent vector)
  - constructors with rvalue references in `VectorC2` and `VectorC3`.
 2024-03-27 15:56:03 +01:00
Sven Oesau 86fe47c7f7 re-add Construct_projected_point_2 for 2d closest point query 2024-03-21 12:03:57 +01:00
Sébastien Loriot c6ee406603 undo projection traits changes 2024-03-21 09:41:25 +01:00
Andreas Fabri a650d59632 whitespace 2024-03-15 16:23:12 +01:00
Andreas Fabri 40464539ad bug fix 2024-03-15 16:11:34 +01:00
Andreas Fabri f231a3d812 Enrich Projection_traits so that it can be used with AABB_traits_2 2024-03-15 16:06:46 +01:00