Andreas Fabri
d3b26a60cb
The free function must call the functor
2021-04-22 17:35:27 +01:00
Sebastien Loriot
5b253ad2fc
Merge pull request #4099 from sloriot/CGAL-epeck_pts_cmp
...
Speed up comparison of points
2021-04-21 15:24:11 +02:00
Sebastien Loriot
6d63fcc465
Merge pull request #5585 from afabri/Kernel_23-rational_rotation-GF
...
Kernel_23: Remove local reference in rational_rotation.h
2021-04-17 11:21:14 +02:00
Sébastien Loriot
68dc09b3d9
optimize filter failures
...
cmp_epeck_points.cpp runtime goes from 23s. to 5s.
based on mglisse suggestion
2021-04-10 07:12:25 +02:00
Andreas Fabri
e661acaccb
I should buy glasses -- and run the testsuite locally
2021-04-07 12:21:02 +01:00
Laurent Rineau
1b54449dc5
Merge pull request #4878 from danston/Kernels-decltypes-danston
...
Improve decltype/result_of/invoke_result
2021-04-06 15:13:21 +02:00
Laurent Rineau
de704d8bb9
Merge pull request #5522 from afabri/Nef_3-accelerate_do_intersect_internally-GF
...
Nef_3: Do not test has_on for a point where we know that it will be true
2021-04-06 15:13:07 +02:00
Laurent Rineau
0f61f96c80
Merge pull request #5556 from MaelRL/Kernel_23-Dont_recompute_normal_in_proj_point-GF
...
Fix inconsistency in normal computation in robust projection code
2021-04-06 15:12:53 +02:00
Andreas Fabri
7dc015e7de
Kernel_23: Remove local reference
2021-04-06 09:33:44 +01:00
Andreas Fabri
7ebdd07a4c
Add <RT> to rank as expression templates don't match
2021-03-30 14:28:55 +01:00
Andreas Fabri
6c7f05e0be
rank written by Sebastien
2021-03-29 16:03:06 +01:00
Mael Rouxel-Labbé
48bb925b65
Fix inconsistency in robust projection code
...
If the triangle/plane is degenerate, the case is handled separately.
If we know the plane is not degenerate, the normal should not
be recomputed in a different manner, which might lead
to a null normal and some issues down the line.
2021-03-26 10:41:30 +01:00
Andreas Fabri
e0b410e2e6
int -> result_type
2021-03-24 16:03:51 +01:00
Laurent Rineau
21755b1123
Merge pull request #5245 from GilesBathgate/create-assertions-fix
...
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
2021-03-24 15:05:41 +01:00
Andreas Fabri
a28a7cd44a
Return directly
2021-03-23 17:11:26 +01:00
Andreas Fabri
e98198178f
Add the functor Non_zero_dimension_3 to the Kernel
2021-03-23 15:45:54 +01:00
Doug Roeper
6e4be92b5e
Adds a CGAL::midpoint() implementation for Segments.
2021-03-22 09:11:23 -04:00
Doug Roeper
69779ebf80
Adds some helpers to calculate the span of a Bbox in each dimension.
2021-03-22 06:37:29 -04:00
Andreas Fabri
45909e6d76
Let's fix it step by step, beginning with Do_intersect_3
2021-03-22 09:01:56 +01:00
Maxime Gimeno
735567531b
RENAME
2021-03-19 12:00:08 +01:00
Andreas Fabri
be39ec02fa
Add a solve that 'returns' the denominator instead of making the division
2021-03-18 14:18:11 +01:00
Laurent Rineau
b32250242a
CGAL_Kernel_pred_RT for Do_intersect_2 and Do_intersect_3
...
The code is not ready for that. A lot of overloads of
`Do_interesect_[23]` are implemented by calling the equivalent
overloads from `Intersect_23` (that requires division of coordinates).
2021-03-17 11:34:08 +01:00
Dmitry Anisimov
5235fd6d2c
moved min/max definitions of Segment_2/3 inside the class
2021-03-15 10:50:14 +01:00
Dmitry Anisimov
00c185b028
Merge branch 'master' into Kernels-decltypes-danston
2021-03-12 12:06:20 +01:00
Maxime Gimeno
c2628c16e1
change licenses
2021-03-10 15:16:29 +01:00
Maxime Gimeno
82d2258f0b
Merge remote-tracking branch 'cgal/master' into T2-Document_projection_traits_3-maxGimeno
2021-03-10 15:10:20 +01:00
Maxime Gimeno
6c82c4b09d
Add misisng files
2021-03-10 15:06:53 +01:00
Laurent Rineau
f1e550fdd2
Merge pull request #5363 from sloriot/Kernel-Oriented_side_extra_operator
...
Add an extra operator to have an exact plane
2021-03-03 17:33:20 +01:00
Andreas Fabri
d5a5b20ce8
Make it clear that the functor is not part of the Kernel concept
2021-02-19 20:23:20 +00:00
Dmitry Anisimov
3f4c1c4628
moved point/vertex/[] definitions of Segment_2/3 inside the class
2021-02-12 11:31:03 +01:00
Dmitry Anisimov
2718072e0f
projection traits removed result_of
2021-02-10 10:20:21 +01:00
Dmitry Anisimov
81d9556707
Merge remote-tracking branch 'upstream/master' into Kernels-decltypes-danston
2021-02-10 10:06:45 +01:00
Dmitry Anisimov
af3f6dd07f
fixed warnings with Intersect_3 and result_of
2021-02-09 17:30:06 +01:00
Laurent Rineau
3bd7181ff3
Merge pull request #5244 from afabri/Triangulation_2-Intersect_use_variant-GF
...
Nef_3, Triangulation_2: Change the result type of the Intersect_2 functor
2021-02-05 16:12:58 +01:00
Sébastien Loriot
107567e809
add an extra operator to have an exact plane
2021-01-15 15:38:28 +01:00
Dmitry Anisimov
3127190bcf
marc's review
2020-12-08 12:48:04 +01:00
Andreas Fabri
7314f83ac8
Fixes after comments by Laurent and Marc
2020-12-07 12:41:15 +00:00
Giles Bathgate
5a36ff89b5
Drop NDEBUG it is already visible through CGAL_NO_ASSERTIONS
2020-12-04 19:42:21 +00:00
Andreas Fabri
2e24249f13
Triangulation_2: Change the result type of the Intersect_2 functor
2020-12-04 16:44:22 +00:00
Andreas Fabri
f246c4abf8
merge
2020-11-13 16:26:57 +00:00
Andreas Fabri
5791bc1400
fix do_intersect for 3 planes
2020-10-20 14:55:52 +01:00
Sébastien Loriot
209bee81b3
Merge remote-tracking branch 'cgal/5.1.x-branch' into master
2020-10-20 13:35:25 +02:00
Sébastien Loriot
335ac3d5dd
Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch'
2020-10-20 13:32:03 +02:00
Sébastien Loriot
e5019d04e6
Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch'
2020-10-20 13:27:26 +02:00
Sébastien Loriot
87b8f66e14
update from master
2020-10-20 09:19:13 +02:00
Andreas Fabri
fefbc4bc1a
Add funcion intersection_point for Line/Plane
2020-10-20 09:17:15 +02:00
Andreas Fabri
eafad68789
Add a function that only constructs a point intersection for 3 planes
2020-10-20 09:17:15 +02:00
Andreas Fabri
46698620e3
Hack for a fix of do_intersect(Plane_3,Plane_3,Plane_3)
2020-10-20 09:17:15 +02:00
Thomas Lin Pedersen
38e46d853c
move braces
2020-10-16 16:10:48 +02:00
Thomas Lin Pedersen
f856e13964
move bracers
2020-10-16 16:10:35 +02:00
Jane Tournois
5c8df6672a
remove CGAL_CFG_MATCHING_BUG_ variants
...
the "matching bug" of msvc has been fixed since at least vs 2015
2020-09-25 14:25:14 +02:00
Dmitry Anisimov
371db977c8
better kernel checker
2020-08-20 14:12:16 +02:00
Dmitry Anisimov
ad813b4cb0
further removed result_of and result
2020-07-30 16:19:02 +02:00
Dmitry Anisimov
4248a8a9f7
lazy and type mapper result_of fix
2020-07-23 16:00:06 +02:00
Laurent Rineau
2e8a59d570
Merge branch 'releases/CGAL-4.14-branch' into releases/CGAL-5.0-branch
2020-07-21 15:25:54 +02:00
Dmitry Anisimov
da0635e4b1
result_of changed to decltype
2020-07-20 17:03:28 +02:00
Laurent Rineau
7248270fc3
Add result_of protocol to the Kernel_checker
...
That is used by `Construct_point_3` in `Triangulation_3`.
2020-07-17 09:49:14 +02:00
Laurent Rineau
7173530dad
Merge pull request #4557 from lrineau/NewKernel_d-det-GF-CGAL-5.0
...
NewKernel_d: Accelerate by using Mpzf instead of Gmpq (CGAL-5.0 and later)
2020-05-27 18:27:56 +02:00
Laurent Rineau
88250aee80
Merge pull request #4557 from lrineau/NewKernel_d-det-GF-CGAL-5.0
...
NewKernel_d: Accelerate by using Mpzf instead of Gmpq (CGAL-5.0 and later)
2020-05-27 18:20:14 +02:00
Laurent Rineau
b4f2295bab
Merge pull request #4555 from afabri/NewKernel_d-det-GF
...
NewKernel_d: Accelerate by using Mpzf instead of Gmpq (for CGAL-4.14.x)
2020-05-27 18:15:30 +02:00
Andreas Fabri
b2f8ef30d5
Add non-recursive determinant for 7x7 matrix
2020-05-12 12:26:28 +02:00
Mael Rouxel-Labbé
cb08f676d1
Move check code from determinant.h to Kernel_23/test + more tests
2020-05-12 11:56:18 +02:00
Mael Rouxel-Labbé
8a52dd3393
Remove trailing whitespace / tabs
2020-05-12 11:21:06 +02:00
Maxime Gimeno
6a51a30828
more fixes
2020-04-22 11:02:47 +02:00
Maxime Gimeno
9bf61b7977
more fixes
2020-04-22 11:02:16 +02:00
Maxime Gimeno
5b2d46cfa0
Fixes for min/max
2020-04-21 12:04:45 +02:00
Maxime Gimeno
50766d9d03
Fixes for min/max
2020-04-21 11:52:56 +02:00
Maxime Gimeno
e9d41d7b7d
Fixes for min/max
2020-04-21 11:38:37 +02:00
Sebastien Loriot
a860a7ea5a
Merge pull request #4404 from MaelRL/CGAL-Optimal_bounding_box-GF
...
New Package: Optimal Bounding Box
2020-04-16 18:10:58 +02:00
Sébastien Loriot
a8f9858099
Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch'
2020-04-16 16:29:55 +02:00
Mael Rouxel-Labbé
c16c1a7ea3
Merge remote-tracking branch 'cgal/master' into CGAL-Optimal_bounding_box-GF
2020-04-10 16:10:11 +02:00
Sébastien Loriot
4476663eba
fix compilation error...
2020-04-08 16:14:44 +02:00
Andreas Fabri
0040436ae3
Add non-recursive determinant for 7x7 matrix
2020-03-27 10:57:48 +01:00
Sébastien Loriot
bccba2d76f
extra run of the script to remove tabs and trailing whitespaces
2020-03-27 09:56:00 +01:00
Sébastien Loriot
a776758f78
Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch'
2020-03-27 09:55:19 +01:00
Sébastien Loriot
822bc55640
extra run of the script to remove tabs and trailing whitespaces
2020-03-27 08:28:48 +01:00
Sébastien Loriot
5c5d445eb3
Update branch from master after trailing whitespaces and tabs removal
2020-03-27 08:27:43 +01:00
Sébastien Loriot
9f2eafd06e
extra run of the script to remove tabs and trailing whitespaces
2020-03-26 19:17:02 +01:00
Sébastien Loriot
35b83deffd
Update branch from master after trailing whitespaces and tabs removal
2020-03-26 19:16:25 +01:00
Sébastien Loriot
a943082eff
Update branch from master after trailing whitespaces and tabs removal
2020-03-26 19:01:31 +01:00
Sébastien Loriot
8bb22d5b2c
extra run of the script to remove tabs and trailing whitespaces
...
right after the merge of the 5.0 release branch
+ manual fix of the files (indentation was changed in the meantime):
* Spatial_sorting/include/CGAL/Multiscale_sort.h
* Spatial_sorting/test/Spatial_sorting/test_multiscale.cpp
2020-03-26 14:26:59 +01:00
Sébastien Loriot
8b153fb495
Merge branch 'cgal/releases/CGAL-5.0-branch'
...
whitespace+tab removal, merged with option -Xignore-space-change
2020-03-26 14:22:32 +01:00
Sébastien Loriot
0779373835
extra run of the script to remove tabs and trailing whitespaces
...
right after the merge of 4.14 release branch
+ manual fix on one line in:
* Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
* .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sébastien Loriot
590612a563
run the script to remove tabs and trailing whitespaces
2020-03-26 13:25:16 +01:00
Mael Rouxel-Labbé
3c6e5875d5
Grab return Construct_point_3(Weighted_point_3) by reference
2020-03-24 18:48:32 +01:00
Sebastien Loriot
6b2b1e8470
Merge pull request #4238 from sloriot/sloriot/CGAL-Variadics
...
use Variadic templates
2020-03-17 18:21:56 +01:00
Laurent Rineau
4ec82f4b09
Merge pull request #4540 from mglisse/handle
...
Some noexcept, swap, etc to help Handle* types
2020-03-05 14:52:09 +01:00
Laurent Rineau
0260afee8c
Merge pull request #4542 from sloriot/Kernel-compare_distance_use_FT
...
Use FT instead of RT
2020-03-05 14:52:06 +01:00
Laurent Rineau
0d393fb8db
Merge pull request #4542 from sloriot/Kernel-compare_distance_use_FT
...
Use FT instead of RT
2020-03-05 14:50:42 +01:00
Laurent Rineau
32223bdf4e
Merge branch 'releases/CGAL-5.0-branch' into NewKernel_d-det-GF-CGAL-5.0
...
# Conflicts:
# NewKernel_d/include/CGAL/NewKernel_d/Cartesian_filter_K.h
# NewKernel_d/include/CGAL/typeset.h
2020-03-04 08:55:36 +01:00
Andreas Fabri
5d053dba1a
Add determinant 7x7
2020-03-02 20:56:22 +00:00
Marc Glisse
3ebe8839b6
swap for Point_2 and Point_d
...
and make the implementations more similar, in case someone wants to
replace it with a macro at some point.
2020-03-01 12:50:13 +01:00
Andreas Fabri
99eea7ac21
Add operator for line/point/point
2020-02-25 16:47:12 +00:00
Sébastien Loriot
ba2f2c1c20
use FT instead of RT
...
Compare_distance_3 is a generic functor that is comparing
the returned value of Squared_distance_3. If called to
compare the distance of a point to a plane/segment/triangle
a division is used leading to runtime error.
2020-02-25 14:25:20 +01:00
Marc Glisse
1eed5a908c
swap Simple_cartesian<Gmpq>::Point_3
2020-02-25 08:57:53 +01:00
Marc Glisse
c92587fb9c
More swap
...
We could add it for all kernel wrappers...
It is really inconvenient that swap cannot be autogenerated like move
assignments are.
noexcept(auto) would also be convenient, whatever some people on the
committee claim.
2020-02-25 02:00:48 +01:00
Mael Rouxel-Labbé
84215c95c4
Merge branch 'Box_intersection_d-accelerate-GF-old' into Box_intersection_d-accelerate-GF
2020-02-07 11:03:07 +01:00
Mael Rouxel-Labbé
4536ea4f53
Clean whitespace (no changes)
2020-01-16 12:33:01 +01:00
Laurent Rineau
88d35455e2
Merge branch 'releases/CGAL-4.14-branch' into releases/CGAL-5.0-branch
2020-01-07 14:46:27 +01:00
Laurent Rineau
8ac23b392a
Fix PR #4406 with C++03
2020-01-07 14:45:36 +01:00