Mael Rouxel-Labbé
6e07e59930
Merge branch 'Kernel_Weighted_point_without_conversion-GF-old' into Kernel_Weighted_point_without_conversion-GF
...
Update based on the branch cgal-public-dev/Kernel-Fix_weighted_point-GF
@ 8915b4472d
2017-04-21 14:50:01 +02:00
Mael Rouxel-Labbé
c79e2d4b36
Added Compute_power_product_2 to the 2D kernel predicates
...
doc + test included
2017-04-21 13:07:40 +02:00
Mael Rouxel-Labbé
bb086ff739
Added power_side_of_bounded_power_circle_2 to the 2D kernel predicates
...
A partial implementation was deleted from the Alpha_shapes_2 package without
moving the functions to the kernel...
This implementation adds the missing overloads (4, 3, and 2 points)
Test + doc included
2017-04-21 11:37:27 +02:00
Mael Rouxel-Labbé
232c38cee1
Removed documentation of degenerate cases of power_side_of_oriented_* predicates
...
See Issue https://github.com/CGAL/cgal/issues/2067
2017-04-20 12:54:39 +02:00
Mael Rouxel-Labbé
58883e74cc
Cleaning, same as 6c1c2fa (forgot some predicates, again)
2017-04-20 12:01:37 +02:00
Mael Rouxel-Labbé
6c1c2fa27b
Cleaning, same as 1223f5f (forgot some predicates)
2017-04-19 14:38:00 +02:00
Mael Rouxel-Labbé
7cb4c69ff8
Merge branch 'Kernel_Weighted_point_without_conversion-GF-old' into Kernel_Weighted_point_without_conversion-GF
...
Based on cgal-public-dev/Kernel-Fix_Weighted_point-GF
@ 1223f5f5a0
2017-04-19 12:40:54 +02:00
Mael Rouxel-Labbé
1223f5f5a0
Improved readability of weighted point-related functors (no real changes)
...
Fixed indentation, trailing whitespace, english, etc.
2017-04-19 11:40:58 +02:00
Mael Rouxel-Labbé
dd2e7f3a0c
Made compute_squared_smallest_orthogonal_circle_2() a kernel functor
...
and documented, tested, etc. it
Previously in Alpha_shape_2
2017-04-19 11:06:14 +02:00
Mael Rouxel-Labbé
0e7df2413c
Make all conversions between Point and Weighted_point explicit
...
Also doc changes
2017-04-11 17:03:08 +02:00
Mael Rouxel-Labbé
7d16ce69ec
Removed mentions of explicit conversions between Weighted points and Points
...
This is for another branch!
2017-04-11 15:49:29 +02:00
Mael Rouxel-Labbé
365cfd0566
Fixed predicate Power_side_of_oriented_power_sphere_3
...
The Homogeneous kernel doesn't know how to run that predicate
for 3 or 4 arguments so it must be defined in Kernel/function_objects until
those operators are added
2017-04-06 21:57:21 +02:00
Mael Rouxel-Labbé
322cdd83ab
Fixed predicate Compare_power_distance_2
2017-04-06 18:18:37 +02:00
Mael Rouxel-Labbé
548d2bfb02
Cosmetic changes to Point_23 and Weighted_point_23
2017-04-06 12:38:18 +02:00
Mael Rouxel-Labbé
aacf8db95f
Fixed includes and typedefs in Weighted_point_23
2017-04-06 12:35:24 +02:00
Mael Rouxel-Labbé
2d2e675dac
Fixed missing operators in Cartesian and homogeneous construct_weighted_point_23
2017-04-06 12:18:36 +02:00
Jane Tournois
2b66bb75e9
add Same_uncertainty_nb to return types
2016-11-03 14:55:39 +01:00
Jane Tournois
3c789fb378
rename power_side_of_power_sphereC3 to power_side_of_oriented_power_sphereC3
2016-11-03 14:55:39 +01:00
Jane Tournois
f3a021a195
rename in_smallest_orthogonal_sphereC3 to power_side_of_bounded_power_sphereC3
2016-11-03 14:53:54 +01:00
Andreas Fabri
ad9d2c369c
Rename tests following Olivier's recommendations
2016-11-03 14:53:54 +01:00
Andreas Fabri
d78735364b
Fixes after review by Monique and Olivier
2016-11-03 14:53:15 +01:00
Andreas Fabri
f488b9baf9
Changes after Laurent's review
2016-11-03 14:53:15 +01:00
Andreas Fabri
59cedfc7dd
Fix Mesh_3
2016-11-03 13:08:31 +01:00
Andreas Fabri
44d0fa4d6f
fix the 2D triangulations
2016-11-03 13:08:31 +01:00
Andreas Fabri
ea50fb811d
Cleanup. The 2D and 3D triangulation testsuite pass
2016-11-03 13:07:50 +01:00
Andreas Fabri
c2ee0ae9a8
Use Quotient<RT> as weight in the H2 power_tests
2016-11-03 13:07:50 +01:00
Andreas Fabri
9dde08c414
WIP
2016-11-03 13:07:50 +01:00
Andreas Fabri
7d35bb0a8b
First move the C2 and H2 pedicate and construction files operating on the RT
2016-11-03 13:07:50 +01:00
Andreas Fabri
9e94ee6178
Change the Power_test
2016-11-03 13:07:17 +01:00
Andreas Fabri
c0f7b001c1
Rename C3 implementation of Compute_critical_squared_radius_3
2016-11-03 13:07:17 +01:00
Andreas Fabri
95027822f5
move predicates and constructions in Kernel packages
2016-11-03 13:07:17 +01:00
Andreas Fabri
af6c2e185e
remove Compute_point_3
2016-11-03 13:06:02 +01:00
Andreas Fabri
841ecfe8f4
Add an operator so that the T3 testsuite passes
2016-11-03 13:06:02 +01:00
Andreas Fabri
cf1e513c83
cleanup
2016-11-03 13:04:43 +01:00
Andreas Fabri
6a8f77c5ff
Added CGAL::Weighted_point_3<K> and the predicates and constructions of the Regular Traits to the kernel
...
- The Regular 3 testsuite passes
- only 3D
- not documented
2016-11-03 13:04:43 +01:00
Andreas Fabri
92a854093e
Add Weighted_point_3
2016-11-03 13:04:43 +01:00
Laurent Rineau
f2e7050364
Merge pull request #1428 from sloriot/AABB_tree-fix_Closest_point
...
Fix implementation of AABB_traits::Closest_point
2016-10-17 10:03:20 +02:00
Sébastien Loriot
5c02296eb9
move internal code
2016-10-11 11:31:19 +02:00
Andreas Fabri
c12f285ee4
Dispatch the files in Kernel_23, Cartesian, Homogeneous
2016-09-22 08:38:53 +02:00
Sébastien Loriot
c751ab4310
Add operators for segment and triangle types in Construct_projected_point_3
...
the original implementation comes from the AABB-tree package
2016-09-01 16:04:55 +02:00
Laurent Rineau
3e4fcd8d90
Fix compilation error with gmpxx
...
That is a follow-up to the following commit:
> commit 6b51b12ab5
> Author: Laurent Rineau <laurent.rineau@cgal.org>
> Date: Fri Oct 4 16:42:13 2013 +0200
>
> Fix the case when FT is mpq_class
>
> If x and w are mpq_class objects, then the type of x/w is not mpq_class,
> but only a proxy type that is implicitly convertible to
> mpq_class. With the type deduction, CGAL::make_array(x/w, y/w,
> z/w) will not create an array<mpq_class> but an array of the proxy type.
>
> That creates the following compilation error, in a ternary operator:
>
> - with clang:
> include/CGAL/Cartesian/Vector_3.h:78:25: error: incompatible operand types ('array<__gmp_expr<[...], struct __gmp_binary_expr<class __gmp_expr<mpq_t, mpq_t>, class __gmp_expr<mpq_t, mpq_t>, struct __gmp_binary_divides>>, [...]>' and 'array<__gmp_expr<[...], __mpq_struct [1]>, [...]>')
> : base( w != FT_(1) ? CGAL::make_array(x/w, y/w, z/w)
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> - with g++:
> include/CGAL/Cartesian/Vector_3.h:78:25: error: no match for ternary 'operator?:' (operand types are 'bool', 'std::array<__gmp_expr<__mpq_struct [1], __gmp_binary_expr<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, __gmp_expr<__mpq_struct [1], __mpq_struct [1]>, __gmp_binary_divides> >, 3ul>', and 'std::array<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, 3ul>')
> : base( w != FT_(1) ? CGAL::make_array(x/w, y/w, z/w)
> ^
>
> The fix is to specify the template argument of CGAL::make_array.
The first patch in 2013 was on `Vector_3`, but `Vector_2` also suffers
from the issue.
2016-07-13 16:30:07 +02:00
Andreas Fabri
dd249bb1f0
Call opposite() when changing the order of arguments
2016-04-16 21:02:38 +02:00
Andreas Fabri
d00c04777e
Remove ambiguity reported by GCC
2016-04-15 10:31:33 +02:00
Andreas Fabri
2613be3c1b
Add specializations for Compare_distance_3 for points/segments
2016-04-13 12:35:00 +02:00
Simon Giraudot
1636ff238c
Remove useless copy constructor
2016-01-07 14:02:26 +01:00
Simon Giraudot
b5da6bb4f2
More efficient constructor for Rep
2015-12-17 08:32:33 +01:00
Simon Giraudot
85086088eb
Add default constructor to internal pair struct
2015-12-16 15:29:50 +01:00
Simon Giraudot
78d6384255
Add constructors to internal pair struct
2015-12-16 15:26:32 +01:00
Simon Giraudot
2cbaad50da
Bugfix: do not use std::pair in Line_3 to avoid is_convertible trouble with clang c++11
2015-12-16 12:25:56 +01:00
Andreas Fabri
ab2ad75091
Qualifying with CGAL:: solves the problem, but is it the bestsolution?
2015-08-25 16:19:56 +02:00