Commit Graph

584 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 131242bb80 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_5.3-GF 2021-10-12 09:29:23 +02:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Sébastien Loriot 8350dea94a char* -> std::string 2021-10-04 09:49:24 +02:00
Sébastien Loriot 47028cd184 automatically move data files in data dir + update paths
Done for OFF/OBJ/STL/XYZ/PWN/PLY
2021-10-04 09:42:49 +02:00
Sébastien Loriot bd345c7f83 remove .cmd files for examples 2021-09-23 18:54:46 +02:00
Maxime Gimeno 499301c759 More fixes 2021-08-31 16:00:37 +02:00
Sébastien Loriot 0da1e5690e copyright.txt -> copyright 2021-07-29 10:07:44 +02:00
Maxime Gimeno a3d1765ab4 Merge remote-tracking branch 'cgal/master' into CGAL-Clean_up_boost_versions-maxGimeno 2021-07-19 14:18:40 +02:00
Mael Rouxel-Labbé 78ff9185b3 Harmonize ASCII usage across all packages 2021-06-23 23:34:32 +02:00
albert-github 2a54687e77 Correction of hyperlinks
The link checker gave a number of redirects and incorrect links.
- the redirects have been solved ass far as possible
- the incorrect links have been checked and corrected where possible, others  have been reported through issues;
2021-06-04 13:52:14 +02:00
Maxime Gimeno 393ae7dae6 Clean-up boost_version reqs 2021-05-12 15:03:53 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot c863ee6754 fix check_headers compilation issues 2021-05-04 17:28:52 +02:00
Sébastien Loriot fb6f703b55 IO namespace for files in IO directories 2021-05-04 14:36:06 +02:00
Sebastien Loriot b7323389c7
Merge pull request #5622 from maxGimeno/CMake-Update_versions_in_scripts-maxGimeno
Update maximum cmake versions
2021-04-17 10:58:14 +02:00
Maxime Gimeno c49152359c update max version of cmake and announce the new minimal in CHANGE.md 2021-04-15 15:08:54 +02:00
Sébastien Loriot 350b9172c5 replace %CGAL by \cgal (but in titles) 2021-04-11 14:52:01 +02:00
Laurent Rineau 8dc3256685 Merge pull request #5488 from sgiraudot/Classification-Remove_TensorFlow_support-GF
[Small Feature] Remove TensorFlow support
2021-04-06 15:13:15 +02:00
Laurent Rineau f62aaa72b6 Merge pull request #5552 from sloriot/Classif-RF_warning
Fix deprecated include path
2021-04-06 15:12:56 +02:00
Laurent Rineau 473d30bc43 Merge pull request #5571 from sgiraudot/Classification-Sanitize_addresses-GF
Classification: Sanitize addresses
2021-04-06 15:12:45 +02:00
Laurent Rineau 9d699e45fb Merge pull request #5552 from sloriot/Classif-RF_warning
Fix deprecated include path
2021-04-06 15:11:45 +02:00
Simon Giraudot e0ee8aaf42 Fix memory leak by resetting unique ptr instead of releasing 2021-03-31 13:15:36 +02:00
Simon Giraudot 590aa1b4a6 Fix out of scope references leading to segfaults 2021-03-31 13:15:36 +02:00
Sébastien Loriot 6ba3a6bae0 fix deprecated include path 2021-03-25 13:26:56 +01:00
Laurent Rineau e3485f75b7 Merge pull request #5540 from maxGimeno/Classification-Fix_missing_include-maxGimeno
Classification: Add missing include
2021-03-24 15:01:15 +01:00
Maxime Gimeno e01b9fb6ad add missing include 2021-03-19 15:59:10 +01:00
Simon Giraudot 8264096ee7 Remove TensorFlow support from Classification 2021-02-23 08:52:02 +01:00
Laurent Rineau 4c947f0ee0 Merge pull request #5340 from danston/CGAL-clang_warnings_fix-danston
Clang warnings fixed
2021-02-05 16:10:37 +01:00
Laurent Rineau 657dadf718 Merge pull request #5351 from sgiraudot/Classification-Fix_boost_optional_dependencies-GF
[Classification] Fix Boost optional dependencies
2021-02-05 16:10:32 +01:00
Simon Giraudot fba2e1fc45 Remove false (outdated) dependency to Boost IO Stream / Serialization in code 2021-01-25 15:48:42 +01:00
Laurent Rineau f176529041 Merge pull request #5357 from sloriot/CGAL-boost_function_output-master
Include non-deprecated header (master)
2021-01-21 16:22:39 +01:00
Laurent Rineau 52bb68c012 Merge pull request #5356 from sloriot/CGAL-boost_function_output-5.2
Include non-deprecated header (5.2)
2021-01-21 16:18:55 +01:00
Laurent Rineau dce5ed14b7 Merge pull request #5355 from sloriot/CGAL-boost_function_output-5.1
Include non-deprecated header (5.1)
2021-01-21 16:09:39 +01:00
Sébastien Loriot bc161f2ae9 Merge 'CGAL-Eigen3_support-5.2' 2021-01-15 10:59:20 +01:00
Sébastien Loriot f4935dc199 Merge branch 'CGAL-Eigen3_support-5.1' 2021-01-15 10:54:02 +01:00
Sébastien Loriot eecb00534e fix macro name to be consistent with find_package 2021-01-15 10:43:34 +01:00
Sébastien Loriot ad911271a9 Merge commit '6594e7549bd70923990d86c31e2aa267a79bb629' into HEAD 2021-01-15 10:12:17 +01:00
Sébastien Loriot bdd4efe3b3 Merge commit 'efc0c525e8b' into HEAD 2021-01-15 10:06:56 +01:00
Sébastien Loriot efc0c525e8 include non-deprecated header 2021-01-15 10:02:00 +01:00
Dmitry Anisimov 269a47d773
Merge branch 'master' into CGAL-clang_warnings_fix-danston 2021-01-14 16:51:13 +01:00
Maxime Gimeno c06dde11ce Fix indentation 2021-01-14 09:12:10 +01:00
Maxime Gimeno 5c8c60595b Fix example_cluster_classification 2021-01-13 13:30:04 +01:00
Dmitry Anisimov 76d1fe8c7e classification range loop analysis ref to copy warning fixed 2021-01-07 16:45:08 +01:00
Maxime Gimeno 545c602cc2 fix classif examples 2020-11-17 15:39:27 +01:00
Maxime Gimeno 3b70343590 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-11-16 16:19:43 +01:00
Maxime Gimeno 2ad4c16b6e Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-26 15:00:53 +01:00
Maxime Gimeno bebd60c12b Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-20 09:53:54 +02:00
Simon Giraudot 80a5deb8e9 Merge remote-tracking branch 'mine/Classification-Simpler_IO_for_ETHZ_Random_forest-GF' into Classification-Simpler_IO_for_ETHZ_Random_forest-GF 2020-10-19 07:59:47 +02:00
Mael Rouxel-Labbé 4b28101397 Misc IO fixes 2020-10-14 21:46:18 +02:00
Simon Giraudot 250ab87886 Fix warning using doxygen command instead of markdown 2020-10-12 08:10:41 +02:00
Mael Rouxel-Labbé f55ef7dd50 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-10-09 18:36:17 +02:00
Simon Giraudot 7599bbede7 Better names for 32b size_t IO 2020-10-01 13:53:02 +02:00
Simon Giraudot dea945f78b Update config files with 32b size_t 2020-10-01 13:27:19 +02:00
Simon Giraudot d5df9c1a94 Use binary_file_io.h and fix size_t ambiguity 2020-10-01 13:27:05 +02:00
Simon Giraudot fecb3ff5fc Add Random_numbers dependencies to Classification 2020-09-30 15:24:17 +02:00
Simon Giraudot 627584fd73 Add missing includes 2020-09-30 08:38:45 +02:00
Simon Giraudot c7cd9cbea4 Fix conflicting type name 2020-09-30 08:36:15 +02:00
Simon Giraudot 2d7e15b996 Fix C2563 error on Windows 2020-09-30 08:32:50 +02:00
Laurent Rineau 5cfc758880 Fix a warning
```
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.27.29110\include\numeric(35): warning C4267: '=': conversion from 'size_t' to '_Ty', possible loss of data
        with
        [
            _Ty=int
        ]
C:\cgal_test\CGAL-5.2-I-14\cmake\platforms\Windows_MSVC-2019-Community-Release-64bits\test\Classification_Examples\gis_tutorial_example.cpp(674): note: see reference to function template instantiation '_Ty std::accumulate<std::_Vector_iterator<std::_Vector_val<std::_Simple_types<std::vector<CGAL::Point_3<Kernel_>,std::allocator<CGAL::Point_3<Kernel_>>>>>>,int,main::<lambda_f241736352025ce40037bac2971f2e7f>>(const _InIt,const _InIt,_Ty,_Fn)' being compiled
        with
        [
            _Ty=int,
            Kernel_=CGAL::Epick,
            _InIt=std::_Vector_iterator<std::_Vector_val<std::_Simple_types<std::vector<CGAL::Point_3<CGAL::Epick>,std::allocator<CGAL::Point_3<CGAL::Epick>>>>>>,
            _Fn=main::<lambda_f241736352025ce40037bac2971f2e7f>
        ]
```
2020-09-29 09:31:03 +02:00
Simon Giraudot 7ed93510a7 Remove trailing whitespaces 2020-09-28 15:24:35 +02:00
Simon Giraudot 19004a7432 Merge remote-tracking branch 'mine/Classification-Simpler_IO_for_ETHZ_Random_forest-GF' into Classification-Simpler_IO_for_ETHZ_Random_forest-GF 2020-08-04 13:41:48 +02:00
Simon Giraudot 93d64d108a Specify constness of iterators 2020-08-04 13:16:54 +02:00
Simon Giraudot 0e934b1673 Fix brief first letter in lowercase 2020-08-04 13:16:13 +02:00
Maxime Gimeno 9c15f2c9dc Use FeatureSummary in the demo, and remove CGAL_FOUND 2020-08-04 12:46:17 +02:00
Simon Giraudot 5c8df1034c Few fixes from review 2020-07-15 14:56:51 +02:00
Simon Giraudot 12a027b027 Add function to check validity of ground truth + preconditions 2020-06-29 14:04:56 +02:00
Mael Rouxel-Labbé 26355e2e32 Uniformize capital / third person usage of \brief 2020-06-25 15:13:47 +02:00
Mael Rouxel-Labbé 9cca59ba36 Actually use the new IO functions + some example improvements 2020-06-23 18:24:39 +02:00
Mael Rouxel-Labbé 2d49f7d702 Countless IO fixes...
Don't have the patience to split it nicely
2020-06-21 12:03:28 +02:00
Mael Rouxel-Labbé e09eb39a80 Misc cleaning 2020-06-21 11:39:14 +02:00
Maxime Gimeno ea53a8d70d Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-06-17 14:25:21 +02:00
Maxime Gimeno ed03dc0cb8 replace read_XXX_points() with read_ZZZ() 2020-06-15 14:01:06 +02:00
Maxime Gimeno 7915057945 add missing includes 2020-05-29 16:35:21 +02:00
Simon Giraudot 89285f1feb Merge remote-tracking branch 'mine/CMake-Third_party_imported_targets-GF' into CMake-Third_party_imported_targets-GF 2020-05-28 08:53:17 +02:00
Mael Rouxel-Labbé fb8463f470 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-05-22 15:17:56 +02:00
Sebastien Loriot c602038db9
Merge pull request #4559 from sgiraudot/Spatial_searching-Parallelize_kd_tree_build-GF
[Small Feature] Parallelize KD Tree build
2020-05-05 14:35:02 +02:00
Maxime Gimeno 049439fa6b Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-04-30 16:47:58 +02:00
Sebastien Loriot fea3a179bf
Merge pull request #4505 from sgiraudot/Tutorials-GIS-GF
[Small Feature] GIS Tutorial
2020-04-29 15:15:55 +02:00
Simon Giraudot 7702f57620 Merge remote-tracking branch 'mine/Spatial_searching-Parallelize_kd_tree_build-GF' into Spatial_searching-Parallelize_kd_tree_build-GF 2020-04-27 10:24:28 +02:00
Maxime Gimeno e9d41d7b7d Fixes for min/max 2020-04-21 11:38:37 +02:00
Simon Giraudot 4c9f76f584 Fix conversion warnings 2020-04-21 09:11:45 +02:00
Simon Giraudot 1dd6a665a1 Merge remote-tracking branch 'mine/CMake-Third_party_imported_targets-GF' into CMake-Third_party_imported_targets-GF 2020-04-20 09:09:32 +02:00
Simon Giraudot c03e69d5ae Fix get<>() error on windows 2020-04-20 08:56:08 +02:00
Mael 8d0a0dda7e Fix initializating order warning 2020-04-16 19:49:54 +02:00
Simon Giraudot 95b9f05a28 Merge remote-tracking branch 'mine/Spatial_searching-Parallelize_kd_tree_build-GF' into Spatial_searching-Parallelize_kd_tree_build-GF 2020-04-16 17:03:44 +02:00
Simon Giraudot a08a1e950d Merge remote-tracking branch 'mine/Tutorials-GIS-GF' into Tutorials-GIS-GF 2020-04-16 16:56:13 +02:00
Simon Giraudot 421096fd7f Use imported targets everywhere 2020-04-15 14:06:13 +02:00
Simon Giraudot 14c8e8dd18 Add input file for gis_tutorial example 2020-04-14 09:21:19 +02:00
Simon Giraudot 30e8ac4f7c Improve doc 2020-04-07 14:11:26 +02:00
Simon Giraudot ed25fd2e04 Allow classification package to be used without Boost IO Stream and Serialization 2020-04-07 11:42:56 +02:00
Simon Giraudot 7cfe6df8e3 Allow classification package to be used without Boost IO Stream and Serialization 2020-04-07 11:02:16 +02:00
Simon Giraudot 9e2ce819f0 Merge remote-tracking branch 'mine/Tutorials-GIS-GF' into Tutorials-GIS-GF 2020-04-07 10:15:50 +02:00
Simon Giraudot eee66c5ee7 Fix outdated alpha expansion call 2020-04-07 10:04:05 +02:00
Simon Giraudot 6d0cc18902 Merge remote-tracking branch 'mine/Classification-Simpler_IO_for_ETHZ_Random_forest-GF' into Classification-Simpler_IO_for_ETHZ_Random_forest-GF 2020-04-07 09:54:37 +02:00
Simon Giraudot 59f86419bf Remove trailing whitespaces 2020-04-07 09:51:40 +02:00
Simon Giraudot 2d2fd37799 Small changes 2020-04-07 09:45:00 +02:00
Simon Giraudot f2ca827a5f Split generator function in subfunctions 2020-04-06 11:08:58 +02:00
Simon Giraudot deb64dfd40 Update doc 2020-04-06 10:49:32 +02:00
Simon Giraudot 39ca0f3bf7 Extended labels with indices and colors 2020-04-06 10:25:21 +02:00