Commit Graph

6001 Commits

Author SHA1 Message Date
Sébastien Loriot 48712f7862 don't use c++17 features 2023-06-08 14:04:55 +02:00
Laurent Rineau 0e76c32749 Merge pull request #7447 from MaelRL/CGAL-Fix_warnings-GF
Fix some warnings
2023-06-05 15:10:29 +02:00
Laurent Rineau ae1bbe7e17 Merge pull request #7488 from sloriot/PMP-coref_no_early_exit
Corefinement: remove incorrect early exit
2023-06-05 15:09:59 +02:00
Laurent Rineau e697bb386d Merge pull request #7489 from afabri/PMP-document_overload-GF
PMP: Document overload of angle_and_area_smoothing()
2023-06-05 15:09:56 +02:00
Laurent Rineau f1a717bab5 Merge pull request #7488 from sloriot/PMP-coref_no_early_exit
Corefinement: remove incorrect early exit
2023-06-05 14:01:18 +02:00
Andreas Fabri c1b9ea9d47
Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/angle_and_area_smoothing.h
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2023-06-02 12:27:28 +02:00
Andreas Fabri f3c2d9b310 polish 2023-06-01 17:25:23 +01:00
Sébastien Loriot bf1ffb3cae move tests into the testsuite 2023-06-01 11:38:03 +02:00
Andreas Fabri a8e3c84c78 PMP: Document overload of angle_and_area_smoothing() 2023-06-01 10:37:22 +01:00
Sébastien Loriot e0f48fb51a fix script 2023-06-01 11:18:33 +02:00
Sébastien Loriot cb3a1e03d4 remove the early exit as we could miss the fact that some operations might be impossible 2023-06-01 11:17:45 +02:00
Sébastien Loriot 3d6c0da44c remove debug 2023-05-31 09:14:42 +02:00
Sébastien Loriot b724def918 Merge pull request #6605 from sloriot/PMP-snap_no_deg_faces_created
Avoid creating degenerate faces in snap
2023-05-30 19:15:30 +02:00
Sébastien Loriot 4b2f3e6ec7 take np into account for concurrency 2023-05-30 16:01:05 +02:00
Sébastien Loriot a1fbd105da add TODO 2023-05-30 15:07:13 +02:00
Andreas Fabri 3d6d9b3edc parallelize unique points 2023-05-30 11:10:36 +01:00
Sébastien Loriot e34a79864a debug macro 2023-05-30 10:13:28 +02:00
Andreas Fabri 2695834873 Rename lambdas 2023-05-30 08:10:06 +01:00
Andreas Fabri 1c1ed53c76 Parallelize deduplicate_segments() 2023-05-30 08:03:29 +01:00
Andreas Fabri 278e1867aa parallize #1 2023-05-26 17:12:28 +01:00
Sébastien Loriot 5d73a7addd add TODOs for parallelism 2023-05-25 10:06:51 +02:00
Sébastien Loriot a15956d231 add clear function and input must mesh should be const in principle 2023-05-24 16:09:31 +02:00
Sébastien Loriot ec274dd8e9 hide non used variable 2023-05-23 18:18:28 +02:00
Mael Rouxel-Labbé 7bf284fafa Misc minor changes 2023-05-22 14:01:17 +02:00
Mael Rouxel-Labbé 62ca575170 Simplify expression 2023-05-22 14:01:07 +02:00
Mael Rouxel-Labbé afd096cb91 Fix indentation 2023-05-22 12:30:38 +02:00
Charles Gueunet cf07ee9c91 Trailing 'l' on return statement
In CERES_SOLVER mode only
2023-05-22 10:55:52 +02:00
Sebastien Loriot 32da057717
PMP: Test with class derived from Surface_mesh (#7422)
## Summary of Changes

Add the class `CGAL::Testsuite::DerivedSurfaceMesh` that will enable us
to check if a class derived from ` CGAL::Surface_mesh` passes the
Polygon Mesh Processing testsuite (and others). To get started and early
feedback this is currently only used in a single testcase.

This is related to PR #7418 as we would have detected the issue.

## Release Management

* Affected package(s): PMP

* License and copyright ownership: unchanged
2023-05-22 09:20:40 +02:00
Ivan Paden eb2a023c31 Merge PR #6760 into gsoc2023-adaptive_remesh-ipadjen 2023-05-21 08:50:10 +02:00
Ivan Paden 5c4e6ed7b5 Create a vertex property map that will contain sizing info (WIP)
Also, update target length checks
2023-05-19 23:48:30 +02:00
Ivan Paden 7326fb52ce Add initial preparations for adaptive sizing field
Add Adaptive_sizing_field header with edge min and max limits, and tolerance
Adjust the example
2023-05-19 23:47:41 +02:00
Mael Rouxel-Labbé cb05427cf3 Remove std::move on temporary result 2023-05-16 15:49:34 +02:00
Mael Rouxel-Labbé 752aa94490 Properly initialize kernel functors 2023-05-16 15:49:18 +02:00
Mael Rouxel-Labbé eb1462ea56 Remove needless reference 2023-05-16 15:49:00 +02:00
Mael Rouxel-Labbé aa12591bc3 Use VPM's reference 2023-05-16 15:48:50 +02:00
Laurent Rineau d6581363f5
Activate CDT2 for face triangulation (#7437)
(master only)
2023-05-12 10:05:25 +02:00
Laurent Rineau bb63050ef0 Merge pull request #7436 from sloriot/PMP-doc_compta_ori
Improve doc of compatible_orientations
2023-05-11 17:37:11 +02:00
Jane Tournois 50bbb4f682 add namespace
to avoid conflicts with Uniform_sizing_field in Mesh_3
2023-05-11 16:07:10 +02:00
Sébastien Loriot 5c1e820c1e fix test and demo 2023-05-11 16:07:10 +02:00
Sébastien Loriot ad55b8cd9f fix compilation issues 2023-05-11 16:07:09 +02:00
Jane Tournois 9de41310fd use boost::optional<double> instead of a bool and a double
# Conflicts:
#	Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Isotropic_remeshing/remesh_impl.h
2023-05-11 16:07:08 +02:00
Jane Tournois 0ee9406235 add possibility to provide a variable sizing field to PMP::isotropic_remeshing
# Conflicts:
#	Polygon_mesh_processing/examples/Polygon_mesh_processing/CMakeLists.txt
#	Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Isotropic_remeshing/remesh_impl.h
2023-05-11 16:05:48 +02:00
Sébastien Loriot dbada8d636 fix alternative call + more debug 2023-05-10 14:59:49 +02:00
Sébastien Loriot 9f056f9d09 add missing np 2023-05-10 14:59:42 +02:00
Sébastien Loriot a96af5031e improve doc 2023-05-09 18:56:29 +02:00
Laurent Rineau 7789f8a144 Merge pull request #7418 from MaelRL/PMP-Add_missing_const-GF
Add missing const
2023-05-04 17:22:43 +02:00
Laurent Rineau 038813d7e6 Merge pull request #7418 from MaelRL/PMP-Add_missing_const-GF
Add missing const
2023-05-04 17:21:16 +02:00
Laurent Rineau d2bc415a15 Merge pull request #6950 from lrineau/CGAL-allow_Epick_with_float-GF
Simple_precision_epick: an Epick-like kernel with float as FT
2023-05-04 16:37:17 +02:00
Andreas Fabri 257a03e198 PMP: Test with class derived from Surface_mesh 2023-05-04 11:38:44 +01:00
Sébastien Loriot e0eac4f388 Merge remote-tracking branch 'cgal/master' into HEAD 2023-05-03 18:37:09 +02:00
Laurent Rineau e31efe8cd9 Merge pull request #7401 from sloriot/PDemo-fix_warning
fix demo warnings
2023-05-03 15:05:41 +02:00
Mael Rouxel-Labbé aa2a87e538 Add missing const 2023-05-03 11:27:28 +02:00
hoskillua 83bf49bf39 Computing curvatures mentioned in the outline section (1.3) 2023-05-01 12:29:25 +02:00
hoskillua ae5d32ba2e citing/referencing "corrected curvature measures"
+ refining the theo background
2023-05-01 12:23:20 +02:00
Sébastien Loriot c1294a0eaa boost::integral_constant ---> std::integral_constant 2023-04-29 09:42:15 +02:00
Sébastien Loriot 769fca3597 std::size is also c++17
remove this commit before merging to master
2023-04-29 08:54:05 +02:00
Sébastien Loriot 7f2ca4cfb7 fix more warnings 2023-04-27 15:52:52 +02:00
Sébastien Loriot 585e79b67e add authors from the history section 2023-04-26 13:06:19 +02:00
Sébastien Loriot 731905c02c fix one more 2023-04-26 09:03:28 +02:00
Laurent Rineau b8f23d4feb Merge pull request #7255 from lrineau/CGAL-rename_ctest_test_names-GF
CGAL CTest support: rename the test names
2023-04-24 14:08:27 +02:00
Laurent Rineau 4d76e06383 Merge pull request #7392 from MaelRL/CGAL_IO-Obj_fixes-GF
Fix issues in OBJ I/O
2023-04-24 14:08:22 +02:00
Laurent Rineau 4fe208bdd3 Merge pull request #7392 from MaelRL/CGAL_IO-Obj_fixes-GF
Fix issues in OBJ I/O
2023-04-24 14:06:34 +02:00
Sébastien Loriot 2f7d150531 boost::begin/end/empty/size -> std::begin/end/empty/size 2023-04-23 23:01:35 +02:00
Sébastien Loriot b039040f73 boost::is_convertible -> std::is_convertible 2023-04-23 22:37:07 +02:00
Sébastien Loriot 5726a0a255 boost::is_floating_point -> std::is_floating_point
boost::is_float
2023-04-23 22:37:07 +02:00
Sébastien Loriot a04035879d boost::is_const -> std::is_const 2023-04-23 22:37:07 +02:00
Sébastien Loriot e82d970d19 boost::next -> std::next 2023-04-23 22:37:07 +02:00
Sébastien Loriot 99619dc634 boost::prior -> std::prev 2023-04-23 22:37:07 +02:00
Sébastien Loriot 8b3acae1c7 boost::remove_reference -> std::remove_reference 2023-04-23 22:36:59 +02:00
Sébastien Loriot 61834d5a26 boost::remove_const -> std::remove_const_t 2023-04-23 19:07:54 +02:00
Laurent Rineau 7cb29b5d0a Merge pull request #7353 from MaelRL/PMP-Triangulate_PS-GF
Add triangulate Polygon Soup
2023-04-21 11:21:28 +02:00
Laurent Rineau ad30839e6b Merge pull request #7370 from sloriot/PMP-soup_self_intersections
Add self-intersection test and report functions for triangle soups
2023-04-21 11:20:52 +02:00
Laurent Rineau 205236832e Merge remote-tracking branch 'cgal/master' into CGAL-rename_ctest_test_names-GF
# Conflicts:
#	Polyhedron/demo/Polyhedron/Plugins/PMP/CMakeLists.txt
2023-04-21 10:47:17 +02:00
Sébastien Loriot 5260100f88 fix warning 2023-04-21 09:07:14 +02:00
Sébastien Loriot 3705a4cfef fix typo 2023-04-19 04:09:46 +02:00
Sébastien Loriot f3f6783e8a update split candidate choice in case of presence of deg faces 2023-04-19 03:24:01 +02:00
hoskillua 261eac81e9 user manual - incomplete 2023-04-18 14:30:37 +02:00
Mael Rouxel-Labbé b8e82b9c05 Merge remote-tracking branch 'cgal/master' into PMP-Triangulate_PS-GF 2023-04-18 12:16:27 +02:00
Mael Rouxel-Labbé 82e130d951 Minor example improvements 2023-04-18 12:14:10 +02:00
Mael Rouxel-Labbé 451223a2e8 Fix not forwarding verbose NP to inner functions 2023-04-18 11:22:53 +02:00
hoskillua f8a9862abf incomplete update to user man doc 2023-04-17 15:14:37 +02:00
Laurent Rineau 594682dde3 Merge pull request #5461 from sloriot/PMP-decimation
Add coplanar decimation
2023-04-17 10:14:07 +02:00
Laurent Rineau 824976a003 Merge pull request #7236 from albert-github/feature/issue_7231
issue #7231 Improvement of layout of refines relations.
2023-04-17 10:14:01 +02:00
Laurent Rineau 318fce90e9 Merge pull request #7385 from sloriot/PMP-tr_fix_deg_tri
handle degenerate triangles (usually created with the reprojection)
2023-04-17 10:13:24 +02:00
Sébastien Loriot 054906fe7c handle degenerate triangles (usually created with the reprojection) 2023-04-13 15:17:04 +02:00
Sébastien Loriot 2393258370 add triangle soup specific tests 2023-04-12 16:59:05 +02:00
Sébastien Loriot b123ccf125 copy mesh test for soup 2023-04-12 16:21:42 +02:00
Sébastien Loriot a361f79e1f add missing parameter 2023-04-12 16:21:26 +02:00
Sébastien Loriot 304c1394e5 check source mesh before doing the split 2023-04-12 15:19:07 +02:00
Sébastien Loriot 37361b757b do not split if after split faces are not consistently oriented 2023-04-12 15:13:15 +02:00
Sébastien Loriot 6c2c6a580b remove useless variable and use existing ones 2023-04-12 15:07:16 +02:00
Sébastien Loriot ef41988c64 only one deg face is sufficient to cancel the split 2023-04-12 14:59:19 +02:00
Laurent Rineau 9e18cc6989
Unexpected backtick (#7378)
In the file: Arrangement_on_surface_2/index.html
we see:
```
The example below shows how to construct the same arrangement of five line segments built incrementally in Arrangement_on_surface_2/incremental_insertion.cpp` depicted in Figure 34.9 using the aggregate insertion
```
i.e. an unexpected backtick.
2023-04-12 09:55:42 +02:00
Sébastien Loriot 4dc91d18be directly use std::multiset as the double keys are not needed 2023-04-12 09:19:55 +02:00
albert-github 8a0b21461d Unexpected backtick
- Corrected some more redundant / missing backticks
- correctes a spelling error (Boolean_set_operations_2/doc/Boolean_set_operations_2/CGAL/Boolean_set_operations_2/Gps_default_dcel.h)
2023-04-11 17:38:37 +02:00
Laurent Rineau e042737ed9 Merge pull request #7352 from sloriot/PMP-one_si_test
Do not test twice for self-intersections if there is none
2023-04-11 14:19:02 +02:00
hoskillua 8393933630 minor grammer fixes 2023-04-08 10:27:13 +02:00
hoskillua cef23a9045 moving captions out of the figure 2023-04-08 10:24:47 +02:00
Laurent Rineau 1dce90ee79 Merge remote-tracking branch 'cgal/master' into CGAL-allow_Epick_with_float-GF 2023-04-07 10:59:51 +02:00
Sébastien Loriot aefc4b9ce8 repair soup before orient + to mesh 2023-04-06 19:26:58 +02:00
Sébastien Loriot 2a791d2625 add optional progress display 2023-04-06 19:26:58 +02:00
Sébastien Loriot 2bae23a2d5 triangulate soup 2023-04-06 19:26:58 +02:00
Sébastien Loriot d3bcae07c6 Merge pull request #7353 from MaelRL/PMP-Triangulate_PS-GF
Add triangulate Polygon Soup
2023-04-06 19:26:25 +02:00
Sébastien Loriot e29d52421e fix doc 2023-04-06 19:25:46 +02:00
Sébastien Loriot bd967e7cec avoid duplicated tangency point 2023-04-06 19:25:46 +02:00
Sébastien Loriot b06ed794e6 add more debug 2023-04-06 19:25:46 +02:00
Sébastien Loriot 85b3f7ed57 working around non-triangular polygons 2023-04-06 19:25:46 +02:00
Sébastien Loriot 6139fc4119 insert points even if no constraints 2023-04-06 19:25:46 +02:00
Sébastien Loriot 38a92ead67 make the message clearer 2023-04-06 19:25:46 +02:00
Sébastien Loriot b31dc68889 add another option coplanar orientation 2023-04-06 19:25:46 +02:00
Sébastien Loriot ebb051f0b6 remove debug 2023-04-06 19:25:46 +02:00
Sébastien Loriot 48c49add1c more debug and enum fix 2023-04-06 19:25:46 +02:00
Sébastien Loriot 5defd784cc better treatment of intersection between segments 2023-04-06 19:25:46 +02:00
Sébastien Loriot adb5a31852 dramatic typo 2023-04-06 19:25:46 +02:00
Sébastien Loriot 003910ee22 fix typo 2023-04-06 19:25:46 +02:00
Sébastien Loriot 14105bbdd4 always use local indices for range insertion of constraints 2023-04-06 19:25:46 +02:00
Sébastien Loriot 8ff9f17a41 restore traits creation 2023-04-06 19:25:46 +02:00
Sébastien Loriot 3abf7c401b add debug 2023-04-06 19:25:46 +02:00
Sébastien Loriot f499c39266 add a version with fixed dimension for projection 2023-04-06 19:25:46 +02:00
Sébastien Loriot 2fade29214 add more debug 2023-04-06 19:25:46 +02:00
Sébastien Loriot 0bf300d5c5 plug new coplanar triangle intersection code 2023-04-06 19:25:46 +02:00
Sébastien Loriot 8bea32df62 WIP new coplanar intersection 2023-04-06 19:25:46 +02:00
Sébastien Loriot fa662e7dea WIP handle duplicated intersections + add in intersection list 2023-04-06 19:25:46 +02:00
Sébastien Loriot 8107157782 WIP handle coplanar 2023-04-06 19:25:46 +02:00
Sébastien Loriot 10252faf1d WIP use segments 2023-04-06 19:25:45 +02:00
Sébastien Loriot 39d7bbc57f WIP import intersection computation from coref code 2023-04-06 19:25:45 +02:00
Sébastien Loriot 842b6282b5 STILL WIP: copy/paste code for coplanar intersection 2023-04-06 19:25:45 +02:00
Sébastien Loriot 4bc74c399c WIP: start improving intersect computation 2023-04-06 19:25:45 +02:00
Sébastien Loriot d979121cd2 repair soup is still recommanded 2023-04-06 19:25:45 +02:00
Sébastien Loriot b4887272e8 use soup as input/output in example 2023-04-06 19:25:45 +02:00
Sébastien Loriot 9c2de3ee79 handle soup as input 2023-04-06 19:25:35 +02:00
Sébastien Loriot 822e65b3cf build visitor once for all 2023-04-06 19:25:27 +02:00
Sébastien Loriot 7d1582ddbb avoid doing twice the degenerate test 2023-04-06 19:25:27 +02:00
Sébastien Loriot f9668e279f use self-intersection test for soup for checking the validity of the output
on some cases it seems twice faster
2023-04-06 19:25:27 +02:00
Sébastien Loriot a2169055c5 Merge pull request #7370 from sloriot/PMP-soup_self_intersections
Add self-intersection test and report functions for triangle soups
2023-04-06 19:25:04 +02:00
Sébastien Loriot 8985916382 add note 2023-04-06 19:24:04 +02:00
Sébastien Loriot 140d13a943 fix after Andreas' review 2023-04-06 19:24:04 +02:00
Sébastien Loriot 9cd2e031db fix after review from Mael 2023-04-06 19:24:04 +02:00
Sébastien Loriot 5f3d748e19 add doc for self-intersection related functions for soups 2023-04-06 19:24:04 +02:00
Sébastien Loriot 96868b9fc4 fix debug code 2023-04-06 19:24:04 +02:00
Sébastien Loriot f8ab63088a add self-intersection functions for soup
no doc for now
2023-04-06 19:24:04 +02:00
Sébastien Loriot dd4a4420f0 soup/mesh abstraction 2023-04-06 19:24:04 +02:00
Sébastien Loriot 9ba370a229 use a canonical orientation 2023-04-06 17:54:49 +02:00
Sébastien Loriot 370d9134a0 use insertion by range 2023-04-06 17:54:49 +02:00
Sébastien Loriot e94c7be4aa update doc + TODOs 2023-04-06 17:54:48 +02:00
Sébastien Loriot 34e8d7ee42 disable CDT+ that is slower and add debug 2023-04-06 17:54:48 +02:00
Sébastien Loriot d92d37c476 fix condition 2023-04-06 17:54:48 +02:00
Sébastien Loriot 2b77fcd094 faster implementation + fix intersection segments + check 2023-04-06 17:54:48 +02:00
Sébastien Loriot 944475f169 triangulate input faces 2023-04-06 17:54:48 +02:00
Sébastien Loriot 85368c43c6 use all vertices in the check 2023-04-06 17:54:48 +02:00
Sébastien Loriot e1414de8d9 add debug 2023-04-06 17:54:48 +02:00
Sébastien Loriot 6df9926f9b add another example with soup as input 2023-04-06 17:54:48 +02:00
Sébastien Loriot 47ac016af7 skip degenerate faces 2023-04-06 17:54:48 +02:00
Sébastien Loriot b0edd90580 add option to directly dump the soup 2023-04-06 17:54:48 +02:00
Sébastien Loriot a1ff847b6a add "brute-force" version of autorefine() 2023-04-06 17:54:44 +02:00
Sébastien Loriot 5828644133 fix warnings 2023-04-05 17:24:04 +02:00
Sébastien Loriot a3bf5d80b7 limit the use of pre-computed meshes 2023-04-04 15:36:05 +02:00
Sébastien Loriot cb672d4d90 Merge remote-tracking branch 'cgal/master' into PMP-decimation 2023-04-04 14:25:17 +02:00
Sebastien Loriot 964d108fd7 typo 2023-04-04 14:23:47 +02:00
Sebastien Loriot 5cf0be27c9 Fix typos 2023-04-04 14:22:32 +02:00
Sébastien Loriot 5cca87ee18 readd tests with approximate global criteria 2023-04-04 13:50:03 +02:00
Andreas Fabri e816f17ef4 Derive Visitor in example to have default implementations of some callbacks 2023-04-04 08:47:07 +01:00
Andreas Fabri 8ee3eecc85 Remove unused typedefs 2023-04-04 08:33:51 +01:00
Sébastien Loriot ae57ce5f2c rephrase 2023-03-31 15:47:55 +02:00
Sébastien Loriot 95bc2eac4c rename after rebase 2023-03-31 14:42:20 +02:00
Sébastien Loriot f487828a90 dynamic images 2023-03-31 14:39:33 +02:00
Sébastien Loriot 077f307e01 be more precise 2023-03-31 14:39:33 +02:00
Sébastien Loriot 6330b825ad add bounds 2023-03-31 14:39:33 +02:00
Sébastien Loriot a98de00579 output is possible a polygon mesh 2023-03-31 14:39:33 +02:00
Sébastien Loriot 3e11982062 simplify 2023-03-31 14:39:33 +02:00
Sébastien Loriot c2cb6d1831 rename vertex class 2023-03-31 14:39:33 +02:00
Sébastien Loriot f730ab30d8 move to out np 2023-03-31 14:39:33 +02:00
Sébastien Loriot cfa8c2954f document the property map version of parameters 2023-03-31 14:39:33 +02:00
Sébastien Loriot e316b3fb04 fix helper 2023-03-31 14:39:33 +02:00
Sébastien Loriot 39b84d0433 fix specialization 2023-03-31 14:39:33 +02:00
Sébastien Loriot 5e4e9a9001 fix warning 2023-03-31 14:39:33 +02:00
Sebastien Loriot a34ada1cfe Apply suggestions from code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2023-03-31 14:39:33 +02:00
Sébastien Loriot 36e309e677 add example for almost coplanar remeshing 2023-03-31 14:39:33 +02:00
Sébastien Loriot c88b106640 typos. Thanks again Albert! 2023-03-31 14:39:33 +02:00
Sébastien Loriot 4a0671bd21 add user manual for decimate 2023-03-31 14:39:25 +02:00
Mael dce2d9b780
Merge branch 'master' into PMP-Triangulate_PS-GF 2023-03-31 13:21:44 +02:00
hoskillua 796d7cc57d handled scale dependency and add tests for it 2023-03-31 01:55:26 +02:00
Laurent Rineau d3a91046a9 Merge pull request #7276 from afabri/PMP_smooth_scale-GF
PMP:  Add np for not scaling smoothed mesh
2023-03-30 18:04:34 +02:00
Mael Rouxel-Labbé c346b4a836 Avoid repetition 2023-03-29 15:46:42 +02:00
Mael Rouxel-Labbé 8a39016780 Visitor of triangulate_faces must be a visitor of HoleFilling too 2023-03-29 15:30:25 +02:00
Mael Rouxel-Labbé 5a47df6682 Doc fixes, thanks @albert-github 2023-03-29 15:29:10 +02:00
Mael Rouxel-Labbé 77062ed7c2 Move triangulate_polygons()'s default visitor out of internal namespace
so that it is documented
2023-03-29 12:07:57 +02:00
Mael Rouxel-Labbé 962269c03d Add see also's 2023-03-29 12:07:47 +02:00
Mael Rouxel-Labbé 9387f087e0 Refactor to properly forward NPs to triangulate_hole_polyline + other imprvmts 2023-03-29 11:53:27 +02:00
Mael Rouxel-Labbé 4a2d91e03b Document requirements on faces of triangulate_faces/triangulate_polygons 2023-03-29 10:11:04 +02:00
Mael Rouxel-Labbé 1365fac894 Move macro 2023-03-29 10:08:10 +02:00
Mael Rouxel-Labbé 4d03dbe076 Try-Catch the CDT constraint insertions 2023-03-28 22:42:40 +02:00
Mael Rouxel-Labbé f570e0ec2e Enhance tests 2023-03-28 16:53:08 +02:00
Mael Rouxel-Labbé c451b921ef Rename internal functions for consistency 2023-03-28 16:52:48 +02:00
Mael Rouxel-Labbé 123c2513fc Delegate construction of a 2D CDT to hole filling 2023-03-28 16:52:40 +02:00
Mael Rouxel-Labbé 6a0a0267bf Test triangulate_polygons() 2023-03-28 15:16:52 +02:00
Mael Rouxel-Labbé 7b375129fb Document triangulate_polygons() 2023-03-28 15:16:37 +02:00
Mael Rouxel-Labbé 4b2b996e08 Add visitor for triangulate_polygons() 2023-03-28 14:59:26 +02:00
Mael Rouxel-Labbé 51c1e21847 Change ITag to No intersections, and try{}catch() the CDT2 code 2023-03-28 14:58:39 +02:00
Mael Rouxel-Labbé 83e89d85a6 Fix typo 2023-03-28 14:58:22 +02:00
Sébastien Loriot 9166d28c97 do not test twice for self-intersections if there is none 2023-03-28 11:42:49 +02:00
Mael Rouxel-Labbé 20c2df0692 Add triangulate_PS prototype 2023-03-28 09:59:21 +02:00
hoskillua 33c7f5c03a traillling spaces 2023-03-27 19:37:31 +02:00
hoskillua 4279a734bf minor linting changing 2023-03-27 19:35:31 +02:00
hoskillua 2884d8b3cb using is_zero() & is_negative() for FT variables 2023-03-27 18:06:06 +02:00
hoskillua 5aa995dbe7 missing dots in ref documentation 2023-03-27 17:45:16 +02:00
hoskillua 057b6fc2dd gaussian -> Gaussian in example files 2023-03-27 17:20:26 +02:00
hoskillua 49c12d9265 ref doc fixes 2023-03-25 13:44:36 +02:00
hoskillua 2bc8b1b495 user man doc improvements 2023-03-25 13:29:15 +02:00
hoskillua 556218bf15 gaussian -> Gaussian in docs and comments 2023-03-25 11:57:22 +02:00
Sébastien Loriot 661513b16e gaussian -> Gaussian 2023-03-22 19:12:28 +01:00
Sébastien Loriot 7f4597720e the mesh does not need to be triangulated 2023-03-22 18:44:11 +01:00
Sébastien Loriot 5ef5d67920 do not use pointers 2023-03-22 18:40:44 +01:00
Sébastien Loriot 664aa7c162 Merge remote-tracking branch 'cgal/master' into HEAD 2023-03-22 18:16:01 +01:00
Sébastien Loriot a601cbc5e7 first pass on the API 2023-03-22 18:13:27 +01:00
Sébastien Loriot 21bc3d57c6 fix typo. Thanks Albert! 2023-03-20 13:22:08 +01:00
Sébastien Loriot d89f90055b add example in doc + rephrase 2023-03-20 11:57:40 +01:00
Andreas Fabri 0d320e48a8 Merge branch 'Number_types-fix_VC2017_boost_mp-GF' into CORE-boost_mp_number-GF 2023-03-17 08:28:10 +01:00
Laurent Rineau 2f0203be10 Merge pull request #7255 from lrineau/CGAL-rename_ctest_test_names-GF
CGAL CTest support: rename the test names

# Conflicts:
#	Mesh_3/test/Mesh_3/CMakeLists.txt
2023-03-15 14:23:32 +01:00
albert-github 2d60f46985 issue #7231 Improvement of layout of refines relations.
- Adjusted cgalRefines according to reviews
- Implemented it in all files
2023-03-14 17:37:50 +01:00
Sébastien Loriot 4387ebecdb regroup the setting of face ids at one place
fix a bug when patch need another remeshing
2023-03-10 09:17:30 +01:00
Sébastien Loriot 33c868818f fix property map for region primitives 2023-03-07 17:55:28 +01:00
Sébastien Loriot d799f48887 remove warnings 2023-03-07 13:41:02 +01:00
Sébastien Loriot 648377f127 fix np name + plug region growing in decimation plugin + change cosinus sign in decimate + update doc 2023-03-02 19:08:10 +01:00
Sébastien Loriot f8cc9e6bd0 rename np 2023-03-02 14:49:17 +01:00
Sébastien Loriot b1d2744821 Merge branch 'master' into PMP-decimation 2023-03-02 14:24:27 +01:00
Laurent Rineau ea016d7f5b Merge pull request #6702 from soesau/Region_growing-revision-soesau
[Small Feature] Region growing revision soesau
2023-03-02 13:42:32 +01:00
Sébastien Loriot 12465a6c40 named parameter to pass normal of patches 2023-02-27 17:13:23 +01:00
Sébastien Loriot c21231cef8 early exit if CDT is not 2D 2023-02-27 15:50:42 +01:00
Sébastien Loriot c4f0456f3a add option in the other function too 2023-02-27 15:26:24 +01:00
Sébastien Loriot 52ff9c4e66 add an option to not triangulate patches 2023-02-27 15:16:13 +01:00
Sébastien Loriot 452c18710c add test for corner and face patch maps + fix not a corner value 2023-02-24 16:19:37 +01:00
Laurent Rineau 5a20fd8567 Merge pull request #7238 from albert-github/feature/bug_author_consistency
Making description of author(s)  of a package consistent
2023-02-24 16:14:43 +01:00
Laurent Rineau a38a3fc93f Merge pull request #7260 from afabri/CGAL-set_but_not_used-GF
Use CGAL_assertion_code()
2023-02-24 16:14:39 +01:00
Laurent Rineau 9a47215a84 Merge pull request #7265 from sloriot/PMP-orient_empty_mesh
Early exit if the mesh is empty
2023-02-24 16:14:34 +01:00
Laurent Rineau 8a3184a1a8 Merge branch '5.4.x-branch' into 5.5.x-branch 2023-02-24 16:13:44 +01:00
Sébastien Loriot c587df44a6 fix correspondance between faces 2023-02-24 14:45:01 +01:00
Sébastien Loriot c90d97635d first version of the demo plugin 2023-02-24 10:41:08 +01:00
Andreas Fabri 4a5ada051a Add to changes.md; Update @see in order to show to non-deprecated function 2023-02-23 11:35:12 +00:00
Sébastien Loriot 9e72361537 All packages depends now on CGAL_Core (like Kernel) 2023-02-20 15:24:16 +01:00
David Coeurjolly 19fd037731 Minor API doc edits 2023-02-20 11:20:07 +01:00
Mael Rouxel-Labbé f2cb368919 Add tests 2023-02-20 10:08:35 +01:00
Mael Rouxel-Labbé ee13f77810 Various improvements 2023-02-20 10:08:21 +01:00
Andreas Fabri 545009ab7c PMP: Add np for not scaling smoothed mesh 2023-02-19 21:25:25 +00:00
Sébastien Loriot 0c37af1be9 num_faces is not tight 2023-02-16 14:36:58 +01:00
Sébastien Loriot 640910288b Merge remote-tracking branch 'cgal/master' into Region_growing-revision-soesau 2023-02-16 14:18:17 +01:00
Laurent Rineau a5052f4cd8 Merge pull request #6835 from MaelRL/CGAL-Clean_CMakeLists.txt-GF
Some CMakeLists.txts cleaning
2023-02-16 10:52:29 +01:00
Sébastien Loriot e559a238fd typos 2023-02-14 15:47:18 +01:00
Andreas Fabri 35df6522ba Fix some typos 2023-02-14 14:23:12 +00:00
Andreas Fabri 010293a872 Fix some typos 2023-02-14 14:17:04 +00:00
Sébastien Loriot e431c4e481 early exit if the mesh is empty 2023-02-14 14:16:22 +01:00
Sébastien Loriot fbe559adc9 Merge 'cgal/master' into PMP-decimation 2023-02-14 08:33:24 +01:00
Sébastien Loriot b7f7b434b0 more todo clean up 2023-02-14 08:26:40 +01:00
Sébastien Loriot be85f66ef4 remove TODOs 2023-02-14 08:04:02 +01:00
Sébastien Loriot 74b5d05698 fix test 2023-02-13 19:27:59 +01:00
Sébastien Loriot 8d951594b7 add visitor to clear output mesh if needed 2023-02-13 19:03:26 +01:00
Sébastien Loriot 88bb9570c0 implement API update 2023-02-10 16:09:44 +01:00
Laurent Rineau d33d71a4e0 Merge pull request #7125 from MaelRL/PMP-flip_criterion-GF
Modify flipping criteria in PMP::isotropic_remeshing and PMP::refine
2023-02-10 15:40:49 +01:00
Sébastien Loriot 7e38151479 add documentation for remeshing functions + update API
code has not been updated yet
2023-02-09 16:31:00 +01:00
Andreas Fabri 3d379c3988 Use CGAL_USE() 2023-02-09 10:29:08 +00:00
Andreas Fabri ff61b977af Add fix in PMP::snap() 2023-02-09 10:01:06 +00:00
Sébastien Loriot 6df265125a finish doc for PMP functions 2023-02-07 15:01:00 +01:00
Sébastien Loriot 9242a810c4 Merge remote-tracking branch 'cgal/master' into Region_growing-revision-soesau 2023-02-07 11:31:55 +01:00
Sébastien Loriot dbccebf7df clean up doc and API of new property maps 2023-02-06 18:32:41 +01:00
Laurent Rineau 6df18b668c CGAL CTest support: rename the test names
Now that CTest test names can contain whitespace, we can have
better looking names. That is also more practicle because we can now
copy-paste the target name in `compilation of  <target_name>`.
2023-02-06 12:04:57 +01:00
albert-github 57e900b47c Making description of author(s) of a package consistent
- use `\cgalPckAuthor` in case of one author
- use of `\cgalPckAuthors` in case of multiple authors
- using in case of multiple authors always `, and `
- in the 1.9.6 `BaseDoxyfile.in` let the `\cgalPckAuthors` point to `\cgalPckAuthor` to get consistent output (not done for other versions as in the past the `ALIASES` could not call one another).
2023-02-02 18:40:44 +01:00
hoskillua ec4312695a remove unused var + minor change 2023-02-02 12:23:50 +02:00
hoskillua fcbc89b503 added comments for clarity 2023-02-02 12:07:20 +02:00
Laurent Rineau 1e4165f1db Merge pull request #7184 from afabri/PMP-longest_border-GF
PMP: Make longest_border() extract_boundary_cycles() coherent
2023-02-02 10:58:25 +01:00
hoskillua e71fcd899a removed unused enum 2023-02-02 02:15:34 +02:00
Sébastien Loriot 9e137bca24 Merge 'cgal/master' 2023-01-31 12:26:55 +01:00
Sébastien Loriot 6a7e7d267e fix link 2023-01-31 11:56:48 +01:00
hoskillua bd5d9df950 fix
some functions were passing x to interpolated_corrected_gaussian_curvature_measure_face() when it was not needed (and causes a compilation error for 1 vertex)
2023-01-31 11:57:00 +02:00
hoskillua 4f4eeea292 removing _example suffix (renaming) 2023-01-31 11:55:15 +02:00
hoskillua eef0f5fd80 removed unused parameter 2023-01-31 11:23:46 +02:00
hoskillua 2ccabc9289 renaming files 2023-01-29 09:39:39 +02:00
hoskillua 4e669b79a7 conversion warnings 2023-01-29 06:26:16 +02:00
hoskillua 8d2043d0aa renaming
mostly to pass the max path error
2023-01-28 15:54:35 +02:00
Mael 153c603209
Merge branch 'master' into CGAL-Clean_CMakeLists.txt-GF 2023-01-27 22:09:02 +01:00
Laurent Rineau 5f8930db8c Merge branch '5.5.x-branch'
# Conflicts:
#	Convex_hull_2/test/Convex_hull_2/ch_test_CH.cpp
#	Convex_hull_2/test/Convex_hull_2/ch_test_SC.cpp
#	Convex_hull_2/test/Convex_hull_2/ch_test_SH.cpp
#	Convex_hull_2/test/Convex_hull_2/ch_test_SS.cpp
#	Straight_skeleton_2/include/CGAL/constructions/Straight_skeleton_cons_ftC2.h
#	Straight_skeleton_2/include/CGAL/predicates/Straight_skeleton_pred_ftC2.h
2023-01-27 21:16:14 +01:00
Laurent Rineau fc61b42864 Merge pull request #6858 from sloriot/Doc-exclude_internal
Ignore internal directories
2023-01-27 21:02:29 +01:00
Laurent Rineau 8a6b583780 Merge pull request #6880 from soesau/PMP-tests_only_for_epeck-soesau
Pmp tests only for epeck
2023-01-27 21:02:26 +01:00
Laurent Rineau 122141dda6 Merge pull request #7076 from MaelRL/PMP-Improve_normal_doc-GF
Improve documentation of PMP::compute_vertex_normal()
2023-01-27 21:02:24 +01:00
Laurent Rineau 36bc3d1154 Merge pull request #7126 from sloriot/PMP-repair_si_no_smooth_by_default
Make smooth an option that is OFF by default
2023-01-27 20:52:29 +01:00
Laurent Rineau 119cea4add Merge pull request #7127 from sloriot/PMP-cond_assert
Conditional assertions
2023-01-27 20:52:27 +01:00
hoskillua 28188b5acf Merge remote-tracking branch 'cgal-dev/gsoc2022-ICC-hoskillua' into gsoc2022 2023-01-26 12:07:03 +02:00
hoskillua 00cf0970e5 changed the mesh file used in examples 2023-01-26 12:04:51 +02:00
Sébastien Loriot ee246c87c5 fix function name and add missing constructor 2023-01-25 17:08:27 +01:00
Sébastien Loriot 1294548acc avoid macro substitution 2023-01-24 17:58:27 +01:00
hoskillua 6f2f912c4d minor fix 2023-01-24 18:41:25 +02:00
hoskillua 92e2264435 Update test_interpolated_corrected_curvatures.cpp 2023-01-24 17:58:03 +02:00
hoskillua f9c21faf02 trailling white spaces 2023-01-24 15:11:58 +02:00
hoskillua 7303c7401e move function + minor func doc fix 2023-01-24 14:42:39 +02:00
hoskillua 864eb9be4e Merge remote-tracking branch 'cgal-fork/gsoc2022' into gsoc2022-ICC-hoskillua 2023-01-24 14:38:02 +02:00
hoskillua 999b475e4c tests (incomplete) + minor typename fix
still not passing single vertex on polyhedron due to a problem with vertex normal map
2023-01-24 14:08:02 +02:00
Andreas Fabri 35ffe120e1 fix merge conflict 2023-01-24 10:41:22 +00:00
Sébastien Loriot 69c21bccc3 Merge 'master' 2023-01-24 11:29:48 +01:00
Sébastien Loriot 69610f6958 move function 2023-01-24 11:15:04 +01:00
Sébastien Loriot 50ba18725c fix typename usage 2023-01-24 11:10:29 +01:00
Sébastien Loriot da3db9a406 typo 2023-01-24 09:58:35 +01:00
hoskillua ca4e412e0e minor fix 2023-01-24 09:35:20 +02:00
hoskillua fc943a4c31 minor doc fixes 2023-01-24 09:18:05 +02:00
hoskillua f3264441eb Merge remote-tracking branch 'cgal-fork/gsoc2022' into gsoc2022-ICC-hoskillua 2023-01-24 09:04:53 +02:00
hoskillua a7cd6a275e trailling whitespaces 2023-01-24 09:00:24 +02:00
hoskillua 483e8b8e50 User manual + add example file for 1 vertex curvature 2023-01-24 08:44:09 +02:00
hoskillua 8af5c620fa reference documentation + minor fix
+ added documentation for the at_vertext curvature functions
- removed dynamically allocated pointers for storing the curvature on vertex
2023-01-23 13:49:34 +02:00
Mael 86ec9ce186
Fix indentation 2023-01-20 22:28:05 +01:00
Sébastien Loriot 73bde6daa0 Eigen is needed 2023-01-20 16:02:25 +01:00
Sébastien Loriot cd76994056 rename property map and deprecated old name 2023-01-18 13:45:37 +01:00
Mael d67d7cd4b6
Remove extra `to_double` 2023-01-18 11:15:17 +01:00
Sebastien Loriot 343735b9d7
missing return 2023-01-17 09:58:38 +01:00
Sébastien Loriot 6a7bd8b0e3 fix angle return type 2023-01-16 19:47:25 +01:00
albert-github 9c2f8ff60e Spelling correction in respect to function / variable names
As indicated in #7041 (Spelling corrections) theer were still some open corrections in respect to variables / functions, these have been addressed heer.
2023-01-13 18:51:28 +01:00
Andreas Fabri 7305e1bb38 Fix typo (thank you Albert) 2023-01-12 17:29:30 +00:00
Andreas Fabri c8b8792275 PMP: Guarantee that the longest_border() halfedge is among extract_boundary_cycles() 2023-01-12 17:01:19 +00:00
Mael 4d22c90474
Merge branch 'master' into feature/bug_documentation_spell_20221113 2023-01-04 10:06:45 +01:00
hoskillua f6855fef22 single vertex computation
implemented single vertex curvature computation
compared against the whole mesh computation on both cases of no radius and with radius on some vertices
still need to add tests, documentation and an example file
2023-01-03 12:13:26 +02:00
Mael Rouxel-Labbé 5e101566fb Remove obsolete typedefs 2023-01-02 10:34:27 +01:00
Sébastien Loriot 6e7eda918c remove PCA version 2022-12-23 16:12:33 +01:00
Sébastien Loriot 898142d739 wrong type 2022-12-22 09:49:35 +01:00
Sébastien Loriot f993ad50c9 conditions of inconsistenit_classification() also apply to assertions 2022-12-19 17:43:12 +01:00
Sébastien Loriot f372bbe7c2 make smooth an option that is OFF by default 2022-12-19 14:35:16 +01:00
Mael Rouxel-Labbé 70efea3bcb Tiny code modernization 2022-12-16 16:28:53 +01:00
Mael Rouxel-Labbé 92bd00f612 Change PMP::refine() is_flippable criterion
The current criterion is some kind of Delaunay ball, which might work OK
for flat regions, but can produce super thin wedges (see issue:
https://github.com/CGAL/cgal/issues/6982) when the mesh is not flat.

The criterion used instead is the one used in PMP::isotropic_remeshing
and PMP::remove_almost_degenerate_faces(), which is the typical angle-based
surface Delaunay criterion.
2022-12-16 16:26:43 +01:00
Mael Rouxel-Labbé 52fc2ffdd4 Change criterion used in "should_flip"
The criterion that takes the scalar_product of the cross products
is maybe adapted to minimize the curvature when triangulating faces,
but should_flip() is used in PMP::isotropic_remeshing, (soon) PMP::refine(),
and PMP::remove_almost_degenerate_faces(). These algorithms aim to
produce well-shaped elements. The criterion is not adapted to these
algorithms: for example, on a flat mesh the scalar product is meaningless
so it will pick the diagonal which maximizes the product of the lengths
and product of sines, but this might create very anisotropic elements
since the sine of obtuse angles is still positive.

The "new" criterion is simply the criterion used in mesh smoothing
and the typical Delaunay criterion for surfaces.
2022-12-16 16:21:46 +01:00
Mael Rouxel-Labbé a798fb6803 Minor example improvements 2022-12-16 16:20:25 +01:00
Laurent Rineau f1e1878b8d
Merge pull request #7094 from afabri/PMP_named_parameters-GF
PMP: Replace parameter with named parameter
2022-12-16 10:52:17 +01:00
Sébastien Loriot 069e43a5da remove specific internal exclude list (covered with the general one) 2022-12-15 10:20:45 +01:00
Laurent Rineau c419f52799 Merge pull request #7103 from sloriot/PMP-repair_si_conditional_smoothing
Do not apply smoothing if the CC has some degenerate faces
2022-12-14 10:39:48 +01:00
Laurent Rineau f3e0f45054 Merge pull request #7108 from afabri/PMP-Envelope_warning-GF
PMP: Fix for a -Wmaybe-uninitialized
2022-12-14 10:39:45 +01:00
Laurent Rineau 46b1d230f5 Merge pull request #7103 from sloriot/PMP-repair_si_conditional_smoothing
Do not apply smoothing if the CC has some degenerate faces
2022-12-14 10:18:21 +01:00
Laurent Rineau 2b71438c04 Merge pull request #7108 from afabri/PMP-Envelope_warning-GF
PMP: Fix for a -Wmaybe-uninitialized
2022-12-14 10:18:19 +01:00
Andreas Fabri 39ebebdb5b merge master 2022-12-08 16:49:09 +00:00
Sebastien Loriot f5c41bd712
Merge pull request #7022 from MaelRL/Weights-v2.0-GF-master
Weights fixes (master)
2022-12-08 15:22:19 +01:00
Sebastien Loriot b9a87af07e
Merge pull request #7023 from MaelRL/Weights-v2.0-GF-5.5.x
Weights fixes (5.5.x)
2022-12-08 15:21:58 +01:00
Sebastien Loriot fa72ad2ad0
Merge pull request #6977 from MaelRL/Weights-v2.0-GF
Weights fixes (5.4.x)
2022-12-08 15:21:43 +01:00
Mael Rouxel-Labbé a2316e3f21 Minor improvements 2022-12-08 14:38:36 +01:00
Mael Rouxel-Labbé 28663265c6 Merge remote-tracking branch 'cgal/master' into PMP-snap_no_deg_faces_created 2022-12-08 14:35:48 +01:00
Andreas Fabri 9159816fb4 PMP: Fix for a -Wmaybe-uninitialized 2022-12-07 08:02:35 +00:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Mael db81e4a3fb
Further clarify doc 2022-12-06 22:13:05 +01:00
Andreas Fabri 1adb13edc8 Do not use deprecated functions 2022-12-06 12:34:26 +00:00
Mael 6538b22e06
Merge branch 'master' into CGAL-Clean_CMakeLists.txt-GF 2022-12-05 16:03:41 +01:00
Laurent Rineau 90f6546d77 Merge pull request #7069 from sloriot/PMP-split_repair_5.5
Split repair
2022-12-05 13:50:25 +01:00
Laurent Rineau 42c8c4f9e1 Merge pull request #7070 from sloriot/PMP-split_repair
Split repair (master version)
2022-12-05 12:23:19 +01:00
Laurent Rineau 041df61a70 Merge pull request #7074 from sloriot/PMP-compatible_orientation_missing_option
CGAL::PMP::compatible_orientations: add missing option
2022-12-05 12:22:09 +01:00
Laurent Rineau 17fd74e432 Merge pull request #7090 from afabri/PMP-assertion_bug-GF
Polygon Mesh Processing:  Fix CGAL_assertion_msg
2022-12-05 12:21:51 +01:00
Laurent Rineau 33cffd9c26 Merge pull request #7074 from sloriot/PMP-compatible_orientation_missing_option
CGAL::PMP::compatible_orientations: add missing option
2022-12-05 11:57:16 +01:00
Laurent Rineau ead1795d85 Merge pull request #7090 from afabri/PMP-assertion_bug-GF
Polygon Mesh Processing:  Fix CGAL_assertion_msg
2022-12-05 11:57:06 +01:00
Sébastien Loriot ffc20ffbd1 do not apply smoothing if the CC has some degenerate faces 2022-12-01 04:33:53 +01:00