## Fixed the Landmark point-location strategy of the Aos_2 package, so
that it can be applied to arrangements on a sphere.
The title says it all.
I slightly changed one paragraph in the user manual.
Here is the new version:
The arrangement attached to the landmark strategy must be either (i) an
instance of the `Arrangement_2]<Geom,Dcel>` class template, where the
`Traits` parameter is substituted by a geometry-traits class that models
the `ArrangementLandmarkTraits_2` concept, or (ii) an instance of the
`Arrangement_on_surface_2<GeomTraits,TopolTraits>` class template, where
the `GeometryTraits` is similarly substituted; see Section The Landmark
Concept for details about this concept.
## Release Management
* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): NA
* Feature/Small Feature (if any): NA
* Link to compiled documentation: Changed one paragraph; see above.
* License and copyright ownership: TAU
The regular expression I used was:
```
((?!(?:^.*(\/\/|\/\*).*|^ *\* .*|^[^"]*"(?:"[^"]*"|[^"])*))^(?:.*[ ,\(]|))(\b(?:(?:[A-Za-z]+::)*)(?:max|min))\b *\(
```
Correction of incorrect usage of LaTeX in formulas and bibliography
altough MatHJax and bibtex.pl doesn't always signal it.
- Incorrect biblio entry (missing `,` and `}`)
- Documentation/doc/biblio/geom.bib
- ` ` is not correct LaTeX has to be `~`
-
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt
- Documentation/doc/Documentation/Developer_manual/Chapter_intro.txt
- Incorrect formula regarding usage of `\left` and `\right` (also
signaled by MathJax
-
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt
- `DeclareMathOperator` is a command that should be in the preamble,
alternatively the command `\operatorname` can be used explicitly (as
done here as it is only used once)
-
Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/Kinetic_surface_reconstruction.txt
- Latex has problems with `_` in a `text...` command so it should be
escaped though this gives problems with MathJax hence the extra hook.
MathJax reference:
https://groups.google.com/g/mathjax-users/c/wSh6-hSIUpQ/m/KmzZhQQGslgJ
- Documentation/doc/resources/1.10.0/CGAL_mathjax.js
- Documentation/doc/resources/1.8.13/CGAL_mathjax.js
- Documentation/doc/resources/1.9.6/CGAL_mathjax.js
- Weights/include/CGAL/Weights/authalic_weights.h
## Summary of Changes
Introduces two traits decorators, namely `Arr_tracing_traits_2` and
`Arr_counting_traits_2`, which can be used to extract debugging and
informative metadata about the traits in use while the program is being
executed. They have been part of the CGAL distribution for several years
now . (Probably more than a decade.) I gave it a face lift, wrote the
necessary documentation, and added a small example program called
count_and_trace.cpp.
## Release Management
* Affected package(s): 2D Arrangements (Arrangement_on_surface_2)
* Issue(s) solved (if any): NA
* Feature/Small Feature (if any): Aos 2 Metadata Traits Decorators --
**Pre-approval date 2024/11/12**
* Link to compiled documentation (obligatory for small feature)
[Manual](https://www.cs.tau.ac.il/~efif/doc_output9/Arrangement_on_surface_2/)
* License and copyright ownership: TAU
Correction of incorrect usage of LaTeX in formulas and bibliography altough MatHJax and bibtex.pl doesn't always signal it.
- Incorrect biblio entry (missing `,` and `}`)
- Documentation/doc/biblio/geom.bib
- ` ` is not correct LaTex has to be `~`
- Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt
- Documentation/doc/Documentation/Developer_manual/Chapter_intro.txt
- Incorrect formula regarding usage of `\left` and `\right` (also signaled by MathJax
- Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt
- `DeclareMathOperator` is a command that should be in the preamble, alternatively the command `\operatorname` can be used explicitly (as done here as it is only used once)
- Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/Kinetic_surface_reconstruction.txt
- Latex has problems with `_` in a `text...` command so it should be escaped though this gives problems with MathJax hence the extra hook.
MathJax reference: https://groups.google.com/g/mathjax-users/c/wSh6-hSIUpQ/m/KmzZhQQGslgJ
- Documentation/doc/resources/1.10.0/CGAL_mathjax.js
- Documentation/doc/resources/1.8.13/CGAL_mathjax.js
- Documentation/doc/resources/1.9.6/CGAL_mathjax.js
- Weights/include/CGAL/Weights/authalic_weights.h
Fixed the code that computes intersections in the polycurve traits
(Arr_polycurve_traits_2).
## Summary of Changes
The code of the Intersection_2 functor was developed from scratch.
The old code only supported polylines (by mistake), that is, chains of
segments.
The new code supports intersections of chains of any type of sub-curves.
It turns out that the new code is ~15% more efficient.
While at it, I replaced 'typedef' statements with modern 'using'
statements.
## Release Management
Apparently, there is no "CHANGES.md" file yet for 6.1, so I'll add an
entry that informs about this fix after it is introduced (to 'master'
and 'master' is merged to this branch.)
* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): fix#8468
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership: TAU
## Summary of Changes
- Changed `PUBLIC` to `PRIVATE` in the `target_link_libraries()`
- ~~Link against `Boost::<COMPONENT>`~~ as we do more than just linking
and must use the `CGAL::_.._support`
- Use `target_compile_definitions()` and `add_compile_definitions()`
More to be done.
## Release Management
* Affected package(s): all
* Issue(s) solved (if any): fix one item of #4815
* License and copyright ownership: unchanged
## Summary of Changes
This PR removes outdated conditional blocks that check for specific Qt
versions since CGAL now uses Qt6 exclusively.
## Release Management
* Issue(s) solved (if any): #8381
Efi Fogel
Sébastien Loriot
Laurent Rineau
albert-github
Sebastien Loriot
Sven Oesau
Andreas Fabri
Nicolas Saillant
Mael Rouxel-Labbé