Mael Rouxel-Labbé
521c72d57e
Fix typos
2021-10-04 13:34:07 +02:00
Maxime Gimeno
e6c767d5c9
Simplify the GNUC versions tests
2021-05-12 15:45:07 +02:00
Laurent Rineau
21755b1123
Merge pull request #5245 from GilesBathgate/create-assertions-fix
...
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
2021-03-24 15:05:41 +01:00
Sébastien Loriot
4bb0406240
do not include boost/bind.hpp (shouldn't be used anymore) + fix remaining bind
...
(nasty using namespace boost!)
2021-02-12 15:35:19 +01:00
Giles Bathgate
5a36ff89b5
Drop NDEBUG it is already visible through CGAL_NO_ASSERTIONS
2020-12-04 19:42:21 +00:00
Laurent Rineau
2e8a59d570
Merge branch 'releases/CGAL-4.14-branch' into releases/CGAL-5.0-branch
2020-07-21 15:25:54 +02:00
Laurent Rineau
b2be86babc
Fix result_of issue with C++03
2020-07-17 10:04:03 +02:00
Sébastien Loriot
0779373835
extra run of the script to remove tabs and trailing whitespaces
...
right after the merge of 4.14 release branch
+ manual fix on one line in:
* Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
* .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sébastien Loriot
590612a563
run the script to remove tabs and trailing whitespaces
2020-03-26 13:25:16 +01:00
Sébastien Loriot
254d60f642
First pass on removing license notice in header for GPL files
2019-10-19 15:23:19 +02:00
Sébastien Loriot
7356421d80
introduce Commercial license SPDX tag
2019-10-19 12:15:19 +02:00
Sébastien Loriot
9bd9c68b83
update LGPL[23]+ and GPL[23]+ SPDX tags
...
ack -l --no-svg "SPDX-License-Identifier: GPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-3.0+/SPDX-License-Identifier: GPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-3.0+/SPDX-License-Identifier: LGPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: GPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-2.0+/SPDX-License-Identifier: GPL-2.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-2.0+/SPDX-License-Identifier: LGPL-2.0-or-later/"
2019-10-18 21:57:54 +02:00
Andreas Fabri
e2d19b0c8d
Replace NULL and Nullptr_t with nullptr and nullptr_t
2019-06-04 23:45:44 +02:00
Maxime Gimeno
d7b85085fd
Somehow silent the warning that was actually due to an optionnal in the circulatior type.
2019-05-03 11:01:52 +02:00
Andreas Fabri
7dabb4c47b
Move variable in the ifdef/endif scope
2019-04-30 10:12:58 +02:00
Andreas Fabri
1c72c40b65
Try to fix warning
2019-04-30 08:39:01 +02:00
Andreas Fabri
146dfce5fe
Fix the definition of Partition_traits_2::Polygon_2
2019-04-24 10:34:25 +02:00
Andreas Fabri
98c915f9c2
Add a PointPropertyMap to Partition_traits with as default Identity_property_map
2019-04-23 15:53:02 +02:00
Andreas Fabri
804184ba78
Do not copy the traits object
2019-04-18 11:33:10 +02:00
Andreas Fabri
f6e3221d98
Easy fixes after Mael's review
2019-04-17 22:33:04 +02:00
Andreas Fabri
a22bc68939
Fix warning
2019-04-17 09:19:07 +02:00
Andreas Fabri
70c115b1e9
Fix bug which was revealed through minkowski testsuite
2019-04-16 13:52:11 +02:00
Sébastien Loriot
bd5ef7d9ea
fix init order
2019-04-12 14:52:38 +02:00
Andreas Fabri
fe9fce35f6
Remove typename
2019-04-12 10:31:29 +02:00
Andreas Fabri
a9bb23ce64
cleanup
2019-04-11 11:53:33 +02:00
Andreas Fabri
66437517c9
cleanup
2019-04-11 10:54:00 +02:00
Andreas Fabri
dd6691b2ce
remove template parameter
2019-04-11 09:21:37 +02:00
Andreas Fabri
d60ebe5d87
No need for constructions
2019-04-10 17:33:26 +02:00
Andreas Fabri
2bbfe86fe2
Remove unused code
2019-04-10 14:14:47 +02:00
Andreas Fabri
e632bebdba
Fixes so that the testsuite compiles again
2019-04-10 13:18:25 +02:00
Andreas Fabri
2458965c15
Default initialize
2019-04-10 12:18:57 +02:00
Andreas Fabri
c7d55b72cf
Get rid of construct_segment/construct_ray/intersect/assign in Vertex_visibility_graph
2019-04-09 17:38:40 +02:00
Andreas Fabri
ff305562ff
cleanup
2019-04-09 14:27:18 +02:00
Andreas Fabri
f42e8952f5
Merge branch 'master' into Partition_2-Traits_with_state-GF
2019-04-09 13:57:57 +02:00
Andreas Fabri
2ed0f2d94b
Fixes and add documentation
2019-04-09 13:49:11 +02:00
Andreas Fabri
3d0674ed4f
Add an example that used the traits adapter
2019-04-09 13:10:59 +02:00
Andreas Fabri
ca161c5639
Partition_2: Make it work for a traits with state
2019-04-09 10:54:03 +02:00
Andreas Fabri
4ebeaf017d
WIP - we first have to make it work for a traits class with state
2019-04-08 17:41:09 +02:00
Andreas Fabri
baa2cf4e40
cleanup
2019-04-03 08:22:40 +02:00
Andreas Fabri
7127fa32ad
It now works for all partitions.
...
Somebody should check if the change in
Partition_2/include/CGAL/Partition_2/Rotation_tree_2.h
is ok.
2019-04-02 15:55:45 +02:00
Andreas Fabri
4eeb1fa37f
WIP towards making all partition methods work
2019-04-02 15:31:59 +02:00
Sébastien Loriot
ecd818a3a7
remove cpp11 condition
2019-03-29 10:41:50 +01:00
Laurent Rineau
49732a118c
Merge remote-tracking branch 'cgal/master' into Ipelets-Fix_warning-GF
2019-02-13 16:27:54 +01:00
Laurent Rineau
d97726ffe4
Fix a warning [-Wmaybe-uninitialized]
...
```
In file included from /mnt/testsuite/include/CGAL/Cartesian/Weighted_point_2.h:29,
from /mnt/testsuite/include/CGAL/Cartesian/Cartesian_base.h:34,
from /mnt/testsuite/include/CGAL/Cartesian.h:29,
from /home/cgal_tester/build/src/cmake/platforms/Fedora-rawhide-Release/test/Partition_2/approx_convex_partition_2_test_C.cpp:31:
/mnt/testsuite/include/CGAL/Handle_for.h: In function ‘bool CGAL::partition_appx_cvx_cuts_nonconvex_angle(Edge_circulator, Circulator, const Triangulation&, const Traits&) [with Edge_circulator = CGAL::Triangulation_ds_edge_circulator_2<CGAL::Triangulation_data_structure_2<CGAL::Triangulation_vertex_base_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Triangulation_ds_vertex_base_2<void> >, CGAL::Constrained_triangulation_face_base_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Triangulation_face_base_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Triangulation_ds_face_base_2<void> > > > >; Circulator = CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>; Triangulation = CGAL::Constrained_triangulation_2<CGAL::Triangulation_indirect_traits_2<CGAL::Safe_circulator_from_iterator<__gnu_cxx::__normal_iterator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >*, std::vector<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, std::allocator<CGAL::Partition_vertex<CGAL::Partition_traits_2<CGAL::Cartesian<double> > > > > >, int, int, int>, CGAL::Partition_traits_2<CGAL::Cartesian<double> > >, CGAL::Default, CGAL::Default>; Traits = CGAL::Partition_traits_2<CGAL::Cartesian<double> >]’:
/mnt/testsuite/include/CGAL/Handle_for.h:313:12: warning: ‘*((void*)& next_ccw_pt_ref +40)’ may be used uninitialized in this function [-Wmaybe-uninitialized]
313 | return *(h.Ptr());
In file included from /mnt/testsuite/include/CGAL/partition_2.h:30,
from /home/cgal_tester/build/src/cmake/platforms/Fedora-rawhide-Release/test/Partition_2/approx_convex_partition_2_test_C.cpp:33:
/mnt/testsuite/include/CGAL/Partition_2/partition_approx_convex_2.h:91:34: note: ‘*((void*)& next_ccw_pt_ref +40)’ was declared here
91 | typename Triangulation::Point next_ccw_pt_ref, prev_ccw_pt_ref;
| ^~~~~~~~~~~~~~~
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.14-Ic-122/Partition_2/TestReport_gimeno_Fedora-rawhide-Release.gz
2019-02-13 16:03:20 +01:00
Laurent Rineau
896d5a7bd9
Quiet a warning [-Wmaybe-uninitialized]
...
```
[ 50%] Building CXX object CMakeFiles/test_exact_offset.dir/test_exact_offset.cpp.o
/usr/local/bin/c++ -DCGAL_TEST_SUITE=1 -DCGAL_USE_CORE=1 -DCGAL_USE_GMP -DCGAL_USE_MPFR -isystem /usr/include/x86_64-linux-gnu -I/home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2 -I/home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/include -I/mnt/testsuite/include -DDONT_USE_BOOST_PROGRAM_OPTIONS -Wall -Wextra -O3 -DCGAL_NDEBUG -frounding-math -Wall -frounding-math -o CMakeFiles/test_exact_offset.dir/test_exact_offset.cpp.o -c /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2/test_exact_offset.cpp
In file included from /mnt/testsuite/include/CGAL/Cartesian/Weighted_point_2.h:29,
from /mnt/testsuite/include/CGAL/Cartesian/Cartesian_base.h:34,
from /mnt/testsuite/include/CGAL/Cartesian.h:29,
from /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2/test_exact_offset.cpp:16:
/mnt/testsuite/include/CGAL/Handle_for.h: In function 'OutputIterator CGAL::partition_approx_convex_2(InputIterator, InputIterator, OutputIterator, const Traits&) [with InputIterator = __gnu_cxx::__normal_iterator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >*, std::vector<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >, std::allocator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> > > > >; Traits = CGAL::Partition_traits_2<Rat_kernel>; OutputIterator = std::back_insert_iterator<std::__cxx11::list<CGAL::Polygon_2<Rat_kernel, std::__cxx11::list<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >, std::allocator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> > > > >, std::allocator<CGAL::Polygon_2<Rat_kernel, std::__cxx11::list<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >, std::allocator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> > > > > > > >]':
/mnt/testsuite/include/CGAL/Handle_for.h:313:12: warning: '*((void*)& target +40)' may be used uninitialized in this function [-Wmaybe-uninitialized]
313 | return *(h.Ptr());
In file included from /mnt/testsuite/include/CGAL/partition_2.h:30,
from /mnt/testsuite/include/CGAL/Minkowski_sum_2/Decomposition_strategy_adapter.h:31,
from /mnt/testsuite/include/CGAL/Polygon_convex_decomposition_2.h:27,
from /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2/test_exact_offset.cpp:22:
/mnt/testsuite/include/CGAL/Partition_2/partition_approx_convex_2.h:173:23: note: '*((void*)& target +40)' was declared here
173 | Circulator source, target, before_s, after_s;
| ^~~~~~
```
It seems sufficient to declare the variables at a smaller
scope. Strange...
2019-02-11 14:50:50 +01:00
Laurent Rineau
afc3de2894
Merge branch 'master' into Stream_support-Color-GF
2019-01-23 09:37:08 +01:00
Andreas Fabri
561d689142
Fix Partition_2
2019-01-18 16:07:32 +01:00
Sébastien Loriot
0685423ae8
update from cgal/master
2018-11-02 11:32:31 +01:00
Andreas Fabri
b33ab791e1
Disable a warning. Fix an allocator call
2018-05-15 15:37:51 +02:00
Andreas Fabri
955b6a89e6
fix includes
2018-05-04 09:00:11 +02:00