Commit Graph

1798 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé dd2fca2780 Actually test the full EPECK family 2024-11-03 18:16:13 +01:00
Mael Rouxel-Labbé ee451ed469 Fix dangling reference in Construct_center_3(Circle_3)
This fixes the issue, but it could still be broken e.g. by a kernel
that is based on a CGAL kernel, but redefines the Sphere_3 and
with Sphere_3-functor that would not return a const& (or in that
case the custom kernel needs to define the appropriate functors
too...)

But so much breaks into this configuration, that it's out of scope
for this fix.
2024-11-03 18:09:45 +01:00
Sebastien Loriot 1690619625
CGAL: Modernize CMakeLists.txt (#8528)
## Summary of Changes

- Changed `PUBLIC` to `PRIVATE`  in the `target_link_libraries()`
- ~~Link against `Boost::<COMPONENT>`~~ as we do more than just linking
and must use the `CGAL::_.._support`
- Use `target_compile_definitions()` and `add_compile_definitions()`

More to be done.

## Release Management

* Affected package(s): all
* Issue(s) solved (if any): fix one item of  #4815
* License and copyright ownership: unchanged
2024-10-31 10:32:25 +01:00
Sébastien Loriot fb605cdd39 remove -D that is not compatible with "older" cmake versions 2024-10-22 08:19:49 +02:00
Laurent Rineau d759e72d8d third batch of modifications 2024-10-17 00:17:59 +02:00
Sven Oesau a06002ab2b Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-10-14 14:42:46 +02:00
Andreas Fabri a7ff1c0c79 Add one permution. In fact it should be any mix of types in any order 2024-10-09 16:16:04 +01:00
Andreas Fabri 9e75ab340d Use add_compile_definitions 2024-10-09 11:58:52 +01:00
albert-github f7320ae1c1 Spelling corrections
Spelling corrections
2024-09-13 17:53:05 +02:00
Sebastien Loriot 47c417a785
Deal with duplicate lines (#8396)
## Summary of Changes

Deal with Issue #8348 

## Release Management

* Affected package(s):  Triangulation_2 and Periodic_triangulation_2
* Issue(s) solved (if any): fix #8348 
* License and copyright ownership:  unchanged
2024-08-19 11:17:50 +02:00
Andreas Fabri 12468ccf4a Address #8401 2024-08-09 11:32:26 +01:00
Mael 1a7e526da3
Remove extra comma 2024-07-08 16:31:33 +02:00
Mael Rouxel-Labbé d2475215bb Use the kernel functor for vector constructions 2024-07-04 18:51:58 +02:00
Mael Rouxel-Labbé de4359ad6a Add Compare_angle_3 tests 2024-07-04 18:45:50 +02:00
Mael Rouxel-Labbé 16ea300ab6 Add Compare_angle_3 overload and missing global functions 2024-07-04 18:34:09 +02:00
Mael Rouxel-Labbé 67aba3fefe Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-06-20 10:18:49 +02:00
Laurent Rineau 32893b91c0 Merge pull request #8263 from lrineau/CGAL-update_minimal_cmake-GF
cmake_minimum_required(VERSION 3.12...3.29)
2024-06-12 10:06:12 +02:00
Laurent Rineau 5b003a7808 Merge pull request #8246 from albert-github/feature/bug_spell_20240531
Spelling corrections
2024-06-10 18:47:22 +02:00
Laurent Rineau ee948a2041 Merge branch '5.6.x-branch' 2024-06-10 18:47:09 +02:00
Laurent Rineau b5d531116b Merge pull request #8245 from sloriot/Kernel_23-missing_template
Add missing template parameter in the doc
2024-06-10 18:28:33 +02:00
Laurent Rineau 3a223ebd1e cmake_minimum_required(VERSION 3.12...3.29) 2024-06-06 20:19:44 +02:00
albert-github 36c8b7589d Spelling corrections
Last batch (for now) of spelling corrections in doxygen and normal comments
2024-05-31 19:05:34 +02:00
Sébastien Loriot 3f931d55ff add missing template parameter 2024-05-31 15:08:42 +02:00
Laurent Rineau b8022cbe9f Revert "experiment adding tuple-like support for Segment_3"
This reverts commit ac47f30cd8.
2024-05-22 13:06:39 +02:00
Laurent Rineau 70464ea107 Merge remote-tracking branch 'afabri/STL_extension-Fix_Prevent_deref-GF' into pr/lrineau/8170 2024-05-21 18:55:11 +02:00
Laurent Rineau e9fb0190c3 Merge pull request #7373 from sloriot/Kernel-Perfect_forwarding
Add some perfect forwarding in the Kernel
2024-05-15 16:12:23 +02:00
Laurent Rineau 022b19d3ca Merge pull request #8057 from sloriot/AABB_tree-2d_and_3d
Updating the AABB-tree to work in both 2D and 3D
2024-05-15 16:12:19 +02:00
Laurent Rineau ab37b326d0 Merge pull request #8175 from afabri/Kernel_23-fix_issue_8140-GF
Kernel_23: Fix Issue 8140
2024-05-15 16:12:03 +02:00
Andreas Fabri efdf503e2c Kernel_23: Fix Issue 8140 2024-04-29 16:38:51 +01:00
Laurent Rineau ac47f30cd8 experiment adding tuple-like support for Segment_3 2024-04-26 14:44:37 +02:00
Laurent Rineau cfb8722861 add comments on Compare_angle_3 2024-04-26 14:37:21 +02:00
Laurent Rineau 4adf7e786b fix Compare_angle_3 with six points 2024-04-26 14:37:21 +02:00
Laurent Rineau 15d4d788e6 add Compare_angle_3 with 6 points 2024-04-26 14:37:04 +02:00
Laurent Rineau e313fdc697 Add Compare_xy_2 to TriangulationTraits_2
This enables customization of projection traits for CDT_2s and
facilitates unification with the predicates utilized in
3D triangulations.
2024-04-26 12:13:35 +02:00
Laurent Rineau f305159a26 Merge remote-tracking branch 'cgal/master' into pr/sloriot/7373 2024-04-23 14:37:29 +02:00
Sven Oesau ffba6279c9 Merge remote-tracking branch 'cgal/master' into AABB_tree-2d_and_3d 2024-04-19 08:47:54 +02:00
Andreas Fabri 3effd785c4 Add transform to Polygon_with_holes and Multipolygon_with_holes 2024-04-16 09:05:50 +01:00
Andreas Fabri aad631a533 fixes after review 2024-04-11 10:40:46 +01:00
Laurent Rineau d5ae0c9b94 add a test, and the new class template NT_wrapper 2024-03-28 15:44:47 +01:00
Sébastien Loriot 5254404517 Merge remote-tracking branch 'cgal/master' into HEAD 2024-03-27 22:25:41 +01:00
Laurent Rineau 1926ffd619 Merge remote-tracking branch 'cgal/master' into Kernel-Perfect_forwarding 2024-03-27 17:00:45 +01:00
Laurent Rineau d6c39e52bd fixes
Use:
  - perfect forwarding in objects of the kernel (`Point_2`, `Point_3`,
    `Vector_2`, `Vector_3`), and also in `PointC2`, and `PointC3`
    (that forward to the equivalent vector)
  - constructors with rvalue references in `VectorC2` and `VectorC3`.
2024-03-27 15:56:03 +01:00
Sven Oesau 86fe47c7f7 re-add Construct_projected_point_2 for 2d closest point query 2024-03-21 12:03:57 +01:00
Sébastien Loriot c6ee406603 undo projection traits changes 2024-03-21 09:41:25 +01:00
Andreas Fabri a650d59632 whitespace 2024-03-15 16:23:12 +01:00
Andreas Fabri 40464539ad bug fix 2024-03-15 16:11:34 +01:00
Andreas Fabri f231a3d812 Enrich Projection_traits so that it can be used with AABB_traits_2 2024-03-15 16:06:46 +01:00
Sven Oesau 37e36b8532 fixed tests for point_2 on segment_2 and on triangle_2 2024-03-08 16:43:21 +01:00
Sven Oesau 3f9c5222e2 WIP: adding Construct_projected_point_2 for point onto segment and point onto triangle 2024-03-06 18:23:39 +01:00
Jane Tournois f786b86432 Merge remote-tracking branch 'cgal/master' into PMP-add_bbox_to_face_graph-jtournois 2024-03-06 16:04:58 +00:00
Jane Tournois 75160fc24b reduce number of operations in bbox scaling 2024-03-06 11:52:26 +01:00
Sven Oesau 911ac1a34d added Construct_projected_point_2(Segment_2, Point_2) 2024-03-05 15:54:27 +01:00
Jane Tournois 2d288803b9 doc precondition 2024-03-05 11:25:01 +01:00
Jane Tournois 6407f852e6 add scale(factor) to bbox_2 and uniformize implementation with bbox_3 2024-03-05 09:47:16 +01:00
Jane Tournois 3ceaaccfa1 document Bbox_3::scale(factor) 2024-03-04 16:09:40 +01:00
Jane Tournois 272beb678a move scaling to CGAL::Bbox_3 2024-03-04 16:08:10 +01:00
Laurent Rineau 820465a556 Merge pull request #8023 from sloriot/PMP-soup_autoref_insert_in_edge
Autorefinement: insert points in edge to avoid filter failures
2024-02-28 10:57:25 +01:00
Laurent Rineau fd0dfc6f24 Merge pull request #8008 from afabri/Kernel_23-squared_length-GF
Kernel_23:  Add function squared_length()
2024-02-22 10:23:04 +01:00
Andreas Fabri 4b574dca8e Add tests 2024-02-14 11:43:34 +00:00
albert-github a41564060d Incorrect layout bisector precondition
On the page Kernel_23/group__bisector__grp.html we see for `bisector` with the `Point_3` type arguments in the precondition:
```
‘p != q’
```
instead of
```
p != q
```
due to the fact that there is not a backtick but a single quote as closing part
2024-02-03 17:49:03 +01:00
Mael Rouxel-Labbé 07b9587eae Merge remote-tracking branch 'afabri/Kernel_23-squared_length-GF' into gsoc2022-isosurface 2024-01-31 16:47:01 +01:00
Andreas Fabri e3ee999024 fix grp 2024-01-29 16:26:29 +00:00
Andreas Fabri 276857a49c fix grp 2024-01-29 16:22:20 +00:00
Andreas Fabri ab19b99105 Kernel_23: Add function squared_length() 2024-01-29 16:16:17 +00:00
Mael Rouxel-Labbé f9858e53db Fix location of doc image 2024-01-23 21:50:04 +01:00
Mael Rouxel-Labbé 984a541006 Fix usages of 'th `th 2024-01-23 21:50:04 +01:00
Sebastien Loriot 128b169b24
Fixes when neither LEDA nor GMP is available (#7960) 2024-01-19 13:57:12 +01:00
Andreas Fabri a783412ba7 Use structural filtering for the fixed projection traits classes 2024-01-19 11:51:54 +01:00
Laurent Rineau 11fc1943fb Merge branch '5.5.x-branch' into 5.6.x-branch 2024-01-11 12:44:54 +01:00
Mael Rouxel-Labbé d483b3bdfd Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-01-09 13:52:46 +01:00
Laurent Rineau 3607dc8d0c Merge pull request #7953 from sloriot/Kernel_23-remove_unused_var
Remove unused variable
2024-01-08 10:59:12 +01:00
Sébastien Loriot 3a8ced2ec9 skip if neither core nor leda are present 2024-01-03 18:18:42 +01:00
Sébastien Loriot eed5e4f61f move comment 2024-01-02 13:15:28 +01:00
Sébastien Loriot a4ba059221 remove unused variable 2024-01-02 09:34:07 +01:00
Sebastien Loriot caecbe29c7
Replace boost::mpl (#7813)
- `boost::mpl::if_` --> `std::conditional`
- `boost::enable_if` -> `std::enable_if`
- `boost::mpl::and_` -> `&&`
- `boost::mpl::or_` -> `||`
- `boost::constant::bool_` -> `std::bool_constant`
- ...
2023-12-26 17:33:36 +01:00
Sébastien Loriot 6eff89bbc8 Merge pull request #7614 from sloriot/PMP-BF_autorefine
Add autorefine for triangle soup
2023-12-26 12:11:04 +01:00
Sébastien Loriot 89d3d74865 Merge remote-tracking branch 'cgal/5.6.x-branch' 2023-12-18 13:31:48 +01:00
Sébastien Loriot ee1fa58406 Merge remote-tracking branch 'cgal/5.5.x-branch' 2023-12-18 13:31:06 +01:00
Sebastien Loriot 00f0c85499
Kernel_23: Deal with concurrent executions and IO (#7921)
## Summary of Changes

Write and read back in a `std::stringstream` to avoid simultaneous IO on
the same file name.
Error seen in this
[testsuite](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-124/Circular_kernel_2/TestReport_gimeno_ArchLinux-clang-CXX17-Release.gz).

## Release Management

* Affected package(s):  Kernel_23, Circular_kernel_2
* License and copyright ownership: unchanged
2023-12-18 13:25:36 +01:00
Laurent Rineau 9a944e563c Merge remote-tracking branch 'cgal/master' into PMP-BF_autorefine
# Conflicts:
#	Installation/CHANGES.md
#	Polygon_mesh_processing/examples/Polygon_mesh_processing/CMakeLists.txt
2023-12-13 15:57:30 +01:00
Laurent Rineau e2a745f79f Merge pull request #7892 from sloriot/CGAL-fix_dh_angle_sign
fix dihedral angle computation
2023-12-11 13:56:02 +01:00
Laurent Rineau 4be3a1e589 Merge pull request #7892 from sloriot/CGAL-fix_dh_angle_sign
fix dihedral angle computation
2023-12-11 13:50:38 +01:00
Andreas Fabri f4154836ae Kernel_23: Deal with concurrent executions and IO 2023-12-11 08:35:02 +00:00
Sébastien Loriot d75e4f2f54 Merge remote-tracking branch 'cgal/master' into PMP-BF_autorefine 2023-12-08 13:26:06 +01:00
Sebastien Loriot 9822b6b085
protect from macro substitution
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2023-11-30 09:20:53 +01:00
Laurent Rineau 46877d4134 fix two typos 2023-11-29 15:34:36 +01:00
Laurent Rineau df4eed9302 add tests for the dihedral angle 2023-11-29 15:27:57 +01:00
Sébastien Loriot 4bed66e82f fix description 2023-11-29 13:17:10 +01:00
Sébastien Loriot 5879bb72c6 add comments about the formula 2023-11-29 13:11:21 +01:00
Sébastien Loriot 0e3f3a33d1 test to be fixed --> tetra orientation is 0 2023-11-29 12:27:34 +01:00
Sébastien Loriot 0145bafbc5 update formula
will add comments in a upcoming commit
2023-11-29 12:22:46 +01:00
Sébastien Loriot 6b570f767e fix sign 2023-11-28 18:10:32 +01:00
Sébastien Loriot 87b8695d8d Merge remote-tracking branch 'cgal/master' 2023-11-27 14:42:00 +01:00
Andreas Fabri 0acea19e20 Fix Kernel_23 2023-10-17 15:30:57 +01:00
Andreas Fabri fb4095a054 Partial fix of Kernel_23 2023-10-17 15:18:55 +01:00
Sébastien Loriot fbd24d665d add version for Point_2/Vector_2 2023-10-09 12:30:37 +02:00
Sébastien Loriot 8700394122 boost::mpl::if_ -> std::conditional 2023-09-24 22:57:20 +02:00
Laurent Rineau 46923342ad Merge pull request #7576 from albert-github/feature/issue_7395
issue #7395 Improvement of layout of model relations

# Conflicts:
#	Kernel_23/doc/Kernel_23/CGAL/Vector_2.h
2023-09-07 10:48:34 +02:00
Laurent Rineau 6ce966767b Merge pull request #7660 from afabri/Arrangement-typo-GF
Arrangement: small doc fixes
2023-09-07 10:46:26 +02:00
Laurent Rineau eb70c2f310 Merge pull request #7650 from sloriot/K23-compare_dihedral_angle_deg_tet
Be more permissive in Compare_dihedral_angle_3
2023-08-28 15:45:12 +02:00