Commit Graph

221 Commits

Author SHA1 Message Date
Jane Tournois fb898e9ab1 remove return_empty_on_invalid_input
and show in an example how to check preconditions
2025-06-13 14:30:05 +02:00
Jane Tournois 1323411457 doc 2025-06-12 17:56:14 +02:00
Jane Tournois 2a2651b343 doc (review round 6 Mael) 2025-06-12 17:42:00 +02:00
Jane Tournois e0324b6ff0 typo! 2025-06-12 17:20:32 +02:00
Jane Tournois 8ebfd91d8e review round 6 Mael (ref manual 1st part) 2025-06-12 13:53:34 +02:00
Jane Tournois 7600e30fd4 fix doxygen warnings 2025-06-05 17:01:56 +02:00
Jane Tournois 0e3778ff1a face/facet vocabulary
the np is now plc_face_id
where "face" stands for "polygon" as in FaceListGraph for example
2025-06-05 16:10:21 +02:00
Laurent Rineau 08d39c959f bug-fix for Thingi-79020 2025-06-04 01:08:04 +02:00
Laurent Rineau 7a2f548768 a lambda function to factorize a piece of code 2025-06-04 00:52:38 +02:00
Jane Tournois 1afaad6fdf use right named parameter name 2025-06-03 10:57:44 +02:00
Jane Tournois 19f10ea890 rename plc_face_id to plc_facet_id 2025-06-02 12:49:03 +02:00
Jane Tournois 9efcb22083 fix include 2025-06-02 12:12:15 +02:00
Jane Tournois 2145617b2c replace assertion with exception 2025-06-02 12:03:23 +02:00
Jane Tournois ab8fed4841 use try/catch to pre-catch non-planar PLC facets when CDT_2 fails 2025-06-02 11:22:38 +02:00
Jane Tournois 1f3e98abac replace face_patch_map with plc_face_id
the patches actually correspond to PLC faces,
which must be planar, and do not match the "face patches"
of PMP::isotropic_remeshing for example

+ add a np to CGAL::IO::write_MEDIT(ccdt) to save the corresponding PLC ids,
or just "1" everywhere as patch id
2025-05-30 16:52:00 +02:00
Laurent Rineau 4e591900d1 fix a bug in get_remeshing_triangulation 2025-05-23 15:42:08 +02:00
Laurent Rineau b3722b1885 rename convert_to_triangulation_3 2025-05-23 12:30:32 +02:00
Laurent Rineau 3db82de277 Tr_of_default/Tr 2025-05-21 14:00:34 +02:00
Laurent Rineau 73fd95ab6b fix warnings 2025-05-20 16:49:14 +02:00
Laurent Rineau a94a768c04 refactor write_MEDIT
... and use it more in CDT_3 examples
2025-05-20 16:49:02 +02:00
Laurent Rineau 37463c9150 2D case 2025-05-20 16:41:08 +02:00
Laurent Rineau 7955df7f66 remove ccdt.convert_for_remeshing()
and inline it into `CGAL::convert_to_triangulation_3(ccdt)`
2025-05-20 16:24:27 +02:00
Laurent Rineau fec07c6488 Tr_or_default/Tr 2025-05-19 18:49:45 +02:00
Laurent Rineau ae597dd2ea review Mael 2025-05-19 18:47:14 +02:00
Laurent Rineau 4d5876392d doc of convert_to_triangulation_3(ccdt) 2025-05-19 18:34:32 +02:00
Laurent Rineau f3f72fcbf3 review Mael 2025-05-19 17:59:56 +02:00
Laurent Rineau aca6fbe2ea reorganize doc of make_conforming_constrained_Delaunay_triangulation_3 2025-05-19 17:57:17 +02:00
Laurent Rineau 5db49a1b89 review Mael 2025-05-19 17:14:57 +02:00
Laurent Rineau d07dc0daad remove the lambda expression
maybe solve that issue:
```
    21>C:\CGAL_ROOT\CGAL-6.1-Ic-155\include\CGAL/Conforming_constrained_Delaunay_triangulation_vertex_data_3.h(82,1): error C2888: '==::<lambda_f8bc645280bb56be32d0268df7c48762>': symbol cannot be defined within namespace 'CGAL' [C:\CGAL_ROOT\CGAL-6.1-Ic-155\cmake\platforms\MSVC-2019-Community-Release\test\Constrained_triangulation_3_Examples\ccdt_3_preprocessing.vcxproj]
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-155/Constrained_triangulation_3_Examples/TestReport_Christo_MSVC-2019-Community-Release.gz
2025-05-16 16:33:03 +02:00
Laurent Rineau 8e398f0aa2 (max) 2025-05-14 10:38:12 +02:00
Laurent Rineau 2035e0c312 refactoring 2025-05-13 17:32:31 +02:00
Sébastien Loriot fba1b5068e be consistant 2025-05-13 15:24:36 +02:00
Sébastien Loriot dca12bcd6b simplify patch id copies 2025-05-13 15:12:59 +02:00
Sébastien Loriot 2887ee0a36 reuse existing map 2025-05-13 14:49:30 +02:00
Sébastien Loriot d6146730a8 fix condition 2025-05-13 13:51:19 +02:00
Sébastien Loriot 57524e12e4 fix rw_points type and construction 2025-05-13 13:43:30 +02:00
Sébastien Loriot e4bd0348a4 avoid precondition checking after creating the mesh from a soup 2025-05-13 13:42:25 +02:00
Laurent Rineau 89966ea79b fix `polygon_id_to_sm_face_map`
The name was wrong, because one needs actually the mapping in two sides.
2025-05-13 12:33:01 +02:00
Sébastien Loriot 9b6bf75b11 missing call to orient soup 2025-05-13 11:43:49 +02:00
Sébastien Loriot 317b64d705 add a macro to reduce dependencies 2025-05-13 11:32:31 +02:00
Sébastien Loriot f40c64ba13 rename np 2025-05-13 11:26:47 +02:00
Sébastien Loriot 0064ea9f3e add missing precondition check for soup + always assert in debug 2025-05-13 11:20:26 +02:00
Sébastien Loriot 6879158e32 typo 2025-05-12 17:50:47 +02:00
Sébastien Loriot 0aba404db4 workaround anchor issues by adding subgroups to disambiguate overloads 2025-05-12 17:47:53 +02:00
Jane Tournois ebd9ecab58 documentation of check_preconditions, the new NP 2025-05-12 15:47:42 +02:00
Jane Tournois 270c507ce7 v0 of add named parameter check_preconditions()
optional parameter, to check a priori that preconditions are satisfied
2025-05-12 15:14:08 +02:00
Jane Tournois ca1a5982b6 add an example with self-intersections and autorefinement 2025-05-12 12:12:32 +02:00
Jane Tournois b70e78f22b document CGAL::IO::write_MEDIT 2025-05-12 10:52:19 +02:00
Jane Tournois 0c3b8b8b11 workaround static_assert for msvc <= 2019 2025-05-12 09:52:51 +02:00
Laurent Rineau 3409d4c974 fix warnings 2025-05-11 23:00:33 +02:00
Laurent Rineau 7c2537b62a merge issue 2025-05-09 16:16:24 +02:00
Laurent Rineau e3190d62db other fixes for MSVC 2017 2025-05-09 16:14:18 +02:00
Jane Tournois 0830299bbf Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-09 16:04:33 +02:00
Jane Tournois 697101bf8e fix remeshing example and test
add edge_is_constrained_map to convert_to_triangulation_3()
similarly to what is done with a C3T3
2025-05-09 16:04:19 +02:00
Laurent Rineau c388b62f3b fixes for msvc 2017 2025-05-09 16:04:05 +02:00
Laurent Rineau a8fb8c5981 fix compilation of cdt_3_plugin 2025-05-09 15:29:01 +02:00
Jane Tournois e3a7e453fe fix compilation with CCDT_cb 2025-05-09 14:35:18 +02:00
Jane Tournois 7180a85762 remove from CCDT_Cb/Vb everything that is needed by Simplicial_Cb/Vb
to separate the needs of different packages
all the needed info is available in ccdt_data() in CCDT_Cb/Vb
2025-05-07 22:42:25 +02:00
Laurent Rineau 774ef98ed6 fix the second constructor in 2D case, and amend the test 2025-05-06 17:01:01 +02:00
Laurent Rineau 0f296df8a7 deal with 2D inputs 2025-05-06 13:09:42 +02:00
Laurent Rineau b394cfd319 add does_polygon_soup_self_intersect
undocumented for now
2025-05-06 13:08:18 +02:00
Laurent Rineau a9469fc688 document that the triangulation must be 3D 2025-05-05 15:47:18 +02:00
Jane Tournois 0575a1e579 write the full documentation only once in the function templates
and add links to it
This avoids future divergence between the 2 versions, and makes things more
clear for the reader
2025-05-05 12:34:52 +02:00
Jane Tournois c3831eef9c wip review Mael
- expose nothing from cell_data and vertex_data
- add const ref
- doc
2025-05-02 16:17:55 +02:00
Jane Tournois 65edb3d613 move sync_vertex_type_with_dimension_and_index() to a lambda function
to avoid undocumented functions in the vertex base
2025-05-02 15:11:32 +02:00
Jane Tournois b9fd8a3b8e rename Base_with_time_stamp to Triangulation_simplex_base_with_time_stamp 2025-05-02 14:44:36 +02:00
Laurent Rineau e31144344f another fix, so that it works as well on Linux 2025-05-02 14:23:31 +02:00
Laurent Rineau d6ae7c9686 MSVC 2019 does not have std::basic_format_string
See https://github.com/microsoft/STL/pull/3074 implemented later in Sept 2022.
2025-05-02 10:57:56 +02:00
Laurent Rineau d47c44f7f3 fix when Qt6 is not available 2025-05-02 09:56:56 +02:00
Laurent Rineau 108cf8e44f fix ws 2025-04-30 17:33:57 +02:00
Laurent Rineau b190978599 fix the static assertions
... by using Boost containers instead of those from the STL.
2025-04-30 11:32:18 +02:00
Laurent Rineau 0ec75e54ee Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into pr/lrineau/8186 2025-04-29 17:41:39 +02:00
Laurent Rineau 1c4e24621c fix the assertions about nothrow_movable in CDT_3
using Boost implementation of `unordered_map` instead of the std:: version.
2025-04-29 17:41:30 +02:00
Jane Tournois da73a5db7f fix type name 2025-04-29 15:58:08 +02:00
Laurent Rineau 9f38c6887f fix doc 2025-04-29 15:47:47 +02:00
Laurent Rineau 958d50eb20 more debug message 2025-04-29 15:47:41 +02:00
Jane Tournois c95bcb5cb7 wip review Mael 2025-04-29 15:17:54 +02:00
Laurent Rineau 89752983f7 protect debug messages with the flag debug_missing_region() 2025-04-29 13:40:44 +02:00
Laurent Rineau 13f8e779e0 fix unused variable 2025-04-28 21:00:52 +02:00
Laurent Rineau c0abf42c57 add CGAL::draw for CCDT_3 2025-04-28 17:07:54 +02:00
Laurent Rineau 58bc7b1a76 always use `auto` for the traits functors 2025-04-28 17:07:54 +02:00
Sébastien Loriot 946472addd fix license checking headers 2025-04-24 20:32:59 +02:00
Laurent Rineau c3bf6f945b Andreas is right: it should be `int` 2025-04-24 12:57:51 +02:00
Laurent Rineau 17c749f44f face_patch_map for polygon soups 2025-04-24 12:56:33 +02:00
Andreas Fabri 4055ff4f94 Replace std_size_t with CDT_3_signed_index 2025-04-11 12:00:47 +01:00
Andreas Fabri 235a9426bb Use CDT_3_signed_index 2025-04-11 10:15:03 +01:00
Andreas Fabri fed7f0bf0d Conditional #include 2025-04-11 09:55:33 +01:00
Sébastien Loriot 261e80f029 add explicit CXX20 2025-04-11 10:49:56 +02:00
Andreas Fabri eeb4decd2a Use named parameter helper 2025-04-11 10:46:23 +02:00
Andreas Fabri 14cfb4d104 Use std::function to avoid VC2017 error 2025-04-11 08:48:37 +01:00
Andreas Fabri 63b8eb9e30 Change anchors 2025-04-08 10:25:22 +01:00
Andreas Fabri 9009ed5c8d clang does not fully support <concepts> 2025-04-08 09:51:18 +01:00
Jane Tournois 620ae7d697 remove tab 2025-04-03 14:12:26 +02:00
Jane Tournois f2d0b189cc typo & todo 2025-04-03 12:54:41 +02:00
Jane Tournois 68b6b6f001 explicitely add default type for Tr, and a public typedef for Triangulation
the default type was already there but hidden in a fwd declaration

+ document convert_to_triangulation_3()
2025-04-03 12:11:49 +02:00
Laurent Rineau cbad336cad fix issue #8811 2025-04-02 18:40:24 +02:00
Laurent Rineau 4e9ecde5e1 merge my work into cgal/Triangulation_3-CDT_3-lrineau 2025-04-02 15:19:41 +02:00
Laurent Rineau fc6e62861f change the way to compute the default CDT type 2025-04-02 15:10:59 +02:00
Jane Tournois 8873d24b44 add missing CGAL:: (compilation error in external project) 2025-04-01 15:36:15 +02:00
Laurent Rineau 398df2bf2a improve Conforming_constrained_Delaunay_triangulation_cell_base_3 2025-03-31 10:09:45 +02:00