Commit Graph

65 Commits

Author SHA1 Message Date
Jane Tournois 5f2afe2e36
fix typedefs (code review)
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2024-09-26 11:58:20 +02:00
Andreas Fabri 7d849ee2d3 Merge remote-tracking branch 'cgal/master' into BGL-Openmesh_selection-GF 2024-09-17 08:48:44 +01:00
Sébastien Loriot 41b096c91a Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-09-11 17:23:50 +02:00
Jane Tournois 2eb80332ba create selection item only when OM file contains feature vertices or edges 2024-09-10 11:07:39 +02:00
Jane Tournois 1066666ad8 Merge remote-tracking branch 'cgal/master' into BGL-Openmesh_selection-GF 2024-09-09 15:26:04 +01:00
Andreas Fabri 705729e45e cleanup 2024-09-08 12:17:24 +01:00
Jane Tournois 2145d262d3 add write_OM() and use it in OM_io_plugin 2024-09-05 17:14:53 +02:00
Jane Tournois 07fac94de2 use CGAL::OpenMesh_support 2024-09-05 17:13:43 +02:00
Sebastien Loriot 9ded34f6dd
Mesh_3 - bug fixes for `edge_distance` and `edge_min_size` (#8405)
## Summary of Changes

While experimenting on self-intersecting polyhedral surfaces, I met two
bugs:
* `edge_min_size` was not enough taken into account in
`Protect_edges_sizing_field`,
* `edge_distance` was missing the information of which `curve_id` the
edge belongs to (available using internal code)
causing crashes.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
2024-08-26 15:24:29 +02:00
Sebastien Loriot fb9120fb30
Remove outdated Qt version checks (#8402)
## Summary of Changes

This PR removes outdated conditional blocks that check for specific Qt
versions since CGAL now uses Qt6 exclusively.

## Release Management

* Issue(s) solved (if any): #8381
2024-08-26 15:23:54 +02:00
Andreas Fabri 302e2fe594 We are only interested in features 2024-08-22 14:53:11 +01:00
Andreas Fabri 496019ae4e Add a selection item for edges marked in the om file 2024-08-22 13:25:31 +01:00
Andreas Fabri 4832f06ae4 Add plugin to read OpenMesh .om files 2024-08-22 11:40:27 +01:00
Sébastien Loriot a1a7b65275 remove remaining QT_VERSION_CHECK 2024-08-19 13:01:09 +02:00
Sebastien Loriot ac9a701342
remove leftover 2024-08-19 12:53:37 +02:00
Nicolas Saillant 1286d8b636 Remove deprecated Qt version checks 2024-08-19 12:02:19 +02:00
Sebastien Loriot 47c417a785
Deal with duplicate lines (#8396)
## Summary of Changes

Deal with Issue #8348 

## Release Management

* Affected package(s):  Triangulation_2 and Periodic_triangulation_2
* Issue(s) solved (if any): fix #8348 
* License and copyright ownership:  unchanged
2024-08-19 11:17:50 +02:00
Sebastien Loriot 862a3b6539
Update CMakeLists.txt for recent VTK to fix CMake Warning (#8279)
## Summary of Changes

Versions >= 9 of VTK trigger the following CMake warning using CGAL's
CMakeLists
```
CMake Deprecation Warning at C:/dev/VTK-9.2.2/build/lib/cmake/vtk-9.2/vtk-use-file-deprecated.cmake:1 (message):
  The `VTK_USE_FILE` is no longer used starting with 8.90.
Call Stack (most recent call first):
  CMakeLists.txt:32 (include)
```

I suggest this modification of the CMakeLists of Mesh_3 examples, that
also requires moving to VTK 9 (9.0 was released in 2020).
If this modification and new requirement are validated, I can apply the
change everywhere.

## Release Management

* Affected package(s): Mesh_3 for now
* License and copyright ownership: unchanged
2024-08-19 11:14:31 +02:00
Andreas Fabri 12468ccf4a Address #8401 2024-08-09 11:32:26 +01:00
Jane Tournois fa97ae8612 add missing not-nullptr check 2024-08-08 17:31:14 +02:00
Jane Tournois 4d38aa566e improve Mesh_3 log in demo 2024-08-08 17:30:22 +02:00
Nicolas Saillant bf10f945a9 Remove deprecated Qt version checks and unused code 2024-08-07 10:00:59 +02:00
Sébastien Loriot f02748b9b6 Merge pull request #8368 from sloriot/Lab-unused_file
Remove file unused
2024-07-23 17:20:58 +02:00
Sébastien Loriot 3a0e644ab7 Merge pull request #8294 from MaelRL/Lab-Add_add_face_from_selection-GF
Lab: Add an operation to create triangle faces from vertex selections
2024-07-23 17:18:41 +02:00
Sébastien Loriot 2d67765426 remove tmp file generated 2024-07-22 15:24:17 +02:00
Sébastien Loriot ec80cdddc3 remove file unused 2024-07-22 14:25:57 +02:00
Sébastien Loriot 651e3cd0bb fix warning 2024-06-21 14:53:53 +02:00
Mael Rouxel-Labbé 363df4c424 Add an operation to add triangle faces from vertex selection 2024-06-19 16:00:23 +02:00
Mael Rouxel-Labbé 4b71b12443 Remove noise 2024-06-19 15:59:23 +02:00
Mael Rouxel-Labbé 1c51d11541 Improve existing operation names 2024-06-19 15:00:08 +02:00
Sébastien Loriot f8af2993da improve generation of polylines
several options:
- 2d
- triangulated
- polygon
- one per line
2024-06-18 12:02:08 +02:00
Laurent Rineau 1b534cd347 Merge pull request #8248 from sloriot/CGAL-deprecate_Surface_mesher
deprecate Surface_mesher package
2024-06-12 10:06:14 +02:00
Laurent Rineau 32893b91c0 Merge pull request #8263 from lrineau/CGAL-update_minimal_cmake-GF
cmake_minimum_required(VERSION 3.12...3.29)
2024-06-12 10:06:12 +02:00
Laurent Rineau f3b409a807 require VTK version 9.0 or later 2024-06-11 15:57:25 +02:00
Laurent Rineau 5b003a7808 Merge pull request #8246 from albert-github/feature/bug_spell_20240531
Spelling corrections
2024-06-10 18:47:22 +02:00
Laurent Rineau 3a223ebd1e cmake_minimum_required(VERSION 3.12...3.29) 2024-06-06 20:19:44 +02:00
Jane Tournois d2fe7f260f use Mesh_3 for Poisson reconstruction in demo 2024-06-04 12:58:45 +02:00
albert-github 36c8b7589d Spelling corrections
Last batch (for now) of spelling corrections in doxygen and normal comments
2024-05-31 19:05:34 +02:00
Mael Rouxel-Labbé 1dc48a834c Fix default tab being components 2024-05-29 13:53:22 +02:00
Mael Rouxel-Labbé 8e0e94b63a Remove not useful CC selection in deformation widget 2024-05-29 12:29:05 +02:00
Mael Rouxel-Labbé b5c6abf6d0 Fix CC selection + Selection widget UI improvements 2024-05-29 12:28:28 +02:00
Mael Rouxel-Labbé 0e43336bef Fix using the fcolor pmap when there is no face color 2024-05-28 16:30:10 +02:00
Mael Rouxel-Labbé ad0d88d203 Fix using the fcolor pmap when there is no face color 2024-05-28 08:39:50 +02:00
Sebastien Loriot d06a57a292
Mesh_3 edge_distance criterion : an upper bound for the distances of the feature edge to the input feature (#7532)
## Summary of Changes

Fixes issue #5110.
Adds a edge_distance criteria to the mesh generation process.
This criteria is an upper bound for the distance from the edge to the 1D
feature.

## Release Management

* Affected package(s): Mesh_3
* Issue(s) solved (if any): fix #5110
* Link to small feature page :
[Mesh_3_edge_distance_criteria](https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Mesh_3_edge_distance_criteria)
* Link to compiled documentation
[*here*](https://cgal.github.io/7532/v1/Manual/index.html):
*
[Mesh_edge_criteria_3](https://cgal.github.io/7532/v1/Mesh_3/classCGAL_1_1Mesh__edge__criteria__3.html)
  * [Mesh_criteria_3](https://cgal.github.io/7532/v1/Mesh_3)
2024-05-27 10:58:15 +02:00
Sebastien Loriot a4e54b0f03
CGAL Lab: Add a target CGALlab_compile_all_plugins (#8222)
## Summary of Changes

Fix a usability issue with Visual Studio Code. There is now a new target
`CGALlab_compile_all_plugins` that compiles the executable `CGALlab` and
all the plugins.

That target, as seen in the vscode Make Project Outline, is placed just
below the `CGALlab` target.


![Screenshot_20240524_165017](https://github.com/CGAL/cgal/assets/5746675/9b7ebd26-19f6-46c4-97b1-677c5aecdb48)

If the executable `CGALlab_compile_all_plugins` is launched, it just
displays:

```
This executable is not intended to be run.
Please run the CGALlab executable instead.
```

## Release Management

* Affected package(s): Lab
2024-05-26 17:46:32 +02:00
Sébastien Loriot 17840c623b fix property_map() calls that should be add_property_map() 2024-05-24 18:51:10 +02:00
Laurent Rineau 0ba688ae6c Add a target CGALlab_compile_all_plugins 2024-05-24 16:55:10 +02:00
Laurent Rineau 7befb9c86d fix a warning 2024-05-24 16:02:19 +02:00
Laurent Rineau 81357855d5
Using std::optional for Property_container::get<T> (#8035)
## Summary of Changes
Switching from `std::pair<Property_map<T>, bool>` to `std::optional` in
`Property_container::get<T>`

Introducing `Pair_optional_adaptor` for backward compatibility which
extends `std::optional<T>` to interface of `std::pair`

using `Pair_optional_adaptor` for `Surface_mesh` and `Point_set_3`

## Release Management

* Affected package(s): Point_set_3, Surface_mesh, STL_Extension
2024-05-22 12:12:56 +02:00
Sven Oesau fb99772ec4 fixing warnings and errors 2024-05-16 11:24:45 +02:00