Commit Graph

1732 Commits

Author SHA1 Message Date
Sébastien Loriot 676c367852 fix warnings cherry-picked from master targetting 5.4 2021-11-29 18:02:31 +01:00
Mael Rouxel-Labbé 131242bb80 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_5.3-GF 2021-10-12 09:29:23 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Mael Rouxel-Labbé 5578bf43ff Misc cleaning 2021-09-27 15:35:40 +02:00
Mael Rouxel-Labbé c8cc0747fa Clarify binary warning 2021-09-27 15:33:42 +02:00
albert-github 2a54687e77 Correction of hyperlinks
The link checker gave a number of redirects and incorrect links.
- the redirects have been solved ass far as possible
- the incorrect links have been checked and corrected where possible, others  have been reported through issues;
2021-06-04 13:52:14 +02:00
Laurent Rineau 59a0da4f13 Merge pull request #5692 from maxGimeno/CGAL_cpp11_atomic_and_threads-maxGimeno
CGAL:: Use std atomic and threads

# Conflicts:
#	Arrangement_on_surface_2/include/CGAL/Arr_counting_traits_2.h
2021-05-19 17:23:53 +02:00
Laurent Rineau 82bec8a1d6 Merge pull request #5692 from maxGimeno/CGAL_cpp11_atomic_and_threads-maxGimeno
CGAL:: Use std atomic and threads

# Conflicts:
#	Arrangement_on_surface_2/include/CGAL/Arr_counting_traits_2.h
2021-05-19 17:11:37 +02:00
Laurent Rineau d6b2c8d9dc Merge pull request #5671 from maxGimeno/CGAL_IO-Add_missing-deprecated_functions-maxGimeno
CGAL_IO: Add missing fallbacks

# Conflicts:
#	BGL/include/CGAL/boost/graph/IO/INP.h
#	Point_set_processing_3/include/CGAL/IO/write_xyz_points.h
2021-05-18 18:13:38 +02:00
Maxime Gimeno 17ac255108 Fix calls t cpp11:atomic stuff 2021-05-18 15:43:59 +02:00
Maxime Gimeno 9acf3d4b19 Add missing fallbacks for IO functions and result_of 2021-05-07 12:50:51 +02:00
Maxime Gimeno 33cefe1be7 remove calls to cpp11::sleep_for() 2021-05-07 11:13:03 +02:00
Maxime Gimeno e9b7595fff Deprecate CGAL headers for threads, atomic and result_of, and move their content to config.h as fallback 2021-05-07 11:09:24 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot fbbf3863af remove extra IO 2021-05-04 18:25:16 +02:00
Sébastien Loriot 2060e0e352 move LAS_property in IO 2021-05-04 15:58:29 +02:00
Sébastien Loriot 12f0e412b5 write_vtu -> write_VTU 2021-05-04 15:12:36 +02:00
Sébastien Loriot 56025fb5f9 fix release number of depreciation 2021-05-04 14:38:47 +02:00
Sébastien Loriot fb6f703b55 IO namespace for files in IO directories 2021-05-04 14:36:06 +02:00
Sébastien Loriot 8005f91c22 add IO namespace for Point_set_3 and Point_set_processing_3 packages 2021-05-03 19:21:57 +02:00
Laurent Rineau e935a3d99b Merge pull request #5629 from sgiraudot/PSP-Fix_clustering_warning-GF
PSP: Fix conversion warnings in clustering
2021-04-28 15:24:10 +02:00
Laurent Rineau e562de0160 Merge pull request #5629 from sgiraudot/PSP-Fix_clustering_warning-GF
PSP: Fix conversion warnings in clustering
2021-04-28 15:22:43 +02:00
Laurent Rineau 5e20081197 Merge pull request #5629 from sgiraudot/PSP-Fix_clustering_warning-GF
PSP: Fix conversion warnings in clustering
2021-04-28 15:22:11 +02:00
Simon Giraudot f7f781c2d2 Fix warning by explicitly casting to/from property map value type 2021-04-19 12:44:59 +02:00
Sébastien Loriot 39367c2313 Merge remote-tracking branch 'cgal/5.2.x-branch' 2021-04-17 11:14:29 +02:00
Sébastien Loriot cbd95907cd Merge remote-tracking branch 'cgal/5.1.x-branch' into HEAD 2021-04-17 11:11:28 +02:00
Maxime Gimeno c49152359c update max version of cmake and announce the new minimal in CHANGE.md 2021-04-15 15:08:54 +02:00
Laurent Rineau 1b54449dc5 Merge pull request #4878 from danston/Kernels-decltypes-danston
Improve decltype/result_of/invoke_result
2021-04-06 15:13:21 +02:00
Laurent Rineau 343ef10367 Merge pull request #5547 from sgiraudot/Fix_stdpow_related_warnings-GF
Fix warning: std::pow(float, int) returns double instead of float in recent C++
2021-04-06 15:13:00 +02:00
Laurent Rineau 97f526878f Merge pull request #5547 from sgiraudot/Fix_stdpow_related_warnings-GF
Fix warning: std::pow(float, int) returns double instead of float in recent C++
2021-04-06 15:11:49 +02:00
Simon Giraudot ff2675dc61 Fix pointmatcher example 2021-04-06 10:40:53 +02:00
Laurent Rineau 21755b1123 Merge pull request #5245 from GilesBathgate/create-assertions-fix
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
2021-03-24 15:05:41 +01:00
Laurent Rineau aea492ee49 Merge pull request #5536 from maxGimeno/Fix_ply_doc-maxGimeno
Documentation: Fix `read_ply_points_with_properties`
2021-03-24 15:00:22 +01:00
Simon Giraudot ab14acff77 Replace std::pow(x,2) by CGAL::square(x) 2021-03-23 13:14:41 +01:00
Simon Giraudot 91de37ec3a Fix warning: std::pow(float, int) returns double instead of float in recent C++ 2021-03-23 11:25:53 +01:00
Maxime Gimeno 5b397e9d6f Fix group name for read_ply_points_with_properties 2021-03-19 08:40:21 +01:00
Dmitry Anisimov 00c185b028
Merge branch 'master' into Kernels-decltypes-danston 2021-03-12 12:06:20 +01:00
Laurent Rineau 158495bdb5 Merge pull request #5444 from sgiraudot/Poisson-Kernel_compatibility-GF
[Poisson Reconstruction] Compatibility with Simple Cartesian
2021-03-10 10:39:37 +01:00
Laurent Rineau 92e024f123 Merge pull request #5444 from sgiraudot/Poisson-Kernel_compatibility-GF
[Poisson Reconstruction] Compatibility with Simple Cartesian
2021-03-10 10:33:14 +01:00
Laurent Rineau f51ee121db Merge branch '5.2.x-branch'
# Conflicts:
#	Bounding_volumes/examples/Approximate_min_ellipsoid_d/CMakeLists.txt
#	Bounding_volumes/test/Bounding_volumes/CMakeLists.txt
#	Jet_fitting_3/examples/Jet_fitting_3/CMakeLists.txt
#	Point_set_processing_3/test/Point_set_processing_3/CMakeLists.txt
#	Polygon_mesh_processing/benchmark/Polygon_mesh_processing/CMakeLists.txt
#	Ridges_3/examples/Ridges_3/CMakeLists.txt
#	Shape_detection/examples/Shape_detection/CMakeLists.txt
2021-03-03 18:27:54 +01:00
Laurent Rineau 3ab3b10d47 Merge pull request #5247 from MaelRL/SDG-Fix_doc-GF
Doc improvements for TDS-related classes
2021-03-03 17:38:18 +01:00
Laurent Rineau 3621aaaf3e Merge pull request #5426 from sgiraudot/PSP-RANSAC-Fix_warnings-GF
[PSP/RANSAC] Fix warnings
2021-03-03 17:33:05 +01:00
Laurent Rineau 45373bef84 Merge pull request #5426 from sgiraudot/PSP-RANSAC-Fix_warnings-GF
[PSP/RANSAC] Fix warnings
2021-03-03 17:10:18 +01:00
Mael Rouxel-Labbé 5efa544734 Merge remote-tracking branch 'cgal/master' into SDG-Fix_doc-GF 2021-02-22 17:19:40 +01:00
Laurent Rineau a72fdb7b3c Merge pull request #5352 from lrineau/CGAL-fix_CGAL_IO-GF
Fixes after the PR "CGAL I/O
2021-02-18 15:23:43 +01:00
Dmitry Anisimov 81d9556707 Merge remote-tracking branch 'upstream/master' into Kernels-decltypes-danston 2021-02-10 10:06:45 +01:00
Simon Giraudot 848aa7d8ab Fix compatibility of Poisson with Simple_cartesian<float> 2021-02-08 10:16:59 +01:00
Laurent Rineau 4c947f0ee0 Merge pull request #5340 from danston/CGAL-clang_warnings_fix-danston
Clang warnings fixed
2021-02-05 16:10:37 +01:00
Maxime Gimeno 2dac31f36f Clean-up and fix doc 2021-02-05 14:14:11 +01:00