Commit Graph

3727 Commits

Author SHA1 Message Date
Sébastien Loriot 90bc05e715 Merge pull request #6047 from MaelRL/PM-Fix_pmaps_reference_types_5.3-GF
Various fixes for property maps (5.3)
2021-10-29 17:39:22 +02:00
Laurent Rineau e9cb30955c Merge pull request #6037 from sloriot/PMP-nm_map_license
Add missing license include directive
2021-10-29 17:00:02 +02:00
Laurent Rineau 04cde86a24 Merge pull request #6080 from sloriot/PMP-max_w
Workaround compilation error on Windows, about `max`
2021-10-29 16:59:22 +02:00
Laurent Rineau 7c185a3e5c Merge pull request #6051 from MaelRL/PMP-Forward_GT_orient_to_bound_volume-GF
PMP: Forward the geometric traits in `orient_to_bound_a_volume()`
2021-10-29 16:50:09 +02:00
Laurent Rineau 8a797935aa Merge pull request #6068 from sloriot/PMP-sampling_doc
Fix NPs and improve doc
2021-10-29 16:50:03 +02:00
Laurent Rineau 5d965e0507 Merge pull request #6051 from MaelRL/PMP-Forward_GT_orient_to_bound_volume-GF
PMP: Forward the geometric traits in `orient_to_bound_a_volume()`
2021-10-29 16:46:39 +02:00
Laurent Rineau 4a17e26e28 Merge pull request #6068 from sloriot/PMP-sampling_doc
Fix NPs and improve doc
2021-10-29 16:46:33 +02:00
Sébastien Loriot f4f484c5e0 workaround warning 2021-10-25 09:47:29 +02:00
Sébastien Loriot b793e7cd90 fix NPs and improve doc 2021-10-19 17:38:12 +02:00
Mael Rouxel-Labbé 1ab6b44d7d Fix NP forwarding in volume_CC 2021-10-15 10:22:08 +02:00
Mael Rouxel-Labbé 1f73af6cc4 Drive-by cleaning 2021-10-14 11:09:04 +02:00
Mael Rouxel-Labbé 91e7f1d20c Forward the geom traits in orient_to_bound_a_volume 2021-10-14 11:06:04 +02:00
Sébastien Loriot bdec97bccb remove backtick 2021-10-12 15:02:42 +02:00
Mael Rouxel-Labbé 131242bb80 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_5.3-GF 2021-10-12 09:29:23 +02:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Sébastien Loriot 64ead81a1c add missing license include directive 2021-10-08 15:28:13 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Laurent Rineau fb9333f0d0 Merge pull request #6028 from MaelRL/CGAL-Fix_typos-GF
Fix typos
2021-10-07 14:27:21 +02:00
Laurent Rineau 94ee9b1613 Merge pull request #6030 from MaelRL/CGAL-Minor_fixes-GF
Fix uninitialized id maps in heat method
2021-10-07 14:27:16 +02:00
Laurent Rineau 0e3b73852f Merge branch '5.2.x-branch' into 5.3.x-branch 2021-10-07 14:26:14 +02:00
Mael Rouxel-Labbé 863ab7541c Various whitespace fixes 2021-10-05 12:14:03 +02:00
Mael Rouxel-Labbé 84d84278b9 Fix VPM type 2021-10-05 12:14:02 +02:00
Mael Rouxel-Labbé 521c72d57e Fix typos 2021-10-04 13:34:07 +02:00
Mael Rouxel-Labbé 625848e629 Fix missing ':' in various namespaces 2021-10-04 13:21:47 +02:00
Laurent Rineau 01017f9deb Merge pull request #6022 from sloriot/PMP-deps
Reduce dependencies
2021-09-30 16:49:34 +02:00
Laurent Rineau 999ce8134a Merge pull request #6022 from sloriot/PMP-deps
Reduce dependencies
2021-09-30 16:48:55 +02:00
Laurent Rineau 804feece28 Merge pull request #5761 from danston/Weights-unification-danston
[Small Feature] Weights Unification
2021-09-29 16:59:34 +02:00
Laurent Rineau bb58df3ae5 Merge pull request #6021 from MaelRL/PMP-Snap_with_KD_tree-GF
Improvements for PMP's snapping code
2021-09-29 16:59:26 +02:00
Sébastien Loriot 2b666db30c use function
avoid compilation error about unknown function
2021-09-29 12:11:42 +02:00
Laurent Rineau 7e42541573 Merge pull request #5633 from sloriot/PMP-add_filter_for_caps_needles
Add a filter in function to remove caps/needle
2021-09-29 11:46:47 +02:00
Laurent Rineau e87bf84395 Merge pull request #5994 from MaelRL/PMP-Detect_sharp_edges_const-GF
Enhancements & fixes for PMP::detect_features
2021-09-29 11:46:41 +02:00
Laurent Rineau 0d304fe737 Merge pull request #6015 from sloriot/PMP-snap_fix_w
Fix vv snapping weight
2021-09-29 11:46:28 +02:00
Laurent Rineau b19086946c Merge pull request #5994 from MaelRL/PMP-Detect_sharp_edges_const-GF
Enhancements & fixes for PMP::detect_features
2021-09-29 11:45:38 +02:00
Sébastien Loriot c374b382a5 reduce dependancies 2021-09-29 11:06:39 +02:00
Mael Rouxel-Labbé b92c22d0a9 Improve preprocessing of snapping (don't move fixed vertices during collapsing) 2021-09-28 16:49:19 +02:00
Mael Rouxel-Labbé 60567eccbb Add Kd_tree-based vertex-vertex snapping + PMP::snap visitor 2021-09-28 16:25:43 +02:00
Sébastien Loriot 542d3603be fix weight for vertex-vertex snapping 2021-09-27 19:46:14 +02:00
Mael 4e5fbb6f22
Specify namespace
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2021-09-27 12:15:09 +02:00
Mael Rouxel-Labbé 878d94e299 Fix sign call 2021-09-24 09:47:33 +02:00
Mael Rouxel-Labbé 2bc5643972 Fix comparison 2021-09-21 16:50:19 +02:00
Laurent Rineau 8cdfc3b214 Merge pull request #5941 from afabri/PMP-edge_lenght_area-GF
Polygon Mesh Processing:  Add measure functions not using sqrt
2021-09-20 17:07:09 +02:00
Mael Rouxel-Labbé c7519ef93c Cache the squared cos value 2021-09-15 14:59:55 +02:00
Mael Rouxel-Labbé a5bbd05c42 Do not compute square roots + various improvements 2021-09-15 14:46:56 +02:00
Mael Rouxel-Labbé 8b7ab25966 Minor cleaning 2021-09-15 14:08:25 +02:00
Sébastien Loriot 2337757ce4 add a way to pass functions to build local filters ...
...  created from link faces of edges to be flipped or collapsed
2021-09-14 21:43:41 +02:00
Sebastien Loriot 575939c64f
Merge pull request #5952 from sloriot/SS-remove_Polygon_dep
remove artificial dependency to Polygon
2021-09-10 17:40:20 +02:00
Sebastien Loriot 4610cf3c66
Merge pull request #5904 from sloriot/CGAL-remove_config_flags
Replace macros with inline functions and remove a config flag
2021-09-10 17:38:50 +02:00
Sébastien Loriot 4afc249100 do not hide type definitions 2021-09-09 15:58:00 +02:00
Sébastien Loriot 000b03b595 follow up of #5889
cherry-picking for autorefinement
2021-09-06 18:44:07 +02:00
Dmitry Anisimov 936968fb4f Merge remote-tracking branch 'origin/master' into Weights-unification-danston 2021-09-06 10:38:24 +02:00
Sébastien Loriot d26246bced add missing include + restore dependency 2021-09-01 17:46:33 +02:00
Sébastien Loriot d82ca80d04 add a filter in function to remove caps/needle to be able to plug envelope 2021-08-31 15:52:47 +02:00
Andreas Fabri 168941a9b1 untabify 2021-08-31 12:19:31 +01:00
Andreas Fabri ed14ac0a28 Remove an #include 2021-08-31 12:11:37 +01:00
Andreas Fabri 265ca39dc1 Use geomtraits 2021-08-31 12:10:14 +01:00
Andreas Fabri e40cbc0ff5 Fixes after Mael's review 2021-08-31 10:07:44 +01:00
Andreas Fabri c71681747e Add functions for area and length that do not sqrt 2021-08-30 16:26:03 +01:00
Andreas Fabri 86ff15de35 Add the sqrt related warning to face_area() 2021-08-30 16:25:42 +01:00
Sebastien Loriot 2f0a643a84
Merge pull request #5889 from sloriot/PMP-cherry_picks_from_5089
Bug fixes cherry picked from #5049
2021-08-30 15:51:23 +02:00
Sébastien Loriot 4454c5b3ed Merge remote-tracking branch 'cgal/master' into T2-Document_projection_traits_3-maxGimeno 2021-08-30 12:25:51 +02:00
Sebastien Loriot 20ea9e775f
Merge pull request #4009 from afabri/CGAL-internal-GF
CGAL: Move from CGAL/internal  to CGAL/Pkg/internal
2021-08-30 11:55:36 +02:00
Sebastien Loriot 1bd8e07743
Merge pull request #5851 from maxGimeno/PMP-Add_a_visitor_to_orient_polygon_soup-maxGimeno
PMP: Add a visitor to the orientation function
2021-08-30 10:45:41 +02:00
Sebastien Loriot 3a00b6fe3e
Merge pull request #5592 from afabri/PMP_accelerate_corefine-GF
PMP Corefinement: Replace containers to make it faster
2021-08-30 10:42:07 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Sebastien Loriot 7e4fb11544
Merge pull request #5662 from sloriot/PMP-track_remove_si
Add a visitor to stop repair and track the current status
2021-08-18 18:52:14 +02:00
Dmitry Anisimov 60804d738e Merge remote-tracking branch 'origin/master' into Weights-unification-danston 2021-08-14 18:34:47 +02:00
Sébastien Loriot 038c57fb6a Merge pull request #5837 from maxGimeno/PMP-Self_intersections_limited_report-maxGImeno
PMP: Limited Number of Self-intersections
2021-08-13 18:23:20 +02:00
Sébastien Loriot e16e75c273 Merge pull request #5861 from sloriot/PMP-coref_vertex_visitor
Add vertex related functions in corefinement visitor
2021-08-13 18:17:39 +02:00
Sebastien Loriot e8b37c038a
Merge pull request #5781 from afabri/PMP_repair_psoup_use_deque-GF
PMP: Use deque instead of vector
2021-08-13 18:15:02 +02:00
Sébastien Loriot 40c7a67a91 add more function in the visitor to have a finer control 2021-08-13 14:23:20 +02:00
Sébastien Loriot 4f159d0209 add a visitor to stop repair and track the current status 2021-08-13 14:13:16 +02:00
Dmitry Anisimov c975eddf13 Merge remote-tracking branch 'origin/master' into Weights-unification-danston 2021-08-12 13:29:26 +02:00
Sébastien Loriot 814c9138ef Merge remote-tracking branch 'cgal/5.3.x-branch' 2021-08-12 10:38:11 +02:00
Sébastien Loriot cff3cdb40e Merge remote-tracking branch 'cgal/5.2.x-branch' into HEAD 2021-08-12 10:23:57 +02:00
Sebastien Loriot a6e19f5580
Merge pull request #5802 from janetournois/PMP-isotropic_remeshing_document_new_params-jtournois
PMP::isotropic_remeshing - document new parameters
2021-08-12 10:05:28 +02:00
Maxime Gimeno 7345cf1318 Merge remote-tracking branch 'cgal/master' into PMP-Self_intersections_limited_report-maxGImeno 2021-08-11 15:31:20 +02:00
Maxime Gimeno f7df517f57 Merge remote-tracking branch 'cgal/master' into T2-Document_projection_traits_3-maxGimeno 2021-08-09 09:14:23 +02:00
Sébastien Loriot 17ca9d86dc rename visitor concept 2021-08-05 18:13:40 +02:00
Sébastien Loriot b539d4a301 extend the visitor to report non-manifold vertex in an umbrella without nm edge 2021-08-05 18:13:35 +02:00
Sébastien Loriot 050e81d5fd set coplanar status of patches before classification
cherry-picked from #5049
2021-08-04 14:58:16 +02:00
Sébastien Loriot 8903e746f0 Correctly split intersection polylines when boundary/interior status changes along the polyline
Cherry-picked from #5049
2021-08-04 14:58:16 +02:00
Sébastien Loriot 6349441c4b better handling of boundary cases (cherry-picked from #5049) 2021-08-04 14:57:51 +02:00
Dmitry Anisimov 4126a5feec
Merge branch 'master' into Weights-unification-danston 2021-08-04 13:58:33 +02:00
Sébastien Loriot 1082f223db Merge remote-tracking branch 'cgal/5.3.x-branch' 2021-08-04 09:19:24 +02:00
Mael 753fc4d434 Minor comment fixes 2021-08-04 09:11:35 +02:00
Sébastien Loriot bc1fe892d8 remove const& 2021-08-02 10:40:12 +02:00
Sébastien Loriot d2a3f35d03 replace point -> vertex 2021-08-02 10:05:59 +02:00
Maxime Gimeno c99fdebafe add a non_manifold_vertex() function to the visitor 2021-07-30 12:17:06 +02:00
Sébastien Loriot 592e470b72 update doc 2021-07-30 11:37:53 +02:00
Maxime Gimeno e52775f943 Documentation 2021-07-29 11:32:35 +02:00
Simon Lopez 7f6c39e898 Skip shared edges which are border edges 2021-07-29 10:52:13 +02:00
Laurent Rineau 4fb90756da Merge pull request #5475 from sloriot/gsoc2019-PMPHDist-martinskrodzki
[Small Feature] Add bounded error Hausdorff distance
2021-07-27 16:28:04 +02:00
Maxime Gimeno 22edbbe428 Merge remote-tracking branch 'cgal/master' into PMP-Add_a_visitor_to_orient_polygon_soup-maxGimeno 2021-07-26 11:46:51 +02:00
Maxime Gimeno e83dc8775d fixes after review 2021-07-23 15:13:33 +02:00
Sébastien Loriot 9c670a3552 add visitor calls done in the output builder 2021-07-21 13:55:00 +02:00
Sébastien Loriot f9a9d126e3 add visitor functions for intersection point detection and new vertex creation 2021-07-21 13:19:23 +02:00
Maxime Gimeno 83e7abf042 Changes after review 2021-07-21 12:48:11 +02:00
Maxime Gimeno 3cfa3e8c86 Use a NP to pass the visitor 2021-07-19 13:40:19 +02:00
Maxime Gimeno 1b04db1fad Give the visitor by copy (1st step for the Named Parameters) 2021-07-19 13:18:26 +02:00